rcicindela 0.1.0 → 0.2.0

data/README.rdoc

@@ -5,6 +5,7 @@ http://wiki.github.com/jugyo/rcicindela
 == DESCRIPTION:
 
 RCicindela is a wrapper library for Cicindela.
+
 Cicindela is a recommendation engine made by Livedoor.
 See Also: http://code.google.com/p/cicindela2/
 
@@ -26,6 +27,10 @@ Getting recommendations:
 
 == INSTALL:
 
+  sudo gem install rcicindela
+
+or
+
  gem source -a http://gems.github.com
  sudo gem install jugyo-rcicindela
 

data/lib/rcicindela.rb

@@ -1,12 +1,18 @@
-require 'open-uri'
+require 'net/http'
 
 class RCicindela
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 
-  attr_reader :base_uri
+  attr_reader :host, :port, :base_path, :timeout, :default_params
 
-  def initialize(base_uri)
-    @base_uri = base_uri.sub(/\/*$/, '')
+  def initialize(host, options = {})
+    @host = host
+    @port = options[:port] || 80
+    @base_path = options[:base_path] || '/'
+    @timeout = options[:timeout] || 1
+    @default_params = options[:default_params] || {}
+
+    @base_path.sub!(/\/+$/, '')
   end
 
   %w(
@@ -26,15 +32,24 @@ class RCicindela
   ).each do |api_method|
     prefix, method = api_method.split('/')
     define_method(method) do |params|
-      get(prefix, {:op => method}.merge(params))
+      request(prefix, {:op => method}.merge(params))
     end
   end
 
   private
 
-  def get(prefix, params)
-    url = base_uri + '/' + prefix + '?' + params.map{ |k, v| [k.to_s, v.to_s] }.sort.map{ |i| i.join('=') }.join('&')
-    open(url).read
+  def request(prefix, params)
+    params = default_params.merge(params)
+    path = base_path + '/' + prefix + '?' + params.map{ |k, v| [k.to_s, v.to_s] }.sort.map{ |i| i.join('=') }.join('&')
+    get(path)
   end
-end
 
+  def get(path)
+    result = nil
+    Net::HTTP.start(host, port) do |http|
+      http.open_timeout = http.read_timeout = timeout
+      result = http.get(path).body
+    end
+    result
+  end
+end

data/spec/rcicindela_spec.rb

@@ -3,52 +3,60 @@
 require File.dirname(__FILE__) + '/spec_helper'
 
 describe RCicindela do
-  it 'should create instance with base_uri' do
-    uri = 'http://localhost/cicindela'
-    c = RCicindela.new(uri)
-    c.base_uri.should == uri
-  end
-
-  it 'should create instance with base_uri end "/"' do
-    uri = 'http://localhost/cicindela/'
-    c = RCicindela.new(uri)
-    c.base_uri.should == 'http://localhost/cicindela'
-  end
-
-  it 'should create instance with base_uri end "///"' do
-    uri = 'http://localhost/cicindela///'
-    c = RCicindela.new(uri)
-    c.base_uri.should == 'http://localhost/cicindela'
+  it 'should create instance' do
+    c = RCicindela.new('localhost', :port => 80, :base_path => '/cicindela/', :timeout => 10)
+    c.host.should == 'localhost'
+    c.port.should == 80
+    c.base_path.should == '/cicindela'
+    c.timeout.should == 10
   end
 
   describe 'Create instance with "http://localhost/cicindela" as base_uri' do
     before(:each) do
-      @cicindela = RCicindela.new('http://localhost/cicindela')
-    end  
+      @cicindela = RCicindela.new('localhost', :base_path => '/cicindela')
+    end
 
     it 'call method "get" when call insert_pick' do
-      @cicindela.should_receive(:get).with('record', {:op => 'insert_pick', :set => 'test', :user_id => 1, :item_id => 1})
+      @cicindela.should_receive(:request).with('record', {:op => 'insert_pick', :set => 'test', :user_id => 1, :item_id => 1})
       @cicindela.insert_pick(:set => 'test', :user_id => 1, :item_id => 1)
     end
 
     it 'call method "get" when call for_item' do
-      @cicindela.should_receive(:get).with('recommend', {:op => 'for_item', :set => 'test', :item_id => 1})
+      @cicindela.should_receive(:request).with('recommend', {:op => 'for_item', :set => 'test', :item_id => 1})
       @cicindela.for_item(:set => 'test', :item_id => 1)
     end
 
     it 'call method "open" when call insert_pick' do
-      @cicindela.should_receive(:open).
-        with("http://localhost/cicindela/record?item_id=1&op=insert_pick&set=test&user_id=1").and_return(StringIO.new('result'))
+      @cicindela.should_receive(:get).
+        with("/cicindela/record?item_id=1&op=insert_pick&set=test&user_id=1").and_return('result')
       result = @cicindela.insert_pick(:set => 'test', :user_id => 1, :item_id => 1)
       result.should == 'result'
     end
 
     it 'call method "open" when call for_item' do
-      @cicindela.should_receive(:open).
-        with("http://localhost/cicindela/recommend?item_id=1&op=for_item&set=test").and_return(StringIO.new('result'))
+      @cicindela.should_receive(:get).
+        with("/cicindela/recommend?item_id=1&op=for_item&set=test").and_return('result')
       result = @cicindela.for_item(:set => 'test', :item_id => 1)
       result.should == 'result'
     end
   end
-end
 
+  describe 'Create instance with default option' do
+    before(:each) do
+      @cicindela = RCicindela.new(
+        'localhost', :base_path => '/cicindela', :default_params => {:set => 'test', :user_id => 1})
+    end
+
+    it 'call method "get" when call insert_pick' do
+      @cicindela.should_receive(:request).with('record', {:op => 'insert_pick', :item_id => 1})
+      @cicindela.insert_pick(:item_id => 1)
+    end
+
+    it 'call method "open" when call insert_pick' do
+      @cicindela.should_receive(:get).
+        with("/cicindela/record?item_id=1&op=insert_pick&set=test&user_id=1").and_return('result')
+      result = @cicindela.insert_pick(:item_id => 1)
+      result.should == 'result'
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rcicindela
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors: 
 - jugyo
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-14 00:00:00 +09:00
+date: 2009-05-21 00:00:00 +09:00
 default_executable: 
 dependencies: []