rbtc_arbitrage_simple 1.2.3 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 40fce7b383de7c133941d19f55ff55adaf3fa01d
-  data.tar.gz: d625c40f8afee77529f458183cf32fba33fef0d8
+  metadata.gz: ef0a86fb8de589d7b45bc44e07ce93222bad2e17
+  data.tar.gz: b78c0c931af1ff282bba897320eb59c0b5279615
 SHA512:
-  metadata.gz: 8c08ee2166aafcd8dbd14dfa1a02ae5e0c14881b1b778b906fa6662e13ccc04770d2e7aae4e66c9da16a01b6a42188719030d758ea1f59282cd2b6392910f7ee
-  data.tar.gz: a8ef905fc4e189aa20ff6839440960f1e00c744119142d8e0b69af44af1eb226b98c80fc7bd6b7766ab7d79696d04b78a88049efbd732e245faf02f5d97096e9
+  metadata.gz: ff3874ce7ee3bdecf7b30e8338d2472fe33371f1a62ecb135e1dfcbcb04e1342828415907990aba602262450a59096e0fc4f34447ac65930269d116f7e73e826
+  data.tar.gz: 77c3cdb383df68cd78e3facc9122f7001e55fd0179b1aca441abd5a286e2b771c2a731ed66a5e6c7c7708c7c406cbba1608bd80640462f212bc7a3d21478f167

data/.travis.yml

@@ -6,6 +6,11 @@ rvm:
   - ruby-head
   - jruby-19mode
   - jruby-head
+
+matrix:
+  allow_failures:
+    - rvm: 2.1.0
+    - rvm: ruby-head
 env:
   global:
   - secure: FdoR9cSL5JzSiGRgmrEGCx55VdP7QU6jt2vzeJyc+2Ho67UXxJuXWgFdwojs6X85O3in8YfSOInBLGXXsD8a3mBuvhsAaMmDLbhFKfEExsc9bnpTj3k95UMGRO3pGNkk1tfj/ohsLFs+yL4r/mFZ5pOoxWW0uhYuRPA+Jk39hZg=
@@ -21,3 +26,6 @@ env:
   - secure: IFyJX6lAmBpef0I50UPCy6L5IRxqRKoPhv74s5y0FPB4chrir7iMZ7Sd1IczxV7ly4Dt7hdALHP1qMTmkcGmTV6YOzwR46G4JAwWtX2xlf4OYk4jey7qjNsS6iijD6dvdYjqSKUuGaX3Til3kUOLcA3hhINvHxj5unv2pHB2W70=
   - secure: YiYtCBJNfgWuzQ059RMmZxM00bs4c/GuqaEaKufLPPByJHHt3z4jCNT5lurox/RIqSYTv+1Nvgor1xJZF4VPDIhtoCpVRe3g5Pvubrp4gWQry11ta0f1JhPSrm5ORlF1hpHPfzHHSh+/YVmKcO8agQAaIgfKcXDzsE6j5QqiGWQ=
   - secure: TCrSkWTG2A7ZHxU/J82R1oRn3+ISYHOZmukvBT/OkOh35yjhtig3KhroYki67guCClVxov+ZPvCRUKgmsEoVng1ljk/ZXyyNf4QNVccEJxHCwIRiqs36jlC2ebd8g+JJUPrnnWGO/U5vBm+WlrOb4lFlIsBuCYI+FBAFYTPmKEs=
+  - secure: cePvBAt6j7UwybsP6Cs5a7mwaXMHDteXC1ENsNMy69qV5mae7oRKqsfavZ8ar33apNXqALXDWiDnHH7wPccMl3GXIquHE7I73lAOcEu4V+f7nHqqFuJezA12IL0swOQhDNK23C5ibkFftlpG2jTxHpaRLaDNCuv404cREalwwgA=
+  - secure: PLTV2N3BYlqXmDDuOuZGk83YApX3oEIpskkWHUGj8f3wBpjOSPxuLBdpSGMXRqT2kIMJqle65gqlYpwh4NcTgqL93iNAT9fh7WDyNx/SUL+Mz04kphAC6N0VPyg7nvTi33bDbkmAAFNc+1yoWKAlB2gjKKXFtdxTwMp4SjvNsfs=
+  - secure: nyFUNdswDOM0UgW3T/jeEvIyZPSGq+ZEpyYw6KGpwb7a5F1DbAfoSy6zJGWK6S3vKf6814e43HmawhJlhcD9KYOV783O7KYu54FTmhZ/SP9QhNV+w1hiKKRQcTlJdjbPIuO5piuMDMCPacCJa+C9YO0lhhxfZ+/6F4SNR1fteN0=

data/Gemfile.lock

@@ -1,12 +1,13 @@
 PATH
   remote: .
   specs:
-    rbtc_arbitrage_simple (1.2.3)
+    rbtc_arbitrage_simple (1.4.4)
       activemodel (>= 3.1)
       activesupport (>= 3.1)
       btce (= 0.2.4)
-      coinbase (= 1.2.4)
+      coinbase (= 1.2.6)
       mtgox
+      pony
       thor
 
 GEM
@@ -31,10 +32,10 @@ GEM
     codeclimate-test-reporter (0.2.0)
       simplecov (>= 0.7.1, < 1.0.0)
     coderay (1.1.0)
-    coinbase (1.2.4)
+    coinbase (1.2.6)
       hashie (>= 1.2.0)
       httparty (>= 0.8.3)
-      money (>= 4.0.1)
+      money (= 5.1.1)
       multi_json (>= 1.3.4)
     coveralls (0.7.0)
       multi_json (~> 1.3)
@@ -70,11 +71,15 @@ GEM
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9)
     lumberjack (1.0.4)
+    mail (2.2.7)
+      activesupport (>= 2.3.6)
+      mime-types
+      treetop (>= 1.4.5)
     method_source (0.8.2)
     mime-types (2.0)
     minitest (4.7.5)
-    money (6.0.0)
-      i18n (~> 0.6.4)
+    money (5.1.1)
+      i18n (~> 0.6.0)
     monkey-patch (0.0.14)
       activesupport
     mtgox (1.1.0)
@@ -83,6 +88,9 @@ GEM
     multi_json (1.8.2)
     multi_xml (0.5.5)
     multipart-post (1.2.0)
+    polyglot (0.3.3)
+    pony (1.6.2)
+      mail (>= 2.0)
     pry (0.9.12.4)
       coderay (~> 1.0)
       method_source (~> 0.8)
@@ -128,6 +136,9 @@ GEM
     tilt (1.4.1)
     timers (1.1.0)
     tins (0.13.1)
+    treetop (1.4.15)
+      polyglot
+      polyglot (>= 0.3.1)
     tzinfo (0.3.38)
     vcr (2.8.0)
     webmock (1.16.1)

data/README.md

@@ -8,11 +8,11 @@ A Ruby gem for executing arbitrage between the MtGox and Bitstamp bitcoin exchan
 
 [Why I open sourced a bitcoin arbitrate bot](http://hankstoever.com/posts/2-Why-I-open-sourced-a-bitcoin-arbitrage-bot)
 
-I'm also creating a course on [creating your own bitcoin arbitrage bot](https://www.uludum.org/funds/2) 
+I'm also creating a course on [creating your own bitcoin arbitrage bot](https://www.uludum.org/funds/2)
 
 Donations accepted: **16BMcqf93eEpb2aWgMkJCSQQH85WzrpbdZ**
 
-[![Build Status](https://travis-ci.org/hstove/rbtc_arbitrage.png?branch=master)](https://travis-ci.org/hstove/rbtc_arbitrage)
+[![Build Status](https://travis-ci.org/hstove/rbtc_arbitrage.png?branch=no-native)](https://travis-ci.org/hstove/rbtc_arbitrage)
 [![Coverage Status](https://coveralls.io/repos/hstove/rbtc_arbitrage/badge.png)](https://coveralls.io/r/hstove/rbtc_arbitrage)
 [![Code Climate](https://codeclimate.com/github/hstove/rbtc_arbitrage.png)](https://codeclimate.com/github/hstove/rbtc_arbitrage)
 

data/bin/rbtc_simple

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
 
+$LOAD_PATH.unshift File.join(File.dirname(__FILE__), '..', 'lib')
 require 'rbtc_arbitrage'
 RbtcArbitrage::CLI.start ARGV

data/lib/rbtc_arbitrage.rb

@@ -3,6 +3,7 @@ require 'mtgox'
 require_relative 'rbtc_arbitrage/campbx.rb'
 require 'btce'
 require 'coinbase'
+require 'pony'
 require_relative 'rbtc_arbitrage/client.rb'
 Dir["#{File.dirname(__FILE__)}/rbtc_arbitrage/**/*.rb"].each { |f| require(f) }
 

data/lib/rbtc_arbitrage/cli.rb

@@ -9,6 +9,7 @@ module RbtcArbitrage
     option :buyer, type: :string, default: "campbx"
     option :seller, type: :string, default: "mtgox"
     option :repeat, type: :numeric, default: nil
+    option :notify, type: :boolean, default: false
     def trade
       RbtcArbitrage::Trader.new(options).trade
     end

data/lib/rbtc_arbitrage/trader.rb

@@ -13,11 +13,14 @@ module RbtcArbitrage
       @options = {}
       set_key opts, :volume, 0.01
       set_key opts, :cutoff, 2
-      set_key opts, :logger, Logger.new(STDOUT)
+      default_logger = Logger.new($stdout)
+      default_logger.datetime_format = "%^b %e %Y %l:%M:%S %p %z"
+      set_key opts, :logger, default_logger
       set_key opts, :verbose, true
       set_key opts, :live, false
       set_key opts, :repeat, nil
       exchange = opts[:buyer] || :campbx
+      set_key opts, :notify, false
       @buy_client = client_for_exchange(exchange)
       exchange = opts[:seller] || :mtgox
       @sell_client = client_for_exchange(exchange)
@@ -38,15 +41,18 @@ module RbtcArbitrage
 
       execute_trade if options[:live]
 
+      notify
+
       if @options[:repeat]
         trade_again
       end
+
       self
     end
 
     def trade_again
       sleep @options[:repeat]
-      @logger.info " - " if @options[:verbose]
+      logger.info " - " if @options[:verbose]
       @buy_client = @buy_client.class.new(@options)
       @sell_client = @sell_client.class.new(@options)
       trade
@@ -104,6 +110,15 @@ module RbtcArbitrage
       [@sell_client, @buy_client].each do |client|
         client.validate_env
       end
+      if options[:notify]
+        ["PASSWORD","USERNAME","EMAIL"].each do |key|
+          key = "SENDGRID_#{key}"
+          unless ENV[key]
+            raise ArgumentError, "Exiting because missing required ENV variable $#{key}."
+          end
+        end
+        setup_pony
+      end
     end
 
     def client_for_exchange market
@@ -119,5 +134,60 @@ module RbtcArbitrage
         raise ArgumentError, "Invalid exchange - '#{market}'"
       end
     end
+
+    def notify
+      return false unless options[:notify]
+      return false unless @percent > options[:cutoff]
+      setup_pony
+
+      options[:logger].info "Sending email to #{ENV['SENDGRID_EMAIL']}"
+      Pony.mail({
+        body: notification,
+        to: ENV['SENDGRID_EMAIL'],
+      })
+    end
+
+    def setup_pony
+      Pony.options = {
+        from: ENV['FROM_EMAIL'] || "info@example.org",
+        subject: "rbtc_arbitrage notification",
+        via: :smtp,
+        via_options: {
+          address: 'smtp.sendgrid.net',
+          port: '587',
+          domain: 'heroku.com',
+          user_name: ENV['SENDGRID_USERNAME'],
+          password: ENV['SENDGRID_PASSWORD'],
+          authentication: :plain,
+          enable_starttls_auto: true
+        }
+      }
+    end
+
+    def notification
+      lower_ex = @buy_client.exchange.to_s.capitalize
+      higher_ex = @sell_client.exchange.to_s.capitalize
+      <<-eos
+      Update from your friendly rbtc_arbitrage trader:
+
+      -------------------
+
+      #{lower_ex}: $#{buyer[:price].round(2)}
+      #{higher_ex}: $#{seller[:price].round(2)}
+      buying #{@options[:volume]} btc from #{lower_ex} for $#{@paid.round(2)}
+      selling #{@options[:volume]} btc on #{higher_ex} for $#{@received.round(2)}
+      profit: $#{(@received - @paid).round(2)} (#{@percent.round(2)}%)
+
+      -------------------
+
+      options:
+
+      #{options.reject{|k,v| v.is_a?(Logger)}.collect{|k,v| "#{k}: #{v.to_s}"}.join(" | ")}
+
+      -------------------
+
+      https://github.com/hstove/rbtc_arbitrage
+      eos
+    end
   end
 end

data/lib/rbtc_arbitrage/version.rb

@@ -1,3 +1,3 @@
 module RbtcArbitrage
-  VERSION = "1.2.3"
+  VERSION = "1.4.4"
 end

data/rbtc_arbitrage.gemspec

@@ -26,5 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activesupport", ">= 3.1"
   spec.add_dependency "thor"
   spec.add_dependency "btce", '0.2.4'
-  spec.add_dependency "coinbase", '1.2.4'
+  spec.add_dependency "coinbase", '1.2.6'
+  spec.add_dependency "pony"
 end

data/spec/trader_spec.rb

@@ -37,6 +37,20 @@ describe RbtcArbitrage::Trader do
         end
       end
     end
+
+    ["PASSWORD","USERNAME","EMAIL"].each do |key|
+      key = "SENDGRID_#{key}"
+      it "should raise if --notify and not ENV[#{key}]" do
+        trader.sell_client.stub(:validate_env)
+        trader.buy_client.stub(:validate_env)
+        old_val = ENV[key]
+        ENV[key] = nil
+        trader.options[:notify] = true
+        expect { trader.validate_env }.to raise_error(ArgumentError)
+        trader.options[:notify] = false
+        expect { trader.validate_env }.not_to raise_error
+      end
+    end
   end
 
   describe "#fetch_prices" do
@@ -71,6 +85,7 @@ describe RbtcArbitrage::Trader do
         live: true,
         seller: :btce,
         buyer: :mtgox,
+        notify: true,
       }
     }
 
@@ -142,6 +157,7 @@ describe RbtcArbitrage::Trader do
   describe "#trade" do
     it "calls the right methods" do
       trader.should_receive(:fetch_prices)
+      trader.should_receive(:notify)
       trader.should_not_receive(:log_info)
       trader.should_not_receive(:execute_trade)
 
@@ -183,15 +199,29 @@ describe RbtcArbitrage::Trader do
   end
 
   describe "#log_info" do
-    it "calls logger.info" do
+    before :each do
       trader.buyer[:price] = 1
       trader.seller[:price] = 1
       trader.instance_variable_set :@percent, 1
       trader.instance_variable_set :@paid, 1
       trader.instance_variable_set :@received, 1
+    end
+    it "calls logger.info" do
       trader.logger.should_receive(:info).exactly(5).times
       trader.log_info
     end
+
+    it "formats the log correctly" do
+      FileUtils.mkdir_p('tmp')
+      date = DateTime.now.strftime "%^b %e %Y %l"
+      logger = Logger.new('tmp/log.info')
+      logger.datetime_format = trader.logger.datetime_format
+      trader.options[:logger] = logger
+      trader.log_info
+      contents = File.read("tmp/log.info")
+      contents.should include(date)
+      contents.should include(" INFO -- ")
+    end
   end
 
   describe "#logger" do
@@ -225,4 +255,82 @@ describe RbtcArbitrage::Trader do
     end
   end
 
+  describe "#notify" do
+    it "returns false when notify == false" do
+      trader.notify.should == false
+    end
+
+    it "returns false unless cutoff < percent" do
+      trader.options[:notify] = true
+      trader.instance_variable_set :@percent, 1
+      trader.notify.should == false
+    end
+
+    it "calls Sendgrid when notify == true" do
+      trader.options[:notify] = true
+      trader.instance_variable_set :@percent, 3
+      trader.instance_variable_set :@paid, 5
+      trader.instance_variable_set :@received, 6
+      trader.buyer[:price] = 1
+      trader.seller[:price] = 1
+
+      trader.options[:logger].should_receive(:info)
+      Pony.should_receive(:mail).with({
+        to: ENV['SENDGRID_EMAIL'],
+        body: trader.notification,
+      })
+
+      trader.notify
+    end
+  end
+
+  describe "#setup_pony" do
+    it "gets called on validation when --notify" do
+      ["PASSWORD","USERNAME","EMAIL"].each do |key|
+        key = "SENDGRID_#{key}"
+        ENV[key] ||= "something"
+      end
+      trader.options[:notify] = true
+      trader.should_receive(:setup_pony).once
+      trader.validate_env
+    end
+    it "sets up pony correctly" do
+      opts = {
+        from: "info@example.org",
+        subject: "rbtc_arbitrage notification",
+        :via => :smtp,
+        :via_options => {
+          :address => 'smtp.sendgrid.net',
+          :port => '587',
+          :domain => 'heroku.com',
+          :user_name => ENV['SENDGRID_USERNAME'],
+          :password => ENV['SENDGRID_PASSWORD'],
+          :authentication => :plain,
+          :enable_starttls_auto => true
+        }
+      }
+      Pony.should_receive(:options=).with(opts)
+      trader.setup_pony
+    end
+  end
+
+  describe "#notification" do
+    it "includes the right values" do
+      trader.instance_variable_set :@percent, 3
+      trader.instance_variable_set :@paid, 5
+      trader.instance_variable_set :@received, 8
+      trader.buyer[:price] = 1.00453
+      trader.seller[:price] = 3.50453
+
+      value = trader.notification
+      value.should include("$1.0")
+      value.should include("$3.5")
+      value.should include("$3.0")
+      value.should include("3.0%")
+    end
+    context "--live" do
+      it "should say that it made a trade"
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rbtc_arbitrage_simple
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.4.4
 platform: ruby
 authors:
 - Hank Stoever
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-23 00:00:00.000000000 Z
+date: 2014-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -114,14 +114,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.2.4
+        version: 1.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.2.4
+        version: 1.2.6
+- !ruby/object:Gem::Dependency
+  name: pony
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A gem for conducting arbitrage with Bitcoin.
 email:
 - hstove@gmail.com