rbs 3.9.0.dev.1 → 3.9.0.pre.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 311aed14b7b84b6b21cb187b72c1ddd87a427b6ec02805017f83b5fbcbfaac7b
-  data.tar.gz: 4fc2e119368352b2fbded9355834757399cde34f3912c24ae82e91db67042762
+  metadata.gz: dfc16707bf516d2296468a341b413fd87a4ecb032b8fb54717fa36ffe6310d10
+  data.tar.gz: ecbf8ac797a87c14b34aa0e78bf7c7c708762bc5048c16230f5d2bf23d38f981
 SHA512:
-  metadata.gz: 6c9b1a6188ac4585b3ea5b9dd72432f12ea13ee4c8311a15a86f0cee5595acef46901e04105e40a84703ea51e036efb645a53cacaa1517d213420b2251f3f506
-  data.tar.gz: 4061149d53166bbe1a6029cebbacc54117eccf5d414c1859b50c5049d2898245a27ccf8f558b9c11d5edaa0b276ba88c111b8c80505a5b911664e77b5351dc2a
+  metadata.gz: c8f881cc73012ba92d79512a934c1d75fe879e0de1b03e44286d4288414cf7678b5d5cf1319718765c6457136fc1a72ce435fe8392fc186abdd3d712f4662d6e
+  data.tar.gz: e724bc074e0ac9e3cd46e8eb40ad6b0837a31820786d924bc4e79760946f55cf0ad8d7ca7ca2bee97ca9ad98ef5c4671e9df0dee4ece85f636f72ebd8787a85d

data/.github/workflows/ruby.yml

@@ -80,3 +80,29 @@ jobs:
       - name: Run test
         run: |
           bundle exec rake ${{ matrix.job }}
+  valgrind:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.4"
+          bundler-cache: none
+      - name: Set working directory as safe
+        run: git config --global --add safe.directory $(pwd)
+      - name: Set up permission
+        run: chmod -R o-w /opt/hostedtoolcache/Ruby
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libdb-dev curl autoconf automake m4 libtool python3 valgrind
+      - name: Update rubygems & bundler
+        run: |
+          ruby -v
+          gem update --system
+      - name: bin/setup
+        run: |
+          bin/setup
+      - run: bundle exec rake test:valgrind
+        env:
+          RUBY_FREE_AT_EXIT: 1

data/CHANGELOG.md

@@ -1,5 +1,54 @@
 # CHANGELOG
 
+## 3.9.0.pre.1 (2025-03-11)
+
+### Signature updates
+
+* `CGI.escape/unescape_uri_component` ([#2299](https://github.com/ruby/rbs/pull/2299))
+* `Enumerator::Chain` ([#2220](https://github.com/ruby/rbs/pull/2220))
+* `IO.read` ([#2216](https://github.com/ruby/rbs/pull/2216))
+* `IPAddr#netmask` ([#2311](https://github.com/ruby/rbs/pull/2311))
+* `Kernel#gets`, `Kernel#readline`, `Kernel#readlines` ([#2212](https://github.com/ruby/rbs/pull/2212))
+* `Net::HTTP.start` ([#2225](https://github.com/ruby/rbs/pull/2225))
+* `OpenSSL::BN` ([#2267](https://github.com/ruby/rbs/pull/2267))
+* `OpenSSL::PKey::{RSA,DSA,DH}#params` ([#2255](https://github.com/ruby/rbs/pull/2255))
+* `UNIXSocket#send_io`, `UNIXSocket#recv_io` ([#2264](https://github.com/ruby/rbs/pull/2264))
+* `URI.encode/decode_uri_component` ([#2299](https://github.com/ruby/rbs/pull/2299))
+* Rename to reduce top-level interface and type alias ([#2250](https://github.com/ruby/rbs/pull/2250))
+
+### Language updates
+
+* Let class/module alias decls, global decls, and constant decls be annotated ([#2302](https://github.com/ruby/rbs/pull/2302))
+* Add `resolve-type-names: false` magic comment ([#2234](https://github.com/ruby/rbs/pull/2234))
+
+### Library changes
+
+* Remove unused root variable ([#2307](https://github.com/ruby/rbs/pull/2307))
+* Run Valgrind on CI and fix memory leaks ([#2309](https://github.com/ruby/rbs/pull/2309))
+* Add information for VariableDuplicationError ([#2310](https://github.com/ruby/rbs/pull/2310))
+* Reduce Array object allocation during parsing ([#2304](https://github.com/ruby/rbs/pull/2304))
+* No class variable duplication validation ([#2305](https://github.com/ruby/rbs/pull/2305))
+* Keep annotations during type name resolution ([#2303](https://github.com/ruby/rbs/pull/2303))
+* Fix method annotations ([#2301](https://github.com/ruby/rbs/pull/2301))
+* Fix class variable ([#2300](https://github.com/ruby/rbs/pull/2300))
+* Add bundled gems to alumnus  ([#2288](https://github.com/ruby/rbs/pull/2288))
+* Exclude `attr_*` methods from duplicate checks. ([#2294](https://github.com/ruby/rbs/pull/2294))
+* Validate superclass and module-self-type ([#2289](https://github.com/ruby/rbs/pull/2289))
+* Remove case when `rubygems` and `set` ([#2279](https://github.com/ruby/rbs/pull/2279))
+* Check variable duplication ([#2241](https://github.com/ruby/rbs/pull/2241))
+* Validate variable types ([#2237](https://github.com/ruby/rbs/pull/2237))
+* Remove call to `TypeParam#unchecked!` from C parser ([#2256](https://github.com/ruby/rbs/pull/2256))
+* Remove call to `Any#todo!` from C parser ([#2249](https://github.com/ruby/rbs/pull/2249))
+* [rbs/unit_test] Treat nil as a return value ([#2257](https://github.com/ruby/rbs/pull/2257))
+
+### Miscellaneous
+
+* Apply rubocop style to RBS ([#2292](https://github.com/ruby/rbs/pull/2292))
+* Eliminate external HTTP requests on test ([#2253](https://github.com/ruby/rbs/pull/2253))
+* Prevent a warning: the block passed to 'map_type_name' .. may be ignored ([#2248](https://github.com/ruby/rbs/pull/2248))
+* Update ruby version for rubocop ([#2251](https://github.com/ruby/rbs/pull/2251))
+* Drop templates from package ([#2214](https://github.com/ruby/rbs/pull/2214))
+
 ## 3.8.1 (2024-12-27)
 
 ### Signature updates

data/Rakefile

@@ -11,7 +11,7 @@ bin = File.join(__dir__, "bin")
 
 Rake::ExtensionTask.new("rbs_extension")
 
-Rake::TestTask.new(:test => :compile) do |t|
+test_config = lambda do |t|
   t.libs << "test"
   t.libs << "lib"
   t.test_files = FileList["test/**/*_test.rb"].reject do |path|
@@ -19,6 +19,16 @@ Rake::TestTask.new(:test => :compile) do |t|
   end
 end
 
+Rake::TestTask.new(test: :compile, &test_config)
+
+unless Gem.win_platform?
+  require "ruby_memcheck"
+
+  namespace :test do
+    RubyMemcheck::TestTask.new(valgrind: :compile, &test_config)
+  end
+end
+
 multitask :default => [:test, :stdlib_test, :typecheck_test, :rubocop, :validate, :test_doc]
 
 task :lexer do

data/ext/rbs_extension/parser.c

@@ -61,6 +61,7 @@ typedef struct {
 } method_params;
 
 static VALUE EMPTY_ARRAY;
+static VALUE EMPTY_HASH;
 
 static inline void melt_array(VALUE *array) {
   if (*array == EMPTY_ARRAY) {
@@ -68,6 +69,12 @@ static inline void melt_array(VALUE *array) {
   }
 }
 
+static inline void melt_hash(VALUE *hash) {
+  if (*hash == EMPTY_HASH) {
+    *hash = rb_hash_new();
+  }
+}
+
 static bool rbs_is_untyped_params(method_params *params) {
   return NIL_P(params->required_positionals);
 }
@@ -343,7 +350,7 @@ static VALUE parse_keyword_key(parserstate *state) {
 /*
   keyword ::= {} keyword `:` <function_param>
 */
-static void parse_keyword(parserstate *state, VALUE keywords, VALUE memo) {
+static void parse_keyword(parserstate *state, VALUE *keywords, VALUE memo) {
   VALUE key = parse_keyword_key(state);
 
   if (!NIL_P(rb_hash_aref(memo, key))) {
@@ -359,7 +366,8 @@ static void parse_keyword(parserstate *state, VALUE keywords, VALUE memo) {
   parser_advance_assert(state, pCOLON);
   VALUE param = parse_function_param(state);
 
-  rb_hash_aset(keywords, key, param);
+  melt_hash(keywords);
+  rb_hash_aset(*keywords, key, param);
 
   return;
 }
@@ -466,7 +474,7 @@ PARSE_OPTIONAL_PARAMS:
         parser_advance(state);
 
         if (is_keyword(state)) {
-          parse_keyword(state, params->optional_keywords, memo);
+          parse_keyword(state, &params->optional_keywords, memo);
           parser_advance_if(state, pCOMMA);
           goto PARSE_KEYWORDS;
         }
@@ -533,7 +541,7 @@ PARSE_KEYWORDS:
     case pQUESTION:
       parser_advance(state);
       if (is_keyword(state)) {
-        parse_keyword(state, params->optional_keywords, memo);
+        parse_keyword(state, &params->optional_keywords, memo);
       } else {
         raise_syntax_error(
           state,
@@ -556,7 +564,7 @@ PARSE_KEYWORDS:
     case tBANGIDENT:
     KEYWORD_CASES
       if (is_keyword(state)) {
-        parse_keyword(state, params->required_keywords, memo);
+        parse_keyword(state, &params->required_keywords, memo);
       } else {
         raise_syntax_error(
           state,
@@ -613,8 +621,8 @@ static void initialize_method_params(method_params *params){
     .optional_positionals = EMPTY_ARRAY,
     .rest_positionals = Qnil,
     .trailing_positionals = EMPTY_ARRAY,
-    .required_keywords = rb_hash_new(),
-    .optional_keywords = rb_hash_new(),
+    .required_keywords = EMPTY_HASH,
+    .optional_keywords = EMPTY_HASH,
     .rest_keywords = Qnil,
   };
 }
@@ -2958,10 +2966,15 @@ rbsparser_lex(VALUE self, VALUE buffer, VALUE end_pos) {
 void rbs__init_parser(void) {
   RBS_Parser = rb_define_class_under(RBS, "Parser", rb_cObject);
   rb_gc_register_mark_object(RBS_Parser);
+
   VALUE empty_array = rb_obj_freeze(rb_ary_new());
   rb_gc_register_mark_object(empty_array);
   EMPTY_ARRAY = empty_array;
 
+  VALUE empty_hash = rb_obj_freeze(rb_hash_new());
+  rb_gc_register_mark_object(empty_hash);
+  EMPTY_HASH = empty_hash;
+
   rb_define_singleton_method(RBS_Parser, "_parse_type", rbsparser_parse_type, 5);
   rb_define_singleton_method(RBS_Parser, "_parse_method_type", rbsparser_parse_method_type, 5);
   rb_define_singleton_method(RBS_Parser, "_parse_signature", rbsparser_parse_signature, 3);

data/ext/rbs_extension/parserstate.c

@@ -363,6 +363,7 @@ parserstate *alloc_parser(VALUE buffer, lexstate *lexer, int start_pos, int end_
 
   if (!NIL_P(variables)) {
     if (!RB_TYPE_P(variables, T_ARRAY)) {
+      free_parser(parser);
       rb_raise(rb_eTypeError,
                "wrong argument type %"PRIsVALUE" (must be array or nil)",
                rb_obj_class(variables));
@@ -387,11 +388,24 @@ parserstate *alloc_parser(VALUE buffer, lexstate *lexer, int start_pos, int end_
   return parser;
 }
 
+void free_typevar_tables(id_table *table) {
+  while (table != NULL) {
+    id_table *next = table->next;
+    if (table->ids != NULL) {
+      free(table->ids);
+    }
+    free(table);
+    table = next;
+  }
+}
+
 void free_parser(parserstate *parser) {
   free(parser->lexstate);
   if (parser->last_comment) {
     free_comment(parser->last_comment);
   }
+
+  free_typevar_tables(parser->vars);
   rbs_constant_pool_free(&parser->constant_pool);
   free(parser);
 }

data/lib/rbs/definition_builder.rb

@@ -569,11 +569,11 @@ module RBS
       case l.source
       when AST::Members::InstanceVariable
         if r.source.instance_of?(AST::Members::InstanceVariable) && l.declared_in == r.declared_in
-          raise InstanceVariableDuplicationError.new(member: l.source)
+          raise InstanceVariableDuplicationError.new(type_name: l.declared_in, variable_name: l.source.name, location: l.source.location)
         end
       when AST::Members::ClassInstanceVariable
         if r.source.instance_of?(AST::Members::ClassInstanceVariable) && l.declared_in == r.declared_in
-          raise ClassInstanceVariableDuplicationError.new(member: l.source)
+          raise ClassInstanceVariableDuplicationError.new(type_name: l.declared_in, variable_name: l.source.name, location: l.source.location)
         end
       end
     end

data/lib/rbs/errors.rb

@@ -325,24 +325,25 @@ module RBS
   class VariableDuplicationError < DefinitionError
     include DetailedMessageable
 
-    attr_reader :member
-
-    def initialize(member:)
-      @member = member
+    attr_reader :type_name
+    attr_reader :variable_name
+    attr_reader :location
 
-      super "#{Location.to_string location}: Duplicated variable name #{member.name}"
-    end
+    def initialize(type_name:, variable_name:, location:)
+      @type_name = type_name
+      @variable_name = variable_name
+      @location = location
 
-    def location
-      loc = @member.location or raise
-      loc[:name]
+      super "#{Location.to_string location}: Duplicated #{kind} variable name `#{variable_name}` in `#{type_name}`"
     end
   end
 
   class InstanceVariableDuplicationError < VariableDuplicationError
+    def kind = 'instance'
   end
 
   class ClassInstanceVariableDuplicationError < VariableDuplicationError
+    def kind = 'class instance'
   end
 
   class UnknownMethodAliasError < DefinitionError

data/lib/rbs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RBS
-  VERSION = "3.9.0.dev.1"
+  VERSION = "3.9.0.pre.1"
 end

data/sig/errors.rbs

@@ -185,17 +185,20 @@ module RBS
   class VariableDuplicationError < DefinitionError
     include DetailedMessageable
 
-    attr_reader member: AST::Members::Var
-
-    def initialize: (member: AST::Members::Var) -> void
+    attr_reader type_name: TypeName
+    attr_reader variable_name: Symbol
+    attr_reader location: Location[untyped, untyped]?
 
-    def location: () -> Location[bot, bot]
+    def initialize: (type_name: TypeName, variable_name: Symbol, location: Location[untyped, untyped]?) -> void
+    def kind: () -> String
   end
 
   class InstanceVariableDuplicationError < VariableDuplicationError
+    def kind: () -> String
   end
 
   class ClassInstanceVariableDuplicationError < VariableDuplicationError
+    def kind: () -> String
   end
 
   # The `alias` member declares an alias from unknown method

data/stdlib/ipaddr/0/ipaddr.rbs

@@ -276,6 +276,14 @@ class IPAddr
   #
   def native: () -> IPAddr
 
+  # <!--
+  #   rdoc-file=lib/ipaddr.rb
+  #   - netmask()
+  # -->
+  # Returns the netmask in string format e.g. 255.255.0.0
+  #
+  def netmask: () -> String
+
   # <!--
   #   rdoc-file=lib/ipaddr.rb
   #   - prefix()

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rbs
 version: !ruby/object:Gem::Version
-  version: 3.9.0.dev.1
+  version: 3.9.0.pre.1
 platform: ruby
 authors:
 - Soutaro Matsumoto
 bindir: exe
 cert_chain: []
-date: 2025-03-06 00:00:00.000000000 Z
+date: 2025-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logger