rbs 1.5.1 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4c3e2d7c96d7bfa810d993696088e8e4d7cd17301c5a96f925b38a6d2d6ef0c
-  data.tar.gz: f1a618f362782267bcbb221314f0070f0d6e6be4cd2436e3bf904c7bcbace039
+  metadata.gz: fb7050ff50eb28c830dd0b36c6f36a5d1913342daf67096313b2abf6d5285dbe
+  data.tar.gz: 4ee896f45c1857cea2f15a6cc69fd976c15055a36bb77cec51c669dfb56cc79e
 SHA512:
-  metadata.gz: c98f6bdf67e2fc41f421ccd778a029b74f5ecc121f79e3c0740fb2d5b7eb03d8ac95116ba2bfa4193d6aeee2fb1d819f5144d6e6c883e1e332ee4fa96f41cbb7
-  data.tar.gz: 515b1091e01179d3b472e8a7dc16fb520767a2b2d7617bebd14fce0d806ff6368ee633234de91cc49c0814673d55f5b44cff87bb5bbb5098f25b46002d14d7b7
+  metadata.gz: 3aa3aa5be6922a746a36012cb3c5ba624a44d0ed5dac05790942ebf44bb7f4f44a107209465a69143282b33e9a18b7b4f820d093b6228f0a091c0fb190268e32
+  data.tar.gz: fa46604d3d6b154555084d4d77861dbc8eae77d54f88486cf6df691da4b605576569f7d55acac1deeb3b30202ea561c9cf221ac44c8aab6acbe0cd483f7d786d

data/.github/dependabot.yml

@@ -0,0 +1,10 @@
+version: 2
+updates:
+  - package-ecosystem: "bundler"
+    directory: "/"
+    schedule:
+      interval: "daily"
+  - package-ecosystem: "bundler"
+    directory: "/steep"
+    schedule:
+      interval: "daily"

data/CHANGELOG.md

@@ -2,6 +2,31 @@
 
 ## master
 
+## 1.6.0 (2021-09-05)
+
+This release includes a preview of `rbs collection` commands, which is _bundler for RBS_.
+The command helps you manage RBS files from gem_rbs_collection or other repositories.
+
+This feature is a preview, and any feedback is welcome!
+
+## Signature updates
+
+* objspace ([\#763](https://github.com/ruby/rbs/pull/763), [\#776](https://github.com/ruby/rbs/pull/776))
+* tempfile ([\#767](https://github.com/ruby/rbs/pull/767), [\#775](https://github.com/ruby/rbs/pull/775))
+* `IO#set_encoding_by_bom` ([\#106](https://github.com/ruby/rbs/pull/106))
+* `OpenSSL::PKey::EC#dh_compute_key` ([\#775](https://github.com/ruby/rbs/pull/775))
+
+## Library changes
+
+* Add `rbs collection` ([\#589](https://github.com/ruby/rbs/pull/589), [\#772](https://github.com/ruby/rbs/pull/772), [\#773](https://github.com/ruby/rbs/pull/773))
+
+## Miscellaneous
+
+* Let `bin/annotate-with-rdoc` process nested constants/classes ([\#766](https://github.com/ruby/rbs/pull/766), [\#768](https://github.com/ruby/rbs/pull/768))
+* Stop printing version mismatch message in CI ([\#777](https://github.com/ruby/rbs/pull/777))
+* Update Steep and fix type errors ([\#770](https://github.com/ruby/rbs/pull/770), [\#774](https://github.com/ruby/rbs/pull/774))
+* Add dependabot configuration ([\#771](https://github.com/ruby/rbs/pull/771))
+
 ## 1.5.1 (2021-08-22)
 
 ### Miscellaneous

data/Gemfile

@@ -16,6 +16,7 @@ gem 'stackprof'
 gem "goodcheck"
 gem "dbm"
 gem 'digest'
+gem 'tempfile'
 
 # Test gems
 gem "rbs-amber", path: "test/assets/test-gem"

data/Steepfile

@@ -1,13 +1,21 @@
+D = Steep::Diagnostic
+
 target :lib do
   signature "sig"
   check "lib"
   ignore "lib/rbs/parser.rb"
   ignore "lib/rbs/prototype", "lib/rbs/test", "lib/rbs/test.rb"
 
-  library "set", "pathname", "json", "logger", "monitor", "tsort"
+  library "set", "pathname", "json", "logger", "monitor", "tsort", "uri"
   signature "stdlib/strscan/0/"
   signature "stdlib/rubygems/0/"
   signature "stdlib/optparse/0/"
+
+  configure_code_diagnostics do |config|
+    config[D::Ruby::MethodDefinitionMissing] = :hint
+    config[D::Ruby::ElseOnExhaustiveCase] = :hint
+    config[D::Ruby::FallbackAny] = :hint
+  end
 end
 
 # target :lib do

data/core/io.rbs

@@ -635,6 +635,8 @@ class IO < Object
   def set_encoding: (?String | Encoding ext_or_ext_int_enc) -> self
                   | (?String | Encoding ext_or_ext_int_enc, ?String | Encoding int_enc) -> self
 
+  def set_encoding_by_bom: () -> Encoding?
+
   # Returns status information for *ios* as an object of type `File::Stat` .
   #
   # ```ruby

data/docs/collection.md

@@ -0,0 +1,116 @@
+# RBS Collection manager
+
+`rbs collection` sub command manages third party gems' RBS. In short, it is `bundler` for RBS.
+
+## Requirements
+
+* `git(1)`
+* `Gemfile.lock`
+
+
+## Usage
+
+### Setup
+
+First, generate the configuration file, `rbs_collection.yaml`, with `rbs collection init`.
+
+```console
+$ rbs collection init
+created: rbs_collection.yaml
+
+$ cat rbs_collection.yaml
+# Download sources
+sources:
+  - name: ruby/gem_rbs_collection
+    remote: https://github.com/ruby/gem_rbs_collection.git
+    revision: main
+    repo_dir: gems
+
+# A directory to install the downloaded RBSs
+path: .gem_rbs_collection
+
+gems:
+  # Skip loading rbs gem's RBS.
+  # It's unnecessary if you don't use rbs as a library.
+  - name: rbs
+    ignore: true
+```
+
+I also recommend updating `.gitignore`.
+
+```console
+$ echo /.gem_rbs_collection/ >> .gitignore
+```
+
+### Install dependencies
+
+Then, install gems' RBS with `rbs collection install`! It copies RBS from [the gem RBS repository](https://github.com/ruby/gem_rbs_collection) to `.gem_rbs_collection/` directory by default.
+I recommend to ignore `.gem_rbs_collection/` from version control system, such as Git.
+
+```console
+$ rbs collection install
+Installing ast:2.4 (ruby/gem_rbs_collection@4b1a2a2f64c)
+...
+It's done! 42 gems's RBSs now installed.
+```
+
+Finally the third party RBSs are available! `rbs` commands, such as `rbs validate`, automatically load the third party RBSs.
+
+### Other commands
+
+`rbs collection` has two more commands.
+
+* `rbs collection update` updates `rbs_collection.lock.yaml`.
+* `rbs collection clean` removes unnecessary rbs from `.gem_rbs_collection` directory.
+
+## Configuration
+
+Configure `rbs collection` with editing `rbs_collection.yaml`.
+
+```yaml
+# Download sources.
+# You can add own collection git repository.
+sources:
+  - name: ruby/gem_rbs_collection
+    remote: https://github.com/ruby/gem_rbs_collection.git
+    revision: main
+    repo_dir: gems
+
+# A directory to install the downloaded RBSs
+path: .gem_rbs_collection
+
+gems:
+  # If the Gemfile.lock doesn't contain csv gem but you use csv gem,
+  # you can write the gem name explicitly to install RBS of the gem.
+  - name: csv
+
+  # If the Gemfile.lock contains nokogiri gem but you don't want to use the RBS,
+  # you can ignore the gem.
+  # `rbs collection` avoids to install nokogiri gem's RBS by this change.
+  # It is useful if the nokogiri RBS has a problem, such as compatibility issue with other RBS.
+  - name: nokogiri
+    ignore: true
+```
+
+## Files / Directories
+
+* `rbs_collection.yaml`
+  * The configuration file.
+  * You need to edit it if:
+    * You don't want to ignore gem's RBS.
+    * You want to add gem's RBS explicitly.
+  * You can change the file path with `--collection` option. e.g. `rbs --collection another_conf.yaml collection install`.
+* `rbs_collection.lock.yaml`
+  * RBS installs and loads RBS files with this file.
+  * It is auto-generated file. Do not edit this file.
+  * I recommend to manage it with VCS such as git.
+* `.gem_rbs_collection/`
+  * RBS installs third party RBS files to the directory.
+  * I recommend to ignore it from VCS.
+  * You can change the path with `path` option of `rbs_collection.yaml` file.
+
+
+## How it works
+
+`rbs collection` is integrated with Bundler.
+`rbs collection install` command generates `gem_rbs_collection.lock.yaml` from `gem_rbs_collection.yaml` and `Gemfile.lock`. It uses `Gemfile.lock` to detects dependencies.

data/lib/rbs/builtin_names.rb

@@ -51,5 +51,6 @@ module RBS
     Regexp = Name.define(:Regexp)
     TrueClass = Name.define(:TrueClass)
     FalseClass = Name.define(:FalseClass)
+    Numeric = Name.define(:Numeric)
   end
 end

data/lib/rbs/cli.rb

@@ -6,6 +6,7 @@ module RBS
   class CLI
     class LibraryOptions
       attr_accessor :core_root
+      attr_accessor :config_path
       attr_reader :repos
       attr_reader :libs
       attr_reader :dirs
@@ -16,6 +17,7 @@ module RBS
 
         @libs = []
         @dirs = []
+        @config_path = Collection::Config::PATH
       end
 
       def loader
@@ -25,6 +27,8 @@ module RBS
         end
 
         loader = EnvironmentLoader.new(core_root: core_root, repository: repository)
+        lock = config_path&.then { |p| Collection::Config.lockfile_of(p) }
+        loader.add_collection(lock) if lock
 
         dirs.each do |dir|
           loader.add(path: Pathname(dir))
@@ -52,6 +56,14 @@ module RBS
           self.core_root = nil
         end
 
+        opts.on('--collection PATH', "File path of collection configration (default: #{Collection::Config::PATH})") do |path|
+          self.config_path = Pathname(path).expand_path
+        end
+
+        opts.on('--no-collection', 'Ignore collection configration') do
+          self.config_path = nil
+        end
+
         opts.on("--repo DIR", "Add RBS repository") do |dir|
           repos << dir
         end
@@ -68,7 +80,7 @@ module RBS
       @stderr = stderr
     end
 
-    COMMANDS = [:ast, :list, :ancestors, :methods, :method, :validate, :constant, :paths, :prototype, :vendor, :parse, :test]
+    COMMANDS = [:ast, :list, :ancestors, :methods, :method, :validate, :constant, :paths, :prototype, :vendor, :parse, :test, :collection]
 
     def parse_logging_options(opts)
       opts.on("--log-level LEVEL", "Specify log level (defaults to `warn`)") do |level|
@@ -819,11 +831,90 @@ EOB
 
       # @type var out: String
       # @type var err: String
-      out, err, status = Open3.capture3(env_hash, *args)
+      out, err, status = __skip__ = Open3.capture3(env_hash, *args)
       stdout.print(out)
       stderr.print(err)
 
       status
     end
+
+    def run_collection(args, options)
+      warn "warning: rbs collection is experimental, and the behavior may change until RBS v2.0"
+
+      opts = collection_options(args)
+      params = {}
+      opts.order args.drop(1), into: params
+      config_path = options.config_path or raise
+      lock_path = Collection::Config.to_lockfile_path(config_path)
+
+      case args[0]
+      when 'install'
+        unless params[:frozen]
+          Collection::Config.generate_lockfile(config_path: config_path, gemfile_lock_path: Pathname('./Gemfile.lock'))
+        end
+        Collection::Installer.new(lockfile_path: lock_path, stdout: stdout).install_from_lockfile
+      when 'update'
+        # TODO: Be aware of argv to update only specified gem
+        Collection::Config.generate_lockfile(config_path: config_path, gemfile_lock_path: Pathname('./Gemfile.lock'), with_lockfile: false)
+        Collection::Installer.new(lockfile_path: lock_path, stdout: stdout).install_from_lockfile
+      when 'init'
+        if config_path.exist?
+          puts "#{config_path} already exists"
+          exit 1
+        end
+
+        config_path.write(<<~'YAML')
+          # Download sources
+          sources:
+            - name: ruby/gem_rbs_collection
+              remote: https://github.com/ruby/gem_rbs_collection.git
+              revision: main
+              repo_dir: gems
+
+          # A directory to install the downloaded RBSs
+          path: .gem_rbs_collection
+
+          gems:
+            # Skip loading rbs gem's RBS.
+            # It's unnecessary if you don't use rbs as a library.
+            - name: rbs
+              ignore: true
+        YAML
+        stdout.puts "created: #{config_path}"
+      when 'clean'
+        unless lock_path.exist?
+          puts "#{lock_path} should exist to clean"
+          exit 1
+        end
+        Collection::Cleaner.new(lockfile_path: lock_path)
+      when 'help'
+        puts opts.help
+      else
+        puts opts.help
+        exit 1
+      end
+    end
+
+    def collection_options(args)
+      OptionParser.new do |opts|
+        opts.banner = <<~HELP
+          Usage: rbs collection [install|update|init|clean|help]
+
+          Manage RBS collection, which contains third party RBS.
+
+          Examples:
+
+            # Initialize the configration file
+            $ rbs collection init
+
+            # Generate the lock file and install RBSs from the lock file
+            $ rbs collection install
+
+            # Update the RBSs
+            $ rbs collection update
+        HELP
+        opts.on('--frozen') if args[0] == 'install'
+      end
+    end
   end
 end

data/lib/rbs/collection/cleaner.rb

@@ -0,0 +1,29 @@
+module RBS
+  module Collection
+    class Cleaner
+      attr_reader :lock
+
+      def initialize(lockfile_path:)
+        @lock = Config.from_path(lockfile_path)
+      end
+
+      def clean
+        lock.repo_path.glob('*/*') do |dir|
+          *_, gem_name, version = dir.to_s.split('/')
+          gem_name or raise
+          version or raise
+          next if needed? gem_name, version
+
+          FileUtils.remove_entry_secure(dir.to_s)
+        end
+      end
+
+      def needed?(gem_name, version)
+        gem = lock.gem(gem_name)
+        return false unless gem
+
+        gem['version'] == version
+      end
+    end
+  end
+end

data/lib/rbs/collection/config/lockfile_generator.rb

@@ -0,0 +1,95 @@
+module RBS
+  module Collection
+
+    # This class represent the configration file.
+    class Config
+      class LockfileGenerator
+        attr_reader :config, :lock, :gemfile_lock, :lock_path
+
+        def self.generate(config_path:, gemfile_lock_path:, with_lockfile: true)
+          new(config_path: config_path, gemfile_lock_path: gemfile_lock_path, with_lockfile: with_lockfile).generate
+        end
+
+        def initialize(config_path:, gemfile_lock_path:, with_lockfile:)
+          @config = Config.from_path config_path
+          @lock_path = Config.to_lockfile_path(config_path)
+          @lock = Config.from_path(lock_path) if lock_path.exist? && with_lockfile
+          @gemfile_lock = Bundler::LockfileParser.new(gemfile_lock_path.read)
+        end
+
+        def generate
+          config.gems.each do |gem|
+            assign_gem(gem_name: gem['name'], version: gem['version'])
+          end
+
+          gemfile_lock_gems do |spec|
+            assign_gem(gem_name: spec.name, version: spec.version)
+          end
+          remove_ignored_gems!
+
+          config.dump_to(lock_path)
+          config
+        end
+
+        private def assign_gem(gem_name:, version:)
+          locked = lock&.gem(gem_name)
+          specified = config.gem(gem_name)
+
+          return if specified&.dig('ignore')
+          return if specified&.dig('source') # skip if the source is already filled
+
+          if locked
+            # If rbs_collection.lock.yaml contain the gem, use it.
+            upsert_gem specified, locked
+          else
+            # Find the gem from gem_collection.
+            source = find_source(gem_name: gem_name)
+            return unless source
+
+            installed_version = version
+            best_version = find_best_version(version: installed_version, versions: source.versions({ 'name' => gem_name }))
+            # @type var new_content: RBS::Collection::Config::gem_entry
+            new_content = {
+              'name' => gem_name,
+              'version' => best_version.to_s,
+              'source' => source.to_lockfile,
+            }
+            upsert_gem specified, new_content
+          end
+        end
+
+        private def upsert_gem(old, new)
+          if old
+            old.merge! new
+          else
+            config.add_gem new
+          end
+        end
+
+        private def remove_ignored_gems!
+          config.gems.reject! { |gem| gem['ignore'] }
+        end
+
+        private def gemfile_lock_gems(&block)
+          gemfile_lock.specs.each do |spec|
+            yield spec
+          end
+        end
+
+        private def find_source(gem_name:)
+          sources = config.sources
+
+          sources.find { |c| c.has?({ 'name' => gem_name, 'revision' => nil } ) }
+        end
+
+        private def find_best_version(version:, versions:)
+          candidates = versions.map { |v| Gem::Version.create(v) or raise }
+          return candidates.max || raise unless version
+
+          v = Gem::Version.create(version) or raise
+          Repository.find_best_version(v, candidates)
+        end
+      end
+    end
+  end
+end