rbbt-util 5.34.25 → 5.34.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1a0dc0772864a83c7c6b159d53dc1c5d95e7f58619c4e4b0c630e8240a621aa
-  data.tar.gz: c8a029debfd1ee7c820185aa1dead29575ecd173a1868692751c6a01dc7be01a
+  metadata.gz: da3b496fd0fb7d9ff645cba0fb4ba3914288fb0b88bf80f43a79d02bd1ee2cfd
+  data.tar.gz: ab120f9bb96f1b0628f1edc6dc114a43c32ed39a5c29ce5252bbf85383d24359
 SHA512:
-  metadata.gz: b151561ce56b42af19160eff58a8f45be7fedd6226d960987111e8b9d1147802eb612f96b85a47ad849476b7d4520df457ed70e91e9528d67e9e03a6959f78c4
-  data.tar.gz: 60b1a486a88bd2c65a4c003130c7c81de42ce72446420797132d1047be2446fce74f7cb35c80a652a1f56dcc630ba6e32d7c991a524efeab85a05325aaae1024
+  metadata.gz: 3f5b5326a834f1f972756919ea2f04c9626998be3c9ca058fd386c06787011ad021798e6091eb8eae1f7873dcceb9adcfa02de14a5269dadef4a2902d5475a9d
+  data.tar.gz: d74344affb899a6b62a494d02e9058dc338a7be4138b9ce32331d0657bc121035b312da21f48827751dc13e1bdee4511fb6f1eeaf481d39f73e5967ff3243800

data/lib/rbbt/workflow/dependencies.rb

@@ -72,12 +72,7 @@ module Workflow
   def setup_override_dependency(dep, workflow, task_name)
     return [] if dep == :skip || dep == 'skip'
 
-    if not Step === dep
-      located = Open.exists?(dep) || Open.exists?(dep + '.info')
-      dep = Workflow.load_step(dep)
-    else
-      located = true
-    end
+    dep = Workflow.load_step(dep) if not Step === dep
 
     dep.original_workflow ||= dep.workflow if dep.workflow
     dep.original_task_name ||= dep.task_name if dep.task_name
@@ -88,7 +83,6 @@ module Workflow
     dep.workflow = workflow
     dep.info[:name] = dep.name
 
-
     begin
       workflow = Kernel.const_get workflow if String === workflow
       dep.task = workflow.tasks[task_name] if dep.task.nil? && workflow.tasks.include?(task_name)
@@ -97,13 +91,17 @@ module Workflow
     end
 
     dep.task_name = task_name
-    dep.overriden = dep.original_task_name.to_sym if dep.original_task_name && located
+    dep.overriden = dep.original_task_name.to_sym if dep.original_task_name 
 
     dep.extend step_module
 
     dep
   end
 
+  def unlocated_override?(dep)
+    String === dep && ! (Open.exists?(dep) || Open.exists?(dep + '.info'))
+  end
+
   def assign_dep_inputs(_inputs, options, all_d, task_info)
     IndiferentHash.setup(_inputs)
 
@@ -155,6 +153,7 @@ module Workflow
 
     override_dependencies = override_dependencies(inputs)
 
+    overriden = false
     dependencies.each do |dependency|
       _inputs = IndiferentHash.setup(inputs.dup)
       jobname = orig_jobname
@@ -165,6 +164,7 @@ module Workflow
                    workflow, dep_task, options = dependency
 
                    if override_dependencies[workflow.to_s] && value = override_dependencies[workflow.to_s][dep_task]
+                     overriden = true if (options.nil? || ! options[:not_overriden]) && ! unlocated_override?(value)
                      setup_override_dependency(value, workflow, dep_task)
                    else
 
@@ -177,15 +177,23 @@ module Workflow
 
                      job = workflow._job(dep_task, jobname, _inputs)
                      ComputeDependency.setup(job, compute) if compute
+
+                     overriden = true if TrueClass === job.overriden && (options.nil? || ! options[:not_overriden])
+
                      job
                    end
                  when Step
-                   dependency
+                   job = dependency
+                   overriden = true if TrueClass === job.overriden && (options.nil? || ! options[:not_overriden])
+                   job
                  when Symbol
                    if override_dependencies[self.to_s] && value = override_dependencies[self.to_s][dependency]
+                     overriden = true if (options.nil? || ! options[:not_overriden]) && ! unlocated_override?(value)
                      setup_override_dependency(value, self, dependency)
                    else
-                     _job(dependency, jobname, _inputs)
+                     job = _job(dependency, jobname, _inputs)
+                     overriden = true if TrueClass === job.overriden && (options.nil? || ! options[:not_overriden])
+                     job
                    end
                  when Proc
                    if DependencyBlock === dependency
@@ -193,6 +201,7 @@ module Workflow
                      wf, task_name, options = orig_dep
 
                      if override_dependencies[wf.to_s] && value = override_dependencies[wf.to_s][task_name]
+                       overriden = true if (options.nil? || ! options[:not_overriden]) && ! unlocated_override?(value)
                        dep = setup_override_dependency(value, wf, task_name)
                      else
 
@@ -208,16 +217,20 @@ module Workflow
                        dep.each{|d| 
                          next if d.nil?
                          if Hash === d
+                           d = d.merge(options)
                            d[:workflow] ||= wf 
                            d[:task] ||= task_name
                            _override_dependencies = override_dependencies.merge(override_dependencies(d[:inputs] || {}))
                            d = if _override_dependencies[d[:workflow].to_s] && value = _override_dependencies[d[:workflow].to_s][d[:task]]
+                                 overriden = true if (options.nil? || ! options[:not_overriden]) && ! unlocated_override?(value)
                                  setup_override_dependency(value, d[:workflow], d[:task])
                                else
                                  task_info = d[:workflow].task_info(d[:task])
 
                                  _inputs = assign_dep_inputs({}, options.merge(d[:inputs] || {}), real_dependencies, task_info) 
-                                 d[:workflow]._job(d[:task], d[:jobname], _inputs) 
+                                 job = d[:workflow]._job(d[:task], d[:jobname], _inputs) 
+                                 overriden = true if TrueClass === job.overriden && (d.nil? || ! d[:not_overriden])
+                                 job
                                end
                          end
                          ComputeDependency.setup(d, compute) if compute
@@ -232,11 +245,15 @@ module Workflow
                        dep[:workflow] ||= wf || self
                        _override_dependencies = override_dependencies.merge(override_dependencies(dep[:inputs] || {}))
                        if _override_dependencies[dep[:workflow].to_s] && value = _override_dependencies[dep[:workflow].to_s][dep[:task]]
+                         overriden = true if (options.nil? || ! options[:not_overriden]) && ! unlocated_override?(value)
                          setup_override_dependency(value, dep[:workflow], dep[:task])
                        else
                          task_info = (dep[:task] && dep[:workflow]) ? dep[:workflow].task_info(dep[:task]) : nil
                          _inputs = assign_dep_inputs({}, dep[:inputs], real_dependencies, task_info)
-                         dep = dep[:workflow]._job(dep[:task], dep[:jobname], _inputs)
+                         job = dep[:workflow]._job(dep[:task], dep[:jobname], _inputs)
+                         job = d[:workflow]._job(d[:task], d[:jobname], _inputs) 
+                         overriden = true if TrueClass === job.overriden && (d.nil? || ! d[:not_overriden])
+                         job
                        end
                      end
                    end
@@ -248,6 +265,6 @@ module Workflow
 
       real_dependencies << real_dep
     end
-    real_dependencies.flatten.compact
+    [real_dependencies.flatten.compact, overriden]
   end
 end

data/lib/rbbt/workflow/step/dependencies.rb

@@ -526,6 +526,7 @@ class Step
   end
 
   def overriden?
+    return @overriden
     return true if @overriden
     return true if dependencies && dependencies.select{|dep| TrueClass === dep.overriden }.any?
     info[:archived_info].each do |f,i|

data/lib/rbbt/workflow.rb

@@ -285,6 +285,7 @@ module Workflow
 
     workdir[taskname][tagged_jobname].find
   end
+
   def import_task(workflow, orig, new)
     orig_task = workflow.tasks[orig]
     new_task = orig_task.dup
@@ -442,10 +443,8 @@ module Workflow
     end
 
     real_inputs = {}
-    has_overriden_inputs = false
 
     inputs.each do |k,v|
-      #has_overriden_inputs = true if String === k and k.include? "#"
       next unless (task_inputs.include?(k.to_sym) or task_inputs.include?(k.to_s))
       default = all_defaults[k]
       next if default == v 
@@ -461,12 +460,10 @@ module Workflow
 
     jobname = DEFAULT_NAME if jobname.nil? or jobname.empty?
 
-    dependencies = real_dependencies(task, jobname, defaults.merge(inputs), task_dependencies[taskname] || [])
-
-    overriden_deps = dependencies.select{|d| d.overriden }
-    true_overriden_deps = overriden_deps.select{|d| TrueClass === d.overriden }
+    dependencies, overriden = real_dependencies(task, jobname, defaults.merge(inputs), task_dependencies[taskname] || [])
 
-    overriden = has_overriden_inputs || overriden_deps.any?
+    #overriden_deps        = dependencies.select{|d| Symbol === d.overriden }
+    #overriden_target_deps = overriden_deps.select{|d| TrueClass === d.overriden }
 
     extension = task.extension
 
@@ -492,19 +489,20 @@ module Workflow
       step_path = step_path taskname, jobname, input_values, dependencies, extension
     end
 
-
     job = get_job_step step_path, task, input_values, dependencies
     job.workflow = self
+    job.overriden ||= overriden 
     job.clean_name = jobname
 
-    case not_overriden 
-    when TrueClass
-      job.overriden = has_overriden_inputs || true_overriden_deps.any?
-    when :not_overriden_dep
-      job.overriden = true if has_overriden_inputs || true_overriden_deps.any?
-    else
-      job.overriden = true if has_overriden_inputs || true_overriden_deps.any?
-    end
+    #iif [job, not_overriden]
+    #case not_overriden 
+    #when TrueClass
+    #  job.overriden = false
+    #when :not_overriden_dep
+    #  job.overriden = true if overriden_target_deps.any?
+    #else
+    #  job.overriden = true if overriden_deps.any?
+    #end
 
     job.real_inputs = real_inputs.keys
     job

data/test/rbbt/test_workflow.rb

@@ -166,6 +166,33 @@ for this dependency
     dep = dependencies.flatten.first
   end
 
+  task :overr_orig => :string do
+    "over"
+  end
+
+  task :overr_alt => :string do
+    "alt"
+  end
+
+  dep :overr_orig
+  task :overr_target => :string do
+    step(:overr_orig).load.reverse
+  end
+
+  dep :overr_alt, :not_overriden => true
+  dep :overr_target, "TestWF#overr_orig" => :overr_alt, :not_overriden => true
+  task :overr_action => :string do
+    step(:overr_target).load.upcase
+  end
+
+
+  dep :overr_alt, :not_overriden => true
+  dep :overr_target, "TestWF#overr_orig" => :overr_alt
+  task :overr_action2 => :string do
+    step(:overr_target).load.upcase
+  end
+
+
 end
 
 TestWF.workdir = Rbbt.tmp.test.jobs.TestWF
@@ -419,7 +446,7 @@ class TestWorkflow < Test::Unit::TestCase
       TmpFile.with_file do |dir|
         Path.setup(dir)
         Step.save_job_inputs(job, dir)
-        assert_equal Dir.glob(dir + "/*"), [dir.file.find]
+        assert_equal Dir.glob(dir + "/*"), [dir.file.find + '.as_path']
       end
     end
 
@@ -427,7 +454,7 @@ class TestWorkflow < Test::Unit::TestCase
     TmpFile.with_file do |dir|
       Path.setup(dir)
       Step.save_job_inputs(job, dir)
-      assert_equal Dir.glob(dir + "/*"), [dir.file.find + '.yaml']
+      assert_equal Dir.glob(dir + "/*"), [dir.file.find + '.as_path']
       inputs  = Workflow.load_inputs(dir, [:file], :file => :file)
       assert_equal inputs, {:file => 'code'}
     end
@@ -472,4 +499,18 @@ class TestWorkflow < Test::Unit::TestCase
       end
     end
   end
+
+  def test_overriden
+    job = TestWF.job(:overr_action)
+    job.recursive_clean
+    assert_equal "TLA", job.run
+
+    assert Symbol === job.step(:overr_orig).overriden
+    assert TrueClass === job.step(:overr_target).overriden
+    assert ! job.overriden
+
+    job = TestWF.job(:overr_action2)
+    assert_equal "TLA", job.run
+    assert job.overriden
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rbbt-util
 version: !ruby/object:Gem::Version
-  version: 5.34.25
+  version: 5.34.26
 platform: ruby
 authors:
 - Miguel Vazquez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-12 00:00:00.000000000 Z
+date: 2022-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake