rbattlenet 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8003293eb4fd70da7ba5d7d56b7abcf775d631af
-  data.tar.gz: 67f6be0c0acf097957c8f26c64b9206e195785e6
+  metadata.gz: 672edf0b68f7ad1b2454b354fd27b3c37c23d31d
+  data.tar.gz: 8327e06e65939d323d1029907d0443db31bf0a3d
 SHA512:
-  metadata.gz: f34af6db0c0ba2b899c2edcabb6bf71dc0c9dbd82e1eb571e487c473724c3facdbd40314a83bbb44e4e921c04515d96b94d3ea4408df4b842bbd131fae576f1a
-  data.tar.gz: 609d9866e4b272540b73f5d86bbe74c6f98529123f8188e826d99f35e11f48b890919ff8bd9d22c512ebc20cc2cc63ec2f5e8665eb796cb3fc8b64e4ea232a31
+  metadata.gz: 6fdd4a997da1db188b701be7b6a8b7bb378f2fed9350d2cf336d0eb79d48f9d3013d87893b029f478b4fa72c26c75cb0cd7becf5a0beaa927b705a3eded48cc8
+  data.tar.gz: dc7fba179d4496987ecafcc118c87fdf5442a251a065cda35564039e19a7c242db46dfa413676c0c708c7fcc668ccdd0b1d034f665ced0cbf7f2a91f9426e974

data/README.md

@@ -1,6 +1,7 @@
 # RBattlenet
+[![Code Climate](https://codeclimate.com/github/wingyu/rbattlenet/badges/gpa.svg)](https://codeclimate.com/github/wingyu/rbattlenet)
 
-A Ruby wrapper for the Blizzard's Battle.net Community Platform API.
+A Ruby gem that wraps Blizzard's Battle.net Community Platform API.
 Currently RBattlenet only covers the World of Warcraft, Diablo 3 and StarCraft 2 APIs
 
 ## Installation
@@ -43,42 +44,20 @@ RBattlenet.set_region(region: "eu", locale: "en_GB")
 
 ```ruby
 character = RBattlenet::Wow::Character.find(name: "milhause", realm: "saurfang")
+#character["name"] will give you "Milhause"
 ```
-<a name="overview"></a>
-## Overview
+## Documentation
 ### [World of Warcraft](#wow)
 
 * [Achievement](#wow-achievement)
 * [Auction](#wow-auction)
 * [Battle Pet](#wow-battle-pet)
-  * [Ability](#wow-battle-pet-ability)
-  * [Species](#wow-battle-pet-species)
-  * [Stats](#wow-battle-pet-stats)
 * [Challenge](#wow-challenge)
-  * [Realm Leaderboard](#wow-challenge-realm-leaderboard)
-  * [Region Leaderboard](#wow-challenge-region-leaderboard)
 * [Character](#wow-character)
-  * [Profile](#wow-character-profile)
-  * [Additional Fields](#wow-character-fields)
 * [Data Resources](#wow-data)
-  * [Battlegroups](#wow-data-battlegroups)
-  * [Character Achievements](#wow-data-character-achievements)
-  * [Character Classes](#wow-data-character-classes)
-  * [Character Races](#wow-data-character-races)
-  * [Guild Achievements](#wow-data-guild-achievements)
-  * [Guild Perks](#wow-data-guild-perks)
-  * [Guild Rewards](#wow-data-guild-rewards)
-  * [Item Classes](#wow-data-item-classes)
-  * [Pet Types](#wow-data-pet-types)
-  * [Talents](#wow-data-talents)
 * [Guild](#wow-guild)
-  * [Profile](#wow-guild-profile)
-  * [Profile](#wow-guild-fields)
 * [Item](#wow-item)
-  * [Item](#wow-item-item)
-  * [Item Set](#wow-item-item-set)
 * [PVP](#wow-pvp)
-  * [Leaderboards](#wow-pvp-leaderboards)
 * [Quest](#wow-quest)
 * [Realm Status](#wow-realm-status)
 * [Recipe](#wow-recipe)
@@ -87,22 +66,13 @@ character = RBattlenet::Wow::Character.find(name: "milhause", realm: "saurfang")
 ### [Starcraft 2](#sc2)
 
 * [Data Resources](#sc2-data)
-  * [Achievements](#sc2-data-achievements)
-  * [Rewards](#sc2-data-rewards)
 * [Ladder](#sc2-ladder)
 * [Profile](#sc2-profile)
-  * [Ladders](#sc2-profile-ladders)
-  * [Match History](#sc2-profile-match-history)
 
 ### [Diablo 3](#d3)
 
 * [Data Resources](#d3-data)
-  * [Artisan](#d3-data-artisan)
-  * [Follower](#d3-data-follower)
-  * [Item](#d3-data-item)
 * [Profile](#d3-profile)
-  * [Career](#d3-profile-career)
-  * [Hero](#d3-profile-hero)
 
 ---
 
@@ -131,21 +101,18 @@ RBattlenet::Wow::Auction.find(realm: "saurfang")
 <a name="wow-battle-pet"></a>
 ### Battle Pet
 
-<a name="wow-battle-pet-ability"></a>
 #### Abilities
 
 ```ruby
 RBattlenet::Wow::Battlepet.find_abilities(id: 640)
 ```
 
-<a name="wow-battle-pet-species"></a>
 #### Species
 
 ```ruby
 RBattlenet::Wow::Battlepet.find_species(species_id: 258)
 ```
 
-<a name="wow-battle-pet-stats"></a>
 #### Stats
 
 ```ruby
@@ -160,14 +127,12 @@ RBattlenet::Wow::Battlepet.find_stats(species_id: 258,
 <a name="wow-challenge"></a>
 ### Challenge
 
-<a name="wow-challenge-realm-leaderboard"></a>
 #### Realm Leaderboard
 
 ```ruby
 RBattlenet::Wow::Challenge.find_realm(realm: "saurfang")
 ```
 
-<a name="wow-challenge-region-leaderboard"></a>
 #### Region Leaderboard
 
 
@@ -180,7 +145,6 @@ RBattlenet::Wow::Challenge.find_region
 <a name="wow-character"></a>
 ### Character
 
-<a name="wow-character-profile"></a>
 #### Profile
 
 
@@ -188,7 +152,6 @@ RBattlenet::Wow::Challenge.find_region
 RBattlenet::Wow::Character.find(name: "milhause", realm: "saurfang")
 ```
 
-<a name="wow-character-fields"></a>
 #### Additional Fields
 
 To see all possible fields visit: [https://dev.battle.net/](https://dev.battle.net)
@@ -199,11 +162,11 @@ RBattlenet::Wow::Character.find(name: "milhause",
   realm: "saurfang",
   fields: ["pet slots", "guild"])
 ```
+---
 
 <a name="wow-data"></a>
 ### Data Resources
 
-<a name="wow-data-battlegroups"></a>
 #### Battlegroups
 
 
@@ -211,7 +174,6 @@ RBattlenet::Wow::Character.find(name: "milhause",
 RBattlenet::Wow::DataResources.find_battlegroups
 ```
 
-<a name="wow-data-character-achievements"></a>
 #### Character Achievements
 
 
@@ -219,7 +181,6 @@ RBattlenet::Wow::DataResources.find_battlegroups
 RBattlenet::Wow::DataResources.find_character_achievements
 ```
 
-<a name="wow-data-character-classes"></a>
 #### Character Classes
 
 
@@ -227,7 +188,6 @@ RBattlenet::Wow::DataResources.find_character_achievements
 RBattlenet::Wow::DataResources.find_character_classes
 ```
 
-<a name="wow-data-character-races"></a>
 #### Character Races
 
 
@@ -235,7 +195,6 @@ RBattlenet::Wow::DataResources.find_character_classes
 RBattlenet::Wow::DataResources.find_character_races
 ```
 
-<a name="wow-data-guild-achievements"></a>
 #### Guild Achievements
 
 
@@ -243,7 +202,6 @@ RBattlenet::Wow::DataResources.find_character_races
 RBattlenet::Wow::DataResources.find_guild_achievements
 ```
 
-<a name="wow-data-guild-perks"></a>
 #### Guild Perks
 
 
@@ -259,7 +217,6 @@ RBattlenet::Wow::DataResources.find_guild_perks
 RBattlenet::Wow::DataResources.find_guild_rewards
 ```
 
-<a name="wow-data-item-classes"></a>
 #### Item Classes
 
 
@@ -267,7 +224,6 @@ RBattlenet::Wow::DataResources.find_guild_rewards
 RBattlenet::Wow::DataResources.find_item_classes
 ```
 
-<a name="wow-data-pet-types"></a>
 #### Pet Types
 
 
@@ -275,7 +231,6 @@ RBattlenet::Wow::DataResources.find_item_classes
 RBattlenet::Wow::DataResources.find_pet_types
 ```
 
-<a name="wow-data-talents"></a>
 #### Talents
 
 
@@ -288,14 +243,12 @@ RBattlenet::Wow::DataResources.find_talents
 <a name="wow-item"></a>
 ### Item
 
-<a name="wow-item-item"></a>
 #### Item
 
 ```ruby
 RBattlenet::Wow::Item.find(id: 18803);
 ```
 
-<a name="wow-item-item-set"></a>
 #### Item Set
 
 
@@ -308,14 +261,12 @@ RBattlenet::Wow::Item.find_set(id: 1060)
 <a name="wow-guild"></a>
 ### Guild
 
-<a name="wow-guild-profile"></a>
 #### Profile
 
 ```ruby
 RBattlenet::Wow::Guild.find(name: "razors edge", realm:"saurfang")
 ```
 
-<a name="wow-guild-fields"></a>
 #### Additional data
 
 
@@ -330,7 +281,6 @@ RBattlenet::Wow::Guild.find(name: "razors edge",
 <a name="wow-pvp"></a>
 ### PVP
 
-<a name="wow-pvp-leaderboards"></a>
 #### Leaderboards
 
 ```ruby
@@ -384,14 +334,12 @@ RBattlenet::Wow::Spell.find(id: 8056)
 RBattlenet::Sc2::Profile.find(id: 2137104, region: 1, name: 'skt')
 ```
 
-<a name="sc2-profile-ladders"></a>
 #### Ladders
 
 ```ruby
 RBattlenet::Sc2::Profile.find_ladders(id: 2137104, region: 1, name: 'skt')
 ```
 
-<a name="sc2-profile-match-history"></a>
 #### Match history
 
 
@@ -413,7 +361,6 @@ RBattlenet::Sc2::Ladder.find(id: 2200)
 <a name="sc2-data"></a>
 ### Data Resources
 
-<a name="sc2-data-achievements"></a>
 #### Achievements
 
 
@@ -421,7 +368,6 @@ RBattlenet::Sc2::Ladder.find(id: 2200)
 RBattlenet::Sc2::DataResources.find_achievements
 ```
 
-<a name="sc2-data-rewards"></a>
 #### Rewards
 
 
@@ -437,21 +383,18 @@ RBattlenet::Sc2::DataResources.find_rewards
 <a name="d3-data"></a>
 ### Data Resources
 
-<a name="d3-data-artisan"></a>
 #### Artisan
 
 ```ruby
 RBattlenet::D3::DataResources.find_artisan(artisan: 'blacksmith')
 ```
 
-<a name="d3-data-follower"></a>
 #### Follower
 
 ```ruby
 RBattlenet::D3::DataResources.find_follower(follower: 'templar')
 ```
 
-<a name="d3-data-item"></a>
 #### Item
 
 ```ruby
@@ -465,14 +408,12 @@ RBattlenet::D3::DataResources.find_item(data: data)
 <a name="d3-profile"></a>
 ### Profile
 
-<a name="d3-profile-career"></a>
 #### Career
 
 ```ruby
 RBattlenet::D3::Profile.find_career(battletag: "FaYe-2543")
 ```
 
-<a name="d3-profile-hero"></a>
 #### Hero
 
 ```ruby

data/lib/rbattlenet/rbattlenet.rb

@@ -61,7 +61,7 @@ module RBattlenet
     #Wrapper for HTTParty requests that injects query parameters
     def get(uri, queries = @@queries)
       begin
-        HTTParty.get(uri + queries)
+        HTTParty.get(URI.escape(uri + queries))
       rescue
         RBattlenet::Errors::ConnectionError
       end
@@ -72,10 +72,6 @@ module RBattlenet
       "https://#{@@region}.api.battle.net/#{path}"
     end
 
-    def parse_spaces(input)
-      input.gsub(" ", '%20')
-    end
-
     #Merges required and optional query parameters
     def merge_queries(queries)
       @@queries + "#{queries}"

data/lib/rbattlenet/version.rb

@@ -1,3 +1,3 @@
 module RBattlenet
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/lib/rbattlenet/wow/challenge.rb

@@ -2,7 +2,6 @@ module RBattlenet
   module Wow
     class Challenge
       def self.find_realm(realm:)
-        realm =  RBattlenet.parse_spaces(realm)
 
         uri = RBattlenet.
           base_uri("#{GAME}/challenge/#{realm}")

data/lib/rbattlenet/wow/character.rb

@@ -3,7 +3,6 @@ module RBattlenet
     class Character
       def self.find(name:, realm:, fields: nil)
         fields = RBattlenet.parse_fields(fields)
-        realm =  RBattlenet.parse_spaces(realm)
         queries = RBattlenet.merge_queries(fields)
 
         uri = RBattlenet.

data/lib/rbattlenet/wow/guild.rb

@@ -2,9 +2,7 @@ module RBattlenet
   module Wow
     class Guild
       def self.find(name:, realm:, fields: nil)
-        name = RBattlenet.parse_spaces(name)
         fields = RBattlenet.parse_fields(fields)
-        realm =  RBattlenet.parse_spaces(realm)
         queries = RBattlenet.merge_queries(fields)
 
         uri = RBattlenet.

data/rbattlenet.gemspec

@@ -21,7 +21,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "httparty", "~> 0.13.6"
   spec.add_development_dependency 'vcr', '~> 2.9.3'
   spec.add_development_dependency "webmock"
+
+  spec.add_runtime_dependency "httparty", "~> 0.13.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rbattlenet
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Vincent Wong
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-29 00:00:00.000000000 Z
+date: 2016-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: httparty
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.13.6
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.13.6
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: httparty
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.13.6
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.13.6
 description: My attempt at creating a Ruby wrapper for the Blizzard's Battle.net Community
   Platform API.
 email:
@@ -217,7 +217,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: A wrapper for the Blizzard's Battle.net API