rb_lovely 0.6.3 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 81e2fd334254b0f4e4583898aec3b6dd84f81e0a
-  data.tar.gz: 00285bf3cd11e2b69fc919668beda886ee618b5d
+  metadata.gz: 0f77c4e7bc0c9011e9fac59b5c509836c1217661
+  data.tar.gz: abeb9c72ab3f9c8a636986fb792639fb922c3409
 SHA512:
-  metadata.gz: 81555a532701e85a2e4dd0fd2388d895ee2810e07a273f5e039e45373d4476b8be3b3bbcf1d1a8afda11af4c0829ba7f24d28e71fd55efeda70810ea5e5e6add
-  data.tar.gz: 03117a51cacbb791b7529cd8691c087e0b8c4bb9c47cf95ac1d638731e1f374fc53d979b2992ceb559b75ba74776303c7465c81f02d69f492b8ce55ab639f93f
+  metadata.gz: 424beddca21eba29ed7e03d7bc61c071d4f29eeced343c4160a0259ef3132249b84b6c29293d27ccb755cb44fd14e4a9f49f0aa053534de9856ba532f5b44068
+  data.tar.gz: 5df6f7524c57ad2b0dbe6753f8b4c4ec6d2f50dfc387a6a0894f43172952bc2cf102c76fa546a266851099302791c9f1292fa361a064da4cb911a66314521a75

data/ext/rb_lovely/container.hpp

@@ -5,9 +5,7 @@
 
 namespace rb_lovely {
 
-// TODO: No more toS, provide inspect instead which is what the containers should be using
-//       for each member.
-auto toS = [](VALUE val) { return RSTRING_PTR(rb_funcall(val, to_sSym, 0)); };
+auto rbInspect = [](VALUE val) { return RSTRING_PTR(rb_funcall(val, inspectSym, 0)); };
 
 }
 #endif

data/ext/rb_lovely/package.cpp

@@ -5,7 +5,7 @@ namespace rb_lovely {
   VALUE rbMod;
   VALUE cmpMethSym;
   VALUE hashEqualitySym;
-  VALUE to_sSym;
+  VALUE inspectSym;
   VALUE hashSym;
   VALUE compareSym;
   VALUE callSym;

data/ext/rb_lovely/ruby_util.hpp

@@ -7,7 +7,7 @@ namespace rb_lovely {
 extern VALUE rbMod;
 extern VALUE cmpMethSym;
 extern VALUE hashEqualitySym;
-extern VALUE to_sSym;
+extern VALUE inspectSym;
 extern VALUE hashSym;
 extern VALUE callSym;
 extern VALUE compareSym;
@@ -39,7 +39,7 @@ static void initRubyUtil() {
   rbMod = rb_define_module("RbLovely");
   cmpMethSym = rb_intern("<=>");
   hashEqualitySym = rb_intern("eql?");
-  to_sSym = rb_intern("to_s");
+  inspectSym = rb_intern("inspect");
   hashSym = rb_intern("hash");
   callSym = rb_intern("call");
   compareSym = ID2SYM(rb_intern("compare"));

data/ext/rb_lovely/sorted_hash.cpp

@@ -113,7 +113,7 @@ VALUE hashUpdate(VALUE self, VALUE key, VALUE val) {
     hash->container.replace(it, member(hash->compareProc, key, val));
   else
     hash->container.insert(member(hash->compareProc, key, val));
-  return self;
+  return val;
 }
 
 VALUE hashReplace(VALUE self, VALUE key, VALUE val) {
@@ -163,9 +163,9 @@ VALUE hashToString(VALUE self) {
   if (! hash->container.empty()) {
     auto& idx = hash->container.get<1>();
     auto it = idx.begin();
-    str << ' ' << toS(it->key) << " => " << toS(it->val);
+    str << ' ' << rbInspect(it->key) << " => " << rbInspect(it->val);
     for (++it; it != idx.end(); ++it) {
-      str << ", " << toS(it->key) << " => " << toS(it->val);
+      str << ", " << rbInspect(it->key) << " => " << rbInspect(it->val);
     }
   }
   str << " }";

data/ext/rb_lovely/sorted_set.cpp

@@ -79,9 +79,9 @@ VALUE setToString(VALUE self) {
   Set* set = rubyCast<Set>(self);
   if (! set->empty()) {
     auto it = set->begin();
-    str << ' ' << toS(*it);
+    str << ' ' << rbInspect(*it);
     for (++it; it != set->end(); ++it) {
-      str << ", " << toS(*it);
+      str << ", " << rbInspect(*it);
     }
   }
   str << " }";

data/yard.rb

@@ -171,6 +171,21 @@ module RbLovely
     #   expect(hash.to_a).to eql [[:b, 1], [:a, 3]]
     def self.[](*content) ; end
 
+    # Set the value associated with a key. If the key already then it and its value are removed.
+    # @return The value that was passed.
+    # @example
+    #   hash = RbLovely::SortedHash.new
+    #   hash[:a] = 'yo'
+    def []=(key, value) ; end
+
+    # Set the value associated with a key. If the key already then it and its value are removed.
+    # @return The value that was previously associated with the key or nil if the key was not present in the hash.
+    # @example
+    #   hash = RbLovely::SortedHash[:a, 'yi']
+    #   expect(hash.replace(:a, 'yo')).to eql('yi')
+    #   expect(hash.replace(:b, 'hm')).to eql(nil)
+    def replace(key, value) ; end
+
     # Delete the value associated with a key.
     # @return The value associated with the deleted key or nil if the key was not in the hash.
     # @example

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rb_lovely
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
 platform: ruby
 authors:
 - James Pike