razorpay 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39cc293b9e35da57fbe365e94ee9d46d9c21d7843d8e08f40382d9683d5dac8a
-  data.tar.gz: '086f7b483c58b0841a5b4a7cc677f4d4cc083536b0999f5abff1986287be0fe3'
+  metadata.gz: 2bfaf6eed8197ba96d0e861fc499da1b7bf502602330f005d32edda91971fcb6
+  data.tar.gz: 59e845994a4d2865e3832709d5aa6afc7bbc038f4655033e5e445843f1bad13d
 SHA512:
-  metadata.gz: af4c5ba0f617c776ac5b4ad191062e9530eb1c70443bc1e030873f90edb8b6072a90e66d50e7b55da8d1cbf30f6f590cb94f51c67b6cb9383584cd1f44182aaa
-  data.tar.gz: 1ddbe5914250c4dd745da91780ad0ac9e35f13fee040490a4b49cd43f5a72a5882aeaec3af6b311220c3537af41b36e5348428dc746f0f8fe3a1f24cbcc45fe2
+  metadata.gz: 35657de03884f8dd1fd50e038f318586ac8520653c9f75bb66dae4363c1a558122362a21f0f843cb1d7d685612c4a47c9c465bb5485e43b4a2fe4b6dd5dd84ea
+  data.tar.gz: d753fdf647555ac0084b4341e6e27a9bf998b9b9d32e2e6ffab9976fa1ab51b79c11653ad6ef36d8ea7f4afa53ccfaa64f47878e15fb95966d9d2a3e56309ba4

data/CHANGELOG.md

@@ -4,6 +4,16 @@ Changelog for Razorpay-Ruby SDK.
 
 ## Unreleased
 
+## [2.4.1] - 2019-04-09
+
+### Fixed
+
+- Subscription signature verification [[#81][81]]
+
+### Added
+
+- Ruby version to user agent header [[#79][79]]
+
 ## [2.4.0] - 2019-04-08
 
 ### Changed
@@ -109,7 +119,8 @@ Changelog for Razorpay-Ruby SDK.
 
 # Diff
 
-- [Unreleased](https://github.com/razorpay/razorpay-ruby/compare/2.4.0...HEAD)
+- [Unreleased](https://github.com/razorpay/razorpay-ruby/compare/2.4.1...HEAD)
+- [2.4.1](https://github.com/razorpay/razorpay-ruby/compare/2.4.0...2.4.1)
 - [2.4.0](https://github.com/razorpay/razorpay-ruby/compare/2.3.0...2.4.0)
 - [2.3.0](https://github.com/razorpay/razorpay-ruby/compare/2.2.0...2.3.0)
 - [2.2.0](https://github.com/razorpay/razorpay-ruby/compare/2.1.0...2.2.0)
@@ -126,3 +137,5 @@ Changelog for Razorpay-Ruby SDK.
 [68]: https://github.com/razorpay/razorpay-ruby/pull/68
 [72]: https://github.com/razorpay/razorpay-ruby/pull/72
 [75]: https://github.com/razorpay/razorpay-ruby/pull/75
+[79]: https://github.com/razorpay/razorpay-ruby/pull/79
+[81]: https://github.com/razorpay/razorpay-ruby/pull/81

data/lib/razorpay/constants.rb

@@ -2,5 +2,5 @@
 module Razorpay
   BASE_URI = 'https://api.razorpay.com/v1/'.freeze
   TEST_URL = 'https://api.razorpay.com/'.freeze
-  VERSION = '2.4.0'.freeze
+  VERSION = '2.4.1'.freeze
 end

data/lib/razorpay/request.rb

@@ -16,7 +16,7 @@ module Razorpay
       @entity_name = entity_name
       custom_headers = Razorpay.custom_headers || {}
       predefined_headers = {
-        'User-Agent' => "Razorpay-Ruby/#{Razorpay::VERSION}"
+        'User-Agent' => "Razorpay-Ruby/#{Razorpay::VERSION}; Ruby/#{RUBY_VERSION}"
       }
       # Order is important to give precedence to predefined headers
       headers = custom_headers.merge(predefined_headers)

data/lib/razorpay/utility.rb

@@ -4,11 +4,12 @@ module Razorpay
   # Helper functions are defined here
   class Utility
     def self.verify_payment_signature(attributes)
-      signature = attributes[:razorpay_signature]
-      order_id = attributes[:razorpay_order_id] || attributes[:razorpay_subscription_id]
-      payment_id = attributes[:razorpay_payment_id]
+      signature = attributes.delete(:razorpay_signature)
 
-      data = [order_id, payment_id].join '|'
+      # Data requires the values to be in sorted order of their keys.
+      # attributes.sort returns a nested array, and the last
+      # element of each is the value. These are joined.
+      data = attributes.sort.map(&:last).join('|')
 
       secret = Razorpay.auth[:password]
 

data/test/razorpay/test_razorpay.rb

@@ -22,7 +22,7 @@ module Razorpay
       stub_get(/$/, 'hello_response')
       Razorpay.headers = custom_headers
       Razorpay::Request.new('dummy').make_test_request
-      user_agent = "Razorpay-Ruby/#{Razorpay::VERSION}"
+      user_agent = "Razorpay-Ruby/#{Razorpay::VERSION}; Ruby/#{RUBY_VERSION}"
       headers = { 'User-Agent' => user_agent, 'Authorization' => 'Basic a2V5X2lkOmtleV9zZWNyZXQ=' }
       headers = headers.merge(custom_headers)
       assert_requested :get, 'https://api.razorpay.com/',
@@ -43,7 +43,7 @@ module Razorpay
     def test_auth_header_and_user_agent
       stub_get(/$/, 'hello_response')
       Razorpay::Request.new('dummy').make_test_request
-      user_agent = "Razorpay-Ruby/#{Razorpay::VERSION}"
+      user_agent = "Razorpay-Ruby/#{Razorpay::VERSION}; Ruby/#{RUBY_VERSION}"
       headers = { 'User-Agent' => user_agent, 'Authorization' => 'Basic a2V5X2lkOmtleV9zZWNyZXQ=' }
       assert_requested :get, 'https://api.razorpay.com/',
                        headers: headers,

data/test/razorpay/test_utility.rb

@@ -9,9 +9,9 @@ module Razorpay
 
     def test_payment_signature_verification
       payment_response = {
-        razorpay_order_id: 'fake_order_id',
+        razorpay_order_id: 'fake_other_id',
         razorpay_payment_id: 'fake_payment_id',
-        razorpay_signature: 'b2335e3b0801106b84a7faff035df56ecffde06918c9ddd1f0fafbb37a51cc89'
+        razorpay_signature: '965ee2de4c5c4e6f006fb0a5a1736d992e5d4d52f9fe10b98c9b97ee169ebe18'
       }
       Razorpay::Utility.verify_payment_signature(payment_response)
 
@@ -23,10 +23,12 @@ module Razorpay
 
     def test_subscription_signature_verification
       payment_response = {
-        razorpay_subscription_id: 'fake_order_id',
         razorpay_payment_id: 'fake_payment_id',
-        razorpay_signature: 'b2335e3b0801106b84a7faff035df56ecffde06918c9ddd1f0fafbb37a51cc89'
+        razorpay_subscription_id: 'fake_other_id',
+        razorpay_signature: '3dabcab8ca113e7994cf78c80f8d50974ddfb2d380029743f30a6d67934cd845'
       }
+      # A different signature is expected here compared to the previous test,
+      # since the sorted order of the keys is different in this case
       Razorpay::Utility.verify_payment_signature(payment_response)
 
       payment_response[:razorpay_signature] = '_dummy_signature' * 4

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: razorpay
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Abhay Rana
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-08 00:00:00.000000000 Z
+date: 2019-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty