razorpay 2.2.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9694a52cd9fc7e6968d50450c8cd6baedcb13031
-  data.tar.gz: c8b1e34dc5549b3d5a3bde42447a4bac74271326
+  metadata.gz: cd8a703b64189d31348ac44fccf9edef384ff5af
+  data.tar.gz: f007b3cd479849931bda5fc5f59d584f4a15e18b
 SHA512:
-  metadata.gz: 655d3f40379bd8f58ce447fd3d96f6c2420909abf627d6775977a56d8809fd87dfaf4a66a0a341e23f7efe07d971ce146930d919f498d907fa37a9d64fcdef6d
-  data.tar.gz: 528df3860b6623d9215b097b5e4b82192ee444c980c5db7d13b618d77beafd8bb0ce1bd5ed46cbce1360a34bd591e0a7b225d376244c0eae9968d402adb42bfb
+  metadata.gz: 6d0c677d255482d7378c2eecf523d3ee8ae9d106af592885613d6c08a4a2b5be24c39c9c1c8dba270029336e1a1a56dc385358b48e90ff3e80adf638dedcf266
+  data.tar.gz: 942c7c1247d66d697b4f597125d5c2c145112e0ea62f1fa14c4fe5835c03607a13fdcce26c36185a4ccd0fd08cd08fbaeb260a4751e2983c105c7a9d0229a22c

data/.rubocop.yml

@@ -14,3 +14,8 @@ Style/ClassVars:
 
 Metrics/MethodLength:
   Max: 15
+
+Naming/UncommunicativeMethodParamName:
+  MinNameLength: 1
+  AllowNamesEndingInNumbers: false
+

data/CHANGELOG.md

@@ -4,6 +4,11 @@ Changelog for Razorpay-Ruby SDK.
 
 ## Unreleased
 
+## [2.3.0] - 2018-04-20
+### Added
+- Support for subscription signature verification
+- Bang! methods (`capture!`, `refund!`) that update the calling entity
+
 ## [2.2.0] - 2018-01-29
 ### Added
 - Support for Subscriptions
@@ -65,7 +70,8 @@ Changelog for Razorpay-Ruby SDK.
 ### Added
 - Initial Release
 
-[Unreleased]: https://github.com/razorpay/razorpay-ruby/compare/2.2.0...HEAD
+[Unreleased]: https://github.com/razorpay/razorpay-ruby/compare/2.3.0...HEAD
+[2.3.0]: https://github.com/razorpay/razorpay-ruby/compare/2.2.0...2.3.0
 [2.2.0]: https://github.com/razorpay/razorpay-ruby/compare/2.1.0...2.2.0
 [2.1.0]: https://github.com/razorpay/razorpay-ruby/compare/2.0.1...2.1.0
 [2.1.0.pre]: https://github.com/razorpay/razorpay-ruby/compare/2.0.1...2.1.0.pre

data/README.md

@@ -60,6 +60,19 @@ refund = Razorpay::Refund.create(payment_id:"payment_id")
 Razorpay::Refund.fetch(refund.id)
 ```
 
+If payment is captured or refunded via `capture!` or `refund!`, then the calling object is also updated:
+```rb
+payment = Razorpay::Payment.fetch('payment_id')
+payment.status
+# 'authorized'
+payment.capture!
+payment.status
+# 'captured'
+payment.refund!
+payment.status
+# 'refunded'
+```
+
 For other applications (such as fetching payments and refunds),
 see our online documentation on <https://docs.razorpay.com>
 

data/lib/razorpay/constants.rb

@@ -2,5 +2,5 @@
 module Razorpay
   BASE_URI = 'https://api.razorpay.com/v1/'.freeze
   TEST_URL = 'https://api.razorpay.com/'.freeze
-  VERSION = '2.2.0'.freeze
+  VERSION = '2.3.0'.freeze
 end

data/lib/razorpay/entity.rb

@@ -5,6 +5,8 @@ module Razorpay
   # This saves data in a hash internally, and makes it available
   # via direct methods
   class Entity
+    attr_reader :attributes
+
     def initialize(attributes)
       @attributes = attributes
     end
@@ -29,5 +31,16 @@ module Razorpay
     def to_json
       @attributes.to_json
     end
+
+    # Mutates the entity in accordance with
+    # the block passed to this construct
+    #
+    # Used to implement bang methods, by calling
+    # the non-bang method in the passed block
+    def with_a_bang
+      mutated_entity = yield
+      @attributes = mutated_entity.attributes
+      mutated_entity
+    end
   end
 end

data/lib/razorpay/invoice.rb

@@ -37,12 +37,24 @@ module Razorpay
       self.class.edit id, options
     end
 
+    def edit!(options = {})
+      with_a_bang { edit options }
+    end
+
     def issue
       self.class.issue id
     end
 
+    def issue!
+      with_a_bang { issue }
+    end
+
     def cancel
       self.class.cancel id
     end
+
+    def cancel!
+      with_a_bang { cancel }
+    end
   end
 end

data/lib/razorpay/payment.rb

@@ -27,10 +27,20 @@ module Razorpay
       self.class.request.post "#{id}/refund", options
     end
 
+    def refund!(options = {})
+      refund = refund options
+      with_a_bang { self.class.request.fetch id }
+      refund
+    end
+
     def capture(options)
       self.class.request.post "#{id}/capture", options
     end
 
+    def capture!(options)
+      with_a_bang { capture options }
+    end
+
     def refunds
       self.class.request.get "#{id}/refunds"
     end

data/lib/razorpay/subscription.rb

@@ -28,5 +28,9 @@ module Razorpay
     def cancel(options = {})
       self.class.cancel id, options
     end
+
+    def cancel!(options = {})
+      with_a_bang { cancel options }
+    end
   end
 end

data/lib/razorpay/utility.rb

@@ -5,7 +5,7 @@ module Razorpay
   class Utility
     def self.verify_payment_signature(attributes)
       signature = attributes[:razorpay_signature]
-      order_id = attributes[:razorpay_order_id]
+      order_id = attributes[:razorpay_order_id] || attributes[:razorpay_subscription_id]
       payment_id = attributes[:razorpay_payment_id]
 
       data = [order_id, payment_id].join '|'

data/lib/razorpay/virtual_account.rb

@@ -25,6 +25,14 @@ module Razorpay
       request.patch id, status: 'closed'
     end
 
+    def close
+      self.class.request.patch id, status: 'closed'
+    end
+
+    def close!
+      with_a_bang { close }
+    end
+
     def payments(options = {})
       r = self.class.request
       r.request :get, "/virtual_accounts/#{id}/payments", options

data/razorpay-ruby.gemspec

@@ -1,4 +1,4 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', Dir.pwd)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'razorpay/constants'
 

data/test/fixtures/fake_refunded_payment.json

@@ -0,0 +1,14 @@
+{
+  "id": "fake_payment_id",
+  "entity": "payment",
+  "amount": 500,
+  "currency": "INR",
+  "status": "refunded",
+  "amount_refunded": 500,
+  "refund_status": null,
+  "error_code": null,
+  "error_description": null,
+  "udf": {},
+  "created_at": 1400826750,
+  "method": "card"
+}

data/test/razorpay/test_invoice.rb

@@ -66,6 +66,14 @@ module Razorpay
       assert_invoice_details(invoice)
     end
 
+    def test_invoice_can_be_issued_by_invoice_instance!
+      stub_post(%r{invoices\/#{@invoice_id}\/issue$}, 'issue_invoice', {})
+      invoice = Razorpay::Invoice.fetch(@invoice_id)
+      invoice.issue!
+      assert_equal 'issued', invoice.status
+      refute_nil invoice.issued_at
+    end
+
     def test_invoice_can_be_cancelled_by_invoice_id
       stub_post(%r{invoices\/#{@invoice_id}\/cancel$}, 'cancel_invoice', {})
       invoice = Razorpay::Invoice.cancel(@invoice_id)
@@ -90,15 +98,21 @@ module Razorpay
       assert_invoice_details(invoice)
     end
 
-    def test_edit_invoice
+    def test_invoice_can_be_cancelled_by_invoice_instance!
+      stub_post(%r{invoices\/#{@invoice_id}\/cancel$}, 'cancel_invoice', {})
+      invoice = Razorpay::Invoice.fetch(@invoice_id)
+      invoice.cancel!
+      assert_equal 'cancelled', invoice.status
+      refute_nil invoice.cancelled_at
+    end
+
+    def test_edit_invoice!
       invoice = Razorpay::Invoice.fetch(@invoice_id)
       assert_instance_of Razorpay::Invoice, invoice, 'invoice not an instance of Razorpay::Invoice class'
       assert_nil invoice.invoice_number
-
       update_invoice_data = { invoice_number: '12345678' }
       stub_patch(%r{invoices/#{@invoice_id}$}, 'update_invoice', update_invoice_data)
-
-      invoice = invoice.edit(update_invoice_data)
+      invoice.edit!(update_invoice_data)
       assert_instance_of Razorpay::Invoice, invoice, 'invoice not an instance of Razorpay::Invoice class'
       refute_nil invoice.invoice_number
     end

data/test/razorpay/test_payment.rb

@@ -7,7 +7,7 @@ module Razorpay
       @payment_id = 'fake_payment_id'
 
       # Any request that ends with payments/payment_id
-      stub_get(%r{payments\/#{Regexp.quote(@payment_id)}$}, 'fake_payment')
+      stub_get(%r{payments\/#{@payment_id}$}, 'fake_payment')
       stub_get(/payments$/, 'payment_collection')
     end
 
@@ -43,6 +43,14 @@ module Razorpay
       assert_equal refund.payment_id, @payment_id
     end
 
+    def test_payment_refund!
+      payment = Razorpay::Payment.fetch(@payment_id)
+      stub_get(%r{payments/#{@payment_id}$}, 'fake_refunded_payment')
+      stub_post(%r{payments/#{@payment_id}/refund$}, 'fake_refund', {})
+      payment.refund!
+      assert_equal 'refunded', payment.status
+    end
+
     def test_partial_refund
       # For some reason, stub doesn't work if I pass it a hash of post body
       stub_post(%r{payments/#{@payment_id}/refund$}, 'fake_refund', 'amount=2000')
@@ -59,6 +67,13 @@ module Razorpay
       assert_equal 'captured', payment.status
     end
 
+    def test_payment_capture!
+      stub_post(%r{payments/#{@payment_id}/capture$}, 'fake_captured_payment', 'amount=5100')
+      payment = Razorpay::Payment.fetch(@payment_id)
+      payment.capture!(amount: 5100)
+      assert_equal 'captured', payment.status
+    end
+
     def test_payment_capture_without_fetch
       stub_post(%r{payments/#{@payment_id}/capture$}, 'fake_captured_payment', 'amount=5100')
       payment = Razorpay::Payment.capture(@payment_id, amount: 5100)

data/test/razorpay/test_subscription.rb

@@ -79,6 +79,13 @@ module Razorpay
       assert_subscription_details(subscription)
     end
 
+    def test_subscription_can_be_cancelled_by_subscription_instance!
+      stub_post(%r{subscriptions\/#{@subscription_id}\/cancel$}, 'cancel_subscription', {})
+      subscription = Razorpay::Subscription.fetch(@subscription_id)
+      subscription.cancel!
+      assert_equal 'cancelled', subscription.status
+    end
+
     private
 
     def assert_subscription_details(subscription)

data/test/razorpay/test_utility.rb

@@ -21,6 +21,20 @@ module Razorpay
       end
     end
 
+    def test_subscription_signature_verification
+      payment_response = {
+        razorpay_subscription_id: 'fake_order_id',
+        razorpay_payment_id: 'fake_payment_id',
+        razorpay_signature: 'b2335e3b0801106b84a7faff035df56ecffde06918c9ddd1f0fafbb37a51cc89'
+      }
+      Razorpay::Utility.verify_payment_signature(payment_response)
+
+      payment_response[:razorpay_signature] = '_dummy_signature' * 4
+      assert_raises(SecurityError) do
+        Razorpay::Utility.verify_payment_signature(payment_response)
+      end
+    end
+
     def test_webhook_signature_verification
       webhook_body = fixture_file('fake_payment_authorized_webhook')
       secret = 'chosen_webhook_secret'

data/test/razorpay/test_virtual_account.rb

@@ -36,13 +36,29 @@ module Razorpay
       assert_includes receiver.keys, 'account_number'
     end
 
-    def test_close_virtual_account
+    def test_close_virtual_account_class_method
       stub_patch(%r{virtual_accounts/#{@virtual_account_id}$}, 'fake_virtual_account_closed', 'status=closed')
       virtual_account = Razorpay::VirtualAccount.close(@virtual_account_id)
       assert_instance_of Razorpay::VirtualAccount, virtual_account
       assert_equal 'closed', virtual_account.status
     end
 
+    def test_close_virtual_account
+      stub_patch(%r{virtual_accounts/#{@virtual_account_id}$}, 'fake_virtual_account_closed', 'status=closed')
+      virtual_account = Razorpay::VirtualAccount.fetch(@virtual_account_id)
+      virtual_account = virtual_account.close
+      assert_instance_of Razorpay::VirtualAccount, virtual_account
+      assert_equal 'closed', virtual_account.status
+    end
+
+    def test_close_virtual_account!
+      stub_patch(%r{virtual_accounts/#{@virtual_account_id}$}, 'fake_virtual_account_closed', 'status=closed')
+      virtual_account = Razorpay::VirtualAccount.fetch(@virtual_account_id)
+      virtual_account.close!
+      assert_instance_of Razorpay::VirtualAccount, virtual_account
+      assert_equal 'closed', virtual_account.status
+    end
+
     def test_fetch_all_virtual_accounts
       virtual_accounts = Razorpay::VirtualAccount.all
       assert_instance_of Razorpay::Collection, virtual_accounts

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: razorpay
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Abhay Rana
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-29 00:00:00.000000000 Z
+date: 2018-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -152,6 +152,7 @@ files:
 - test/fixtures/fake_payment_bank_transfer.json
 - test/fixtures/fake_plan.json
 - test/fixtures/fake_refund.json
+- test/fixtures/fake_refunded_payment.json
 - test/fixtures/fake_subscription.json
 - test/fixtures/fake_virtual_account.json
 - test/fixtures/fake_virtual_account_closed.json
@@ -226,6 +227,7 @@ test_files:
 - test/fixtures/fake_payment_bank_transfer.json
 - test/fixtures/fake_plan.json
 - test/fixtures/fake_refund.json
+- test/fixtures/fake_refunded_payment.json
 - test/fixtures/fake_subscription.json
 - test/fixtures/fake_virtual_account.json
 - test/fixtures/fake_virtual_account_closed.json