raygun4ruby 1.1.3 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9e6e07eb62a1e5b014f23705b3438154a8d5645
-  data.tar.gz: 1669c3ed97bc8ab9f2234db2d351e1542539136e
+  metadata.gz: 48b225693ce7d8b12ed42cf62c7ac62772631423
+  data.tar.gz: 6a6d145569e18de22b0f6264ea124d5893a5bb28
 SHA512:
-  metadata.gz: 8ce62d3015545c77a1cdbdf76dc5215c9f8aa01b1ff7930d77debda1140dd267eb52cf01ee4736c10866ff8c9c67565b9de9748b74179d08477f1fc1d0edfc08
-  data.tar.gz: 96f8dc35a93f66b220d368f0370b413e605a080a07ee849747ef3009be7230df23ac4a401e55a657b23ecd941fdce3b7a7348df6abdfc53df2a6b45a2d319449
+  metadata.gz: 57fb50409b4dbcbeead76dc3306b2d5204652b0a3ec274c51ad7c8f2852300456af3b048cc03f3f964c2d9bace03640ad8a957b20f589977f7d4cb69ab7289f3
+  data.tar.gz: f6ba6f88c324f94d72ae15acab093ce33c5a47e8020d97ca7ce67f9a315aa8c6241ce6cadd21b7536ae64e0149a48ce03e4005a1e8537b0855eaeda63f068030

data/lib/raygun/client.rb

@@ -49,7 +49,7 @@ module Raygun
         {
           lineNumber: line_number,
           fileName:   file_name,
-          methodName: method.gsub(/^in `(.*?)'$/, "\\1")
+          methodName: method ? method.gsub(/^in `(.*?)'$/, "\\1") : "(none)"
         }
       end
 
@@ -76,7 +76,7 @@ module Raygun
           hostName:    env["SERVER_NAME"],
           url:         env["PATH_INFO"],
           httpMethod:  env["REQUEST_METHOD"],
-          iPAddress:   ip_address_from(env),
+          iPAddress:   "#{ip_address_from(env)}",
           queryString: Rack::Utils.parse_nested_query(env["QUERY_STRING"]),
           form:        form_data(env),
           headers:     headers(env),

data/lib/raygun/version.rb

@@ -1,3 +1,3 @@
 module Raygun
-  VERSION = "1.1.3"
+  VERSION = "1.1.4"
 end

data/lib/raygun.rb

@@ -50,7 +50,7 @@ module Raygun
       end
     rescue Exception => e
       if configuration.failsafe_logger
-        failsafe_log("Problem reporting exception to Raygun: #{e.class}: #{e.message}\n\n#{e.backrace.join("\n")}")
+        failsafe_log("Problem reporting exception to Raygun: #{e.class}: #{e.message}\n\n#{e.backtrace.join("\n")}")
       else
         raise e
       end

data/raygun4ruby.gemspec

@@ -30,5 +30,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "~> 4.2"
   spec.add_development_dependency "redis-namespace", ">= 1.3.1"
   spec.add_development_dependency "resque"
-  spec.add_development_dependency "sidekiq", "~> 3"
+  spec.add_development_dependency "sidekiq", [">= 3", "< 3.2.2"]
 end

data/test/unit/client_test.rb

@@ -6,6 +6,16 @@ class ClientTest < Raygun::UnitTest
 
   class TestException < StandardError; end
 
+  class FakeActionDispatcherIp
+    attr_reader :ip
+    def initialize remote_ip
+      @ip = remote_ip
+    end
+    def to_s
+      return ip
+    end
+  end
+
   def setup
     super
     @client = Raygun::Client.new
@@ -90,6 +100,18 @@ class ClientTest < Raygun::UnitTest
     assert_silent { @client.track_exception(bad_exception) }
   end
 
+  def test_backtrace_without_method_name
+
+    expected = {
+      lineNumber: "123",
+      fileName:   "/some/folder/some_file.rb",
+      methodName: "(none)"
+    }
+
+    # note lack of "in method name" in this stack trace line
+    assert_equal expected, @client.send(:stack_trace_for, "/some/folder/some_file.rb:123")
+  end
+
   def test_full_payload_hash
     Timecop.freeze do
       Raygun.configuration.version = 123
@@ -242,12 +264,35 @@ class ClientTest < Raygun::UnitTest
       "SERVER_PROTOCOL"=>"HTTP/1.1",
       "SCRIPT_NAME"=>"",
       "REMOTE_ADDR"=>"127.0.0.1",
-      "action_dispatch.remote_ip"=>"123.456.789.012"
+      "action_dispatch.remote_ip"=> "123.456.789.012"
     }
 
     assert_equal "123.456.789.012", @client.send(:ip_address_from, sample_env_hash)
     assert_equal "123.456.789.012", @client.send(:request_information, sample_env_hash)[:iPAddress]
   end
+  def test_ip_address_from_old_action_dispatch
+    old_action_dispatch_ip = FakeActionDispatcherIp.new("123.456.789.012")
+    sample_env_hash = {
+      "HTTP_VERSION"=>"HTTP/1.1",
+      "HTTP_HOST"=>"localhost:3000",
+      "HTTP_CONNECTION"=>"keep-alive",
+      "HTTP_CACHE_CONTROL"=>"max-age=0",
+      "HTTP_ACCEPT"=>"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8",
+      "HTTP_USER_AGENT"=>"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.22 Safari/537.36",
+      "HTTP_ACCEPT_ENCODING"=>"gzip,deflate,sdch",
+      "HTTP_ACCEPT_LANGUAGE"=>"en-US,en;q=0.8",
+      "HTTP_COOKIE"=>"cookieval",
+      "GATEWAY_INTERFACE"=>"CGI/1.2",
+      "SERVER_PORT"=>"3000",
+      "SERVER_PROTOCOL"=>"HTTP/1.1",
+      "SCRIPT_NAME"=>"",
+      "REMOTE_ADDR"=>"127.0.0.1",
+      "action_dispatch.remote_ip"=> old_action_dispatch_ip
+    }
+
+    assert_equal old_action_dispatch_ip, @client.send(:ip_address_from, sample_env_hash)
+    assert_equal "123.456.789.012", @client.send(:request_information, sample_env_hash)[:iPAddress]
+  end
 
   def test_ip_address_from_raygun_specific_key
     sample_env_hash = {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: raygun4ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - Mindscape
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-09 00:00:00.000000000 Z
+date: 2014-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -155,16 +155,22 @@ dependencies:
   name: sidekiq
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3'
+    - - <
+      - !ruby/object:Gem::Version
+        version: 3.2.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3'
+    - - <
+      - !ruby/object:Gem::Version
+        version: 3.2.2
 description: Ruby Adapter for Raygun.io
 email:
 - hello@raygun.io