ravelry 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 069008bb3012510d0c56139996efd09180c18c35
-  data.tar.gz: da328e573a10420115bb936ca902b68c54ddcc60
+  metadata.gz: b9132400df864b998861fc08da936fdafd7da5dc
+  data.tar.gz: ce313f70e9acb79289e801f5872e761d7a2a19af
 SHA512:
-  metadata.gz: 0b0ef35f8f4eeebcf3994cab99ee7a56acc01053a84b16707ffe3aec8ab398b19782f1a6c6182b4f77c010307a5126acc98e20f471afb90a7f918934be01279d
-  data.tar.gz: 2aa97bb1a10842a9aec7d41bd5c500a0379c5ed81a1bfac16fd907b69891151a75e00d7411ffac21ffe1f6cf5069f98fc9a92f3923d1d4e33b6c18dbb8b9a62f
+  metadata.gz: 1adcd5d8930d86cfa2a948995fcf54b1251d8358b16d9c6783832e60c333ddfaf5197b7857256d899d69a9676cf261523eaf2b199c58cee4eb8b76c2e0346944
+  data.tar.gz: 0697d617a95f2f02f31a4a0b2598ebbe7caca22bbbf2fd51be5b6e4603483dc6c8a499de4d6a0caad8aca308a3a12b995634ef9d6925f1fc5724c05833e1b4f1

data/CODE_OF_CONDUCT.md

@@ -1,8 +1,14 @@
 # Contributor Code of Conduct
 
-As contributors and maintainers of this project, and in the interest of fostering an open and welcoming community, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.
+As contributors and maintainers of this project, and in the interest of
+fostering an open and welcoming community, we pledge to respect all people who
+contribute through reporting issues, posting feature requests, updating
+documentation, submitting pull requests or patches, and other activities.
 
-We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, religion, or nationality.
+We are committed to making participation in this project a harassment-free
+experience for everyone, regardless of level of experience, gender, gender
+identity and expression, sexual orientation, disability, personal appearance,
+body size, race, ethnicity, age, religion, or nationality.
 
 Examples of unacceptable behavior by participants include:
 
@@ -10,13 +16,35 @@ Examples of unacceptable behavior by participants include:
 * Personal attacks
 * Trolling or insulting/derogatory comments
 * Public or private harassment
-* Publishing other's private information, such as physical or electronic addresses, without explicit permission
-* Other unethical or unprofessional conduct.
-
-Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. By adopting this Code of Conduct, project maintainers commit themselves to fairly and consistently applying these principles to every aspect of managing this project. Project maintainers who do not follow or enforce the Code of Conduct may be permanently removed from the project team.
-
-This code of conduct applies both within project spaces and in public spaces when an individual is representing the project or its community.
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.
-
-This Code of Conduct is adapted from the [Contributor Covenant](http://contributor-covenant.org), version 1.2.0, available at [http://contributor-covenant.org/version/1/2/0/](http://contributor-covenant.org/version/1/2/0/)
+* Publishing other's private information, such as physical or electronic
+  addresses, without explicit permission
+* Other unethical or unprofessional conduct
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+By adopting this Code of Conduct, project maintainers commit themselves to
+fairly and consistently applying these principles to every aspect of managing
+this project. Project maintainers who do not follow or enforce the Code of
+Conduct may be permanently removed from the project team.
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting a project maintainer at [INSERT EMAIL ADDRESS]. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. Maintainers are
+obligated to maintain confidentiality with regard to the reporter of an
+incident.
+
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 1.3.0, available at
+[http://contributor-covenant.org/version/1/3/0/][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/3/0/

data/README.md

@@ -1,8 +1,8 @@
 # Ravelry
 
-_You are reading documentation for version: 0.0.6_
+_You are reading documentation for version: 0.0.7_
 
-[ ![Codeship Status for ArtCraftCode/ravelry](https://codeship.com/projects/fc6710e0-5719-0133-36cc-5ebc52a48109/status?branch=0.0.6)](https://codeship.com/projects/109462)
+[ ![Codeship Status for ArtCraftCode/ravelry](https://codeship.com/projects/fc6710e0-5719-0133-36cc-5ebc52a48109/status?branch=0.0.7)](https://codeship.com/projects/109462)
 
 This gem is actively being developed. Be sure to check the branch for the version you're using as breaking changes can (and will!) be introduced.
 
@@ -23,6 +23,7 @@ API | Endpoint | Ravelry gem class / module
 **Needles** | [list](http://www.ravelry.com/api#needles_list) | `Ravelry::Needles.list`
 **Needles** | [sizes](http://www.ravelry.com/api#needles_sizes) | `Ravelry::Needles.sizes`
 **Needles** | [types](http://www.ravelry.com/api#needles_types) | `Ravelry::Needles.types`
+**Patterns** | [search](http://www.ravelry.com/api#patterns_search) | `Ravelry::Pattern.search`
 **Patterns** | [show](http://www.ravelry.com/api#patterns_show) | `Ravelry::Pattern.get`
 **People** | [show](http://www.ravelry.com/api#people_show) | `Ravelry::User.get`
 
@@ -39,7 +40,7 @@ Hooray! You now have a gem.
 Add to your `Gemfile`:
 
 ```ruby
-gem "ravelry", "~> 0.0.6"
+gem "ravelry", "~> 0.0.7"
 ```
 
 **I highly recommend pinning your version** because the gem is in active development and I _promise_ I will break shit.
@@ -74,7 +75,7 @@ Ravelry.configuration.personal_key
 
 # Usage
 
-Full documentation for this gem is available [here](http://www.rubydoc.info/gems/ravelry/0.0.6).
+Full documentation for this gem is available [here](http://www.rubydoc.info/gems/ravelry/0.0.7).
 
 # API quirks
 

data/lib/ravelry/needles.rb

@@ -12,7 +12,8 @@ module Ravelry
     # Arguments: needle type (string, optional)
     # 
     def sizes(craft='')
-      result = Utils::Request.get("needles/sizes.json?craft=#{craft}", :needle_sizes)
+      result = Utils::Request
+        .get('needles/sizes.json', :needle_sizes, {:craft => craft})
       result.map { |needle| Needle.new(needle) }
     end
 
@@ -32,4 +33,4 @@ module Ravelry
       result.map { |needle| Needle.new(needle) }
     end
   end
-end
+end

data/lib/ravelry/pattern.rb

@@ -84,6 +84,16 @@ module Ravelry
   #
   # See the documentation for each object's available methods.
   #
+  # # Searching
+  #
+  # To search for patterns, use the `Pattern.search` class method, which
+  # returns an array of patterns:
+  #
+  # ```ruby
+  # Ravelry::Pattern.search('socks')
+  # # => [#<Pattern>, ...]
+  # ```
+  #
   class Pattern < Data
 
     include Build
@@ -98,6 +108,33 @@ module Ravelry
       @data = Utils::Request.get("patterns/#{@id}.json", :pattern)
     end
 
+    # Search for patterns.
+    #
+    # Corresponds to Ravelry API endpoint `Patterns#search`
+    #
+    # @param query [String] required
+    # @option options [Boolean] :personal_attributes
+    # @option options [Integer] :page
+    # @option options [Integer] :page_size
+    # @return [Array<Pattern>] an array of `Pattern`s
+    def self.search(query, options={})
+      params = {query: query}
+      params.merge!(options)
+
+      unless params[:personal_attributes].nil?
+        params[:personal_attributes] = (params[:personal_attributes] ? 1 : 0)
+      end
+
+      patterns = Utils::Request
+        .get("patterns/search.json", :patterns, params)
+
+      patterns.map do |data|
+        pattern = Ravelry::Pattern.new
+        pattern.data = data
+        pattern
+      end
+    end
+
     # Creates all objects associated with your pattern; returns nothing; sets `attr_readers`.
     #
     def build
@@ -387,4 +424,4 @@ module Ravelry
       data[:yarn_weight_description]
     end
   end
-end
+end

data/lib/ravelry/utils/build.rb

@@ -9,7 +9,11 @@ module Ravelry
     # See {Ravelry::Author} for more information.
     #
     def self.author(data)
-      @author = Author.new(data[:pattern_author])
+      if data[:pattern_author]
+        @author = Author.new(data[:pattern_author])
+      else
+        @author = nil
+      end
     end
 
     # Creates and returns an array of {Ravelry::Category} objects.
@@ -17,11 +21,9 @@ module Ravelry
     # See {Ravelry::Category} for more information.
     #
     def self.categories(data)
-      @categories = []
-      data[:pattern_categories].each do |cat|
-        @categories << Category.new(cat)
+      @categories = data.fetch(:pattern_categories, []).map do |cat|
+        Category.new(cat)
       end
-      @categories
     end
 
     # Creates and returns a {Ravelry::Craft} object.
@@ -29,7 +31,11 @@ module Ravelry
     # See {Ravelry::Craft} for more information.
     #
     def self.craft(data)
-      @craft = Craft.new(data[:craft])
+      if data[:craft]
+        @craft = Craft.new(data[:craft])
+      else
+        @craft = nil
+      end
     end
 
     # Creates and returns an array of {Ravelry::Needle} objects.
@@ -39,11 +45,9 @@ module Ravelry
     # See {Ravelry::Needle} for more information.
     #
     def self.needles(data)
-      @needles = []
-      data[:pattern_needle_sizes].each do |ndl|
-        @needles << Needle.new(ndl)
+      @needles = data.fetch(:pattern_needle_sizes, []).map do |ndl|
+        Needle.new(ndl)
       end
-      @needles
     end
 
     # Creates and returns an array of {Ravelry::Pack} objects.
@@ -51,13 +55,11 @@ module Ravelry
     # See {Ravelry::Pack} for more information.
     #
     def self.packs(data)
-      @packs = []
-      data[:packs].each do |pack_data|
+      @packs = data.fetch(:packs, []).map do |pack_data|
         pack = Pack.new
         pack.data = pack_data
-        @packs << pack
+        pack
       end
-      @packs
     end
 
     # Creates and returns a {Ravelry::PatternType} object.
@@ -67,7 +69,11 @@ module Ravelry
     # See {Ravelry::PatternType} for more information.
     #
     def self.pattern_type(data)
-      @pattern_type = PatternType.new(data[:pattern_type])
+      if data[:pattern_type]
+        @pattern_type = PatternType.new(data[:pattern_type])
+      else
+        @pattern_type = nil
+      end
     end
 
     # Creates and returns an array of {Ravelry::Photo} objects.
@@ -75,13 +81,11 @@ module Ravelry
     # See {Ravelry::Photo} for more information.
     #
     def self.photos(data)
-      @photos = []
-      data[:photos].each do |photo_data|
+      @photos = data.fetch(:photos, []).map do |photo_data|
         photo = Photo.new(photo_data[:id])
         photo.data = photo_data
-        @photos << photo
+        photo
       end
-      @photos
     end
 
     # Creates and returns an array of {Ravelry::Printing} objects.
@@ -89,11 +93,9 @@ module Ravelry
     # See {Ravelry::Printing} for more information.
     #
     def self.printings(data)
-      @printings = []
-      data[:printings].each do |printing_data|
-        @printings << Printing.new(printing_data)
+      @printings = data.fetch(:printings, []).map do |printing_data|
+        Printing.new(printing_data)
       end
-      @printings
     end
 
     # Creates and returns an array of {Ravelry::UserSite} objects.
@@ -101,11 +103,9 @@ module Ravelry
     # See {Ravelry::UserSite} for more information.
     #
     def self.user_sites(data)
-      @user_sites = []
-      data[:user_sites].each do |site|
-        @user_sites << UserSite.new(site)
+      @user_sites = data.fetch(:user_sites, []).map do |site|
+        UserSite.new(site)
       end
-      @user_sites
     end
 
     # Creates and returns an array of {Ravelry::Yarn} objects.
@@ -113,13 +113,13 @@ module Ravelry
     # See {Ravelry::Yarn} for more information.
     #
     def self.yarns(data)
-      @yarns = []
-      data[:packs].each do |pack_data|
+      packs = data.fetch(:packs, []).select { |pack| pack[:yarn] }
+
+      @yarns = packs.map do |pack|
         yarn = Yarn.new
-        yarn.data = pack_data[:yarn]
-        @yarns << yarn
+        yarn.data = pack[:yarn]
+        yarn
       end
-      @yarns
     end
 
     # Creates and returns an array of {Ravelry::YarnWeight} objects.
@@ -127,13 +127,13 @@ module Ravelry
     # See {Ravelry::YarnWeight} for more information.
     #
     def self.yarn_weights(data)
-      @yarn_weights = []
-      data[:packs].each do |pack|
+      packs = data.fetch(:packs, []).select { |pack| pack[:yarn_weight] }
+
+      @yarn_weights = packs.map do |pack|
         yarn_weight = YarnWeight.new
         yarn_weight.data = pack[:yarn_weight]
-        @yarn_weights << yarn_weight
+        yarn_weight
       end
-      @yarn_weights
     end
 
   end

data/lib/ravelry/utils/request.rb

@@ -3,12 +3,17 @@ module Ravelry
     module Request
       extend self
 
-      def get(url, key)
-        request = Typhoeus::Request.get("https://api.ravelry.com/#{url}", userpwd: "#{Ravelry.configuration.access_key}:#{Ravelry.configuration.personal_key}")
+      def get(url, key, params={})
+        request = Typhoeus::Request.get(
+          "https://api.ravelry.com/#{url}",
+          userpwd: "#{Ravelry.configuration.access_key}:#{Ravelry.configuration.personal_key}",
+          params: params
+        )
+
         data = JSON.parse(request.response_body, {symbolize_names: true})
         return data[key] if key
         return data
       end
     end
   end
-end
+end

data/lib/ravelry/version.rb

@@ -1,3 +1,3 @@
 module Ravelry
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/spec/helpers/request_helpers.rb

@@ -0,0 +1,32 @@
+require_relative 'request_helpers/misc_helpers'
+require_relative 'request_helpers/needles_helpers'
+require_relative 'request_helpers/pattern_helpers'
+
+module RequestHelpers
+  # Helpers that stub API requests
+
+  # Stubs a Typhoeus request with a response fixture
+  #
+  def stub_request_with_fixture(url_or_pattern, file)
+    response = fixture_response(file)
+    Typhoeus.stub(url_or_pattern).and_return(response)
+  end
+
+  # Returns a Typhoeus::Response with the given fixture as the body
+  #
+  def fixture_response(file)
+    Typhoeus::Response.new(code: 200, body: fixture(file))
+  end
+
+  private
+  def fixture(file)
+    File.read(fixture_path(file))
+  end
+
+  def fixture_path(file)
+    File.expand_path(
+      "request_helpers/fixtures/#{file}",
+      File.dirname(__FILE__)
+    )
+  end
+end

data/spec/helpers/request_helpers/misc_helpers.rb

@@ -0,0 +1,17 @@
+module RequestHelpers
+  # Helpers that stub out requests to misc endpoints
+
+  def stub_color_families
+    stub_request_with_fixture(
+      %r{/color_families\.json},
+      'color_families.json'
+    )
+  end
+
+  def stub_yarn_weights
+    stub_request_with_fixture(
+      %r{/yarn_weights\.json},
+      'yarn_weights.json'
+    )
+  end
+end

data/spec/helpers/request_helpers/needles_helpers.rb

@@ -0,0 +1,24 @@
+module RequestHelpers
+  # Helpers that stub out requests to needles endpoints
+
+  def stub_needles_sizes
+    stub_request_with_fixture(
+      %r{/needles/sizes\.json},
+      'needles_sizes.json'
+    )
+  end
+
+  def stub_needles_types
+    stub_request_with_fixture(
+      %r{/needles/types\.json},
+      'needles_types.json'
+    )
+  end
+
+  def stub_needles_list
+    stub_request_with_fixture(
+      %r{/people/[^/]+/needles/list\.json},
+      'needles_list.json'
+    )
+  end
+end

data/spec/helpers/request_helpers/pattern_helpers.rb

@@ -0,0 +1,17 @@
+module RequestHelpers
+  # Helpers that stub out requests to pattern endpoints
+
+  def stub_patterns_show_paid
+    stub_request_with_fixture(
+      %r{/patterns/[0-9]+\.json},
+      'patterns_show_paid.json'
+    )
+  end
+
+  def stub_patterns_search
+    stub_request_with_fixture(
+      %r{/patterns/search.json},
+      'patterns_search.json'
+    )
+  end
+end

data/spec/ravelry/misc_spec.rb

@@ -2,6 +2,10 @@ require_relative '../spec_helper'
 
 describe Ravelry::Misc do
   context '#color_families' do
+    before do
+      stub_color_families
+    end
+
     it 'should return an array of color families' do
       result = Ravelry::Misc.color_families
       expect(result.first).to be_instance_of(Ravelry::ColorFamily)
@@ -9,9 +13,13 @@ describe Ravelry::Misc do
   end
 
   context '#yarn_weights' do
+    before do
+      stub_yarn_weights
+    end
+
     it 'should return an array of color families' do
       result = Ravelry::Misc.yarn_weights
       expect(result.first).to be_instance_of(Ravelry::YarnWeight)
     end
   end
-end
+end

data/spec/ravelry/needles_spec.rb

@@ -2,6 +2,10 @@ require_relative '../spec_helper'
 
 describe Ravelry::Needles do
   context '#sizes' do
+    before do
+      stub_needles_sizes
+    end
+
     it 'should return an array of needles' do
       result = Ravelry::Needles.sizes
       expect(result.first).to be_instance_of(Ravelry::Needle)
@@ -9,6 +13,10 @@ describe Ravelry::Needles do
   end
 
   context '#types' do
+    before do
+      stub_needles_types
+    end
+
     it 'should return an array of needles' do
       result = Ravelry::Needles.types
       expect(result.first).to be_instance_of(Ravelry::Needle)
@@ -16,9 +24,13 @@ describe Ravelry::Needles do
   end
 
   context '#list' do
+    before do
+      stub_needles_list
+    end
+
     it 'should return an array of needles' do
       result = Ravelry::Needles.list("feministy")
       expect(result.first).to be_instance_of(Ravelry::Needle)
     end
   end
-end
+end

data/spec/ravelry/pattern_spec.rb

@@ -1,6 +1,9 @@
 require_relative '../spec_helper'
 
 describe Ravelry::Pattern do
+  before do
+    stub_patterns_show_paid
+  end
 
   it 'should be an instance of Patterns' do
     pattern = p_initialize_paid_with_fetch
@@ -25,6 +28,45 @@ describe Ravelry::Pattern do
     end
   end
 
+  context '#search' do
+    let(:result) { Ravelry::Pattern.search('hello') }
+    before { stub_patterns_search }
+
+    it 'should succeed' do
+      expect(result).to be
+    end
+
+    it 'should send a request to /patterns/search.json' do
+      expect(Ravelry::Utils::Request).to receive(:get)
+        .with('patterns/search.json', :patterns, {:query => 'hello'})
+        .and_call_original
+
+      Ravelry::Pattern.search('hello')
+    end
+
+    it 'should set params' do
+      expect(Ravelry::Utils::Request).to receive(:get)
+        .with('patterns/search.json', :patterns, {
+          :query => 'hello',
+          :personal_attributes => 1,
+          :page => 123,
+          :page_size => 2
+        })
+        .and_call_original
+
+      Ravelry::Pattern
+        .search('hello', personal_attributes: true, page: 123, page_size: 2)
+    end
+
+    it 'should return an array' do
+      expect(result).to be_kind_of(Array)
+    end
+
+    it 'should return an array of Patterns' do
+      expect(result[0]).to be_kind_of(Ravelry::Pattern)
+    end
+  end
+
   context 'class methods' do
     before do
       @api = p_initialize_with_data

data/spec/ravelry/utils/build_spec.rb

@@ -13,6 +13,16 @@ describe Ravelry::Build do
     it 'returns an instance of Author' do
       expect(@author).to be_instance_of(Ravelry::Author)
     end
+
+    context 'without an author' do
+      before do
+        @author = Ravelry::Build.author({})
+      end
+
+      it 'returns nil' do
+        expect(@author).to be(nil)
+      end
+    end
   end
 
   context '#categories' do
@@ -35,6 +45,16 @@ describe Ravelry::Build do
     it 'returns an array with Category objects' do
       expect(@categories[0]).to be_instance_of(Ravelry::Category)
     end
+
+    context 'without categories' do
+      before do
+        @categories = Ravelry::Build.categories({})
+      end
+
+      it 'returns an empty array' do
+        expect(@categories).to eql([])
+      end
+    end
   end
 
   context '#craft' do
@@ -49,6 +69,16 @@ describe Ravelry::Build do
     it 'returns an instance of Craft' do
       expect(@craft).to be_instance_of(Ravelry::Craft)
     end
+
+    context 'without a craft' do
+      before do
+        @craft = Ravelry::Build.craft({})
+      end
+
+      it 'returns nil' do
+        expect(@craft).to be(nil)
+      end
+    end
   end
 
   context '#needles' do
@@ -67,6 +97,16 @@ describe Ravelry::Build do
     it 'returns an Array of Needle objects' do
       expect(@needles[0]).to be_instance_of(Ravelry::Needle)
     end
+
+    context 'without needles' do
+      before do
+        @needles = Ravelry::Build.needles({})
+      end
+
+      it 'returns an empty array' do
+        expect(@needles).to eql([])
+      end
+    end
   end
 
   context '#packs' do
@@ -89,6 +129,40 @@ describe Ravelry::Build do
     it 'returns an Array of Pack objects' do
       expect(@packs[0]).to be_instance_of(Ravelry::Pack)
     end
+
+    context 'without packs' do
+      before do
+        @packs = Ravelry::Build.packs({})
+      end
+
+      it 'returns an empty array' do
+        expect(@packs).to eql([])
+      end
+    end
+  end
+
+  context '#pattern_type' do
+    before do
+      @type = Ravelry::Build.pattern_type(paid_pattern_stub)
+    end
+
+    it 'exists' do
+      expect(@type).to be_true
+    end
+
+    it 'returns an instance of Type' do
+      expect(@type).to be_instance_of(Ravelry::PatternType)
+    end
+
+    context 'without a type' do
+      before do
+        @type = Ravelry::Build.pattern_type({})
+      end
+
+      it 'returns nil' do
+        expect(@type).to be(nil)
+      end
+    end
   end
 
   context '#photos' do
@@ -107,6 +181,16 @@ describe Ravelry::Build do
     it 'returns an array of Photo objects' do
       expect(@photos[0]).to be_instance_of(Ravelry::Photo)
     end
+
+    context 'without photos' do
+      before do
+        @photos = Ravelry::Build.photos({})
+      end
+
+      it 'returns an empty array' do
+        expect(@photos).to eql([])
+      end
+    end
   end
 
   context '#printings' do
@@ -125,19 +209,27 @@ describe Ravelry::Build do
     it 'returns an array with Printing objects' do
       expect(@printings[0]).to be_instance_of(Ravelry::Printing)
     end
-  end
 
-  context '#type' do
-    before do
-      @type = Ravelry::Build.pattern_type(paid_pattern_stub)
-    end
+    context 'without printings' do
+      before do
+        @printings = Ravelry::Build.printings({})
+      end
 
-    it 'exists' do
-      expect(@type).to be_true
+      it 'returns an empty array' do
+        expect(@printings).to eql([])
+      end
     end
+  end
 
-    it 'returns an instance of Type' do
-      expect(@type).to be_instance_of(Ravelry::PatternType)
+  context '#user_sites' do
+    context 'without user sites' do
+      before do
+        @user_sites = Ravelry::Build.user_sites({})
+      end
+
+      it 'returns an empty array' do
+        expect(@user_sites).to eql([])
+      end
     end
   end
 
@@ -161,6 +253,16 @@ describe Ravelry::Build do
     it 'returns an array of Yarn objects' do
       expect(@yarns[0]).to be_instance_of(Ravelry::Yarn)
     end
+
+    context 'without yarns' do
+      before do
+        @yarns = Ravelry::Build.yarns({})
+      end
+
+      it 'returns an empty array' do
+        expect(@yarns).to eql([])
+      end
+    end
   end
 
   context '#yarn_weights' do
@@ -183,5 +285,15 @@ describe Ravelry::Build do
     it 'returns an array of YarnWeight objects' do
       expect(@yw[0]).to be_instance_of(Ravelry::YarnWeight)
     end
+
+    context 'without yarn weights' do
+      before do
+        @yw = Ravelry::Build.yarn_weights({})
+      end
+
+      it 'returns an empty array' do
+        expect(@yw).to eql([])
+      end
+    end
   end
 end

data/spec/ravelry/utils/request_spec.rb

@@ -0,0 +1,20 @@
+require_relative '../../spec_helper'
+
+describe Ravelry::Utils::Request do
+  let(:response) { double(:response_body => '{}') }
+  let(:url) { 'current_user.json' }
+  let(:userpwd) do
+    "#{Ravelry.configuration.access_key}:#{Ravelry.configuration.personal_key}"
+  end
+  let(:params) { {test: 123} }
+
+  context '#get' do
+    it 'passes in query params' do
+      expect(Typhoeus::Request).to receive(:get)
+        .with("https://api.ravelry.com/#{url}", userpwd: userpwd, params: params)
+        .and_return(response)
+
+      Ravelry::Utils::Request.get(url, nil, params)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -8,6 +8,7 @@ require_relative 'helpers/pattern_helpers'
 require_relative 'helpers/pack_helpers'
 require_relative 'helpers/yarn_helpers'
 require_relative 'helpers/yarn_weight_helpers'
+require_relative 'helpers/request_helpers'
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
@@ -19,6 +20,7 @@ RSpec.configure do |config|
   config.include PackHelpers
   config.include YarnHelpers
   config.include YarnWeightHelpers
+  config.include RequestHelpers
   config.order = "random"
   config.before(:all) do
     Ravelry.configure do |config|
@@ -27,4 +29,8 @@ RSpec.configure do |config|
       config.personal_key = ENV['RAV_PERSONAL']
     end
   end
-end
+
+  config.before(:each) do
+    Typhoeus::Expectation.clear
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ravelry
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Liz Abinante
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-10 00:00:00.000000000 Z
+date: 2016-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,16 +58,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".ruby-version"
-- ".yardopts"
 - CODE_OF_CONDUCT.md
-- Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
-- VERSION
 - lib/ravelry.rb
 - lib/ravelry/author.rb
 - lib/ravelry/category.rb
@@ -92,10 +85,13 @@ files:
 - lib/ravelry/version.rb
 - lib/ravelry/yarn.rb
 - lib/ravelry/yarn_weight.rb
-- ravelry.gemspec
 - spec/helpers/helpers.rb
 - spec/helpers/pack_helpers.rb
 - spec/helpers/pattern_helpers.rb
+- spec/helpers/request_helpers.rb
+- spec/helpers/request_helpers/misc_helpers.rb
+- spec/helpers/request_helpers/needles_helpers.rb
+- spec/helpers/request_helpers/pattern_helpers.rb
 - spec/helpers/yarn_helpers.rb
 - spec/helpers/yarn_weight_helpers.rb
 - spec/ravelry/author_spec.rb
@@ -112,6 +108,7 @@ files:
 - spec/ravelry/printing_spec.rb
 - spec/ravelry/user_spec.rb
 - spec/ravelry/utils/build_spec.rb
+- spec/ravelry/utils/request_spec.rb
 - spec/ravelry/yarn_spec.rb
 - spec/ravelry/yarn_weight_spec.rb
 - spec/ravelry_spec.rb
@@ -144,6 +141,10 @@ test_files:
 - spec/helpers/helpers.rb
 - spec/helpers/pack_helpers.rb
 - spec/helpers/pattern_helpers.rb
+- spec/helpers/request_helpers/misc_helpers.rb
+- spec/helpers/request_helpers/needles_helpers.rb
+- spec/helpers/request_helpers/pattern_helpers.rb
+- spec/helpers/request_helpers.rb
 - spec/helpers/yarn_helpers.rb
 - spec/helpers/yarn_weight_helpers.rb
 - spec/ravelry/author_spec.rb
@@ -160,6 +161,7 @@ test_files:
 - spec/ravelry/printing_spec.rb
 - spec/ravelry/user_spec.rb
 - spec/ravelry/utils/build_spec.rb
+- spec/ravelry/utils/request_spec.rb
 - spec/ravelry/yarn_spec.rb
 - spec/ravelry/yarn_weight_spec.rb
 - spec/ravelry_spec.rb

data/.gitignore

@@ -1,8 +0,0 @@
-# yard generated
-doc
-.yardoc
-
-# bundler
-.bundle
-
-*.gem

data/.rspec

@@ -1,2 +0,0 @@
---color
---format documentation

data/.ruby-version

@@ -1 +0,0 @@
-2.1.2

data/.yardopts

@@ -1 +0,0 @@
---markup markdown

data/Gemfile

@@ -1,16 +0,0 @@
-source "http://rubygems.org"
-
-gem "typhoeus", "~> 0.6"
-
-group :development do
-  gem "rspec", "~> 2.14.1"
-  gem "bundler"
-  gem "yard"
-  gem "redcarpet"
-end
-
-group :test do
-	gem "rake"
-  gem "pry"
-  gem "pry-nav"
-end

data/Gemfile.lock

@@ -1,42 +0,0 @@
-GEM
-  remote: http://rubygems.org/
-  specs:
-    coderay (1.1.0)
-    diff-lcs (1.2.5)
-    ethon (0.7.1)
-      ffi (>= 1.3.0)
-    ffi (1.9.6)
-    method_source (0.8.2)
-    pry (0.10.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    pry-nav (0.2.4)
-      pry (>= 0.9.10, < 0.11.0)
-    rake (10.1.1)
-    redcarpet (3.0.0)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.7)
-    rspec-expectations (2.14.4)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.4)
-    slop (3.6.0)
-    typhoeus (0.6.9)
-      ethon (>= 0.7.1)
-    yard (0.8.7.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler
-  pry
-  pry-nav
-  rake
-  redcarpet
-  rspec (~> 2.14.1)
-  typhoeus (~> 0.6)
-  yard

data/VERSION

@@ -1 +0,0 @@
-0.0.6

data/ravelry.gemspec

@@ -1,28 +0,0 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'ravelry/version'
-
-Gem::Specification.new do |spec|
-  spec.name = "ravelry"
-  spec.version = Ravelry::VERSION
-  spec.authors = ["Liz Abinante"]
-  spec.date = "2015-11-10"
-  spec.summary = "Ruby gem for accessing the Ravelry API."
-  spec.description = "Ruby gem for accessing the Ravelry API painlessly, easily, and awesomely."
-  spec.email = "me@liz.codes"
-  spec.homepage = "http://github.com/ArtCraftCode/ravelry"
-  spec.licenses = ["MIT"]
-  spec.require_paths = ["lib"]
-  spec.required_ruby_version = '>= 2.0.0'
-
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_dependency "typhoeus", "~> 0.6"
-end
-