rav-meser-api 1.0.10 → 1.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e0f636412d9ed71a57d55b4ae742cea7573c724b
-  data.tar.gz: edc1bc29eb40961ae5645384d9296d41dedc45a0
+  metadata.gz: b5af78dca1569cd1371bd4c865e0d6e008dbeb83
+  data.tar.gz: e1eab72927bd85dd10a0ab5d707a50f2cc1b2e1c
 SHA512:
-  metadata.gz: 4eb0fac7401857a4a098809c5fa65e525a159e199fc6f5968663f5753bda1f4523ae01d3637f18d266bbb61a03d883f5f836e284f076f956cc94ef5b19fdd6e6
-  data.tar.gz: 6c5b4fec06e98487021242d5cf3502db6106982659ace432256cf43f7b6f41d0bf4a0c1b331abf4be81a799956ecc07c25fa64e271e76e87ac529d6d96d90f68
+  metadata.gz: 8066c1b337a3bae6da3baef2229ba92e1df9aa00039902db86047908d3bc833544772a234b9b1de1fea85e0ce3e497dafd7401ad63545250ac434daf24bdc386
+  data.tar.gz: 5142d7e8a5dc350110f5bf8a956eb7c32861c3d7e4300ea431f60576b994945907d7af958aea3da54341052fc583ada78208fb0f723b5855364f9ca235076214

data/lib/rav-meser-api.rb

@@ -2,8 +2,8 @@ require 'rubygems'
 require 'oauth'
 require 'json'
 require 'optparse'
-require 'pp'
 require 'uri'
+# require 'pp'
 # require 'pry'
 
 # gem class name RavMeser
@@ -148,13 +148,19 @@ class RavMeser
   #   id: (int)
   #   args: (Hash)
   def upsert_subscribers(id, args = {})
+    raise 'Too few subscribers' if args.length.zero?
+
     create_response = send_request(:post, 'subscribers', '/' + id.to_s + '/subscribers', [], args)
+    raise "ERRORS: #{create_response['ERRORS']}" unless create_response['ERRORS'].empty?
 
-    update_args = {}
-    create_response['EMAILS_EXISTING'].each_with_index do |email, index|
-      update_args[index] = get_subscriber_args_and_set_identifier(args, email)
+    edit_response = {}
+    unless create_response['EMAILS_EXISTING'].empty?
+      update_args = {}
+      create_response['EMAILS_EXISTING'].each_with_index do |email, index|
+        update_args[index] = get_subscriber_args_and_set_identifier(args, email)
+      end
+      edit_response = send_request(:put, 'subscribers', '/' + id.to_s + '/subscribers', [], update_args)
     end
-    edit_response = send_request(:put, 'subscribers', '/' + id.to_s + '/subscribers', [], update_args)
 
     [create_response, edit_response]
   end
@@ -170,18 +176,20 @@ class RavMeser
   #   id: (int)
   #   args: (Hash)
   def upsert_subscriber(id, args = {})
-    return { error: 'Too many subscribers' } unless args.length == 1
+    raise 'Too many subscribers' unless args.length == 1
 
+    edit_response = {}
     create_response = send_request(:post, 'subscribers', '/' + id.to_s + '/subscribers', [], args)
+    raise "ERRORS: #{create_response['ERRORS']}" unless create_response['ERRORS'].empty?
+
     if create_response['EMAILS_EXISTING'].length == 1
       args[0][:IDENTIFIER] = args[0].delete(:EMAIL)
       edit_response = send_request(:put, 'subscribers', '/' + id.to_s + '/subscribers', [], args)
     end
 
-    [create_response, edit_response || {}]
+    [create_response, edit_response]
   end
 
-
   # <!----------- PERSONAL FIELDS -----------!>
 
   # get personal fields from specific list
@@ -299,7 +307,12 @@ class RavMeser
     query = [query]
     path_request = query.empty? ? path : path + URI.encode_www_form(query)
     response = @access_token.request(type, path_request, json_obj)
-    response = JSON.parse(response.body) unless response.class == String
+
+    begin
+      response = JSON.parse(response.body)
+    rescue StandardError => e
+      raise "RavMeser API return invalid response.\n#{e}"
+    end
     response
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rav-meser-api
 version: !ruby/object:Gem::Version
-  version: 1.0.10
+  version: 1.0.11
 platform: ruby
 authors:
 - Itamar Davidyan