rating 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7828759c72eb95c9dc6562c8c56b2b42c2b266e6
-  data.tar.gz: ad5a258d49d2bbf05f0d2fbc54800e590850d5a9
+  metadata.gz: ba499c445d9291907d676503a5e1a1ad2cb81672
+  data.tar.gz: e3f4479fbb330484091e31cc576bb373b877103f
 SHA512:
-  metadata.gz: 880d5a7fe68b86e91d9b7eaf1c3f3ab3b7ef40eac8db2942daa8a7beca89e5887abbf92fbdc05b5bc751dd9ea292362bb5513c6adb43f74391a832027e5e15e4
-  data.tar.gz: 94e6666f1174c77da6cd9db33fd2415aa4af621813689da0ff7c1f082c55b39015d2538add63cff10b4972a4a5797859f1b3c42d061d4611b1b14106d6b703fb
+  metadata.gz: 1e21b59e0a17407cb7d11c482d6114a0aa2823dcc7fa5f35ab72173d0dd7e23b1e315a923d4ca8bdc8cca235be77c32e50cabd3aa89753f9faed4fc5298e4043
+  data.tar.gz: 93ac02ecb7f4c1295f6c86e3483bfb80a4c7c8235fcd21e748c5a00c68f3c7db00c2443da7e8a2dc6aac8a578972f52c8641061cb877e7ad6cfe7438fbadd9bd

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## v0.4.0
+
+### News
+
+- Adds support to MySQL using decimal over float cast on calculations.
+
+### Updates
+
+- Grows up the decimal precision to enable billion of records count.
+
 ## v0.3.0
 
 ### News

data/lib/generators/rating/templates/db/migrate/create_rating_tables.rb

@@ -3,7 +3,7 @@
 class CreateRatingTables < ActiveRecord::Migration[5.0]
   def change
     create_table :rating_rates do |t|
-      t.decimal :value, default: 0, precision: 17, scale: 14
+      t.decimal :value, default: 0, precision: 25, scale: 16
 
       t.references :author,    index: true, null: false, polymorphic: true
       t.references :resource,  index: true, null: false, polymorphic: true
@@ -17,8 +17,8 @@ class CreateRatingTables < ActiveRecord::Migration[5.0]
       unique: true
 
     create_table :rating_ratings do |t|
-      t.decimal :average,  default: 0, mull: false, precision: 17, scale: 14
-      t.decimal :estimate, default: 0, mull: false, precision: 17, scale: 14
+      t.decimal :average,  default: 0, mull: false, precision: 25, scale: 16
+      t.decimal :estimate, default: 0, mull: false, precision: 25, scale: 16
       t.integer :sum,      default: 0, mull: false
       t.integer :total,    default: 0, mull: false
 

data/lib/rating/models/rating/rating.rb

@@ -25,8 +25,8 @@ module Rating
 
         sql = %(
           SELECT
-            (#{total_count} / CAST(#{distinct_count} AS float)) count_avg,
-            COALESCE(AVG(value), 0)                             rating_avg
+            (CAST(#{total_count} AS DECIMAL(17, 14)) / #{distinct_count}) count_avg,
+            COALESCE(AVG(value), 0)                                       rating_avg
           FROM #{rate_table_name}
           WHERE resource_type = :resource_type AND #{scope_type_query(scopeable)}
         ).squish

data/lib/rating/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rating
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/spec/models/rating/averager_data_spec.rb

@@ -14,7 +14,7 @@ RSpec.describe Rating::Rating, ':averager_data' do
     end
 
     it 'returns the average of number of records for the given resource type' do
-      expect(result.as_json['count_avg']).to eq 1.3333333333333333
+      expect(result.as_json['count_avg'].to_s).to eq '1.333333333333333333'
     end
   end
 

data/spec/models/rating/data_spec.rb

@@ -22,7 +22,7 @@ RSpec.describe Rating::Rating, ':data' do
     end
 
     it 'returns the estimate for a resource' do
-      expect(result[:estimate]).to eq 42.50000000000001
+      expect(result[:estimate].to_s).to eq '42.5000000000000000012000000505'
     end
   end
 

data/spec/models/rating/update_rating_spec.rb

@@ -10,8 +10,8 @@ RSpec.describe Rating::Rating, ':update_rating' do
     it 'updates the rating data of the given resource' do
       record = described_class.find_by(resource: article_1)
 
-      expect(record.average).to  eq 50.50000000000001
-      expect(record.estimate).to eq 42.50000000000001
+      expect(record.average).to  eq 50.5
+      expect(record.estimate).to eq 42.5
       expect(record.sum).to      eq 101
       expect(record.total).to    eq 2
     end

data/spec/rails_helper.rb

@@ -3,9 +3,15 @@
 ENV['RAILS_ENV'] ||= 'test'
 
 require 'active_record/railtie'
+require 'mysql2'
 require 'pry-byebug'
 require 'rating'
 
-ActiveRecord::Base.establish_connection adapter: :sqlite3, database: ':memory:'
+client = Mysql2::Client.new(host: :localhost, username: :root)
+
+client.query 'DROP DATABASE IF EXISTS rating_test;'
+client.query 'CREATE DATABASE IF NOT EXISTS rating_test;'
+
+ActiveRecord::Base.establish_connection adapter: :mysql2, database: :rating_test, username: :root
 
 Dir[File.expand_path('support/**/*.rb', __dir__)].each { |file| require file }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rating
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Washington Botelho
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-01 00:00:00.000000000 Z
+date: 2018-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -59,7 +59,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -73,7 +73,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -87,7 +87,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -101,7 +101,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: shoulda-matchers
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -115,7 +115,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="