rapporteur 1.1.0 → 2.0.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzI4YmEwOWRmNDc4MjQwNjVhNWI3MDNiZGM2MDg3NGZmYjYxODEwYw==
+    YzExOTM1MmZmNjFhYWY1MTRiN2QwMDcyOTMwMzNmZTk3MmY3MmZmMA==
   data.tar.gz: !binary |-
-    NzdiMGZhZmFiODMyNTRiZGJmMjYxOWI0MTJhMjRjMzg0NWVhODM4Zg==
+    MjBjMDgxMGI1ZDg0NzY0YWUwZGVmOGFlNDY0MDBmN2IxMmNkNGZlNw==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZGVkMTcyMzZhMWU0OGY3ZjNkZmUyNzI5MDJkYTc3ZWRkNzhlNWUzMzI0ZDdh
-    NDk1MzllN2Y0YWY0YWJjODYxMDFlNGJiYjE3MzczNjdkM2U0ZTUxY2Q1ZmM0
-    NTYyZWFiNzAwMjQ0MGU2MTdmMjhlZDQwM2I2NmY1YmQ5NDNhZDA=
+    MDNhMzI1ZWUyOTE3OTllOTA3NjVkZDQ1YjZmNGJiMGJmMzBhNDAwYjE2YWQ0
+    YWQ5NDliZTFkOGY4MzkyMWFiMWNiODZhNTI5OGY0OTYwYmNlMDRiZTUyZmQz
+    OGYzNmVhZjYxZTJiMmUzNmJiODY0NGQxYjhmMzI4NDkxMzRkNDI=
   data.tar.gz: !binary |-
-    M2U4Y2IzYzhkYTQ3OTkzYTc0NGFhYmM2NjIwNTRhNjliN2JmMTc2MGUyMGJi
-    M2ViNDU4ZGQ1Y2M5Y2Q5MTI1YTRmNTk1OGIxNWZlOTQ3ZmIxMzFkNDIxM2I5
-    MDExN2YzNDc4NjVhZTZiYjEwN2VjYzk3OGU2ZDgyMzMxODFiODI=
+    YmNkYzlkYzQ2NTZlNTNiZmExNzM3Y2JiM2FiYTgxMDczZjdmNjI2YzA5MzZj
+    NTJiNzYxY2YxYjQ0OWM0ODRiZjA3YWU3MTdjNDllYzdjMTM0MjkyOTA2OTEz
+    NjcyMjg3OWI2NzMyZDkzYTE2ZGI1YjAwOTA1ZDVjNDkxYTZlNTE=

data/.travis.yml

@@ -2,6 +2,7 @@ language: ruby
 rvm:
   - 1.9.2
   - 1.9.3
+  - jruby
 gemfile:
   - gemfiles/rails3.1.gemfile
   - gemfiles/rails3.2.gemfile

data/CHANGELOG.md

@@ -4,6 +4,29 @@
 
 * No significant changes.
 
+## [2.0.0][v2.0.0] / 2013-05-31
+
+* Removed active_model_serializers dependency.
+* Extracted time and revision checks into Checks::TimeCheck and
+  Checks::RevisionCheck, and applied them as the default checks.
+* Updated Checker#add_error to allow for I18n interpolated values.
+* Updated Checker#add_check to take a block in addition to a lambda or object
+  that responds to #call.
+* Added Checker#halt! which checks can call to short-circuit processing of any
+  further checks.
+
+### :boom: Backward incompatible changes
+
+* Flattened the messages key in the JSON response. All messages are now
+  included at the top level of the hash.
+* It's now possible to remove all checks by calling Checker#clear. This
+  includes the default TimeCheck and RevisionCheck checks.
+* Simplified the I18n scope to "rapporteur.errors.{attribute}.{key}". This
+  means that Checker#add_error now takes at least 2 arguments, similarly to
+  ActiveModel::Errors#add.
+* Added a facade for all Checker interaction. Clients should not use
+  Rapporteur::Checker.add_check et al, in favor of using Rapporteur.add_check.
+
 ## [1.1.0][v1.1.0] / 2013-05-30
 
 * Add the ability to define custom successful response messages via
@@ -20,6 +43,7 @@
 * Initial public release.
 
 
-[unreleased]: https://github.com/codeschool/rapporteur/compare/v1.1.0...master
+[unreleased]: https://github.com/codeschool/rapporteur/compare/v2.0.0...master
+[v2.0.0]: https://github.com/codeschool/rapporteur/compare/v1.1.0...v2.0.0
 [v1.1.0]: https://github.com/codeschool/rapporteur/compare/v1.0.1...v1.1.0
 [v1.0.1]: https://github.com/codeschool/rapporteur/compare/v1.0.0...v1.0.1

data/Gemfile

@@ -1,2 +1,5 @@
 source 'https://rubygems.org'
 gemspec
+
+gem "activerecord-jdbcsqlite3-adapter",  :platforms => :jruby
+gem "sqlite3",                           :platforms => :ruby

data/README.md

@@ -36,6 +36,7 @@ Supported Ruby versions:
 
 * MRI 1.9.2
 * MRI 1.9.3
+* JRuby 1.7.4
 
 Supported Rails versions:
 
@@ -106,7 +107,7 @@ environment or application configuration files or initializers, such as:
 
 ```ruby
 # config/initializers/rapporteur.rb
-Rapporteur::Checker.add_check(Rapporteur::Checks::ActiveRecordCheck)
+Rapporteur.add_check(Rapporteur::Checks::ActiveRecordCheck)
 ```
 
 Or, make an environment specific check with:
@@ -115,7 +116,7 @@ Or, make an environment specific check with:
 # config/environments/production.rb
 MyApplication.configure do
   config.to_prepare do
-    Rapporteur::Checker.add_check(Rapporteur::Checks::ActiveRecordCheck)
+    Rapporteur.add_check(Rapporteur::Checks::ActiveRecordCheck)
   end
 end
 ```
@@ -130,12 +131,16 @@ happy with it, add an error to the given `checker` instance:
 ```ruby
 # config/initializers/rapporteur.rb
 
+Rapporteur.add_check do |checker|
+  checker.add_message(:paid, "too much")
+end
+
 my_proc_check = lambda { |checker|
   checker.add_error("You have bad luck!") if rand(10) > 5
   checker.add_message(:luck, "good")
 }
 
-Rapporteur::Checker.add_check(my_proc_check)
+Rapporteur.add_check(my_proc_check)
 
 class MyClassCheck
   def self.call(checker)
@@ -144,7 +149,7 @@ class MyClassCheck
   end
 end
 
-Rapporteur::Checker.add_check(MyClassCheck)
+Rapporteur.add_check(MyClassCheck)
 ```
 
 Certainly, the definition and registration of the checks do not need to occur

data/app/controllers/statuses_controller.rb

@@ -3,8 +3,6 @@ class StatusesController < ActionController::Base
   respond_to :json
 
   def show
-    respond_with(Rapporteur::Checker.run, {
-      serializer: Rapporteur::Serializer
-    })
+    respond_with(Rapporteur.run)
   end
 end

data/config/locales/en.yml

@@ -1,8 +1,5 @@
 en:
-  activemodel:
+  rapporteur:
     errors:
-      models:
-        rapporteur/checker:
-          attributes:
-            base:
-              database_unavailable: "The application database is inaccessible or unavailable"
+      database:
+        unavailable: "The application database is inaccessible or unavailable"

data/gemfiles/rails3.1.gemfile

@@ -2,6 +2,8 @@
 
 source "https://rubygems.org"
 
+gem "activerecord-jdbcsqlite3-adapter", :platforms=>:jruby
+gem "sqlite3", :platforms=>:ruby
 gem "railties", "~> 3.1.0"
 
 gemspec :path=>"../"

data/gemfiles/rails3.2.gemfile

@@ -2,6 +2,8 @@
 
 source "https://rubygems.org"
 
+gem "activerecord-jdbcsqlite3-adapter", :platforms=>:jruby
+gem "sqlite3", :platforms=>:ruby
 gem "railties", "~> 3.2.0"
 
 gemspec :path=>"../"

data/lib/rapporteur.rb

@@ -1,5 +1,3 @@
-require 'active_model_serializers'
-
 require "rapporteur/engine" if defined?(Rails)
 require "rapporteur/version"
 
@@ -8,8 +6,63 @@ require "rapporteur/version"
 #
 module Rapporteur
   autoload :Checker, 'rapporteur/checker'
+  autoload :CheckerDeprecations, 'rapporteur/checker_deprecations'
   autoload :Checks, 'rapporteur/checks'
   autoload :Responder, 'rapporteur/responder'
   autoload :Revision, 'rapporteur/revision'
-  autoload :Serializer, 'rapporteur/serializer'
+
+
+  # Public: Add a pre-built or custom check to your status endpoint. These
+  # checks are used to test the state of the world of the application, and
+  # need only respond to `#call`.
+  #
+  # Once added, the given check will be called and passed an instance of this
+  # checker. If everything is good, do nothing! If there is a problem, use
+  # `add_error` to add an error message to the checker.
+  #
+  # Examples
+  #
+  #   Rapporteur.add_check { |checker|
+  #     checker.add_error("Bad luck.") if rand(2) == 1
+  #   }
+  #
+  # Returns the Checker instance.
+  # Raises ArgumentError if the given check does not respond to call.
+  #
+  def self.add_check(object_or_nil_with_block=nil, &block)
+    checker.add_check(object_or_nil_with_block, &block)
+  end
+
+  # Internal: The Checker instance. All toplevel calls on Rapporteur are
+  # delgated to this object.
+  #
+  def self.checker
+    unless @checker
+      @checker = Checker.new
+      add_check(Checks::RevisionCheck)
+      add_check(Checks::TimeCheck)
+    end
+    @checker
+  end
+
+  # Public: Empties all configured checks from the checker. This may be
+  # useful for testing and for cases where you might've built up some basic
+  # checks but for one reason or another (environment constraint) need to
+  # start from scratch.
+  #
+  # Returns the Checker instance.
+  #
+  def self.clear_checks
+    checker.clear
+  end
+
+  # Public: This is the primary execution point for this class. Use run to
+  # exercise the configured checker and collect any application errors or
+  # data for rendering.
+  #
+  # Returns the Checker instance.
+  #
+  def self.run
+    checker.run
+  end
 end

data/lib/rapporteur/checker.rb

@@ -1,4 +1,3 @@
-require 'singleton'
 require 'set'
 
 module Rapporteur
@@ -7,9 +6,15 @@ module Rapporteur
   # controller with that data for rendering.
   #
   class Checker
-    include Singleton
     include ActiveModel::Validations
-    include ActiveModel::SerializerSupport
+    extend CheckerDeprecations
+
+
+    def initialize
+      @messages = Hash.new
+      @checks = Set.new
+      reset
+    end
 
 
     # Public: Add a pre-built or custom check to your status endpoint. These
@@ -22,16 +27,21 @@ module Rapporteur
     #
     # Examples
     #
-    #   Rapporteur::Checker.add_check(lambda { |checker|
+    #   Rapporteur.add_check { |checker|
     #     checker.add_error("Bad luck.") if rand(2) == 1
-    #   })
+    #   }
     #
-    # Returns Rapporteur::Checker.
+    # Returns self.
     # Raises ArgumentError if the given check does not respond to call.
     #
-    def self.add_check(object)
-      raise ArgumentError, "A check must respond to #call." unless object.respond_to?(:call)
-      instance.checks << object
+    def add_check(object_or_nil_with_block=nil, &block)
+      if block_given?
+        @checks << block
+      elsif object_or_nil_with_block.respond_to?(:call)
+        @checks << object_or_nil_with_block
+      else
+        raise ArgumentError, "A check must respond to #call."
+      end
       self
     end
 
@@ -40,26 +50,41 @@ module Rapporteur
     # checks but for one reason or another (environment constraint) need to
     # start from scratch.
     #
-    # Returns Rapporteur::Checker.
+    # Returns self.
     #
-    def self.clear
-      instance.checks.clear
+    def clear
+      @checks.clear
       self
     end
 
+    ##
+    # Public: Checks can call this method to halt any further processing. This
+    # is useful for critical or fatal check failures.
+    #
+    # For example, if load is too high on a machine you may not want to run any
+    # other checks.
+    #
+    # Returns true.
+    #
+    def halt!
+      @halted = true
+    end
+
     # Public: This is the primary execution point for this class. Use run to
     # exercise the configured checker and collect any application errors or
     # data for rendering.
     #
-    # Returns a Rapporteur::Checker instance.
+    # Returns self.
     #
-    def self.run
-      instance.messages.clear
-      instance.errors.clear
-      instance.run
+    def run
+      reset
+      @checks.each do |object|
+        object.call(self)
+        break if @halted
+      end
+      self
     end
 
-
     # Public: Add an error message to the checker in order to have it rendered
     # in the status request.
     #
@@ -72,10 +97,12 @@ module Rapporteur
     #   checker.add_error("You failed.")
     #   checker.add_error(:i18n_key_is_better)
     #
-    # Returns the Rapporteur::Checker instance.
+    # Returns self.
     #
-    def add_error(message)
-      errors.add(:base, message)
+    def add_error(key, message, options={})
+      options[:scope] = [:rapporteur, :errors, key]
+      options[:default] = [message, message.to_s.humanize]
+      errors.add(key, message, options)
       self
     end
 
@@ -92,47 +119,38 @@ module Rapporteur
     #   checker.add_message(:repository, 'git@github.com/user/repo.git')
     #   checker.add_message(:load, 0.934)
     #
-    # Returns the Rapporteur::Checker instance.
+    # Returns self.
     #
     def add_message(name, message)
-      messages[name] = message
+      @messages[name] = message
       self
     end
 
-    # Public: Returns the Set of checks currently configured.
+    ##
+    # Internal: Returns a hash of messages suitable for conversion into JSON.
     #
-    def checks
-      @checks ||= Set.new
+    def as_json(args={})
+      @messages
     end
 
-    # Public: Returns the Hash of messages currently configured.
+    ##
+    # Internal: Used by Rails' JSON serialization, specifically in
+    # ActionController::Responder.
     #
-    def messages
-      @messages ||= Hash.new
+    def read_attribute_for_serialization(key)
+      @messages[key]
     end
 
-    # Public: Returns a String containing the current revision of the
-    # application.
-    #
-    def revision
-      Revision.current
-    end
+    alias read_attribute_for_validation read_attribute_for_serialization
 
-    # Public: Executes the configured checks.
-    #
-    # Returns the Rapporteur::Checker instance.
-    #
-    def run
-      checks.each do |object|
-        object.call(self)
-      end
-      self
-    end
 
-    # Public: Returns a Time instance containing the current system time.
-    #
-    def time
-      Time.now
+    private
+
+
+    def reset
+      @halted = false
+      @messages.clear
+      errors.clear
     end
   end
 end

data/lib/rapporteur/checker_deprecations.rb

@@ -0,0 +1,20 @@
+require 'active_support/deprecation'
+
+module Rapporteur
+  module CheckerDeprecations
+    def add_check(*args, &block)
+      ActiveSupport::Deprecation.warn("use Rapporteur.add_check", caller)
+      Rapporteur.add_check(*args, &block)
+    end
+
+    def clear
+      ActiveSupport::Deprecation.warn("use Rapporteur.clear", caller)
+      Rapporteur.clear
+    end
+
+    def run
+      ActiveSupport::Deprecation.warn("use Rapporteur.run", caller)
+      Rapporteur.run
+    end
+  end
+end

data/lib/rapporteur/checks.rb

@@ -1,5 +1,8 @@
 module Rapporteur
   module Checks
     autoload :ActiveRecordCheck, 'rapporteur/checks/active_record_check'
+
+    TimeCheck = lambda { |checker| checker.add_message(:time, Time.now.utc) }
+    RevisionCheck = lambda { |checker| checker.add_message(:revision, Revision.current) }
   end
 end

data/lib/rapporteur/checks/active_record_check.rb

@@ -4,7 +4,7 @@ module Rapporteur
       def self.call(checker)
         ActiveRecord::Base.connection.execute("SELECT current_time AS time").first.fetch('time')
       rescue
-        checker.add_error(:database_unavailable)
+        checker.add_error(:database, :unavailable)
       end
     end
   end

data/lib/rapporteur/rspec.rb

@@ -19,17 +19,6 @@ shared_examples_for 'a successful status response' do
     it 'does not contain errors' do
       expect(subject).not_to(have_key('errors'))
     end
-
-    it 'contains the current application revision' do
-      expect(subject.fetch('revision')).to(match(/^[a-f0-9]{40}$/))
-    end
-
-    it 'contains the current time in ISO8601' do
-      time = Time.now
-      Time.stub(:now).and_return(time)
-      expect(subject.fetch('time')).to(match(/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/))
-      expect(subject.fetch('time')).to(eq(time.utc.iso8601))
-    end
   end
 end
 
@@ -52,26 +41,25 @@ shared_examples_for 'an erred status response' do
   end
 end
 
-RSpec::Matchers.define :include_status_error_message do |message|
+RSpec::Matchers.define :include_status_error_message do |attribute, message|
   match do |response|
     @body = JSON.parse(response.body)
-    @body.fetch('errors', {}).fetch('base').include?(message)
+    @body.fetch('errors', {}).fetch(attribute.to_s).include?(message)
   end
 
   failure_message_for_should do |actual|
-    "expected #{@body.inspect} to include a #{message.inspect} error message"
+    "expected #{@body.inspect} to include a #{attribute}:#{message.inspect} error message"
   end
 
   failure_message_for_should_not do |actual|
-    "expected #{@body.inspect} to not include a #{message.inspect} error message"
+    "expected #{@body.inspect} to not include a #{attribute}:#{message.inspect} error message"
   end
 end
 
 RSpec::Matchers.define :include_status_message do |name, message|
   match do |response|
     @body = JSON.parse(response.body)
-    messages = @body.fetch('messages', {})
-    messages.has_key?(name) && messages.fetch(name) == message
+    @body.has_key?(name) && @body.fetch(name) == message
   end
 
   failure_message_for_should do |actual|

data/lib/rapporteur/version.rb

@@ -1,3 +1,3 @@
 module Rapporteur
-  VERSION = "1.1.0"
+  VERSION = "2.0.0"
 end

data/rapporteur.gemspec

@@ -18,13 +18,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'active_model_serializers', '~> 0.7'
   spec.add_dependency 'railties', '~> 3.1'
+  spec.add_dependency 'activesupport'
 
   spec.add_development_dependency "appraisal", "~> 0.5"
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "combustion", "~> 0.5"
   spec.add_development_dependency "rails", "~> 3.1"
   spec.add_development_dependency "rspec-rails", "~> 2.11"
-  spec.add_development_dependency "sqlite3"
 end

data/spec/requests/active_record_check_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe 'A status request with an ActiveRecordCheck' do
   before do
-    Rapporteur::Checker.add_check(Rapporteur::Checks::ActiveRecordCheck)
+    Rapporteur.add_check(Rapporteur::Checks::ActiveRecordCheck)
   end
 
   subject { get(status_path) ; response }
@@ -20,7 +20,7 @@ describe 'A status request with an ActiveRecordCheck' do
     it_behaves_like 'an erred status response'
 
     it 'contains a message regarding the database failure' do
-      expect(subject).to include_status_error_message(I18n.t('activemodel.errors.models.rapporteur/checker.attributes.base.database_unavailable'))
+      expect(subject).to include_status_error_message(:database, I18n.t('rapporteur.errors.database.unavailable'))
     end
   end
 end

data/spec/requests/halt_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe 'A check calling #halt!' do
+  before do
+    Rapporteur.add_check { |checker| checker.add_message(:one, 1) }
+    Rapporteur.add_check { |checker| checker.add_message(:two, 2).halt! }
+    Rapporteur.add_check { |checker| checker.add_message(:three, 3) }
+  end
+
+  subject { get(status_path) ; JSON.parse(response.body) }
+
+  it 'runs the first check' do
+    expect(subject).to include('one')
+  end
+
+  it 'runs the second check' do
+    expect(subject).to include('two')
+  end
+
+  it 'does not run any checks after #halt! is called' do
+    expect(subject).not_to include('three')
+  end
+end

data/spec/requests/messsage_addition_spec.rb

@@ -3,10 +3,9 @@ require 'spec_helper'
 describe 'A status request with a check that modifies messages' do
   subject { get(status_path) ; response }
 
-  context 'creating a message with a lambda' do
+  context 'creating a message with a block' do
     before do
-      Rapporteur::Checker.clear
-      Rapporteur::Checker.add_check(Proc.new { |checker| checker.add_message('git_repo', 'git@github.com:organization/repo.git') })
+      Rapporteur.add_check { |checker| checker.add_message('git_repo', 'git@github.com:organization/repo.git') }
     end
 
     context 'with an unerring response' do
@@ -19,7 +18,7 @@ describe 'A status request with a check that modifies messages' do
 
     context 'with an erring response' do
       before do
-        Rapporteur::Checker.add_check(Proc.new { |checker| checker.add_error('failed') })
+        Rapporteur.add_check { |checker| checker.add_error(:base, 'failed') }
       end
 
       it_behaves_like 'an erred status response'
@@ -30,8 +29,6 @@ describe 'A status request with a check that modifies messages' do
     end
 
     context 'with no message-modifying checks' do
-      before { Rapporteur::Checker.clear }
-
       it_behaves_like 'a successful status response'
 
       it 'does not respond with a messages list' do

data/spec/requests/no_checks_spec.rb

@@ -1,8 +1,6 @@
 require 'spec_helper'
 
 describe 'A status request with no checks' do
-  before { Rapporteur::Checker.clear }
-
   subject { get(status_path) ; response }
 
   it_behaves_like 'a successful status response'

data/spec/requests/revision_check_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe 'A status request with a RevisionCheck' do
+  before do
+    Rapporteur.add_check(Rapporteur::Checks::RevisionCheck)
+  end
+
+  subject { get(status_path) ; response }
+
+  it_behaves_like 'a successful status response'
+
+  context 'the response payload' do
+    subject { get(status_path) ; JSON.parse(response.body) }
+
+    it 'contains the current application revision' do
+      expect(subject.fetch('revision')).to(match(/^[a-f0-9]{40}$/))
+    end
+  end
+end

data/spec/requests/time_check_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe 'A status request with a TimeCheck' do
+  before do
+    Rapporteur.add_check(Rapporteur::Checks::TimeCheck)
+  end
+
+  subject { get(status_path) ; response }
+
+  it_behaves_like 'a successful status response'
+
+  context 'the response payload' do
+    subject { get(status_path) ; JSON.parse(response.body) }
+
+    it 'contains the current time in ISO8601' do
+      time = Time.now
+      Time.stub(:now).and_return(time)
+      expect(subject.fetch('time')).to(match(/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/))
+      expect(subject.fetch('time')).to(eq(time.utc.iso8601))
+    end
+  end
+end
+

data/spec/spec_helper.rb

@@ -15,5 +15,5 @@ RSpec.configure do |config|
 
   config.order = 'random'
 
-  config.before { Rapporteur::Checker.clear }
+  config.before { Rapporteur.clear_checks }
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rapporteur
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Envy Labs
@@ -9,36 +9,36 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-30 00:00:00.000000000 Z
+date: 2013-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: active_model_serializers
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -109,20 +109,6 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.11'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: An engine that provides common status polling endpoint.
 email:
 - ''
@@ -147,13 +133,13 @@ files:
 - gemfiles/rails3.2.gemfile
 - lib/rapporteur.rb
 - lib/rapporteur/checker.rb
+- lib/rapporteur/checker_deprecations.rb
 - lib/rapporteur/checks.rb
 - lib/rapporteur/checks/active_record_check.rb
 - lib/rapporteur/engine.rb
 - lib/rapporteur/responder.rb
 - lib/rapporteur/revision.rb
 - lib/rapporteur/rspec.rb
-- lib/rapporteur/serializer.rb
 - lib/rapporteur/version.rb
 - rapporteur.gemspec
 - spec/internal/config/database.yml
@@ -162,8 +148,11 @@ files:
 - spec/internal/log/.gitignore
 - spec/internal/public/favicon.ico
 - spec/requests/active_record_check_spec.rb
+- spec/requests/halt_spec.rb
 - spec/requests/messsage_addition_spec.rb
 - spec/requests/no_checks_spec.rb
+- spec/requests/revision_check_spec.rb
+- spec/requests/time_check_spec.rb
 - spec/routing/routes_spec.rb
 - spec/spec_helper.rb
 homepage: ''
@@ -197,7 +186,10 @@ test_files:
 - spec/internal/log/.gitignore
 - spec/internal/public/favicon.ico
 - spec/requests/active_record_check_spec.rb
+- spec/requests/halt_spec.rb
 - spec/requests/messsage_addition_spec.rb
 - spec/requests/no_checks_spec.rb
+- spec/requests/revision_check_spec.rb
+- spec/requests/time_check_spec.rb
 - spec/routing/routes_spec.rb
 - spec/spec_helper.rb

data/lib/rapporteur/serializer.rb

@@ -1,30 +0,0 @@
-module Rapporteur
-  # An ActiveModel::Serializer used to serialize the checker data for JSON
-  # rendering.
-  #
-  class Serializer < ActiveModel::Serializer
-    self.root = false
-
-    attributes :revision,
-               :time,
-               :messages
-
-    # Internal: Converts the checker instance time into UTC to provide a
-    # consistent public representation.
-    #
-    # Returns a Time instance in UTC.
-    #
-    def time
-      object.time.utc
-    end
-
-    # Internal: Used by ActiveModel::Serializer to determine whether or not to
-    # include the messages attribute.
-    #
-    # Returns false if the messages are empty.
-    #
-    def include_messages?
-      !object.messages.empty?
-    end
-  end
-end