ransack_memory 0.0.9 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7b6a8a9db701878b3ea62f2af3b217c4cd2311c
-  data.tar.gz: 123cf3cf2b9a5bdb7667836823779f8076a34398
+  metadata.gz: ee63c846270102691c62cd2a7af77912d7aa7651
+  data.tar.gz: 8dd719ca19c83f10078157448a329f56ed959d9b
 SHA512:
-  metadata.gz: f1ff6fe707d3acc50e98da6112f335c8bee0eb6b8b0e8e04f8e70fdd3a636224a03b5777c16deeb2f82e1d1cb4cb385b02c9647c856ca5331f17da02f6158dd3
-  data.tar.gz: 4f345e31551be326d944e5ec8c7dab441ce8ff5bf0f670c126cb421eec787eda87f84f470748312d26db2d5428336847bdf8a1f40faf2e26c2f58f3f435c81dc
+  metadata.gz: 444c11b00620bd325023254a05b48ea80bd53dd527164c0a6db96dc880bbf9098e0049fc49e7ab68ea3e98369febb53db37571e00497a8ba9e7df14b6f789c90
+  data.tar.gz: fdd5cebf99c78325ad1f0744fd41ffbdf03f5a4d617dd0434e767e969cc2b84ebca9326ce1dd3e5024400c3b383e49e3c988e7a7538a07dead13344bc84534ab

data/README.md

@@ -9,6 +9,12 @@ Add this line to your application's Gemfile:
 gem 'ransack_memory'
 ```
 
+Run the generator
+
+```shell
+rails generate ransack_memory
+```
+
 Add this line to your basic controller (typically ApplicationController):
 
 ```ruby
@@ -27,12 +33,12 @@ Add this in your views where you have search forms. This is clear button, which
 You can pass any of link attributes:
 
 ```erb
-<%= clear_filter, title: 'Clear Filter', class: 'btn btn-primary', data: {confirm: 'Really?', my_data: 'something'} %>
+<%= clear_filter title: 'Clear Filter', class: 'btn btn-primary', data: {confirm: 'Really?', my_data: 'something'} %>
 ```
 
 ## Configuration
 
-Create file in config/initializers/ransack_memory.rb with this content:
+Running ```rails generate ransack_memory``` the console will generate `config/initializers/ransack_memory.rb` with this content:
 
 ```ruby
 RansackMemory::Core.config = {
@@ -41,8 +47,6 @@ RansackMemory::Core.config = {
 }
 ```
 
-Or you can generate this config file by running ```rails generate ransack_memory``` in console. 
-
 ## Load saved filters from another controller action
 
 In some cases, you want to load saved filters from another controller action. If so, you just create in the same controller this method:
@@ -57,7 +61,11 @@ Standard session key building is: ```"#{controller_name}_#{action_name}_#{reques
 
 ## Kaminari issue
 
-When you have an issue with Kaminari gem, that you can't go back to the first page, update your kaminari view in `app/views/kaminari/_first_page.html.erb`:
+When you have an issue with Kaminari gem, that you can't go back to the first page, generate a kaminari configuration in the initializers folder 
+and set ```config.params_on_first_page = true```. 
+
+As an alternative update your kaminari view in `app/views/kaminari/_first_page.html.erb`:
 ```erb
 <%= link_to_unless current_page.first?, t('views.pagination.first').html_safe, url_for(params.merge({page: 1, cancel_filter: nil})), remote: remote, class: 'btn btn-secondary' %>
 ```
+However beware that this will probably lead to problems in later Rails versions due to a change in the way it allows you to merge parameters.

data/app/controllers/concerns/ransack_memory/concern.rb

@@ -24,7 +24,7 @@ module RansackMemory
       end
 
       # search term saving
-      session["#{session_key_base}"] = params[::RansackMemory::Core.config[:param]] if params[::RansackMemory::Core.config[:param]].present?
+      session["#{session_key_base}"] = params[::RansackMemory::Core.config[:param]].to_h if params[::RansackMemory::Core.config[:param]].present?
 
       # page number saving
       session["#{session_key_base}_page"] = params[:page] if params[:page].present?
@@ -33,7 +33,7 @@ module RansackMemory
       session["#{session_key_base}_per_page"] = params[:per_page] if params[:per_page].present?
 
       # search term load
-      params[::RansackMemory::Core.config[:param]] = session["#{session_key_base}"].presence
+      params[::RansackMemory::Core.config[:param]] = session["#{session_key_base}"] if session["#{session_key_base}"].present?
 
       # page number load
       params[:page] = session["#{session_key_base}_page"].presence
@@ -42,12 +42,12 @@ module RansackMemory
       params[:per_page] = session["#{session_key_base}_per_page"].presence
 
       # set page number to 1 if filter has changed
-      if (params[::RansackMemory::Core.config[:param]].present? && session[:last_q_params] != params[::RansackMemory::Core.config[:param]]) || (params[:cancel_filter].present? && session["#{session_key_base}_page"] != params[:page])
+      if (params[::RansackMemory::Core.config[:param]].present? && session[:last_q_params] != params[::RansackMemory::Core.config[:param]].permit!.to_h) || (params[:cancel_filter].present? && session["#{session_key_base}_page"] != params[:page])
         params[:page] = nil
         session["#{session_key_base}_page"] = nil
       end
 
-      session[:last_q_params] = params[::RansackMemory::Core.config[:param]]
+      session[:last_q_params] = params[::RansackMemory::Core.config[:param]]&.to_unsafe_h
 
       # session[:last_page] = params[:page]
     end

data/lib/ransack_memory/version.rb

@@ -1,3 +1,3 @@
 module RansackMemory
-  VERSION = '0.0.9'
+  VERSION = '0.1.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ransack_memory
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.1.0
 platform: ruby
 authors:
 - Richard Lapiš
@@ -36,17 +36,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 3
 summary: Automatically save and load ransack's filtered params into session