ransack 1.7.0 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a62534d07f2b79f6ac71228f7b8884c2f97891f
-  data.tar.gz: 983a58938313d8b5ded1e13ff182f0ee1c27ee48
+  metadata.gz: 0a6333c22fc3b35aec6fea8a410ec2705e570031
+  data.tar.gz: ae8c1df141e8944b0509ba07d2e50d19b9c14c66
 SHA512:
-  metadata.gz: eb11af400660331859ddeeb11819d14849fd398ffe3b00368c860ee47baeeace67cb29116d15b46dcad92f1466bb19d6f9e85070baea384ef49500ad1aa1e3a1
-  data.tar.gz: 5ed69b32c4bd6a65b60e8dd2cccb5c634738b8fe3a3a7266ccc5c6a67ab2b720b016afbfcd8e7740c0ed76dea0c00d46db0c8a61b545b7e7ff66d324bd1057d3
+  metadata.gz: d6ed3d7bc6024116ac43c27888dc98b77ce265bab21046c7ac9dd0cb98a12077d7cf8ded176b073f825d11c92cbd02433b29ee5224b858bd5208e1a3edb19724
+  data.tar.gz: 9a6a06c4ee47b701e2ba2f6f29007c5dd00b16a34f7bbb57f9bada3d787a1caf2b6db8107dfaf5cdc0ac433665bc03e86a3e21c15a9e30daff509df5ea043c8d

data/.travis.yml

@@ -1,22 +1,23 @@
-services: mongodb
-
 language: ruby
 
 sudo: false
 
 rvm:
-  - 2.2.3
-  - 2.1
+  - 2.3.1
+  - 2.2.5
+  - 2.1.10
   - 2.0
   - 1.9
 
 env:
-  - RAILS=4-2-stable DB=mongodb
+  - RAILS=5-0-stable DB=sqlite3
+  - RAILS=5-0-stable DB=mysql
+  - RAILS=5-0-stable DB=postgres
+
   - RAILS=4-2-stable DB=sqlite3
   - RAILS=4-2-stable DB=mysql
   - RAILS=4-2-stable DB=postgres
 
-  - RAILS=4-1-stable DB=mongodb
   - RAILS=4-1-stable DB=sqlite3
   - RAILS=4-1-stable DB=mysql
   - RAILS=4-1-stable DB=postgres
@@ -34,30 +35,47 @@ env:
   - RAILS=3-1-stable DB=postgres
 
 matrix:
+  exclude:
+    - rvm: 2.1.10
+      env: RAILS=5-0-stable DB=sqlite3
+    - rvm: 2.1.10
+      env: RAILS=5-0-stable DB=mysql
+    - rvm: 2.1.10
+      env: RAILS=5-0-stable DB=postgres
+
+    - rvm: 2.0
+      env: RAILS=5-0-stable DB=sqlite3
+    - rvm: 2.0
+      env: RAILS=5-0-stable DB=mysql
+    - rvm: 2.0
+      env: RAILS=5-0-stable DB=postgres
+
+    - rvm: 1.9
+      env: RAILS=5-0-stable DB=sqlite3
+    - rvm: 1.9
+      env: RAILS=5-0-stable DB=mysql
+    - rvm: 1.9
+      env: RAILS=5-0-stable DB=postgres
+
   include:
-    - rvm: 2.2.3
+    - rvm: 2.3.1
       env: RAILS=master DB=sqlite3
-    - rvm: 2.2.3
+    - rvm: 2.3.1
       env: RAILS=master DB=mysql
-    - rvm: 2.2.3
+    - rvm: 2.3.1
       env: RAILS=master DB=postgres
-  exclude:
-    - rvm: 2.2.3
-      env: RAILS=3-1-stable DB=sqlite
-    - rvm: 2.2.3
-      env: RAILS=3-1-stable DB=mysql
-    - rvm: 2.2.3
-      env: RAILS=3-1-stable DB=postgres
+
+    - rvm: 2.2.5
+      env: RAILS=master DB=sqlite3
+    - rvm: 2.2.5
+      env: RAILS=master DB=mysql
+    - rvm: 2.2.5
+      env: RAILS=master DB=postgres
+
   allow_failures:
     - env: RAILS=master DB=sqlite3
     - env: RAILS=master DB=mysql
     - env: RAILS=master DB=postgres
-    - rvm: 2.2.3
-      env: RAILS=3-2-stable DB=sqlite
-    - rvm: 2.2.3
-      env: RAILS=3-2-stable DB=mysql
-    - rvm: 2.2.3
-      env: RAILS=3-2-stable DB=postgres
 
 before_script:
   - mysql -e 'create database ransack collate utf8_general_ci;'

data/CHANGELOG.md

@@ -1,9 +1,171 @@
 # Change Log
 
-## Unreleased
+## Version 1.8.0 - 2016-07-14
+### Added
+
+*   Support Mongoid 5. PR [#636](https://github.com/activerecord-hackery/ransack/pull/636), commit
+    [9e5faf4](https://github.com/activerecord-hackery/ransack/commit/9e5faf4).
+
+    *Josef Šimánek*
+
+*   Added optional block argument for the `sort_link` method. PR
+    [#604](https://github.com/activerecord-hackery/ransack/pull/604).
+
+    *Andrea Dal Ponte*
+
+*   Added `ransack_alias` to allow users to customize the names for long
+    ransack field names. PR
+    [#623](https://github.com/activerecord-hackery/ransack/pull/623).
+
+    *Ray Zane*
+
+*   Added support for searching on attributes that have been added to
+    Active Record models with `alias_attribute` (Rails >= 4 only). PR
+    [#592](https://github.com/activerecord-hackery/ransack/pull/592), commit
+    [549342a](https://github.com/activerecord-hackery/ransack/commit/549342a).
+
+    *Marten Schilstra*
+
+*   Add ability to globally hide sort link order indicator arrows with
+    `Ransack.configure#hide_sort_order_indicators = true`. PR
+    [#577](https://github.com/activerecord-hackery/ransack/pull/577), commit
+    [95d4591](https://github.com/activerecord-hackery/ransack/commit/95d4591).
+
+    *Josh Hunter*, *Jon Atack*
+
+*   Add test for `ActionController:Parameter` object params in `sort_link` to
+    ensure Ransack is handling the Rails 5 changes correctly. Commit
+    [b1cfed8](https://github.com/activerecord-hackery/ransack/commit/b1cfed8).
+
+    *Ryan Wood*
+
+*   Add failing tests to facilitate work on issue
+    [#566](https://github.com/activerecord-hackery/ransack/issues/566)
+    of passing boolean values to search scopes. PR
+    [#575](https://github.com/activerecord-hackery/ransack/pull/575).
+
+    *Marcel Eeken*
+
+*   Add Taiwanese Hokkien/Mandarin i18n locale file (`zh-TW.yml`). PR
+    [#674](https://github.com/activerecord-hackery/ransack/pull/674).
+
+    *Sibevin Wang*
+
+*   Add Danish i18n locale file (`da.yml`). PR
+    [#663](https://github.com/activerecord-hackery/ransack/pull/663).
+
+    *Kasper Johansen*
+
+*   Add Brazilian Portuguese i18n locale file (`pt-BR.yml`). PR
+    [#581](https://github.com/activerecord-hackery/ransack/pull/581).
+
+    *Diego Henrique Domingues*
+
+*   Add Indonesian (Bahasa) i18n locale file (`id.yml`). PR
+    [#612](https://github.com/activerecord-hackery/ransack/pull/612).
+
+    *Adam Pahlevi Baihaqi*
+
+*   Add Japanese i18n locale file (`ja.yml`). PR
+    [#622](https://github.com/activerecord-hackery/ransack/pull/622).
+
+    *Masanobu Mizutani*
+
+### Fixed
+
+*   In `FormHelper::SortLink#parameters_hash`, convert `params#to_unsafe_h`
+    only if Rails 5, and add tests. Commit
+    [14e66ca](https://github.com/activerecord-hackery/ransack/commit/14e66ca).
+
+    *Jon Atack*
+
+*   Respect negative conditions for collection associations and fix Mongoid
+    compat. PR [#645](https://github.com/activerecord-hackery/ransack/pull/645).
+
+    *Andrew Vit*
+
+*   Ensure conditions differing only by ransacker_args aren't filtered out.
+    PR [#665](https://github.com/activerecord-hackery/ransack/pull/665).
+
+    *Andrew Porterfield*
+
+*   Fix using aliased attributes in association searches, and add a failing
+    spec. PR [#602](https://github.com/activerecord-hackery/ransack/pull/602).
+
+    *Marten Schilstra*
+
+*   Replace Active Record `table_exists?` API that was deprecated
+    [here](https://github.com/rails/rails/commit/152b85f) in Rails 5. Commit
+    [c9d2297](https://github.com/activerecord-hackery/ransack/commit/c9d2297).
+
+    *Jon Atack*
+
+*   Adapt to changes in Rails 5 where AC::Parameters composes a HWIA instead of
+    inheriting from Hash starting from Rails commit rails/rails@14a3bd5. Commit
+    [ceafc05](https://github.com/activerecord-hackery/ransack/commit/ceafc05).
+
+    *Jon Atack*
+
+*   Fix test `#sort_link with hide order indicator set to true` to fail properly
+    ([4f65b09](https://github.com/activerecord-hackery/ransack/commit/4f65b09)).
+    This spec, added in
+    [#473](https://github.com/activerecord-hackery/ransack/pull/473), tested
+    the presence of the attribute name instead of the absence of the order
+    indicators and did not fail when it should.
+
+    *Josh Hunter*, *Jon Atack*
+
+*   Fix rspec-mocks `stub` deprecation warnings when running the tests. Commit
+    [600892e](https://github.com/activerecord-hackery/ransack/commit/600892e).
+
+    *Jon Atack*
+
+*   Revert
+    [f858dd6](https://github.com/activerecord-hackery/ransack/commit/f858dd6).
+    Fixes [#553](https://github.com/activerecord-hackery/ransack/issues/553)
+    performance regression with the SQL Server adapter.
+
+    *sschwing3*
+
+*   Fix invalid Chinese I18n locale file name by replacing "zh" with "zh-CN".
+    PR [#590](https://github.com/activerecord-hackery/ransack/pull/590).
 
+    *Ethan Yang*
+
+### Changed
+
+*   Memory/speed perf improvement: Freeze strings in array global constants and
+    partially move from using global string constants to frozen strings
+    ([381a83c](https://github.com/activerecord-hackery/ransack/commit/381a83c)
+    and
+    [ce114ec](https://github.com/activerecord-hackery/ransack/commit/ce114ec)).
+
+    *Jon Atack*
+
+*   Escape underscore `_` wildcard characters with PostgreSQL and MySQL. PR
+    [#584](https://github.com/activerecord-hackery/ransack/issues/584).
+
+    *Igor Dobryn*
+
+*   Refactor `Ransack::Adapters` from conditionals to classes
+    ([94a404c](https://github.com/activerecord-hackery/ransack/commit/94a404c)).
+
+    *Jon Atack*
 
 ## Version 1.7.0 - 2015-08-20
+### Added
+
+*   Add Mongoid support for referenced/embedded relations. PR
+    [#498](https://github.com/activerecord-hackery/ransack/pull/498).
+    TODO: Missing spec coverage! Add documentation!
+
+    *Penn Su*
+
+*   Add German i18n locale file (`de.yml`). PR
+    [#537](https://github.com/activerecord-hackery/ransack/pull/537).
+
+    *Philipp Weissensteiner*
+
 ### Fixed
 
 *   Fix
@@ -44,8 +206,8 @@
 
     *Andrew Vit*
 
-*   Fix RSpec `its` method deprecation warning: 'Use of rspec-core's `its`
-    method is deprecated. Use the rspec-its gem instead
+*   Fix RSpec `its` method deprecation warning: "Use of rspec-core's its
+    method is deprecated. Use the rspec-its gem instead"
     ([c09aa17](https://github.com/activerecord-hackery/ransack/commit/c09aa17)).
 
 *   Fix deprecated RSpec syntax in `grouping_spec.rb`
@@ -53,24 +215,11 @@
 
     *Jon Atack*
 
-### Added
-
-*   Add Mongoid support for referenced/embedded relations. PR
-    [#498](https://github.com/activerecord-hackery/ransack/pull/498).
-    TODO: Missing spec coverage! Add documentation!
-
-    *Penn Su*
-
-*   Add German locale file (de.yml). PR
-    [#537](https://github.com/activerecord-hackery/ransack/pull/537).
-
-    *Philipp Weissensteiner*
-
 ### Changed
 
 *   Upgrade gemspec dependencies: MySQL2 from '0.3.14' to '0.3.18', and RSpec
     from '~> 2.14.0' to '~> 2' which loads 2.99
-    ([000cd2](https://github.com/activerecord-hackery/ransack/commit/000cd2)).
+    ([000cd22](https://github.com/activerecord-hackery/ransack/commit/000cd22)).
 
 *   Upgrade spec suite to RSpec 3 `expect` syntax backward compatible with
     RSpec 2.9
@@ -89,10 +238,12 @@
 
 
 ## Version 1.6.6 - 2015-04-05
-### Changed
+### Added
 
-*   Upgrade Polyamorous dependency to version 1.2.0, which uses `Module#prepend`
-    instead of `alias_method` for hooking into Active Record (with Ruby 2.x).
+*   Add the Ruby version to the the header message that shows the database,
+    Active Record and Arel versions when running tests.
+
+*   Add Code Climate analysis.
 
     *Jon Atack*
 
@@ -117,12 +268,10 @@
 
     *Jon Atack*
 
-### Added
-
-*   Add the Ruby version to the the header message that shows the database,
-    Active Record and Arel versions when running tests.
+### Changed
 
-*   Add Code Climate analysis.
+*   Upgrade Polyamorous dependency to version 1.2.0, which uses `Module#prepend`
+    instead of `alias_method` for hooking into Active Record (with Ruby 2.x).
 
     *Jon Atack*
 
@@ -239,7 +388,7 @@
 
     *Josh Kovach*
 
-*   Add an sort_link option to not display sort direction arrows
+*   Add an sort_link option to not display sort order indicator arrows
     ([PR #473](https://github.com/activerecord-hackery/ransack/pull/473)).
 
     *Fred Bergman*
@@ -427,7 +576,7 @@
 
     *Pedro Chambino*
 
-*   Add `ro.yml` Romanian translation file.
+*   Add Romanian i18n locale file (`ro.yml`).
 
     *Andreas Philippi*
 

data/CONTRIBUTING.md

@@ -5,15 +5,15 @@ effective for everyone involved!
 
 Ransack is an open source project and we encourage contributions.
 
+Please do not use the issue tracker for personal support requests. Stack
+Overflow is a better place for that where a wider community can help you!
+
 ## Filing an issue
 
 Good issue reports are extremely helpful!  Please only open an issue if a bug
 is caused by Ransack, is new (has not already been reported), and can be
 reproduced from the information you provide.
 
-Please do not use the issue tracker personal support requests. Stack Overflow
-is a better place for that where a wider community can help you.
-
 Steps:
 
 1. **Use the GitHub issue search** — check if the issue has already been
@@ -22,18 +22,25 @@ Steps:
 2. **Check if the issue has been fixed** — try to reproduce it using the
    `master` branch in the repository.
 
-3. **Isolate and report the problem** — ideally create a reduced test
-   case.
+3. **Isolate the real problem** — make sure the issue is really a bug in
+   Ransack and not in your code or another gem.
+
+4. **Report the issue** by providing the link to a self-contained
+   gist like [this](https://gist.github.com/jonatack/63048bc5062a84ba9e09) or
+   [this](https://gist.github.com/jonatack/5df41a0edb53b7bad989). Please use
+   these code examples as a bug-report template for your Ransack issue!
 
-When filing an issue, please provide these details:
+If you do not provide a self-contained gist and would like your issue to be reviewed, do provide at a minimum:
 
-* A comprehensive list of steps to reproduce the issue :smiley: or even better, a failing spec!
-* The versions of Ruby, Rails, Ransack and your operating system and database.
+* A comprehensive list of steps to reproduce the issue, or even better, a
+  passing/failing test spec.
+* Whether you are using Ransack through another gem like ActiveAdmin,
+  SimpleForm, etc.
+* The versions of Ruby, Rails, Ransack and the database.
 * Any relevant stack traces ("Full trace" preferred).
 
-Any issue that is open for 14 days without actionable information or activity
-will be marked as "stalled" and then closed. Stalled issues can be re-opened
-if actionable information to reproduce the issue is provided.
+Issues filed without the above information or that remain open without activity
+for 14 days will be closed. They can be re-opened if actionable information to reproduce the issue is provided.
 
 ## Pull requests
 
@@ -80,20 +87,24 @@ Here's a quick guide:
 8. Update the Change Log. If you are adding new functionality, document it in
    the README.
 
-9. Commit your changes (`git commit -am 'Add feature/fix bug/improve docs'`).
+9. Make sure git knows your name and email address in your `~/.gitconfig` file:
+
+        $ git config --global user.name "Your Name"
+        $ git config --global user.email "contributor@example.com"
+
+10. Commit your changes (`git commit -am 'Add feature/fix bug/improve docs'`).
+   If your pull request only contains documentation changes, please remember
+   to add `[skip ci]` to the beginning of your commit message so the Travis
+   test suite doesn't :runner: needlessly.
 
-10. If necessary, rebase your commits into logical chunks, without errors. To
+11. If necessary, rebase your commits into logical chunks, without errors. To
    interactively rebase and cherry-pick from, say, the last 10 commits:
    `git rebase -i HEAD~10`, then `git push -f`.
 
-11. Push the branch up to your fork on Github
-   (`git push origin my-new-feature`) and from Github submit a pull request to
+12. Push the branch up to your fork on GitHub
+   (`git push origin my-new-feature`) and from GitHub submit a pull request to
    Ransack's `master` branch.
 
-12. If your pull request only contains documentation changes, please remember
-   to add `[skip ci]` to the beginning of your commit message so the Travis
-   test suite doesn't :runner: needlessly.
-
 At this point you're waiting on us. We like to at least comment on, if not
 accept, pull requests within three business days (and, typically, one business
 day). We may suggest some changes or improvements or alternatives.

data/Gemfile

@@ -3,13 +3,14 @@ gemspec
 
 gem 'rake'
 
-rails = ENV['RAILS'] || '4-2-stable'
+rails = ENV['RAILS'] || '5-0-stable'
 
 if rails == 'master'
+  gem 'rack', github: 'rack/rack'
   gem 'arel', github: 'rails/arel'
   gem 'polyamorous', github: 'activerecord-hackery/polyamorous'
 else
-  gem 'polyamorous', '~> 1.2'
+  gem 'polyamorous', '~> 1.3'
 end
 
 gem 'pry'
@@ -41,10 +42,14 @@ else
   end
 end
 
-if ENV['DB'] =~ /mongodb/
+if ENV['DB'] =~ /mongoid4/
   gem 'mongoid', '~> 4.0.0', require: false
 end
 
+if ENV['DB'] =~ /mongoid5/
+  gem 'mongoid', '~> 5.0.0', require: false
+end
+
 # Removed from Ruby 2.2 but needed for testing Rails 3.x.
 group :test do
   gem 'test-unit', '~> 3.0' if RUBY_VERSION >= '2.2'