randsum 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1ff083ad934444c3cbc349a1210ff7ac7b3e87f
-  data.tar.gz: f01aa2b396ed625cd19029a96dc97a7c2f9603a2
+  metadata.gz: b40795441292e1f022b9964709ae9b1a1440b8d2
+  data.tar.gz: e2403d1ed04af388474c6fb24ee69b1065bc2848
 SHA512:
-  metadata.gz: d6931b687ec9a810ce76d14476a5b5a41f9c8c9fd50f775f9d0f7790a024dd022d7be99ad239e8b196f51ec4614d42b84a1914992d4a87e397eed85774f3a57c
-  data.tar.gz: 69f74d416ff979ed8f5347846d5b6e8b3080bb2dfb4afa48419bb673e947ea044a9ed3a653ac02ddedf410558a0d190fb464122b86965f5b7611e0f868962a6f
+  metadata.gz: 55770ea57631fe9e4d1297b78b824d45067b5b1b52113201491cf72f901e03bb5ce5096be5dd90b5650556fc1fd140a5208bb2e14e65f29d912aa8d75dc4230e
+  data.tar.gz: 6f400f76cb73c5ce4cbc651941646f9cd66dc86c2afeb697e5b95602263c541394d81ce95cc3e6ce1faf4432d49e6c6a264a8e171cbe3dfad7153d198188760a

data/README.md

@@ -84,9 +84,9 @@ That's pretty neat, right?
 Snakeyes. Rough.
 
 
-### Making use of the rolls: the `RollReport`
+### Making use of the rolls: the `Roll`
 
-`Die#roll` returns a `RollReport` object, which can teach you a lot about your rolls (but not, tragically, how to roll better.)
+`Die#roll` returns a `Roll` object, which can teach you a lot about your rolls (but not, tragically, how to roll better.)
 
 ```
 > report = Randsum::D20.roll 5
@@ -128,11 +128,11 @@ And if you don't like that roll (hey we get it) you can use `#die` to get anothe
 #=> You rolled 1 D20, and got 17. (Rolls: [17])
 ```
 
-#### Manipulating `RollReport`s
+#### Manipulating `Roll`s
 
-Roll results can be further manipulated after their original creation. To facilitate popular use-cases for Dice rolling, `RollReport`s also include public `#drop_lowest` and `#drop_highest`, and `#drop` methods.
+Roll results can be further manipulated after their original creation. To facilitate popular use-cases for Dice rolling, `Roll`s also include public `#drop_lowest` and `#drop_highest`, and `#drop` methods.
 
-`#drop_lowest` returns a new `RollReport` without the lowest numerical die roll.
+`#drop_lowest` returns a new `Roll` without the lowest numerical die roll.
 
 ```
 > report = Randsum::D6.roll 4
@@ -163,7 +163,7 @@ Both `#drop_lowest` and `#drop_highest` can also take an optional integer argume
 ### Why build this?
 [Rollr](http://github.com/alxjrvs/rollr) was one of the first things I ever built. I think it's funny, and I'm not sure why.
 
-I recently had the privilege of attending Sandi Metz' POODNyc workshop, which involved a continual practice of refactoring the same "simple" problem over and over again.  I liked revisitng Rollr through the years, and Randsum reflects an attempt to use small refactoring techniques to continue to mull over the "simple" problem of random numbers.
+I liked revisiting Rollr through the years, and Randsum reflects my current take on the problem. I renamed it because at a certain point you realize you just typed `Rollr::Roll.new(rolls:).roll!`and you're just dead inside.
 
 ## Development
 
@@ -173,7 +173,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/alxjrvs/randsum. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/RANDSUM/randsum. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 
 ## License

data/lib/randsum/die.rb

@@ -11,8 +11,9 @@ module Randsum
     end
 
     def roll(quantity = 1)
-      Randsum::RollReport.new(
-        roll_for(quantity)
+      Randsum::Roll.new(
+        quantity: quantity,
+        die: self
       )
     end
 
@@ -23,15 +24,5 @@ module Randsum
     def simple_roll
       randomizer.random_number(sides).to_i + ZERO_INDEX_FIXER
     end
-
-    private
-
-    def roll_for(quantity)
-        Randsum::Roll.new(
-          quantity: quantity,
-          die: self
-        )
-    end
-
   end
 end

data/lib/randsum/roll.rb

@@ -1,6 +1,11 @@
+require 'pry'
 module Randsum
   class Roll
-    attr_reader :die, :quantity, :sides, :result
+    attr_reader :die, :quantity, :sides, :result, :total
+
+    alias_method :length, :quantity
+    alias_method :count, :quantity
+    alias_method :rolls, :result
 
     def initialize(die:, quantity:, result: nil)
       @die = die
@@ -10,8 +15,14 @@ module Randsum
     end
 
     def to_s
-      "Rolls: #{result}"
+      "You rolled #{count} #{die}, and got #{total}. (Rolls: #{result})"
+    end
+    alias_method :inspect, :to_s
+
+    def total
+      @total ||= result.inject(:+)
     end
+    alias_method :to_i, :total
 
     def drop(quantity:,extremity:)
       return new_roll_with(
@@ -23,7 +34,16 @@ module Randsum
       )
     end
 
+    def drop_lowest(quantity = 1)
+      drop(quantity: quantity, extremity: :lowest)
+    end
+
+    def drop_highest(quantity = 1)
+      drop(quantity: quantity, extremity: :highest)
+    end
+
     private
+
     def new_roll_with(result: nil)
       return Roll.new(
         die: die,

data/lib/randsum/version.rb

@@ -1,3 +1,3 @@
 module Randsum
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/lib/randsum.rb

@@ -6,10 +6,8 @@ require "randsum/filters/droppers/high_dropper"
 require "randsum/filters/droppers/low_dropper"
 require "randsum/roll"
 require "randsum/die"
-require "randsum/roll_report"
 
 module Randsum
-
   D2 = Die.new(2)
   D3 = Die.new(3)
   D4 = Die.new(4)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: randsum
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Alex Jarvis
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-04 00:00:00.000000000 Z
+date: 2016-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -97,7 +97,6 @@ files:
 - lib/randsum/filters/filter.rb
 - lib/randsum/metadata.rb
 - lib/randsum/roll.rb
-- lib/randsum/roll_report.rb
 - lib/randsum/version.rb
 - randsum.gemspec
 homepage: http://api.randsum.io

data/lib/randsum/roll_report.rb

@@ -1,61 +0,0 @@
-module Randsum
-  class RollReport
-
-    def initialize(roll)
-      @roll = roll
-    end
-
-    def inspect
-      to_s
-    end
-
-    def to_s
-      "You rolled #{quantity} #{die}, and got #{total}. (#{roll})"
-    end
-
-    def to_i
-      total
-    end
-
-    def sides
-      die.sides
-    end
-
-    def die
-      roll.die
-    end
-
-    def rolls
-      @_rolls ||= roll.result
-    end
-
-    def total
-      @_total ||= rolls.inject(:+)
-    end
-
-    def quantity
-      @_quantity ||= rolls.count
-    end
-
-    def drop(quantity:, extremity:)
-      return RollReport.new(
-        roll.drop(quantity: quantity, extremity: extremity)
-      )
-    end
-
-    def drop_lowest(quantity = 1)
-      return RollReport.new(
-        roll.drop(quantity: quantity, extremity: :lowest)
-      )
-    end
-
-    def drop_highest(quantity = 1)
-      return RollReport.new(
-        roll.drop(quantity: quantity, extremity: :highest)
-      )
-    end
-
-    private
-    attr_reader :roll
-  end
-end