random_point_generator 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 921bc3b41e1b1cf8ef722375ac80bf6f8435c0c1
-  data.tar.gz: 81101d0087d66b407aeb5db865bf40c20aad9267
+  metadata.gz: 2b9067450b27cb5fc90247a50bba38e6abf544cf
+  data.tar.gz: b359ed1859fc41c874fc0ba7745406ed0303bfcc
 SHA512:
-  metadata.gz: 898b5efd7a4b5b4fc4edd777c1d262ce8a6046db9993d3399aeb64c78d01c8e0e6ab46ddc416093e2657a8676998b6c8ec3591abfb528ffbaae3ed12aef56422
-  data.tar.gz: a5b3b1423168b1acfe99aaeb777712acaa0706dc53dc1bdde873e726307419a85771d4841e3f9d28bddefde31b035a5ae18dad5877dea056fd73ef4fd733d8b8
+  metadata.gz: 426974b18e96b759bdc3fc3f85528ce94eb208f83cbf1c719ca211ef0d85b131461d4710a9dcb5c2ca8ca9114b4bb5e005762832fc87445dd2210fdb35d58045
+  data.tar.gz: f5c8236a84c7e8bca633c5607df42238be3160281d6a810bb79a37a4f86de69d085894fcd5d7d1c9e0923ff0da09208db7ce5db1a5a6d107873d637381a91249

data/lib/random_point_generator.rb

@@ -1,5 +1,8 @@
 class RandomPointGenerator
-  def initialize(sw_point = [-90.0, -180.0], ne_point = [90.0, 180.0])
+  def initialize(sw_point = nil, ne_point = nil)
+    sw_point ||= [-90.0, -180.0]
+    ne_point ||= [90.0, 180.0]
+
     @sw_point = sw_point
     @ne_point = ne_point
   end

data/spec/random_point_generator_spec.rb

@@ -1,6 +1,24 @@
 require 'random_point_generator'
 
 describe RandomPointGenerator do
+  shared_examples "generates a valid, random point" do
+    it "generates a point" do
+      expect(subject).to be_an Array
+    end
+
+    it "gives a valid, random latitude" do
+      lat = random_point[0]
+      expect(lat).to be >= expected_lower_lat_bound
+      expect(lat).to be <= expected_upper_lat_bound
+    end
+
+    it "gives a valid, random longitude" do
+      lng = random_point[1]
+      expect(lng).to be >= expected_lower_lng_bound
+      expect(lng).to be <= expected_upper_lng_bound
+    end
+  end
+
   describe "with no bounding box" do
     let(:generator) { described_class.new }
     subject         { generator }
@@ -9,59 +27,96 @@ describe RandomPointGenerator do
       let(:random_point) { generator.random_point }
       subject            { random_point }
 
-      it "generates a point" do
-        expect(subject).to be_an Array
-      end
+      let(:expected_lower_lat_bound) { -90.0 }
+      let(:expected_upper_lat_bound) { 90.0 }
 
-      it "gives a valid, random latitude" do
-        lat = random_point[0]
-        expect(lat).to be >= -90.0
-        expect(lat).to be <= 90.0
-      end
+      let(:expected_lower_lng_bound) { -180.0 }
+      let(:expected_upper_lng_bound) { 180.0 }
 
-      it "gives a valid, random longitude" do
-        lng = random_point[1]
-        expect(lng).to be >= -180.0
-        expect(lng).to be <= 180.0
-      end
+      include_examples "generates a valid, random point"
     end
   end
 
   describe "with a bounding box" do
-    let(:sw_lat) { 5.0 }
-    let(:sw_lng) { 50.0 }
+    describe "with both sw_point and ne_point" do
+      let(:sw_lat) { 5.0 }
+      let(:sw_lng) { 50.0 }
 
-    let(:sw_point) { [sw_lat, sw_lng] }
+      let(:sw_point) { [sw_lat, sw_lng] }
 
-    let(:ne_lat) { 53.4 }
-    let(:ne_lng) { 54.87 }
+      let(:ne_lat) { 53.4 }
+      let(:ne_lng) { 54.87 }
 
-    let(:ne_point) { [ne_lat, ne_lng] }
+      let(:ne_point) { [ne_lat, ne_lng] }
 
-    let(:generator) { described_class.new(sw_point, ne_point) }
-    subject         { generator }
+      let(:generator) { described_class.new(sw_point, ne_point) }
+      subject         { generator }
 
-    describe "#random_point" do
-      let(:random_point) { generator.random_point }
-      subject            { random_point }
+      describe "#random_point" do
+        let(:random_point) { generator.random_point }
+        subject            { random_point }
 
-      it "generates a point" do
-        expect(subject).to be_an Array
-      end
+        let(:expected_lower_lat_bound) { sw_lat }
+        let(:expected_upper_lat_bound) { ne_lat }
+
+        let(:expected_lower_lng_bound) { sw_lng }
+        let(:expected_upper_lng_bound) { ne_lng }
 
-      it "gives a valid, random latitude within the bounding box" do
-        lat = random_point[0]
-        expect(lat).to be >= sw_lat
-        expect(lat).to be <= ne_lat
+        include_examples "generates a valid, random point"
       end
+    end
+
+    describe "with valid sw_point and nil ne_point" do
+      let(:sw_lat) { 5.0 }
+      let(:sw_lng) { 50.0 }
 
-      it "gives a valid, random logitude within the bounding box" do
-        lng = random_point[1]
-        expect(lng).to be >= sw_lng
-        expect(lng).to be <= ne_lng
+      let(:sw_point) { [sw_lat, sw_lng] }
+
+
+      let(:ne_point) { nil }
+
+      let(:generator) { described_class.new(sw_point, ne_point) }
+      subject         { generator }
+
+      describe "#random_point" do
+        let(:random_point) { generator.random_point }
+        subject            { random_point }
+
+        let(:expected_lower_lat_bound) { sw_lat }
+        let(:expected_upper_lat_bound) { 90.0 }
+
+        let(:expected_lower_lng_bound) { sw_lng }
+        let(:expected_upper_lng_bound) { 180.0 }
+
+        include_examples "generates a valid, random point"
       end
     end
 
+    describe "with nil sw_point and nil ne_point" do
+
+      let(:sw_point) { nil }
+
+      let(:ne_lat) { 53.4 }
+      let(:ne_lng) { 54.87 }
+
+      let(:ne_point) { [ne_lat, ne_lng] }
+
+      let(:generator) { described_class.new(sw_point, ne_point) }
+      subject         { generator }
+
+      describe "#random_point" do
+        let(:random_point) { generator.random_point }
+        subject            { random_point }
+
+        let(:expected_lower_lat_bound) { -90.0 }
+        let(:expected_upper_lat_bound) { ne_lat }
+
+        let(:expected_lower_lng_bound) { -180.0 }
+        let(:expected_upper_lng_bound) { ne_lng }
+
+        include_examples "generates a valid, random point"
+      end
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: random_point_generator
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Kyle Tolle
@@ -31,7 +31,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 3.0.0
 description: 
-email: kyle@nullsix.com
+email:
+- kyle@nullsix.com
 executables: []
 extensions: []
 extra_rdoc_files: []