rambulance 0.6.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 56cafb27235f043f1b05600421ba5a01671aa3cd10d9f56beea8b29554e158a9
-  data.tar.gz: 78329235f2a74d2250f33cf80ab32c1312a507808a056a74a1b12c8fe956cdd3
+  metadata.gz: 4e7a19e6d38b6d44ff7cfe3cc0589f0bf8575f1e6750bf73df35096822e62d5a
+  data.tar.gz: cf524a57dc3237fc8a182256986fef5178d2efd7d262f85be0b18f8829522d6e
 SHA512:
-  metadata.gz: 6d64689dae226f3d81305cf569f8de5ea5d90a261de6dd305441dfb231b5565f3821681de0d88895019953d2db6b50829b3c2dde3dcd8c919b4b430f844d3cff
-  data.tar.gz: 3783088dae915e9ac27897858dedb939017fc82d4bda229db4d10ea629bad01e1d14cdfef195e1c04877bee893fda0ae4e258df507d4f0f7552b5c992b05dba3
+  metadata.gz: 8a2dd2e048ccde58d0f8f17d47d0d8f4722a7c83e57062a600c4a2c4d4455823b2d73c854ef77fa7e976db24a888f959b5d3068d059822d73fa428404f2f425e
+  data.tar.gz: 14753c604c06c1a6412372cd63066a5aa8af55c5c5c0fba8ef3d7764228aa8cb9d735748eb3fc023570d7c4633482f6e2ad38746a36087a781fe74a2f3d16b28

data/.travis.yml

@@ -1,94 +1,51 @@
 language: ruby
-script:   bundle exec rake
 cache:    bundler
 sudo:     false
 
+script:
+  - bundle exec rake
+
 before_install:
   - gem update --system
-  - gem pristine bundler
+  - gem install bundler
 
 rvm:
-  - 2.0.0
-  - 2.1
-  - 2.2.9
-  - 2.3.6
-  - 2.4.3
-  - 2.5.0
+  - 2.3.8
+  - 2.4.6
+  - 2.5.5
+  - 2.6.3
   - ruby-head
-  - jruby-9.1.16.0
+  - jruby-9.2.7.0
   - jruby-head
 
 gemfile:
-  - gemfiles/rails_32.gemfile
-  - gemfiles/rails_40.gemfile
-  - gemfiles/rails_41.gemfile
   - gemfiles/rails_42.gemfile
   - gemfiles/rails_50.gemfile
   - gemfiles/rails_51.gemfile
   - gemfiles/rails_52.gemfile
+  - gemfiles/rails_60.gemfile
   - gemfiles/rails_edge.gemfile
 
 matrix:
   exclude:
-    - rvm: 2.0.0
-      gemfile: gemfiles/rails_50.gemfile
-    - rvm: 2.0.0
-      gemfile: gemfiles/rails_51.gemfile
-    - rvm: 2.0.0
-      gemfile: gemfiles/rails_52.gemfile
-    - rvm: 2.0.0
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails_60.gemfile
+    - rvm: 2.3.8
       gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.1
-      gemfile: gemfiles/rails_50.gemfile
-    - rvm: 2.1
-      gemfile: gemfiles/rails_51.gemfile
-    - rvm: 2.1
-      gemfile: gemfiles/rails_52.gemfile
-    - rvm: 2.1
-      gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.2.9
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: 2.2.9
-      gemfile: gemfiles/rails_51.gemfile
-    - rvm: 2.2.9
+    - rvm: 2.4.6
+      gemfile: gemfiles/rails_60.gemfile
+    - rvm: 2.4.6
       gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.3.6
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: 2.3.6
-      gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.4.3
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: 2.4.3
-      gemfile: gemfiles/rails_40.gemfile
-    - rvm: 2.4.3
-      gemfile: gemfiles/rails_41.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_40.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_41.gemfile
+    - rvm: 2.6.3
+      gemfile: gemfiles/rails_42.gemfile
     - rvm: ruby-head
-      gemfile: gemfiles/rails_32.gemfile
+      gemfile: gemfiles/rails_42.gemfile
     - rvm: ruby-head
-      gemfile: gemfiles/rails_40.gemfile
+      gemfile: gemfiles/rails_50.gemfile
     - rvm: ruby-head
-      gemfile: gemfiles/rails_41.gemfile
-    - rvm: jruby-9.1.16.0
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: jruby-9.1.16.0
-      gemfile: gemfiles/rails_40.gemfile
-    - rvm: jruby-9.1.16.0
-      gemfile: gemfiles/rails_41.gemfile
-    - rvm: jruby-head
-      gemfile: gemfiles/rails_32.gemfile
-    - rvm: jruby-head
-      gemfile: gemfiles/rails_40.gemfile
-    - rvm: jruby-head
-      gemfile: gemfiles/rails_41.gemfile
+      gemfile: gemfiles/rails_51.gemfile
   allow_failures:
     - rvm: ruby-head
-    - rvm: jruby-9.1.16.0
+    - rvm: jruby-9.2.7.0
     - rvm: jruby-head
     - gemfile: gemfiles/rails_edge.gemfile
-    - gemfile: gemfiles/rails_32.gem

data/Appraisals

@@ -43,9 +43,15 @@ appraise "rails_51" do
 end
 
 appraise "rails_52" do
-  gem "activesupport", "~> 5.2.0.rc1"
-  gem "actionpack", "~> 5.2.0.rc1"
-  gem "railties", "~> 5.2.0.rc1"
+  gem "activesupport", "~> 5.2.0"
+  gem "actionpack", "~> 5.2.0"
+  gem "railties", "~> 5.2.0"
+end
+
+appraise "rails_60" do
+  gem "activesupport", "~> 6.0.0.rc1"
+  gem "actionpack", "~> 6.0.0.rc1"
+  gem "railties", "~> 6.0.0.rc1"
 end
 
 appraise "rails_edge" do

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [v0.6.0](https://github.com/yuki24/rambulance/tree/v0.6.0)
+
+_<sup>released at 2018-03-08 18:36:16 UTC</sup>_
+
+#### New features
+
+- Add support for Rails 5.2
+- Add a test helper method `#with_exceptions_app` for easier testing ([<tt>f5c16b9</tt>](https://github.com/yuki24/rambulance/commit/f5c16b90ecf5eb4903faa30d760bf5863441e9c5), [#27](https://github.com/yuki24/rambulance/pull/27), [@kbaba1001](https://github.com/kbaba1001))
+
+#### Bug fixes
+
+- Fixed a bug where an `ActionController::UnknownFormat` error could cause a number of issues ([<tt>1b824e6</tt>](https://github.com/yuki24/rambulance/commit/1b824e6c170479ed90e24df1680dd2dec7c98160), [#41](https://github.com/yuki24/rambulance/issues/41), [#42](https://github.com/yuki24/rambulance/pull/42), [@willnet](https://github.com/willnet), [@joker-777](https://github.com/joker-777))
+- Fixed a bug where the methods on the `ExceptionApp` weren't easily inspectable ([<tt>6b4c834</tt>](https://github.com/yuki24/rambulance/commit/6b4c834bb0b8e81f619d9f598310ce68f4f9c66b))
+
 ## [v0.5.0](https://github.com/yuki24/rambulance/tree/v0.5.0)
 
 _<sup>released at 2018-01-02 21:36:02 UTC</sup>_
@@ -10,7 +24,7 @@ _<sup>released at 2018-01-02 21:36:02 UTC</sup>_
 #### Breaking changes & deprecations
 
 - Drop support for Ruby 1.9.3
-- Drop support for Haml and Slim templates
+- Drop support for generating Haml and Slim templates on `rails g rambulance:install`
 
 #### Bug fixes
 

data/Dangerfile

@@ -0,0 +1,13 @@
+# Sometimes it's a README fix, or something like that - which isn't relevant for
+# including in a project's CHANGELOG for example
+declared_trivial = github.pr_title.include? "#trivial"
+
+# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
+warn("PR is classed as Work in Progress") if github.pr_title.include? "WIP"
+
+# Warn when there is a big PR
+warn("Big PR") if git.lines_of_code > 500
+
+# Don't let testing shortcuts get into master by accident
+fail("fdescribe left in tests") if `grep -r fdescribe test/ `.length > 1
+fail("fit left in tests") if `grep -r fit test/ `.length > 1

data/README.md

@@ -94,7 +94,7 @@ $ rails g rambulance:exceptions_app
 
 It'll generate your own custom exceptions app. You can use whatever techniques you use in controllers like `before_filter` and `flash[:notice] = "message..."` since it's a grandchild of `ActionController::Base`!
 
-**Keep in mind that you shouldn't do too many things because something already went wrong with your application!**
+**Note that customizing the exceptions app is strongly discouraged as there would be no guard against bugs that occur in the exceptions app.**
 
 ## Testing
 
@@ -132,8 +132,8 @@ Note that testing error pages is not encouraged in Rails as it leads to overuse
 
 ## Supported Versions
 
-* Ruby 2.0.0, 2.1, 2.2, 2.3, 2,4, 2,5, trunk,  JRuby 9.1.16.0, and JRuby head
-* Rails 3.2, 4.0, 4.1, 4.2, 5.0, 5,1, 5,2 and edge
+* Ruby 2.3, 2,4, 2,5, trunk, JRuby 9.1.16.0, and JRuby head
+* Rails 4.2, 5.0, 5,1, 5,2 and edge
 
 Rambulance doesn't work with Rails 3.1 and below since they don't provide a way to use a custom exceptions app.
 

data/gemfiles/rails_52.gemfile

@@ -2,8 +2,8 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "~> 5.2.0.rc1"
-gem "actionpack", "~> 5.2.0.rc1"
-gem "railties", "~> 5.2.0.rc1"
+gem "activesupport", "~> 5.2.0"
+gem "actionpack", "~> 5.2.0"
+gem "railties", "~> 5.2.0"
 
 gemspec path: "../"

data/gemfiles/rails_60.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activesupport", "~> 6.0.0.rc1"
+gem "actionpack", "~> 6.0.0.rc1"
+gem "railties", "~> 6.0.0.rc1"
+
+gemspec path: "../"

data/lib/generators/rambulance/templates/rambulance.rb

@@ -22,12 +22,12 @@ Rambulance.setup do |config|
   }
 
   # The template name for the layout of the error pages. The default value is
-  # 'error'. For exmaple, if this value is set to "error_page", Rambulance uses
+  # 'error'. For example, if this value is set to "error_page", Rambulance uses
   # 'app/views/layout/error_page.html.erb' as a layout for all the error pages.
   config.layout_name = "error"
 
   # The directry name to organize error page templates. The default value is
-  # 'errors'. For exmaple, if this value is set to "error_pages", Rambulance
+  # 'errors'. For example, if this value is set to "error_pages", Rambulance
   # uses e.g. 'app/views/error_pages/not_found.html.erb'.
   config.view_path = "errors"
 

data/lib/rambulance/exceptions_app.rb

@@ -12,11 +12,9 @@ module Rambulance
   class ExceptionsApp < ActionController::Base
     layout :layout_name
 
-    BAD_REQUEST_EXCEPTION = begin
-                              ActionController::BadRequest
-                            rescue NameError
-                              TypeError # Rails 3.2 doesn't know about ActionController::BadRequest
-                            end
+    if self.respond_to?(:skip_forgery_protection)
+      skip_forgery_protection
+    end
 
     def self.call(env)
       exception       = env["action_dispatch.exception"]
@@ -33,7 +31,7 @@ module Rambulance
 
     def self.local_prefixes
       [Rambulance.view_path]
-    end if ActionPack::VERSION::STRING >= "4.2.0"
+    end
 
     ERROR_HTTP_STATUSES.values.each do |status_in_words|
       eval <<-ACTION, nil, __FILE__, __LINE__ + 1
@@ -57,23 +55,18 @@ module Rambulance
     def process_action(*)
       begin
         request.GET
-      rescue BAD_REQUEST_EXCEPTION
+      rescue ActionController::BadRequest
         request.env["MALFORMED_QUERY_STRING"], request.env["QUERY_STRING"] = request.env["QUERY_STRING"], ""
       end
 
       begin
         request.POST
-      rescue BAD_REQUEST_EXCEPTION, ArgumentError
+      rescue ActionController::BadRequest
         request.env["MALFORMED_BODY"], request.env["rack.input"] = request.env["rack.input"], StringIO.new
       end
 
       # The #formats method needs to be called after the sanitization above.
-      if request.respond_to?(:formats)
-        request.formats << Mime::Type.lookup('text/plain')
-      elsif request.respond_to?(:format) && status == 406
-        # TODO: Remove this conditional when dropping support for Rails 3.2
-        request.format = Mime::Type.lookup('text/plain')
-      end
+      request.formats << Mime::Type.lookup('text/plain')
 
       super
     end

data/lib/rambulance/railtie.rb

@@ -1,15 +1,18 @@
 module Rambulance
   class Railtie < Rails::Railtie
     initializer 'rambulance', after: :prepend_helpers_path do |app|
-      require "rambulance/exceptions_app"
+      ActiveSupport.on_load(:action_controller) do
+        require "rambulance/exceptions_app"
+      end
 
-      app.config.exceptions_app =
+      app.config.exceptions_app = ->(env) {
         begin
           ActiveSupport::Dependencies.load_missing_constant(Object, :ExceptionsApp)
-          ->(env){ ::ExceptionsApp.call(env) }
+          ::ExceptionsApp.call(env)
         rescue NameError
-          ::Rambulance::ExceptionsApp
+          ::Rambulance::ExceptionsApp.call(env)
         end
+      }
 
       ActiveSupport.on_load(:after_initialize) do
         Rails.application.routes.append do

data/lib/rambulance/version.rb

@@ -1,3 +1,3 @@
 module Rambulance
-  VERSION = "0.6.0"
+  VERSION = "1.0.0"
 end

data/test/fake_app/rails_app.rb

@@ -8,6 +8,10 @@ class TestApp < Rails::Application
   config.eager_load = false
   config.root = File.dirname(__FILE__)
   config.autoload_paths += ["#{config.root}/lib"] if ENV["CUSTOM_EXCEPTIONS_APP"]
+
+  if Rails::VERSION::STRING >= "5.2"
+    config.action_controller.default_protect_from_forgery = true
+  end
 end
 Rails.backtrace_cleaner.remove_silencers!
 Rails.application.initialize!
@@ -15,7 +19,7 @@ Rails.application.initialize!
 # routes
 Rails.application.routes.draw do
   resources :users
-  resources :projects, only: :index
+  resources :projects, only: [:index, :create]
 end
 
 # custom exception class
@@ -76,11 +80,16 @@ class UsersController < ApplicationController
   end
 end
 class ProjectsController < ApplicationController
+  if self.respond_to?(:skip_forgery_protection)
+    skip_forgery_protection
+  end
+
   if self.respond_to? :skip_before_action
-    skip_before_action :bad_filter
+    skip_before_action :bad_filter, except: :create
   else
-    skip_filter :bad_filter
+    skip_filter :bad_filter, except: :create
   end
 
   def index; end
+  def create; end
 end

data/test/requests/error_json_test.rb

@@ -29,6 +29,13 @@ class ErrorJsonTest < ActionDispatch::IntegrationTest
     assert_equal "Page not found", json_response['message']
   end
 
+  test 'renders an error page on a POST request' do
+    post '/projects.json'
+
+    assert_equal 500, response.status
+    assert_equal "Something went wrong", json_response['message']
+  end
+
   private
 
   def without_layouts

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rambulance
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-08 00:00:00.000000000 Z
+date: 2019-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -148,6 +148,7 @@ files:
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
+- Dangerfile
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -161,6 +162,7 @@ files:
 - gemfiles/rails_50.gemfile
 - gemfiles/rails_51.gemfile
 - gemfiles/rails_52.gemfile
+- gemfiles/rails_60.gemfile
 - gemfiles/rails_edge.gemfile
 - lib/generators/rambulance/exceptions_app_generator.rb
 - lib/generators/rambulance/install_generator.rb
@@ -220,8 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Simple and safe way to dynamically generate error pages