rambulance 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8cbab6ea7d38072ab9ddf4b8eaaa06fd46be2ee1
-  data.tar.gz: be1217d51c085bcc772d45deb9f64d3fdfd1415d
+  metadata.gz: e8652cd38fd09d82fef4cd8ef0d0c885aef91bc1
+  data.tar.gz: 1df7d4a06a2818bc5ac865fc4bfe64e90add5d8e
 SHA512:
-  metadata.gz: caed478d2b08c895c525200c894d8d13ae623e1e0a9853702d719b36d845ce3eec3db92bee3bc0fdbaf4fafca40758c7f16ec3e18c525ff13af1826fbfa20846
-  data.tar.gz: f73c89f22c997e5adf807bf515b76221a0ef938e0f394add8da2a3cb7deb0a61fbf2556a35349f19ae25940b01859cc10a3fd50fa41f5054831cf16427d463b8
+  metadata.gz: 551b76ece9517a8b7c4c1495363a33a16419e3a449347d28bc5037fa342a62436e60ddce380a0d675f910e32b1915a01e215671ca76eaa86c1b45be9ac9c8035
+  data.tar.gz: 9a8fec47fb990a7bfade1afffd719220e98dc826fc88382804d195f89a5c74687c017ab1596b311243055d9134026e1cf7a5a4dfdacbfb0e9964b72d9f0b1954

data/.travis.yml

@@ -1,5 +1,5 @@
 language: ruby
-script:   bundle exec rake spec:all
+script:   bundle exec rake
 cache:    bundler
 sudo:     false
 
@@ -7,29 +7,37 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1
-  - 2.2.2
+  - 2.2.5
+  - 2.3.1
   - ruby-head
   - jruby
   - jruby-head
-  - rbx-2.4.1
-  - rbx-2.5.3
 
 gemfile:
   - gemfiles/rails_32.gemfile
   - gemfiles/rails_40.gemfile
   - gemfiles/rails_41.gemfile
   - gemfiles/rails_42.gemfile
+  - gemfiles/rails_50.gemfile
   - gemfiles/rails_edge.gemfile
 
 matrix:
   exclude:
+    - rvm: 1.9.3
+      gemfile: gemfiles/rails_50.gemfile
     - rvm: 1.9.3
       gemfile: gemfiles/rails_edge.gemfile
+    - rvm: 2.0.0
+      gemfile: gemfiles/rails_50.gemfile
     - rvm: 2.0.0
       gemfile: gemfiles/rails_edge.gemfile
+    - rvm: 2.1
+      gemfile: gemfiles/rails_50.gemfile
     - rvm: 2.1
       gemfile: gemfiles/rails_edge.gemfile
-    - rvm: 2.2.2
+    - rvm: 2.2.5
+      gemfile: gemfiles/rails_32.gemfile
+    - rvm: 2.3.1
       gemfile: gemfiles/rails_32.gemfile
     - rvm: ruby-head
       gemfile: gemfiles/rails_32.gemfile
@@ -37,8 +45,6 @@ matrix:
     - rvm: ruby-head
     - rvm: jruby
     - rvm: jruby-head
-    - rvm: rbx-2.4.1
-    - rvm: rbx-2.5.3
     - gemfile: gemfiles/rails_edge.gemfile
     - gemfile: gemfiles/rails_32.gem
   fast_finish: true

data/Appraisals

@@ -2,6 +2,7 @@ appraise "rails_32" do
   gem "activesupport", "~> 3.2.0"
   gem "actionpack", "~> 3.2.0"
   gem "railties", "~> 3.2.0"
+  gem "test-unit" if RUBY_VERSION >= "2.2.0"
 end
 
 appraise "rails_40" do
@@ -25,6 +26,14 @@ appraise "rails_42" do
   gem 'minitest', '~> 5.3.4'
 end
 
+appraise "rails_50" do
+  gem "activesupport", "~> 5.0.0"
+  gem "actionpack", "~> 5.0.0"
+  gem "railties", "~> 5.0.0"
+
+  gem 'minitest', '~> 5.3.4'
+end
+
 appraise "rails_edge" do
   git 'git://github.com/rails/rails.git' do
     gem "activesupport", require: 'active_support'

data/Rakefile

@@ -1,23 +1,20 @@
-# encoding: utf-8
 require "bundler/gem_tasks"
-require "rspec/core"
-require "rspec/core/rake_task"
+require "rake/testtask"
 
-RSpec::Core::RakeTask.new(:spec)
+Rake::TestTask.new('test:default') do |task|
+  task.libs << "test"
 
-task default: "spec:all"
-
-namespace :spec do
-  desc "Run Tests with the default exceptions app"
-  task :default do
-    sh "bundle exec rake -t spec"
-  end
+  task.test_files = Dir['test/**/*_test.rb']
+  task.verbose = true
+  task.warning = true
+end
 
+namespace :test do
   desc "Run Tests with a custom exceptions app"
   task :custom do
-    sh "bundle exec rake -t spec CUSTOM_EXCEPTIONS_APP=1"
+    sh "rake test:default CUSTOM_EXCEPTIONS_APP=1"
   end
-
-  desc "Run tests with both of the default and custom apps"
-  task(:all).enhance(%w(default custom))
 end
+
+task(:test).enhance %w(test:default test:custom)
+task default: :test

data/gemfiles/rails_32.gemfile

@@ -5,6 +5,7 @@ source "https://rubygems.org"
 gem "activesupport", "~> 3.2.0"
 gem "actionpack", "~> 3.2.0"
 gem "railties", "~> 3.2.0"
-gem 'jbuilder', '2.2.13'
+gem "test-unit" if RUBY_VERSION >= "2.2.0"
+gem "mime-types", "2.99.3" if RUBY_VERSION < "2.0.0"
 
 gemspec :path => "../"

data/gemfiles/rails_40.gemfile

@@ -6,5 +6,6 @@ gem "activesupport", "~> 4.0.0"
 gem "actionpack", "~> 4.0.0"
 gem "railties", "~> 4.0.0"
 gem "test-unit" if RUBY_VERSION >= "2.2.0"
+gem "mime-types", "2.99.3" if RUBY_VERSION < "2.0.0"
 
 gemspec :path => "../"

data/gemfiles/rails_41.gemfile

@@ -5,5 +5,6 @@ source "https://rubygems.org"
 gem "activesupport", "~> 4.1.0"
 gem "actionpack", "~> 4.1.0"
 gem "railties", "~> 4.1.0"
+gem "mime-types", "2.99.3" if RUBY_VERSION < "2.0.0"
 
 gemspec :path => "../"

data/gemfiles/rails_42.gemfile

@@ -6,5 +6,6 @@ gem "activesupport", "~> 4.2.0"
 gem "actionpack", "~> 4.2.0"
 gem "railties", "~> 4.2.0"
 gem "minitest", "~> 5.3.4"
+gem "mime-types", "2.99.3" if RUBY_VERSION < "2.0.0"
 
 gemspec :path => "../"

data/gemfiles/rails_50.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activesupport", "~> 5.0.0"
+gem "actionpack", "~> 5.0.0"
+gem "railties", "~> 5.0.0"
+gem "minitest", "~> 5.3.4"
+
+gemspec :path => "../"

data/lib/generators/rambulance/templates/rambulance.rb

@@ -10,7 +10,7 @@ Rambulance.setup do |config|
 %>
   #
   # If you add exceptions in this config, Rambulance uses the pairs you defined
-  # here *in addition* to the default maddings. You can also override the default
+  # here *in addition* to the default mappings. You can also override the default
   # mappings although you don't have to in most cases.
   # If Rambulance receives an exception that is not listed here, it'll render
   # the internal server error template and return 500 as http status.

data/lib/rambulance/exceptions_app.rb

@@ -21,8 +21,8 @@ module Rambulance
       status_in_words = if exception
         ActionDispatch::ExceptionWrapper.rescue_responses[exception.class.to_s]
       else
-        env["PATH_INFO"][1..-1].to_sym.tap do |status_in_words|
-          env["PATH_INFO"] = "/#{Rack::Utils::SYMBOL_TO_STATUS_CODE[status_in_words]}"
+        env["PATH_INFO"][1..-1].to_sym.tap do |_status_in_words|
+          env["PATH_INFO"] = "/#{Rack::Utils::SYMBOL_TO_STATUS_CODE[_status_in_words]}"
         end
       end
 
@@ -41,20 +41,30 @@ module Rambulance
       ACTION
     end
 
+    def process(action, *args)
+      if action.to_s.empty?
+        action = request.env["PATH_INFO"][1..-1].to_sym.tap do |status_in_words|
+          request.env["PATH_INFO"] = "/#{Rack::Utils::SYMBOL_TO_STATUS_CODE[status_in_words]}"
+        end
+      end
+
+      super
+    end
+
     private
 
     def process_action(*)
       begin
         request.GET
       rescue BAD_REQUEST_EXCEPTION
-        env["MALFORMED_QUERY_STRING"], env["QUERY_STRING"] = env["QUERY_STRING"], ""
+        request.env["MALFORMED_QUERY_STRING"], request.env["QUERY_STRING"] = request.env["QUERY_STRING"], ""
       end
 
       super
     end
 
     def send_action(name, *args)
-      @_status          = env["PATH_INFO"][1..-1].to_i
+      @_status          = request.env["PATH_INFO"][1..-1].to_i
       @_response.status = @_status
       @_body            = { :status => @_status, :error => Rack::Utils::HTTP_STATUS_CODES.fetch(@_status.to_i, Rack::Utils::HTTP_STATUS_CODES[500]) }
 
@@ -66,7 +76,7 @@ module Rambulance
     end
 
     def exception
-      env["action_dispatch.exception"]
+      request.env["action_dispatch.exception"]
     end
 
     def error_path(status_in_words = status_in_words())

data/lib/rambulance/railtie.rb

@@ -1,6 +1,6 @@
 module Rambulance
   class Railtie < Rails::Railtie
-    initializer 'rambulance' do |app|
+    initializer 'rambulance', after: :prepend_helpers_path do |app|
       require "rambulance/exceptions_app"
 
       app.config.exceptions_app =

data/lib/rambulance/version.rb

@@ -1,3 +1,3 @@
 module Rambulance
-  VERSION = "0.3.1"
+  VERSION = "0.4.0"
 end

data/rambulance.gemspec

@@ -22,12 +22,10 @@ Gem::Specification.new do |spec|
   spec.add_dependency "actionpack"
   spec.add_dependency "railties"
 
-  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "tzinfo"
   spec.add_development_dependency "jbuilder"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "rspec-rails"
   spec.add_development_dependency "capybara"
   spec.add_development_dependency "appraisal"
 end

data/test/fake_app/app/helpers/application_helper.rb

@@ -0,0 +1,5 @@
+module ApplicationHelper
+  def forbidden
+    'Forbidden.'
+  end
+end

data/test/fake_app/app/views/errors/forbidden.html.erb

@@ -0,0 +1 @@
+<%= forbidden %>

data/test/fake_app/lib/exceptions_app.rb

@@ -0,0 +1,23 @@
+class ExceptionsApp < Rambulance::ExceptionsApp
+  def not_found; end
+
+  def internal_server_error
+    render_custom_error_page
+  end
+
+  def not_acceptable
+    render_custom_error_page
+  end
+
+  private
+    def render_custom_error_page
+      render inline: <<-BODY
+        <html>
+          <body>
+            <h1>Custom error page</h1>
+            <p>Something went wrong!</p>
+          </body>
+        </html>
+      BODY
+    end
+end

data/{spec → test}/fake_app/rails_app.rb

@@ -1,5 +1,3 @@
-require 'action_controller/railtie'
-require 'action_view/railtie'
 require 'jbuilder'
 
 # config
@@ -22,19 +20,25 @@ end
 
 # custom exception class
 class CustomException < StandardError; end
+class ForbiddenException < StandardError; end
 
 Rambulance.setup do |config|
   config.layout_name = "error"
   config.rescue_responses = {
     'TypeError'       => :bad_request,
-    'CustomException' => :not_found
+    'CustomException' => :not_found,
+    'ForbiddenException' => :forbidden
   }
 end
 
 # controllers
 class ApplicationController < ActionController::Base
   append_view_path "spec/fake_app/views"
-  before_filter :bad_filter
+  if self.respond_to? :before_filter
+    before_filter :bad_filter
+  else
+    before_action :bad_filter
+  end
 
   private
 
@@ -43,7 +47,11 @@ class ApplicationController < ActionController::Base
   end
 end
 class UsersController < ApplicationController
-  skip_filter :bad_filter, except: :show
+  if self.respond_to? :skip_before_action
+    skip_before_action :bad_filter, except: :show
+  else
+    skip_filter :bad_filter, except: :show
+  end
 
   def index
     raise CustomException
@@ -56,7 +64,8 @@ class UsersController < ApplicationController
   end
 
   def create; end
-end
 
-# helpers
-Object.const_set(:ApplicationHelper, Module.new)
+  def edit
+    raise ForbiddenException
+  end
+end

data/test/requests/error_json_test.rb

@@ -0,0 +1,57 @@
+require 'test_helper'
+
+class ErrorJsonTest < ActionDispatch::IntegrationTest
+  test 'returns the 422 json for ActionController:InvalidAuthenticityToken but without its template' do
+    get '/users/new'
+
+    assert_equal 422, response.status
+    assert_equal "Something went wrong", json_response['message']
+  end
+
+  test 'returns the 500 json for RuntimeError' do
+    get '/users/1.json'
+
+    assert_equal 500, response.status
+    assert_equal "Something went wrong", json_response['message']
+  end
+
+  test 'returns the 404 json for CustomException' do
+    get '/users.json'
+
+    assert_equal 404, response.status
+    assert_equal "Page not found", json_response['message']
+  end
+
+  test 'returns the 404 json for ActinoController::RoutingError' do
+    get '/doesnt_exist.json'
+
+    assert_equal 404, response.status
+    assert_equal "Page not found", json_response['message']
+  end
+
+  private
+
+  def without_layouts
+    `mv test/fake_app/app/views/layouts/application.html.erb .`
+    `mv test/fake_app/app/views/layouts/error.html.erb .`
+
+    yield
+  ensure
+    `mv application.html.erb test/fake_app/app/views/layouts/`
+    `mv error.html.erb test/fake_app/app/views/layouts/`
+  end
+
+  def get(path)
+    without_layouts do
+      if Rails::VERSION::STRING >= '5.1.0'
+        super path, headers: { "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json" }
+      else
+        super path, nil, "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json"
+      end
+    end
+  end
+
+  def json_response
+    JSON.parse(response.body)
+  end
+end if !ENV["CUSTOM_EXCEPTIONS_APP"]

data/test/requests/error_page_test.rb

@@ -0,0 +1,87 @@
+require 'test_helper'
+
+class ErrorPageTest < ActionDispatch::IntegrationTest
+  test 'displays the 500 page for RuntimeError' do
+    visit '/users/1'
+
+    assert_equal 500, page.status_code
+    assert_includes page.body, "Error page"
+    assert_includes page.body, "Something went wrong."
+  end
+
+  test 'displays the 404 page for CustomException' do
+    visit '/users'
+
+    assert_equal 404, page.status_code
+    assert_includes page.body, "Error page"
+    assert_includes page.body, "Page not found."
+  end
+
+  test 'displays the 404 page for ActionController::RoutingError' do
+    visit '/doesnt_exist'
+
+    assert_equal 404, page.status_code
+    assert_includes page.body, "Error page"
+    assert_includes page.body, "Page not found."
+  end
+
+  test 'displays the 400 page when malformed parameters' do
+    page.driver.post '/users?x[y]=1&x[y][][w]=2'
+
+    assert_equal 400, page.status_code
+    assert_includes page.body, "Error page"
+    assert_includes page.body, "Bad request."
+  end
+
+  test 'displays the 404 page for request to non-existing page with malformed parameters' do
+    page.driver.post '/doesnt_exist?x[y]=1&x[y][][w]=2'
+
+    assert_equal 404, page.status_code
+    assert_includes page.body, "Error page"
+    assert_includes page.body, "Page not found."
+  end
+
+  test 'displays the 403 page for ForbiddenException' do
+    visit '/users/1/edit'
+
+    assert_equal 403, page.status_code
+    assert_includes page.body, "Error page"
+    assert_includes page.body, "Forbidden."
+  end
+
+  test 'uses the custom layou twith a custom layout name' do
+    @org, Rambulance.layout_name = Rambulance.layout_name, "application"
+
+    begin
+      visit '/doesnt_exist'
+      assert_includes page.body, "Application page"
+    ensure
+      Rambulance.layout_name = @org
+    end
+  end
+
+  test 'uses the 500 page and returns 422 when the template is missing' do
+    visit '/users/new'
+
+    assert_equal 422, page.status_code
+    assert_includes page.body, "Error page"
+    assert_includes page.body, "Something went wrong."
+  end
+end if !ENV["CUSTOM_EXCEPTIONS_APP"]
+
+class ErrorPageWithCustomExceptionsAppTest < ActionDispatch::IntegrationTest
+  test 'displays 500 page for RuntimeError' do
+    visit '/users/1'
+
+    assert_equal 500, page.status_code
+    assert_includes page.body, "Custom error page"
+  end
+
+  test 'displays 404 page for ActinoController::RoutingError' do
+    visit '/doesnt_exist'
+
+    assert_equal 404, page.status_code
+    assert_includes page.body, "Error page"
+    assert_includes page.body, "Page not found."
+  end
+end if ENV["CUSTOM_EXCEPTIONS_APP"]

data/test/test_helper.rb

@@ -0,0 +1,21 @@
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+
+require 'rails'
+require 'minitest/autorun'
+require 'action_controller/railtie'
+require 'action_view/railtie'
+require 'bundler/setup'
+Bundler.require
+
+require 'fake_app/rails_app'
+require 'capybara/rails'
+
+class ActionDispatch::IntegrationTest
+  include Capybara::DSL
+
+  def teardown
+    Capybara.reset_sessions!
+    Capybara.use_default_driver
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rambulance
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-18 00:00:00.000000000 Z
+date: 2016-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -54,34 +54,6 @@ dependencies:
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.6'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: tzinfo
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: jbuilder
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: tzinfo
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: jbuilder
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -184,6 +156,7 @@ files:
 - gemfiles/rails_40.gemfile
 - gemfiles/rails_41.gemfile
 - gemfiles/rails_42.gemfile
+- gemfiles/rails_50.gemfile
 - gemfiles/rails_edge.gemfile
 - lib/generators/rambulance/exceptions_app_generator.rb
 - lib/generators/rambulance/install_generator.rb
@@ -214,18 +187,20 @@ files:
 - lib/rambulance/railtie.rb
 - lib/rambulance/version.rb
 - rambulance.gemspec
-- spec/fake_app/app/views/errors/bad_request.html.erb
-- spec/fake_app/app/views/errors/internal_server_error.html.erb
-- spec/fake_app/app/views/errors/internal_server_error.json.jbuilder
-- spec/fake_app/app/views/errors/not_found.html.erb
-- spec/fake_app/app/views/errors/not_found.json.jbuilder
-- spec/fake_app/app/views/layouts/application.html.erb
-- spec/fake_app/app/views/layouts/error.html.erb
-- spec/fake_app/lib/exceptions_app.rb
-- spec/fake_app/rails_app.rb
-- spec/requests/error_json_spec.rb
-- spec/requests/error_page_spec.rb
-- spec/spec_helper.rb
+- test/fake_app/app/helpers/application_helper.rb
+- test/fake_app/app/views/errors/bad_request.html.erb
+- test/fake_app/app/views/errors/forbidden.html.erb
+- test/fake_app/app/views/errors/internal_server_error.html.erb
+- test/fake_app/app/views/errors/internal_server_error.json.jbuilder
+- test/fake_app/app/views/errors/not_found.html.erb
+- test/fake_app/app/views/errors/not_found.json.jbuilder
+- test/fake_app/app/views/layouts/application.html.erb
+- test/fake_app/app/views/layouts/error.html.erb
+- test/fake_app/lib/exceptions_app.rb
+- test/fake_app/rails_app.rb
+- test/requests/error_json_test.rb
+- test/requests/error_page_test.rb
+- test/test_helper.rb
 homepage: http://github.com/yuki24/rambulance
 licenses:
 - MIT
@@ -246,20 +221,22 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.7
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Simple and safe way to dynamically generate error pages
 test_files:
-- spec/fake_app/app/views/errors/bad_request.html.erb
-- spec/fake_app/app/views/errors/internal_server_error.html.erb
-- spec/fake_app/app/views/errors/internal_server_error.json.jbuilder
-- spec/fake_app/app/views/errors/not_found.html.erb
-- spec/fake_app/app/views/errors/not_found.json.jbuilder
-- spec/fake_app/app/views/layouts/application.html.erb
-- spec/fake_app/app/views/layouts/error.html.erb
-- spec/fake_app/lib/exceptions_app.rb
-- spec/fake_app/rails_app.rb
-- spec/requests/error_json_spec.rb
-- spec/requests/error_page_spec.rb
-- spec/spec_helper.rb
+- test/fake_app/app/helpers/application_helper.rb
+- test/fake_app/app/views/errors/bad_request.html.erb
+- test/fake_app/app/views/errors/forbidden.html.erb
+- test/fake_app/app/views/errors/internal_server_error.html.erb
+- test/fake_app/app/views/errors/internal_server_error.json.jbuilder
+- test/fake_app/app/views/errors/not_found.html.erb
+- test/fake_app/app/views/errors/not_found.json.jbuilder
+- test/fake_app/app/views/layouts/application.html.erb
+- test/fake_app/app/views/layouts/error.html.erb
+- test/fake_app/lib/exceptions_app.rb
+- test/fake_app/rails_app.rb
+- test/requests/error_json_test.rb
+- test/requests/error_page_test.rb
+- test/test_helper.rb

data/spec/fake_app/lib/exceptions_app.rb

@@ -1,14 +0,0 @@
-class ExceptionsApp < Rambulance::ExceptionsApp
-  def not_found; end
-
-  def internal_server_error
-    render inline: <<-BODY
-      <html>
-        <body>
-          <h1>Custom error page</h1>
-          <p>Something went wrong!</p>
-        </body>
-      </html>
-    BODY
-  end
-end

data/spec/requests/error_json_spec.rb

@@ -1,52 +0,0 @@
-# encoding: UTF-8
-require 'spec_helper'
-
-feature 'Error json response', if: !ENV["CUSTOM_EXCEPTIONS_APP"], type: :request do
-  def json_response
-    JSON.parse(response.body)
-  end
-
-  def get(path)
-    without_layouts do
-      super(path, nil, "CONTENT_TYPE" => "application/json", "HTTP_ACCEPT" => "application/json")
-    end
-  end
-
-  def without_layouts
-    `mv spec/fake_app/app/views/layouts/application.html.erb .`
-    `mv spec/fake_app/app/views/layouts/error.html.erb .`
-
-    yield
-  ensure
-    `mv application.html.erb spec/fake_app/app/views/layouts/`
-    `mv error.html.erb spec/fake_app/app/views/layouts/`
-  end
-
-  scenario 'returns 422 json due to ActionController:InvalidAuthenticityToken but without its template' do
-    get '/users/new'
-
-    expect(response.status).to eq(422)
-    expect(json_response['message']).to eq("Something went wrong")
-  end
-
-  scenario 'returns 500 json due to RuntimeError' do
-    get '/users/1.json'
-
-    expect(response.status).to eq(500)
-    expect(json_response['message']).to eq("Something went wrong")
-  end
-
-  scenario 'returns 404 json due to CustomException' do
-    get '/users.json'
-
-    expect(response.status).to eq(404)
-    expect(json_response['message']).to eq("Page not found")
-  end
-
-  scenario 'returns 404 json due to ActinoController::RoutingError' do
-    get '/doesnt_exist.json'
-
-    expect(response.status).to eq(404)
-    expect(json_response['message']).to eq("Page not found")
-  end
-end

data/spec/requests/error_page_spec.rb

@@ -1,89 +0,0 @@
-# encoding: UTF-8
-require 'spec_helper'
-
-feature 'Error page' do
-  shared_examples_for "an action that renders 500 page if the template is missing" do
-    scenario 'displays 500 page and return 422 Bad Request status' do
-      visit '/users/new'
-
-      expect(page.status_code).to eq(422)
-      expect(page.body).to have_content "Error page"
-      expect(page.body).to have_content "Something went wrong."
-    end
-  end
-
-  context 'generated by the default exceptions app', if: !ENV["CUSTOM_EXCEPTIONS_APP"] do
-    it_behaves_like "an action that renders 500 page if the template is missing"
-
-    scenario 'displays 500 page due to RuntimeError' do
-      visit '/users/1'
-
-      expect(page.status_code).to eq(500)
-      expect(page.body).to have_content "Error page"
-      expect(page.body).to have_content "Something went wrong."
-    end
-
-    scenario 'displays 404 page due to CustomException' do
-      visit '/users'
-
-      expect(page.status_code).to eq(404)
-      expect(page.body).to have_content "Error page"
-      expect(page.body).to have_content "Page not found."
-    end
-
-    scenario 'displays 404 page due to ActionController::RoutingError' do
-      visit '/doesnt_exist'
-
-      expect(page.status_code).to eq(404)
-      expect(page.body).to have_content "Error page"
-      expect(page.body).to have_content "Page not found."
-    end
-
-    scenario 'displays 400 page when malformed parameters' do
-      page.driver.post '/users?x[y]=1&x[y][][w]=2'
-
-      expect(page.status_code).to eq(400)
-      expect(page.body).to have_content "Error page"
-      expect(page.body).to have_content "Bad request."
-    end
-
-    scenario 'displays 404 page for non-existing page when malformed parameters' do
-      page.driver.post '/doesnt_exist?x[y]=1&x[y][][w]=2'
-
-      expect(page.status_code).to eq(404)
-      expect(page.body).to have_content "Error page"
-      expect(page.body).to have_content "Page not found."
-    end
-
-    context "with a custom layout name" do
-      before do
-        @org, Rambulance.layout_name = Rambulance.layout_name, "application"
-      end
-      after { Rambulance.layout_name = @org }
-
-      scenario 'uses the custom layout' do
-        visit '/doesnt_exist'
-        expect(page.body).to have_content "Application page"
-      end
-    end
-  end
-
-  context "generated by a custom exception app", if: ENV["CUSTOM_EXCEPTIONS_APP"] do
-    it_behaves_like "an action that renders 500 page if the template is missing"
-
-    scenario 'displays 404 page due to ActinoController::RoutingError' do
-      visit '/doesnt_exist'
-
-      expect(page.status_code).to eq(404)
-      expect(page.body).to have_content "Error page"
-      expect(page.body).to have_content "Page not found."
-    end
-
-    scenario 'displays 500 page due to RuntimeError' do
-      visit '/users/1'
-
-      expect(page.status_code).to eq(500)
-      expect(page.body).to have_content "Custom error page"
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,19 +0,0 @@
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-
-require 'rails'
-
-require 'bundler/setup'
-Bundler.require
-
-require 'capybara/rspec'
-require 'fake_app/rails_app'
-require 'rspec/rails'
-
-# Requires supporting files with custom matchers and macros, etc,
-# in ./support/ and its subdirectories.
-# Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f }
-
-# RSpec.configure do |config|
-#
-# end