rakuten_web_service 1.4.2 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b14f637d234a8bb4962e0ca46a76b171a7a8918d
-  data.tar.gz: 315b2c8f96b6b630b626cfd6299650a59ce3801e
+  metadata.gz: d5971dec1936ae9d551e73800107c2d1a99fed04
+  data.tar.gz: 9437dd7d638465c013db48a760f703d31e333ad1
 SHA512:
-  metadata.gz: 2e85f855a001112c676e8b17e41c445a67a46060c3bf2a7e9780ed29b11ab0286fe78162128cd198df987bafd079d088ce1cc8d0d57c4f8b8a7f6b519674ae24
-  data.tar.gz: 1f5f80be05c450def2e4e1592e40d0e1f4cd5e17979ff2af8081e67903ef9b05050c8b8ef25bd47ddc734539aae6cf3be0b26c4c2166a95c3d2561733af16c6e
+  metadata.gz: c66a18c2a9fed5a35caf4ef91a70a5665498a18b75e7ec9d1fb31fb1d196898b3fc48924025013b6ef27ca429f742cf882ea5d357c4c9531ac08c45bb31455f2
+  data.tar.gz: 1cb65253cdb7b1317a3b04a0683ca5a60d5150f02d90602205107cfbbdcddd747118fabfade92ef58840085c65d1644f88df91ab4fc59cb0e7b16b31c2d0fcd3

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+# v1.5.0 (2017/03/31)
+
+## Improvements
+
+* Allows to call `RakutenWebService::Recipe.ranking` without `category_id`. [#70](https://github.com/rakuten-ws/rws-ruby-sdk/pull/70)
+
+## Thanks
+
+I'm pleasured to say thanks to @kakakakakku. His work has made the usage of `RWS::Recipe.raning` easy to get the ranking in all genres.
+Thanks!
+
 # v1.4.2 (2017/01/22)
 
 ## Bug Fixes

data/lib/rakuten_web_service/recipe.rb

@@ -17,8 +17,10 @@ module RakutenWebService
       response['result'].map { |r| Recipe.new(r) }
     end
 
-    def self.ranking(category)
-      self.search(category_id: category)
+    def self.ranking(category_id = nil)
+      params = {}
+      params.merge!(category_id: category_id) unless category_id.nil?
+      self.search(params)
     end
 
     class << self

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "1.4.2".freeze
+  VERSION = "1.5.0".freeze
 end

data/spec/rakuten_web_service/recipe_spec.rb

@@ -11,6 +11,12 @@ describe RakutenWebService::Recipe do
       categoryId: category_id
     }
   end
+  let(:expected_query_without_category_id) do
+    {
+      affiliateId: affiliate_id,
+      applicationId: application_id
+    }
+  end
 
   before do
     RakutenWebService.configure do |c|
@@ -26,25 +32,48 @@ describe RakutenWebService::Recipe do
   end
 
   describe '.ranking' do
-    let(:category_id) { '30' }
+    context 'get ranking without category_id' do
+      before do
+        response = JSON.parse(fixture('recipe/ranking.json'))
+
+        @expected_request = stub_request(:get, endpoint).
+          with(query: expected_query_without_category_id).
+          to_return(body: response.to_json)
+      end
 
-    before do
-      response = JSON.parse(fixture('recipe/ranking.json'))
+      subject { RakutenWebService::Recipe.ranking }
 
-      @expected_request = stub_request(:get, endpoint).
-        with(query: expected_query).
-        to_return(body: response.to_json)
+      it 'should call search without category_id' do
+        subject.first
+
+        expect(@expected_request).to have_been_made.once
+      end
+      it 'should return an array of Recipe' do
+        expect(subject).to be_all { |r| r.is_a?(RWS::Recipe) }
+      end
     end
 
-    subject { RakutenWebService::Recipe.ranking(category_id) }
+    context 'get ranking with category_id' do
+      let(:category_id) { '30' }
 
-    it 'should call search with category id' do
-      subject.first
+      before do
+        response = JSON.parse(fixture('recipe/ranking.json'))
 
-      expect(@expected_request).to have_been_made.once
-    end
-    it 'shoudl return an array of Reciep' do
-      expect(subject).to be_all { |r| r.is_a?(RWS::Recipe) }
+        @expected_request = stub_request(:get, endpoint).
+          with(query: expected_query).
+          to_return(body: response.to_json)
+      end
+
+      subject { RakutenWebService::Recipe.ranking(category_id) }
+
+      it 'should call search with category_id' do
+        subject.first
+
+        expect(@expected_request).to have_been_made.once
+      end
+      it 'should return an array of Recipe' do
+        expect(subject).to be_all { |r| r.is_a?(RWS::Recipe) }
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.5.0
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-22 00:00:00.000000000 Z
+date: 2017-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -205,7 +205,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Ruby Client for Rakuten Web Service