rakuten_web_service 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f79961bad825f4fb30452d991970455ea06c3dfe
-  data.tar.gz: 3fe13d653a47429b7a4423f49cfa92a8bc48e41e
+  metadata.gz: 36494ec875153de05cd30a11c266d9c2c7d12b09
+  data.tar.gz: dafab6e790770ec344dca796d261a4896c741b54
 SHA512:
-  metadata.gz: 417d44418dccbcbb5ba5c7cce48168b9204b2d4fa56790119bcc9864abed6e9dfedd8c7738dca523dbc4e733825063f6fe1116da728b281ca0c64bd98748f738
-  data.tar.gz: 64ac7fb9c11bc7754eae3127ea522234289a3f664e4fa274e3297b0883927dacdcb95c0a7db4c45f6910c1324f3bc28ad18e49ddb0af655e646783ad486fa72f
+  metadata.gz: ffddb30af4da3756f6ef0baa4e2ad49c0967d06264eaf39e29c3a1bbb4a109cb7868e63335be9203006f631c4e24ba97144e899532fb2d15a223a7ede2022f2a
+  data.tar.gz: 9464a7badbc80252dfadb8c42104e0deefa028858eb9d09f91ee6545b05bd43cbb27b4ab1071a8e4e0ee08b4d7e28bcb5c1818da190aee180f7281661b240ddd

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# v1.4.0 (2016/11/11)
+
+## Enhancements
+
+* Raise RuntimeError if required option `application_id` is not set when generating parameters. [#51](https://github.com/rakuten-ws/rws-ruby-sdk/pull/51)
+
+
 # v1.3.0 (2016/11/08)
 
 ## Enhancements

data/lib/rakuten_web_service/configuration.rb

@@ -12,8 +12,13 @@ module RakutenWebService
       convert_snake_key_to_camel_key(default_parameters.merge(params))
     end
 
-    def default_parameters 
-      { :application_id => application_id, :affiliate_id => affiliate_id }
+    def default_parameters
+      raise "Application ID is not defined" unless has_required_options?
+      { application_id: application_id, affiliate_id: affiliate_id }
+    end
+
+    def has_required_options?
+      application_id && application_id != ''
     end
 
     def debug_mode?

data/lib/rakuten_web_service/version.rb

@@ -1,3 +1,3 @@
 module RakutenWebService
-  VERSION = "1.3.0".freeze
+  VERSION = "1.4.0".freeze
 end

data/spec/rakuten_web_service/configuration_spec.rb

@@ -102,4 +102,40 @@ describe RakutenWebService::Configuration do
       end
     end
   end
+
+  describe "#default_parameters" do
+    before do
+      RakutenWebService.configure do |c|
+        c.application_id = application_id
+      end
+    end
+
+    context "When application id is given" do
+      let(:application_id) { 'app_id' }
+
+      subject { RakutenWebService.configuration.default_parameters }
+
+      it "has application_id key and its value is a given value" do
+        expect(subject[:application_id]).to eq 'app_id'
+      end
+    end
+    context "When application id is not given" do
+      let(:application_id) { nil }
+
+      it "raises an error" do
+        expect {
+          RakutenWebService.configuration.default_parameters
+        }.to raise_error(RuntimeError, "Application ID is not defined")
+      end
+    end
+    context "When application id is an empty string" do
+      let(:application_id) { '' }
+
+      it "raises an error" do
+        expect {
+          RakutenWebService.configuration.default_parameters
+        }.to raise_error(RuntimeError, "Application ID is not defined")
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rakuten_web_service
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-07 00:00:00.000000000 Z
+date: 2016-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler