rake_check 0.1.2 → 0.1.3

data/lib/rake_check/cane_checker.rb

@@ -10,7 +10,11 @@ class CaneChecker
   # @return [Hash] Checkresult
   # @author dmasur
   def result
-    @shell_output = `cane`
+    @shell_output = begin
+      `cane`
+    rescue Errno::ENOENT
+      "Cane not found"
+    end
     { :type => :cane, :check_output => @shell_output, :status => status }
   end
 
@@ -39,10 +43,8 @@ class CaneChecker
     # @return [String] Colored Validation Count
     # @author dmasur
     def color_violations
-      color = case @violations
-      when 1..9 then :yellow
-      else :red
-      end
+      color = :red
+      color = :yellow if @violations.between?(1, 9)
       @violations = @violations.to_s.send color
     end
 end

data/lib/rake_check/rbp_checker.rb

@@ -10,7 +10,11 @@ class RbpChecker
   # @return [Hash] Checkresult
   # @author dmasur
   def result
-    @shell_output = `rails_best_practices --silent --spec`
+    @shell_output = begin
+      `rails_best_practices --silent --spec`
+    rescue Errno::ENOENT
+      "Rails best practices not found"
+    end
     {:type => :rbp, :check_output => output, :status => status}
   end
 
@@ -21,8 +25,8 @@ class RbpChecker
     # @return [String] Checkoutput
     # @author dmasur
     def output
-      case state
-      when :good then ''
+      if state == :good
+        ''
       else
         regexp = /Please go to .* to see more useful Rails Best Practices./
         output_lines = @shell_output.gsub(regexp, '').split(/\n/)
@@ -36,8 +40,7 @@ class RbpChecker
     # @return [String] Checkstatus
     # @author dmasur
     def status
-      tmp_state = state
-      case tmp_state
+      case state
       when :good then 'OK'.green
       when :error then 'N/A'
       else error_message.red
@@ -50,8 +53,7 @@ class RbpChecker
     # @return [String] Errormessage
     # @author dmasur
     def error_message
-      warning_count = /Found (\d+) warnings/.match(@shell_output)[1]
-      "Found #{warning_count} warnings"
+      /Found \d+ warnings/.match(@shell_output)[0]
     end
 
     ##

data/lib/rake_check/reek_checker.rb

@@ -10,8 +10,13 @@ class ReekChecker
   # @author dmasur
   def result
     require_dependencies
-    shell_output = `reek app lib -y 2>/dev/null`
-    @shell_output = shell_output.split("\n").
+
+    @shell_output = begin
+      `reek app lib -y 2>/dev/null`
+    rescue Errno::ENOENT
+      "Reek not found"
+    end
+    @shell_output = @shell_output.split("\n").
       delete_if{|line| line.include?('already initialized constant') }.join("\n")
     {:type => :reek, :check_output => output, :status => status}
   end

data/lib/rake_check/rspec_checker.rb

@@ -10,7 +10,11 @@ class RspecChecker
   # @return [Hash] Checkresult
   # @author dmasur
   def result directory="spec"
-    @shell_output = `export COVERAGE=true; rspec #{directory}; export COVERAGE=`
+    @shell_output = begin
+      `export COVERAGE=true; rspec #{directory}; export COVERAGE=`
+    rescue Errno::ENOENT
+      "RSpec not found"
+    end
     {:type => directory, :status => status + code_coverage, :check_output => output}
   end
 
@@ -36,10 +40,7 @@ class RspecChecker
     # @return [String] Output
     # @author dmasur
     def output
-      case @shell_output
-      when / 0 failures/ then ''
-      else @shell_output
-      end
+      @shell_output =~ / 0 failures/ ? '' : @shell_output
     end
 
     ##
@@ -48,11 +49,11 @@ class RspecChecker
     # @return [String] Codecoverage
     def code_coverage
       if @shell_output.include?('Coverage report generated')
-        @coverage = /LOC \((\d+\.\d+)%\) covered/.match(@shell_output)[1].to_f
+        @coverage = /LOC \(([\d.]+)%\) covered/.match(@shell_output)[1].to_f
         color_coverage
         " with #{@coverage} Code Coverage"
       else
-        ""
+        ''
       end
     end
 

data/lib/rake_check/tasks/check.rake

@@ -39,12 +39,11 @@ end
 # @author dmasur
 def print_summary results
   results.each do |result|
-    type_name = result[:type].to_s
-    status = result[:status]
-    puts "#{type_name}:\t#{status}"
+    puts "#{result[:type]}:\t#{result[:status]}"
   end
 end
-desc "Check Rails Best Practices and RSpec"
+
+desc "Check all Metric tools"
 task :check do
   results  ||= []
   Dir["spec*"].each do |spec_dir|

data/lib/rake_check/version.rb

@@ -3,5 +3,5 @@ module RakeCheck
   # The Version Constant
   #
   # @author dmasur
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/rake_check/yard_checker.rb

@@ -10,7 +10,11 @@ class YardChecker
   # @return [Hash] Checkresult
   # @author dmasur
   def result
-    @shell_output = `yardoc`
+    @shell_output = begin
+      `yardoc`
+    rescue Errno::ENOENT
+      "Yardoc not found"
+    end
     {:type => :yard, :check_output => output, :status => status}
   end
 
@@ -58,10 +62,6 @@ class YardChecker
     # @return [String] Output
     # @author dmasur
     def output
-      if @shell_output.include? 'documented'
-        ''
-      else
-        @shell_output
-      end
+      @shell_output.include?('documented') ? '' : @shell_output
     end
 end

data/rake_check.gemspec

@@ -19,5 +19,4 @@ Gem::Specification.new do |gem|
   gem.add_dependency "colored"
   gem.add_dependency "rake"
   gem.add_dependency "reek"
-  gem.add_dependency "cane"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rake_check
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70203811968860 !ruby/object:Gem::Requirement
+  requirement: &70265476630660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70203811968860
+  version_requirements: *70265476630660
 - !ruby/object:Gem::Dependency
   name: colored
-  requirement: &70203811968160 !ruby/object:Gem::Requirement
+  requirement: &70265476629760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70203811968160
+  version_requirements: *70265476629760
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70203811967360 !ruby/object:Gem::Requirement
+  requirement: &70265476629220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70203811967360
+  version_requirements: *70265476629220
 - !ruby/object:Gem::Dependency
   name: reek
-  requirement: &70203811966280 !ruby/object:Gem::Requirement
+  requirement: &70265476628500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,18 +54,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70203811966280
-- !ruby/object:Gem::Dependency
-  name: cane
-  requirement: &70203811965100 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: *70203811965100
+  version_requirements: *70265476628500
 description: Checking the Project for Code Smells and bad documentation
 email:
 - dominik.masur@googlemail.com
@@ -112,7 +101,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3766777700523133814
+      hash: -1137789811781084893
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -121,7 +110,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3766777700523133814
+      hash: -1137789811781084893
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.10