rake_check 0.0.1 → 0.1.0

data/.travis.yml

@@ -1,3 +1,4 @@
 language: ruby
 rvm:
-  - 1.9.3
+  - 1.9.3
+script: "rspec spec"

data/lib/rake_check/reek_checker.rb

@@ -1,4 +1,6 @@
 require 'colored'
+require 'yaml'
+require 'reek'
 ##
 # ReekChecker checks the Output of reek for Code Smells
 #
@@ -17,6 +19,7 @@ class ReekChecker
   end
 
   private
+    ##
     # Gives the Check Status
     #
     # @return [String] Checkstatus
@@ -27,21 +30,44 @@ class ReekChecker
       elsif not @shell_output.include? '---'
         'N/A'.red
       else
-        error_count = YAML.parse(@shell_output).children.first.children.count
+        error_count = parsed_output.count
         "#{error_count} Codesmell".yellow
       end
     end
 
+    ##
+    # Parse the Output through YAML
+    #
+    # @return [Array] SmellWarnings
+    # @author dmasur
+    def parsed_output
+      YAML::load(@shell_output)
+    end
+
+    ##
+    # Format the SmellWarning for printing
+    #
+    # @return [String] Formated SmellWarning
+    # @author dmasur
+    def self.format_smell smell_warning
+      location = smell_warning.location
+      output = "#{smell_warning.smell["subclass"]}: "
+      output += "#{location["context"]}@#{location["lines"].join(", ")}"
+      return output
+    end
+
     ##
     # Gives the check output
     #
     # @return [String] Output
     # @author dmasur
     def output
-      unless @shell_output.include? '---'
-        @shell_output
+      if @shell_output.include? '---'
+        parsed_output.map do |smell|
+          ReekChecker.format_smell smell
+        end.join("\n")
       else
-        ''
+        @shell_output
       end
     end
 end

data/lib/rake_check/version.rb

@@ -3,5 +3,5 @@ module RakeCheck
   # The Version Constant
   #
   # @author dmasur
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/spec/lib/rake_check/reek_checker_spec.rb

@@ -13,6 +13,9 @@ describe ReekChecker do
     shell_output = File.read(File.expand_path(File.dirname(__FILE__) +
                                               '/../../files/reek_output.yaml'))
     subject.stub('`' => shell_output)
-    subject.result.should == { type: :reek, check_output: '', status: "\e[33m2 Codesmell\e[0m" }
+    check_output = "DuplicateMethodCall: ReekChecker#status@19, 20, 21, 22, 23\n"
+    check_output += "TooManyStatements: ReekChecker#status@17"
+    subject.result.should == { type: :reek,
+                               check_output: check_output, status: "\e[33m2 Codesmell\e[0m" }
   end
 end

data/spec/spec_helper.rb

@@ -1,9 +1,3 @@
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# Require this file using `require "spec_helper.rb"` to ensure that it is only
-# loaded once.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rake_check
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70144098464480 !ruby/object:Gem::Requirement
+  requirement: &70195768050000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70144098464480
+  version_requirements: *70195768050000
 - !ruby/object:Gem::Dependency
   name: colored
-  requirement: &70144098463700 !ruby/object:Gem::Requirement
+  requirement: &70195768049400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70144098463700
+  version_requirements: *70195768049400
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70144098462760 !ruby/object:Gem::Requirement
+  requirement: &70195768048880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70144098462760
+  version_requirements: *70195768048880
 - !ruby/object:Gem::Dependency
   name: reek
-  requirement: &70144098461880 !ruby/object:Gem::Requirement
+  requirement: &70195768048380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70144098461880
+  version_requirements: *70195768048380
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &70144098461060 !ruby/object:Gem::Requirement
+  requirement: &70195768047900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70144098461060
+  version_requirements: *70195768047900
 - !ruby/object:Gem::Dependency
   name: rails_best_practices
-  requirement: &70144098460120 !ruby/object:Gem::Requirement
+  requirement: &70195768063760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70144098460120
+  version_requirements: *70195768063760
 - !ruby/object:Gem::Dependency
   name: cane
-  requirement: &70144098459640 !ruby/object:Gem::Requirement
+  requirement: &70195768063240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70144098459640
+  version_requirements: *70195768063240
 - !ruby/object:Gem::Dependency
   name: redcarpet
-  requirement: &70144098459200 !ruby/object:Gem::Requirement
+  requirement: &70195768062740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,7 +98,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70144098459200
+  version_requirements: *70195768062740
 description: Checking the Project for Code Smells and bad documentation
 email:
 - dominik.masur@googlemail.com
@@ -145,7 +145,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3943817759965377518
+      hash: 4254309684851123485
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -154,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3943817759965377518
+      hash: 4254309684851123485
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.10