rake-funnel 0.16.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0765d968f496d9b2d6fc6e9987522f44b3b68414
-  data.tar.gz: 6402693233bbd64577af3fa8ac33b7254e68ff1f
+  metadata.gz: 15c93cd453fd3a4cb44ff99fecb8b9e12501bab0
+  data.tar.gz: 2b6ccf54a20198fb9b1c05cdb8c6ae9425b53040
 SHA512:
-  metadata.gz: 6ea5d6e5819f386a9e0ee18919c60a597419df112afd02bfd28165cf073b88f0e84ab6a8ad99120b7d08dad047256077925e9475b7d181fa3957fc0ab6095188
-  data.tar.gz: 9eed51507993fdf63ead454fd9653455c232f7e25163260d96c54e62cc02b46de54119ccf7e464ba857411b66cbf848360b2019e360565bbabc4744d23394175
+  metadata.gz: 4cabea259d82d608fdf27acfdc6e24f2ff085805abf698dbb5b58c15d2281857d56fff1af83c7b463967f9f0478caff3732436fc436fecf18546ee5dd68cf45b
+  data.tar.gz: 6d3f30c6d8570a6c4f501d00c998add9dc75142aa50b933f38891a0dfa4f2a5131885a0b46b4dc8a9dd97c888b8ae0cbd2619648a85239688cdf9602b2eaf262

data/lib/rake/funnel/tasks/bin_path.rb

@@ -24,8 +24,11 @@ module Rake
           task(name, *args) do |_, task_args|
             task_block.call(*[self, task_args].slice(0, task_block.arity)) if task_block
 
+            next unless paths.any?
+
+            add_pattern_to_path_environment(paths)
             Rake.rake_output_message 'Added the following paths to the PATH environment variable:'
-            add_pattern_to_path_environment.each do |p|
+            paths.each do |p|
               Rake.rake_output_message "  - #{p}"
             end
           end
@@ -33,9 +36,11 @@ module Rake
           self
         end
 
-        def add_pattern_to_path_environment
-          paths = Dir[*search_pattern].map { |path| File.expand_path(path) }.sort
+        def paths
+          @paths ||= Dir[*search_pattern].map { |path| File.expand_path(path) }.sort
+        end
 
+        def add_pattern_to_path_environment(paths)
           ENV['PATH'] = ([] << paths << ENV['PATH']).flatten.join(File::PATH_SEPARATOR)
           paths
         end

data/lib/rake/funnel/version.rb

@@ -1,5 +1,5 @@
 module Rake
   module Funnel
-    VERSION = '0.16.0'
+    VERSION = '0.16.1'
   end
 end

data/spec/rake/funnel/tasks/bin_path_spec.rb

@@ -20,33 +20,49 @@ describe Rake::Funnel::Tasks::BinPath do
       allow(Rake).to receive(:rake_output_message)
     }
 
-    before {
-      allow(Dir).to receive(:[]).with(*search_pattern).and_return(search_pattern)
-    }
-
     subject {
       described_class.new do |t|
         t.search_pattern = search_pattern
       end
     }
 
-    before {
-      Task[subject.name].invoke
-    }
+    context 'paths to add' do
+      before {
+        allow(Dir).to receive(:[]).with(*search_pattern).and_return(search_pattern)
+      }
 
-    it 'should prepend sorted matching folders to the PATH environment variable' do
-      paths = search_pattern.map { |path| File.expand_path(path) }.sort.join(File::PATH_SEPARATOR)
+      before {
+        Task[subject.name].invoke
+      }
 
-      expect(ENV).to have_received(:[]=).with('PATH',/^#{paths}/)
-    end
+      it 'should prepend sorted matching folders to the PATH environment variable' do
+        paths = search_pattern.map { |path| File.expand_path(path) }.sort.join(File::PATH_SEPARATOR)
+
+        expect(ENV).to have_received(:[]=).with('PATH',/^#{paths}/)
+      end
+
+      it 'should append original PATH environment variable' do
+        expect(ENV).to have_received(:[]=).with('PATH', /#{default_path}$/)
+      end
 
-    it 'should append original PATH environment variable' do
-      expect(ENV).to have_received(:[]=).with('PATH', /#{default_path}$/)
+      it 'should report added paths' do
+        expect(Rake).to have_received(:rake_output_message).with(%r|/foo$|)
+        expect(Rake).to have_received(:rake_output_message).with(%r|/bar$|)
+      end
     end
 
-    it 'should report added paths' do
-      expect(Rake).to have_received(:rake_output_message).with(%r|/foo$|)
-      expect(Rake).to have_received(:rake_output_message).with(%r|/bar$|)
+    context 'no paths to add' do
+      before {
+        allow(Dir).to receive(:[]).with(*search_pattern).and_return([])
+      }
+
+      before {
+        Task[subject.name].invoke
+      }
+
+      it 'should not print message' do
+        expect(Rake).not_to have_received(:rake_output_message)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rake-funnel
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1
 platform: ruby
 authors:
 - Alexander Groß
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-29 00:00:00.000000000 Z
+date: 2016-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -301,3 +301,4 @@ test_files:
 - spec/rake/funnel/tasks/timing_spec.rb
 - spec/rake/funnel/tasks/zip_spec.rb
 - spec/spec_helper.rb
+has_rdoc: