raja_ongkir 0.0.0 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c14afe8d4400f955bb49b662569dc144d5577c6a
-  data.tar.gz: c6895140d4b17106cf6560d29c19a2c27de1a785
+SHA256:
+  metadata.gz: b25b66ca2a77d0597cd6a49973fe637a5cb179c48a7cb035fd13f85ef7c85374
+  data.tar.gz: e8b47dfef5a9915ea72cbe6e9704baf54004d434ffd58780db041c03946b4209
 SHA512:
-  metadata.gz: 69e51b900a91cb29aa315b65311dc0062202aa5d77a7f8fceb8d0a9f805f010d431f0ca57c5e0390d9800b84693fd322b7e42359a6580ecb96b36564cc7aac01
-  data.tar.gz: 9a978e355364ae41031086b9300290111f1c2615239654bd54c3ed82f6de18d7431b8193c8c3310a6860b8556ba8312eb08237ffbf4e9e8c9fa433ebdefb2ed2
+  metadata.gz: 4bad741c8c4a8ef593add25e1b5f52a34d319108fedc339477c962a38dd037ac7f7d919efb68de0cbf4015c00496266f8a8a91a80b9a79bb5fdbc32fb4bc7941
+  data.tar.gz: 9bcb3e8883c913011747d98bd473bcada4fc17def2a1d6e85dd8823d6a2d56b55db14afba51151ee03dd3966a2893ae22ee172bb4a0ccfb6ae6a66309d865f5d

data/.coveralls.yml

@@ -0,0 +1 @@
+service_name: travis-ci

data/.travis.yml

@@ -1,5 +1,12 @@
-sudo: false
 language: ruby
-rvm:
-  - 2.0.0
-before_install: gem install bundler -v 1.13.6
+notifications:
+  email:
+    - siriusmdely@gmail.com
+deploy:
+  provider: rubygems
+  api_key:
+    secure: kuvEbqWeuDC4J6QGvvzkxc0HhpZNCFB8KN9ybd3SRblz2zgIIdIM9vhMwsk1cqDQnD2kAT1OKEM/bLOrcOGl7OV4IHExhL7ZgQeIzzDhanOaMjkIufRB2IC2Onjdnxvz90P+ZXae6nOUJkdvf31aR8q186iRTfJvP+iYgWQ63jH4mgOySwl1ZE1c56Wt0YTpaeUY1k/QuweYzVML8yg+bA4xyzqWS/grXfJL2bMQ1qHgVEDG3G1zPQF/hpf4CdxjUrsLPa+0UzazBlKhjkTp5arCgaLopK6fR3vGt8lFEq0aBywKqR+qSIIE8ejtWsnHV94kCyWaqKaYRpS6en088jTP0DZUXB5qLCfg9l5dMtuOGKem5YdYFxvoHUB6X5NBizhW4pyf/R66EYsRjmLFlyCUduElTi8nEoK/AbxQMkhF5XmNJMIKCFgwuf/sjDFCFvowKMAR0X4x5YbbGC6vGVZGmK9D8/xymo8rPwl2p8nSrSo7pKdsg57q/T+TobGhxu3rewCo7y61LFSEeXZ9NDSisiKFyUSATfxKVI+JMFLLFEHga/L1BWb1I2YQEq1Lo1mDwV3qDIOOG5XMqBo3hU22doT+kUR7DXQ/lgFUz6gutFbnusqrkUNuTQj6fzCzaogyJ8EsDkMVLGjPoJ6XvJWnnlhHn7AMshp+B8eHxRo=
+  gem: raja_ongkir
+  on:
+    tags: true
+    repo: siriusdely/raja_ongkir

data/README.md

@@ -1,5 +1,10 @@
 # RajaOngkir
 
+[![Gem Version](https://badge.fury.io/rb/raja_ongkir.svg)](https://badge.fury.io/rb/raja_ongkir)
+[![Build Status](https://travis-ci.org/siriusdely/raja_ongkir.svg?branch=master)](https://travis-ci.org/siriusdely/raja_ongkir)
+[![Coverage Status](https://coveralls.io/repos/github/siriusdely/raja_ongkir/badge.svg?branch=master)](https://coveralls.io/github/siriusdely/raja_ongkir?branch=master)
+[![Maintainability](https://api.codeclimate.com/v1/badges/0d3c042cf7cdf145a25d/maintainability)](https://codeclimate.com/github/siriusdely/raja_ongkir/maintainability)
+
 Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/raja_ongkir`. To experiment with that code, run `bin/console` for an interactive prompt.
 
 TODO: Delete this and the text above, and describe your gem
@@ -32,7 +37,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/raja_ongkir. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/siriusdely/raja_ongkir. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 
 ## License

data/Rakefile

@@ -1,10 +1,13 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+require 'bundler/gem_tasks'
+require 'rake/testtask'
+require 'rubocop/rake_task'
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList['test/**/*_test.rb']
+  t.libs << 'test'
+  t.libs << 'lib'
+  t.test_files = FileList['test/**/*_test.rb', 'test/**/*_spec.rb']
 end
 
-task :default => :test
+RuboCop::RakeTask.new
+
+task default: %i[test rubocop]

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "raja_ongkir"
+require 'bundler/setup'
+require 'raja_ongkir'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "raja_ongkir"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/lib/raja_ongkir.rb

@@ -1,20 +1,23 @@
-require "httparty"
-require "net/http"
-require "openssl"
-require "raja_ongkir/version"
-require "uri"
+require 'httparty'
+require 'net/http'
+require 'openssl'
+require 'raja_ongkir/helper'
+require 'raja_ongkir/version'
+require 'uri'
 
 module RajaOngkir
-  BASE_URL = "https://api.rajaongkir.com"
+  BASE_URL = 'https://api.rajaongkir.com'.freeze
 
+  ## Client for rajaongkir.com
+  #
   class Client
     include HTTParty
 
     base_uri BASE_URL
 
-    def initialize(account_type = "starter", api_key)
+    def initialize(api_key, account_type = 'starter')
       @account_type = account_type
-      @api_key = api_key
+      Helper.api_key = api_key
     end
 
     def hi
@@ -25,57 +28,55 @@ module RajaOngkir
       http.verify_mode = OpenSSL::SSL::VERIFY_NONE
 
       request = Net::HTTP::Get.new(url)
-      request["key"] = @api_key
+      request['key'] = @api_key
 
       response = http.request(request)
       puts response.read_body
     end
 
     def provinces(q = nil, options = {})
-      if (options.length > 0 and not q.nil? and not q.is_a?(String)) or
-          (options.length <= 0 and not q.nil? and not q.is_a?(Hash))
-        raise "Provided q must be an String"
-      end
-      if q.is_a?(Hash)
-        options = options.merge(q)
-        q = nil
-      end
-      reload = options[:reload]
-      if reload or not @provinces
-        p "reload"
+      q, options = Helper.sanitize_params q, options
+      if @provinces.nil? || options[:reload]
         # query = id ? build_query(id: id) : build_query
-        response = self.class.get("/#{@account_type}/province", build_query)
-        status = response["rajaongkir"]["status"]
-        unless status["code"] >= 200 and status["code"] < 300
-          raise "#{status["description"]} CODE #{status["code"]}"
-        else
-          @provinces = response["rajaongkir"]["results"]
-        end
-      end
-      unless q and q.is_a?(String)
-        @provinces
-      else
-        @provinces.select{ |p| p["province"].downcase =~ /#{Regexp.quote(q.downcase)}/ }
+        response = self.class.get("/#{@account_type}/province",
+                                  Helper.build_query)
+        @provinces = Helper.items_from_resp response
       end
+      return Helper.filter_by_keyword @provinces, q if q && q.is_a?(String)
+      @provinces
     end
 
     def province(id, options = {})
-      unless id.is_a?(Integer)
-        raise "Provided id must be an Integer."
-      end
+      raise 'Provided id must be an Integer.' unless id.is_a?(Integer)
       @provinces = provinces(options)
-      @provinces.find{ |p| p["province_id"] == id.to_s }
+      @provinces.find { |p| p['province_id'] == id.to_s }
     end
 
-    def cities
-      response = self.class.get("/#{@account_type}/city", headers: {"key" => @api_key})
+    def cities(q = nil, options = {})
+      q, options = Helper.sanitize_params q, options
+      reload = options[:reload]
+      if @cities.nil? || reload
+        response = self.class.get("/#{@account_type}/city", Helper.build_query)
+        @cities = Helper.items_from_resp response
+      end
+      return Helper.filter_by_keyword @cities, q if q && q.is_a?(String)
+      @cities
     end
 
-    private
+    def city(id, options = {})
+      raise 'Provided id must be an Integer.' unless id.is_a?(Integer)
+      @cities = cities(options)
+      @cities.find { |c| c['city_id'] == id.to_s }
+    end
 
-    def build_query query={}
-      query ||= {}
-      {query: query, headers: {"key" => @api_key}}
+    def costs(origin_id, destination_id, grams, courier = 'jne')
+      origin_id, destination_id, grams, courier =
+        Helper.sanitize_costs_params origin_id, destination_id, grams, courier
+      response = self.class.post(
+        "/#{@account_type}/cost",
+        Helper.build_costs_query(origin_id, destination_id, grams, courier)
+      )
+      @costs = Helper.items_from_resp response
     end
   end
 end

data/lib/raja_ongkir/helper.rb

@@ -0,0 +1,66 @@
+module RajaOngkir
+  ## Helper for RajaOngkir::Client
+  #
+  class Helper
+    def self.sanitize_costs_params(origin_id, destination_id, grams, courier)
+      origin_id = origin_id.to_i
+      destination_id = destination_id.to_i
+      grams = grams.to_i
+      raise 'origin_id, destination_id, and grams must be a positive Integer' if
+      origin_id <= 0 || destination_id <= 0 || grams <= 0
+      [origin_id, destination_id, grams, courier]
+    end
+
+    def self.build_costs_query(origin_id, destination_id, grams, courier)
+      {
+        headers: {
+          'key' => api_key,
+          'content-type' => 'application/x-www-form-urlencoded'
+        },
+        body: "origin=#{origin_id}&destination=#{destination_id}&" \
+        "weight=#{grams}&courier=#{courier}"
+      }
+    end
+
+    # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+    def self.sanitize_params(q, options)
+      return [nil, options.merge(q)] if
+      options.length <= 0 && q && q.is_a?(Hash)
+      raise 'Provided q must be a String' if
+      (options.length <= 0 && q && !q.is_a?(String)) ||
+      (!options.empty? && !q.nil? && !q.is_a?(String))
+
+      [q, options]
+    end
+    # rubocop:enable all
+
+    class << self
+      attr_accessor :api_key
+
+      def build_query(query = {})
+        query ||= {}
+        { query: query, headers: { 'key' => api_key } }
+      end
+
+      def items_from_resp(response)
+        status = response['rajaongkir']['status']
+        items = response['rajaongkir']['results']
+        return items if status['code'] >= 200 && status['code'] < 300
+        raise "#{status['description']} CODE #{status['code']}"
+      end
+
+      def filter_by_keyword(items, q)
+        item = items.first
+        if item['city_name']
+          key = 'city_name'
+        elsif item['province']
+          key = 'province'
+        end
+        items.select do |p|
+          p[key].downcase =~ /#{Regexp.quote(q.downcase)}/
+        end
+      end
+    end
+  end
+end

data/lib/raja_ongkir/version.rb

@@ -1,3 +1,3 @@
 module RajaOngkir
-  VERSION = "0.0.0"
+  VERSION = '0.0.2'.freeze
 end

data/raja_ongkir.gemspec

@@ -1,37 +1,61 @@
-# coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'raja_ongkir/version'
 
+# class Gem::Specification
+#   def check_allowed_push_host
+#     # Prevent pushing this gem to RubyGems.org.
+#     # To allow pushes either set the 'allowed_push_host'
+#     # to allow pushing to a single host or delete this section
+#     # to allow pushing to any host.
+#     if respond_to?(:metadata)
+#       metadata['allowed_push_host'] = "TODO: Set to 'http://mygemserver.com'"
+#     else
+#       raise 'RubyGems 2.0 or newer is required to protect against ' \
+#         'public gem pushes.'
+#     end
+#   end
+# end
+
+Gem::Specification.class_exec do
+  def check_allowed_push_host
+    # Prevent pushing this gem to RubyGems.org.
+    # To allow pushes either set the 'allowed_push_host'
+    # to allow pushing to a single host or delete this section
+    # to allow pushing to any host.
+    if respond_to?(:metadata)
+      metadata['allowed_push_host'] = "TODO: Set to 'http://mygemserver.com'"
+    else
+      raise 'RubyGems 2.0 or newer is required to protect against ' \
+        'public gem pushes.'
+    end
+  end
+end
+
 Gem::Specification.new do |spec|
-  spec.name          = "raja_ongkir"
+  spec.name          = 'raja_ongkir'
   spec.version       = RajaOngkir::VERSION
-  spec.authors       = ["Sirius Dely"]
-  spec.email         = ["siriusdely@icloud.com"]
+  spec.authors       = ['Sirius Dely']
+  spec.email         = ['siriusdely@icloud.com']
 
-  spec.summary       = %q{Client for rajaongkir.com}
-  spec.description   = %q{Client for rajaongkir.com}
-  spec.homepage      = "https://github.com/siriusdely/raja-ongkir"
-  spec.license       = "MIT"
+  spec.summary       = 'Client for rajaongkir.com'
+  spec.description   = 'Client for rajaongkir.com'
+  spec.homepage      = 'https://github.com/siriusdely/raja_ongkir'
+  spec.license       = 'MIT'
 
-  # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
-  # to allow pushing to a single host or delete this section to allow pushing to any host.
-  if spec.respond_to?(:metadata)
-    spec.metadata['allowed_push_host'] = "TODO: Set to 'http://mygemserver.com'"
-  else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
-  end
+  spec.check_allowed_push_host
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.13"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest", "~> 5.0"
-  spec.add_runtime_dependency "httparty", "~> 0.15"
+  spec.add_development_dependency 'bundler', '~> 1.13'
+  spec.add_development_dependency 'coveralls', '~> 0.8'
+  spec.add_development_dependency 'minitest', '~> 5.0'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rubocop', '~> 0.49'
+  spec.add_runtime_dependency 'httparty', '~> 0.15'
 end

metadata

@@ -1,69 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: raja_ongkir
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 0.0.2
 platform: ruby
 authors:
 - Sirius Dely
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-22 00:00:00.000000000 Z
+date: 2017-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.13'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.49'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.49'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.15'
 description: Client for rajaongkir.com
@@ -73,8 +101,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".coveralls.yml"
+- ".gitignore"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -83,9 +112,10 @@ files:
 - bin/console
 - bin/setup
 - lib/raja_ongkir.rb
+- lib/raja_ongkir/helper.rb
 - lib/raja_ongkir/version.rb
 - raja_ongkir.gemspec
-homepage: https://github.com/siriusdely/raja-ongkir
+homepage: https://github.com/siriusdely/raja_ongkir
 licenses:
 - MIT
 metadata:
@@ -96,17 +126,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Client for rajaongkir.com