rainforest-cli 1.12.5 → 1.12.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 19fd3d73f7a5c81996ba32511b65ec0d9fc3f325
-  data.tar.gz: 906334408edb3c7b1c46eb8381b02440fda8a2c6
+  metadata.gz: ab9a261f140208e59dd4a9e912dc976a64ae772c
+  data.tar.gz: de8727af6393a26c55ffac08927edd03d5b3c03f
 SHA512:
-  metadata.gz: ec606e2caa52e0142384a6e138130e73caa24191c6c8d6a6d9986d67954329589e37dde21d3c71afab67f5115c9f8eb71b59758fa13720e5303b3075ffdb2d45
-  data.tar.gz: f933956637418ff39a7abe8e51050cc436d536378c38245b00d8a186dff3de919ce05de4957826a9abc8944f266d814f38bc32c9bd371be2d1263d99e57877a6
+  metadata.gz: 8f303a75ca6e391126fb5e9a52d33fac4c022f346657a0267b2516dec220c16152ebe93e69d4b30ad69bc3b41381fa1c99db4ab17298bece05676b7c59de7d55
+  data.tar.gz: 4fb2564cc6757cd8bab4fcf95f29aa7263bc89429d6acd461a852f34635f8d6a4f933565052793917fd1c95e5e770eee844aa79a5616a980522d3f7a2fc9ae9b

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Rainforest CLI Changelog
 
+## 1.12.6 - 12th July 2017
+- Fixed an issue where the process was exiting with exit code 0 regardless of a
+run's final result when using the `--wait` flag.
+(6c851badfaaadeccfb18a0a20278810bbe2d5335, @epaulet)
+
 ## 1.12.5 - 7th March 2017
 - Include site ID for exported tests.
 (1816af9406013ac7594765822f73066adf332cf1, @epaulet)

data/lib/rainforest_cli/runner.rb

@@ -35,18 +35,7 @@ module RainforestCli
       logger.info "Issued run #{run_id}"
 
       if options.foreground?
-        response = wait_for_run_completion(run_id)
-        if options.junit_file?
-          reporter = Reporter.new(options)
-          reporter.run_id = run_id
-          reporter.report
-        end
-
-        if response['result'] != 'passed'
-          exit 1
-        end
-      else
-        true
+        wait_for_run_completion(run_id)
       end
     end
 
@@ -70,7 +59,15 @@ module RainforestCli
         logger.info "The detailed results are available at #{response['frontend_url']}"
       end
 
-      return response
+      if options.junit_file?
+        reporter = Reporter.new(options)
+        reporter.run_id = run_id
+        reporter.report
+      end
+
+      if response['result'] != 'passed'
+        exit 1
+      end
     end
 
     def make_create_run_options

data/lib/rainforest_cli/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module RainforestCli
-  VERSION = '1.12.5'
+  VERSION = '1.12.6'
 end

data/spec/rainforest_cli/runner_spec.rb

@@ -113,4 +113,61 @@ describe RainforestCli::Runner do
     end
   end
 
+  describe '#wait_for_run_completion' do
+    context 'run reaches final state' do
+      let(:run_id) { 123 }
+      let(:final_run_response) do
+        {
+          'id' => run_id,
+          'state' => state,
+          'result' => result,
+          'state_details' => {
+            'is_final_state' => true,
+          },
+        }
+      end
+
+      before do
+        allow_any_instance_of(RainforestCli::HttpClient).to receive(:get)
+        .with("/runs/#{run_id}", {}, retries_on_failures: true)
+        .and_return(final_run_response)
+      end
+
+      context 'run passes' do
+        let(:state) { 'complete' }
+        let(:result) { 'passed' }
+
+        it 'returns without exiting' do
+          expect { subject.wait_for_run_completion(run_id) }.to_not raise_error
+        end
+      end
+
+      context 'run fails' do
+        let(:state) { 'complete' }
+        let(:result) { 'failed' }
+
+        it 'exits 1' do
+          expect { subject.wait_for_run_completion(run_id) }.to raise_error(SystemExit)
+        end
+      end
+
+      context 'run encounters an error' do
+        let(:state) { 'error' }
+        let(:result) { 'no_result' }
+
+        it 'exits 1' do
+          expect { subject.wait_for_run_completion(run_id) }.to raise_error(SystemExit)
+        end
+      end
+
+      context 'run is aborted' do
+        let(:state) { 'aborted' }
+        let(:result) { 'no_result' }
+
+        it 'exits 1' do
+          expect { subject.wait_for_run_completion(run_id) }.to raise_error(SystemExit)
+        end
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rainforest-cli
 version: !ruby/object:Gem::Version
-  version: 1.12.5
+  version: 1.12.6
 platform: ruby
 authors:
 - Russell Smith
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-07 00:00:00.000000000 Z
+date: 2017-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -347,4 +347,3 @@ test_files:
 - spec/validation-examples/parse_errors/no_question_mark.rfml
 - spec/validation-examples/parse_errors/no_rfml_id.rfml
 - spec/validation-examples/parse_errors/no_title.rfml
-has_rdoc: