rainforest-cli 1.12.2 → 1.12.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f59142b19a1c8a1acead8496c363abac25f1e26
-  data.tar.gz: b67f1ccf9a7fc3dbc52762488b1e159048696643
+  metadata.gz: 0fee85958132e3b345c2515604efde99845b0496
+  data.tar.gz: 53901941d283610525d2f9232ad38363d6067675
 SHA512:
-  metadata.gz: 38ad9bb4c69e36ffa54e3e31b597ae3c47adda976579248d504df2781a2c3663464b2d829946d75cc7b394586dfe60df985a668e5b3ccc9e66a8735444def5a7
-  data.tar.gz: b68ddbb6e9ed0ac1e38a1bb954bed905213ff0835e22fca939e92cdca2b23632bc5f453886129eb5667d40a3d771653dbebb3dfd97524f06819bf079f5df56d5
+  metadata.gz: 3bb7f9524db4dc90980a4caaf54ba914368415c0412dd392d0eb945d1e2f43c9755f37ee37c8e068fe8c2a9a7cf016e10d681e8a831661504a42f5b58de86c44
+  data.tar.gz: c92ac9e76dbef3c2c70bbb09ec1270883fea04d3fb04a85ba3907a1d67e9e2e9aaf4d82cd4698a7919cc050cf4adc0bf92e5642a82d3a612170a6bb814eb3751

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Rainforest CLI Changelog
 
+## 1.12.3 - 24th February 2017
+- Validate RFML tests for a title.
+(beb439a3d2c12f618d6b4b00a3a08f1e37bbbe7a, @epaulet)
+
 ## 1.12.2 - 23rd February 2017
 - Default `start_uri` attribute to "/" if omitted from RFML test.
 (ec6049407ec635b7f7bc4f8da516ccddad2b78b3, @epaulet)

data/lib/rainforest_cli/test_parser.rb

@@ -5,9 +5,12 @@ module RainforestCli::TestParser
   require 'rainforest_cli/test_parser/step'
   require 'rainforest_cli/test_parser/embedded_test'
 
-  class Error < Struct.new(:line, :reason)
+  class Error < Struct.new(:location, :reason)
     def to_s
-      "Line #{line}: #{reason}"
+      case location
+      when Integer then "Line #{location}: #{reason}"
+      when Symbol, String then "Field #{location}: #{reason}"
+      end
     end
   end
 
@@ -98,7 +101,14 @@ module RainforestCli::TestParser
       end
 
       if @test.rfml_id == nil
-        @test.errors[0] = Error.new(0, 'Missing RFML ID. Please start a line #! followed by a unique id.')
+        @test.errors[:rfml_id] = Error.new(:rfml_id, 'Missing RFML ID. Please start a line #! followed by a unique id.')
+      end
+
+      if @test.title.nil? || @test.title.empty?
+        @test.errors[:title] = Error.new(
+          :title,
+          'Missing Title for test. Please start a line with "# title: " and specify your test title.',
+        )
       end
 
       return @test

data/lib/rainforest_cli/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module RainforestCli
-  VERSION = '1.12.2'
+  VERSION = '1.12.3'
 end

data/spec/rainforest_cli/test_parser_spec.rb

@@ -12,8 +12,7 @@ describe RainforestCli::TestParser do
     end
 
     describe '#process' do
-      let(:parsed_test) { subject.process }
-      let(:parsed_step) { parsed_test.steps.first }
+      let(:parsed_test) { described_class.new(file_name).process }
 
       describe 'parsing comments' do
         it 'properly identifies comments' do
@@ -28,9 +27,20 @@ describe RainforestCli::TestParser do
         end
 
         it 'properly parses step metadata' do
+          parsed_step = parsed_test.steps.first
           expect(parsed_step.redirect).to eq('false')
         end
       end
+
+      describe 'errors' do
+        context 'no title' do
+          let(:file_name) { './spec/validation-examples/parse_errors/no_title.rfml' }
+
+          specify do
+            expect(parsed_test.errors[:title]).to_not be_nil
+          end
+        end
+      end
     end
   end
 end

data/spec/validation-examples/parse_errors/no_question.rfml

@@ -2,4 +2,4 @@
 # title: No Question Test
 # start_uri: /
 
-This is an action without a question.
+This is an action without a question?

data/spec/validation-examples/parse_errors/no_rfml_id.rfml

@@ -2,4 +2,4 @@
 # start_uri: /
 
 This is an action.
-This is a question.
+This is a question?

data/spec/validation-examples/parse_errors/no_title.rfml

@@ -0,0 +1,6 @@
+#! example_test
+# start_uri: /
+# This test has no title
+
+This is a step action.
+This is a question?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rainforest-cli
 version: !ruby/object:Gem::Version
-  version: 1.12.2
+  version: 1.12.3
 platform: ruby
 authors:
 - Russell Smith
@@ -274,6 +274,7 @@ files:
 - spec/validation-examples/parse_errors/no_question.rfml
 - spec/validation-examples/parse_errors/no_question_mark.rfml
 - spec/validation-examples/parse_errors/no_rfml_id.rfml
+- spec/validation-examples/parse_errors/no_title.rfml
 homepage: https://www.rainforestqa.com/
 licenses:
 - MIT
@@ -345,4 +346,5 @@ test_files:
 - spec/validation-examples/parse_errors/no_question.rfml
 - spec/validation-examples/parse_errors/no_question_mark.rfml
 - spec/validation-examples/parse_errors/no_rfml_id.rfml
+- spec/validation-examples/parse_errors/no_title.rfml
 has_rdoc: