railway-ipc 0.1.7 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d54b5628ec775d68214605d423ffaea0cd56296efce288d9f6d225a3fe5b68a
-  data.tar.gz: b8fce8f52051eb667daa678b931ec24c3fa5de54783918849f618407e5b81863
+  metadata.gz: 39c4398fe9a2406dea3747efe2f8cb83710b0a2f58f56e153f2df57625613445
+  data.tar.gz: 5e6b9f14dfa42fe89078f6a1d95941eb133e113a1e90ff1e48b6804e2e8adec4
 SHA512:
-  metadata.gz: 68e7d82e728b4c3ace10b7c1926672c301bcd5090aa0bfc80b80485936c476fbf59c97493fe7d1eaaf7874620cf967b9b6ee2f95923cbeefff498248732c47e1
-  data.tar.gz: 2780cc3cf0d29b4abfda4fecc2d28a119e08d5592a87b6cba3ebf3c868bdea208c9f3c00ddf4708f35aa6f6b9e21defbd25baf2708006c725c6aec164038563d
+  metadata.gz: dbdfdebec3010f66e63ed12965b3e82135b0599f4bce0a5fa771ce8e28dbed042149b2391c925a614079c0799249fa2cd3f2a114de3527450746420c40b20578
+  data.tar.gz: c02cbdcb2cdc1cb6b609f818fb844c3e8accb6a54821d75b3afbb5197eff4c5ffa49cabb520bec8cfe3989052cbd38456d68e5e532e58244e1ea69e35c8677f4

data/.gitignore

@@ -6,14 +6,15 @@
 /pkg/
 /spec/reports/
 /tmp/
+Gemfile.lock
 
 # rspec failure tracking
 .rspec_status
 
 # rails support app files
-/spec/support/rails_app/.bundle
-/spec/support/rails_app/log/*
-/spec/support/rails_app/tmp/*
 /spec/support/rails_app!/log/.keep
 /spec/support/rails_app!/tmp/.keep
 /spec/support/rails_app.byebug_history
+/spec/support/rails_app/.bundle
+/spec/support/rails_app/log/*
+/spec/support/rails_app/tmp/*

data/CHANGELOG.MD

@@ -1,7 +1,39 @@
-# Changelog for v0.x
+# Changelog
+All notable changes to this project will be documented in this file.
 
-## v0.1.7 (2020-06-29)
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-### Enhancements
+## [Unreleased]
+### Added
+### Changed
+### Removed
+### Fixed
 
+## [1.0.0] - 2020-07-20
+### Added
+* CircleCI build that runs the specs
+* Rubocop (also ran by CircleCI)
+* New error types for incoming messages
+* RailwayIpc::Messages::Unknown protobuf
+
+### Changed
+* Refactored worker to use ProcessIncomingMessage and IncomingMessage abstractions
+* Moved decoding logic from ConsumedMessage to IncomingMessage
+* Removed STATUSES constant from ConsumedMessage
+* Publisher is no longer a Singleton; kept a Singleton version of the Publisher for backwards compatibility that gives a "deprecated" warning
+
+### Removed
+* Removed `BaseMessage` protobuf
+* NullMessage and NullHandler were removed
+
+### Fixed
+* Fixed all Rubocop warnings and errors
+
+## [0.1.7] - 2020-06-29
+### Added
 - Correlation ID and message UUID are auto generated for messages for IDs are not passed in [#23](https://github.com/learn-co/railway_ipc_gem/pull/23)
+
+[Unreleased]: https://github.com/learn-co/railway_ipc_gem/compare/v1.0.0...HEAD
+[1.0.0]: https://github.com/learn-co/railway_ipc_gem/compare/v0.1.7...v1.0.0
+[0.1.7]: https://github.com/learn-co/railway_ipc_gem/releases/tag/v0.1.7

data/Gemfile

@@ -1,5 +1,5 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 gemspec

data/Rakefile

@@ -1,7 +1,13 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
-task :test => :spec
+task default: %i[spec lint]
+
+desc 'Lint code with Rubocop'
+task :lint do
+  exec('./bin/rubocop .')
+end

data/bin/console

@@ -1,10 +1,10 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "railway_ipc"
+require 'bundler/setup'
+require 'railway_ipc'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-require "pry"
+require 'pry'
 Pry.start

data/bin/rspec

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rspec' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rspec-core", "rspec")

data/bin/rubocop

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rubocop' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rubocop", "rubocop")

data/lib/railway_ipc.rb

@@ -1,26 +1,28 @@
+# frozen_string_literal: true
+
 require 'railway_ipc/version'
 require 'sneakers'
 require 'bunny'
 require 'active_record'
 require 'railway_ipc/version'
-require 'railway_ipc/errors'
 require 'railway_ipc/logger'
 require 'railway_ipc/unhandled_message_error'
 require 'railway_ipc/response'
 require 'railway_ipc/rabbitmq/payload'
-require 'railway_ipc/null_message'
-require 'railway_ipc/base_message.pb'
+require 'railway_ipc/unknown_message.pb'
 require 'railway_ipc/rabbitmq/adapter'
 require 'railway_ipc/handler'
 require 'railway_ipc/handler_store'
+require 'railway_ipc/incoming_message'
 require 'railway_ipc/publisher'
-require 'railway_ipc/null_handler'
 require 'railway_ipc/responder'
 require 'railway_ipc/rpc/rpc'
 require 'railway_ipc/consumer/consumer'
+require 'railway_ipc/consumer/process_incoming_message'
 require 'railway_ipc/models/published_message'
 require 'railway_ipc/models/consumed_message'
 require 'railway_ipc/railtie' if defined?(Rails)
+require 'railway_ipc/errors'
 
 module RailwayIpc
   def self.start

data/lib/railway_ipc/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'railway_ipc'
 
 path = File.expand_path(__dir__)

data/lib/railway_ipc/consumer/consumer.rb

@@ -1,11 +1,10 @@
-require "json"
-require "base64"
-require "railway_ipc/consumer/consumer_response_handlers"
+# frozen_string_literal: true
+
+require 'railway_ipc/consumer/consumer_response_handlers'
 
 module RailwayIpc
   class Consumer
     include Sneakers::Worker
-    attr_reader :message, :handler, :protobuf_message, :delivery_info, :decoded_payload, :encoded_message
 
     def self.listen_to(queue:, exchange:)
       from_queue queue,
@@ -23,81 +22,31 @@ module RailwayIpc
       ConsumerResponseHandlers.instance.registered
     end
 
-    def work_with_params(payload, delivery_info, _metadata)
-      @delivery_info = delivery_info
-      @decoded_payload = RailwayIpc::Rabbitmq::Payload.decode(payload)
-      @encoded_message = payload
+    def queue_name
+      queue.name
+    end
 
-      case decoded_payload.type
-      when *registered_handlers
-        @handler = handler_for(decoded_payload)
-        message_klass = message_handler_for(decoded_payload)
-        @protobuf_message = message_klass.decode(decoded_payload.message)
-        process_known_message_type
-      else
-        @protobuf_message = RailwayIpc::BaseMessage.decode(decoded_payload.message)
-        process_unknown_message_type
-      end
+    def exchange_name
+      queue.opts[:exchange]
+    end
+
+    def work(payload)
+      message = RailwayIpc::IncomingMessage.new(payload)
+      RailwayIpc::ProcessIncomingMessage.call(self, message)
       ack!
     rescue StandardError => e
       RailwayIpc.logger.log_exception(
-        feature: "railway_consumer",
+        feature: 'railway_consumer',
         error: e.class,
         error_message: e.message,
-        payload: payload,
+        payload: payload
       )
       raise e
     end
 
-    private
-
-    def process_protobuf!(message)
-      response = handler.handle(protobuf_message)
-      message.status = RailwayIpc::ConsumedMessage.response_to_status(response)
-
-      message.save!
-    end
-
-    def process_known_message_type
-      message = RailwayIpc::ConsumedMessage.find_by(uuid: protobuf_message.uuid)
-
-      return if message && message.processed?
-
-      if message && !message.processed?
-        message.with_lock("FOR UPDATE NOWAIT") { process_protobuf!(message) }
-      else
-        message = create_message_with_status!(RailwayIpc::ConsumedMessage::STATUSES[:processing])
-        message.with_lock("FOR UPDATE NOWAIT") { process_protobuf!(message) }
-      end
-    end
-
-    def process_unknown_message_type
-      if RailwayIpc::ConsumedMessage.exists?(uuid: protobuf_message.uuid)
-        return
-      else
-        create_message_with_status!(RailwayIpc::ConsumedMessage::STATUSES[:unknown_message_type])
-      end
-    end
-
-    def create_message_with_status!(status)
-      RailwayIpc::ConsumedMessage.create!(
-        uuid: protobuf_message.uuid,
-        status: status,
-        message_type: decoded_payload.type,
-        user_uuid: protobuf_message.user_uuid,
-        correlation_id: protobuf_message.correlation_id,
-        queue: delivery_info.consumer.queue.name,
-        exchange: delivery_info.exchange,
-        encoded_message: encoded_message
-      )
-    end
-
-    def message_handler_for(decoded_payload)
-      ConsumerResponseHandlers.instance.get(decoded_payload.type).message
-    end
-
-    def handler_for(decoded_payload)
-      ConsumerResponseHandlers.instance.get(decoded_payload.type).handler.new
+    def get_handler(type)
+      manifest = ConsumerResponseHandlers.instance.get(type)
+      manifest ? manifest.handler.new : nil
     end
   end
 end

data/lib/railway_ipc/consumer/consumer_response_handlers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'railway_ipc/handler_store'
 module RailwayIpc
   class ConsumerResponseHandlers

data/lib/railway_ipc/consumer/process_incoming_message.rb

@@ -0,0 +1,105 @@
+# frozen_string_literal: true
+
+module RailwayIpc
+  class ProcessIncomingMessage
+    class UnknownMessageJob
+      attr_reader :incoming_message, :logger
+
+      def initialize(incoming_message, logger)
+        @incoming_message = incoming_message
+        @logger = logger
+      end
+
+      def status
+        'unknown_message_type'
+      end
+
+      def run
+        logger.warn(
+          incoming_message.decoded,
+          "Ignoring unknown message of type '#{incoming_message.type}'"
+        )
+      end
+    end
+
+    class IgnoredMessageJob
+      attr_reader :incoming_message, :logger
+
+      def initialize(incoming_message, logger)
+        @incoming_message = incoming_message
+        @logger = logger
+      end
+
+      def status
+        'ignored'
+      end
+
+      def run
+        logger.warn(
+          incoming_message.decoded,
+          "Ignoring message, no registered handler for '#{incoming_message.type}'"
+        )
+      end
+    end
+
+    class NormalMessageJob
+      attr_reader :incoming_message, :handler, :status
+
+      def initialize(incoming_message, handler)
+        @incoming_message = incoming_message
+        @handler = handler
+        @status = 'not_processed'
+      end
+
+      def run
+        result = handler.handle(incoming_message.decoded)
+        @status = result.success? ? RailwayIpc::ConsumedMessage::STATUS_SUCCESS : RailwayIpc::ConsumedMessage::STATUS_FAILED_TO_PROCESS
+      end
+    end
+
+    attr_reader :consumer, :incoming_message, :logger
+
+    def self.call(consumer, incoming_message)
+      new(consumer, incoming_message).call
+    end
+
+    def initialize(consumer, incoming_message, logger: RailwayIpc.logger)
+      @consumer = consumer
+      @incoming_message = incoming_message
+      @logger = logger
+    end
+
+    def call
+      raise_message_invalid_error unless incoming_message.valid?
+      message = find_or_create_consumed_message
+      return if message.processed?
+
+      message.update_with_lock(classify_message)
+    end
+
+    private
+
+    def raise_message_invalid_error
+      error = "Message is invalid: #{incoming_message.stringify_errors}."
+      logger.error(incoming_message.decoded, error)
+      raise RailwayIpc::IncomingMessage::InvalidMessage.new(error)
+    end
+
+    def find_or_create_consumed_message
+      RailwayIpc::ConsumedMessage.find_by(uuid: incoming_message.uuid) ||
+        RailwayIpc::ConsumedMessage.create_processing(consumer, incoming_message)
+    end
+
+    # rubocop:disable Metrics/AbcSize
+    def classify_message
+      if incoming_message.decoded.is_a?(RailwayIpc::Messages::Unknown)
+        UnknownMessageJob.new(incoming_message, logger)
+      elsif (handler = consumer.get_handler(incoming_message.type))
+        NormalMessageJob.new(incoming_message, handler)
+      else
+        IgnoredMessageJob.new(incoming_message, logger)
+      end
+    end
+    # rubocop:enable Metrics/AbcSize
+  end
+end

data/lib/railway_ipc/errors.rb

@@ -1 +1,9 @@
-class RailwayIpc::InvalidProtobuf < StandardError; end
+# frozen_string_literal: true
+
+# rubocop:disable Style/ClassAndModuleChildren
+class RailwayIpc::Error < StandardError; end
+class RailwayIpc::InvalidProtobuf < RailwayIpc::Error; end
+class RailwayIpc::FailedToStoreOutgoingMessage < RailwayIpc::Error; end
+class RailwayIpc::IncomingMessage::ParserError < RailwayIpc::Error; end
+class RailwayIpc::IncomingMessage::InvalidMessage < RailwayIpc::Error; end
+# rubocop:enable Style/ClassAndModuleChildren