railsui_charts 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 530d46e697812d44107d9907f5e44a749e5b2b1e1c0abe1c0dc36d52097e0fb4
-  data.tar.gz: 99045f42e3510a662269338984a67c7411d10a86f662ae5d970b4f2f870a26d1
+  metadata.gz: 90aab15c8c1ef133527f757c7e24344da84a62a190825a13decee8979cf79892
+  data.tar.gz: db6626712782f3a93d92ea8c149d9fbe27cece328b1cfca4b611269dd06a8c0b
 SHA512:
-  metadata.gz: '018f092a8cb0907c8166718c6eeb0983dbac13560d261fc8a33dfc5b4a4c29d90e270685cb0a4608870a1832728313c2b2d51defaec64f3add3ddbea237a2cc5'
-  data.tar.gz: bd5f67ec5021ad718cbadbb8afacad0a0792ba479f0c1d33137d78bdc7d686133448f7c8741b6cbd55b64243926080921df2a66fccd740854fd8af1d3f4a2e95
+  metadata.gz: 94345b1a73e7cdd1e2760ee58462f6af60396019295cb0a05a5f300120c2d5ed192d64770cb38254abfa959e94ca5ab51ed9353107163e5f2eb75a22e42611a9
+  data.tar.gz: e89fad7105008595f9de2070044287e1c193a09ab83dd327492a794106259d24783fc30ed580e19c07a40c8a7ea06ed2fbb7ac5780d620af0eafe7ce643da9d8

data/CHANGELOG.md

@@ -6,6 +6,16 @@ public API may change between minor versions.
 
 ## [Unreleased]
 
+## [0.1.2]
+
+### Fixed
+
+- Tooltips on pie, donut and polar area charts rendered as an empty box. A
+  circular chart hands the tooltip a flat array of numbers and names the
+  hovered slice with `seriesIndex`; reading it as one array per series gave
+  every value `undefined`, and rows without a value are dropped. The slice now
+  shows its name and its formatted value.
+
 ## [0.1.1]
 
 ### Fixed
@@ -57,6 +67,7 @@ First release.
   reachable only by hovering a mark
 - Animation stops when the reader has asked for reduced motion
 
-[Unreleased]: https://github.com/getrailsui/railsui_charts/compare/v0.1.1...HEAD
+[Unreleased]: https://github.com/getrailsui/railsui_charts/compare/v0.1.2...HEAD
+[0.1.2]: https://github.com/getrailsui/railsui_charts/compare/v0.1.1...v0.1.2
 [0.1.1]: https://github.com/getrailsui/railsui_charts/compare/v0.1.0...v0.1.1
 [0.1.0]: https://github.com/getrailsui/railsui_charts/releases/tag/v0.1.0

data/app/javascript/controllers/railsui_chart_controller.js

@@ -128,8 +128,23 @@ export default class extends Controller {
       ...options,
       tooltip: {
         ...(options.tooltip || {}),
-        custom: ({ series, dataPointIndex, w }) => {
+        custom: ({ series, seriesIndex, dataPointIndex, w }) => {
           const labels = w.globals.categoryLabels?.length ? w.globals.categoryLabels : w.globals.labels
+
+          // A pie, donut or polar area hands back one number per slice rather
+          // than one array per series, and names the hovered slice with
+          // seriesIndex — dataPointIndex means nothing there. Read as a
+          // cartesian series, every value came out undefined, and since rows
+          // without a value are dropped the tooltip rendered as an empty box.
+          if (!Array.isArray(series[0])) {
+            const slice = seriesIndex ?? dataPointIndex
+            // No row label: the slice's name is already the heading, and
+            // printing it twice in a two-line tooltip reads as a mistake.
+            const row = { label: "", value: series[slice], color: w.globals.colors[slice], format: rowFormats[slice] || null }
+
+            return this.tooltipMarkup(labels?.[slice], [row], null, format)
+          }
+
           const point = (index) => series[index]?.[dataPointIndex]
           const comparing = series.length === 2 && comparedDates.length > 0
 

data/lib/generators/railsui_charts/install/templates/railsui_chart_controller.js

@@ -128,8 +128,23 @@ export default class extends Controller {
       ...options,
       tooltip: {
         ...(options.tooltip || {}),
-        custom: ({ series, dataPointIndex, w }) => {
+        custom: ({ series, seriesIndex, dataPointIndex, w }) => {
           const labels = w.globals.categoryLabels?.length ? w.globals.categoryLabels : w.globals.labels
+
+          // A pie, donut or polar area hands back one number per slice rather
+          // than one array per series, and names the hovered slice with
+          // seriesIndex — dataPointIndex means nothing there. Read as a
+          // cartesian series, every value came out undefined, and since rows
+          // without a value are dropped the tooltip rendered as an empty box.
+          if (!Array.isArray(series[0])) {
+            const slice = seriesIndex ?? dataPointIndex
+            // No row label: the slice's name is already the heading, and
+            // printing it twice in a two-line tooltip reads as a mistake.
+            const row = { label: "", value: series[slice], color: w.globals.colors[slice], format: rowFormats[slice] || null }
+
+            return this.tooltipMarkup(labels?.[slice], [row], null, format)
+          }
+
           const point = (index) => series[index]?.[dataPointIndex]
           const comparing = series.length === 2 && comparedDates.length > 0
 

data/lib/railsui_charts/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsuiCharts
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: railsui_charts
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Andy Leverenz