rails_validations 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca94580d4d2e98cbf041af91b800f16ddbf00510
-  data.tar.gz: 08b0d19a8afb7578b6304803f0e58833f3fdfe92
+  metadata.gz: fc1dd77a7c0210226a3a1d51326400739d74839b
+  data.tar.gz: a6d84e924ef157d550e5a1d560eebb69d6801902
 SHA512:
-  metadata.gz: 36e62bff1d8386a26e4a9791d40d88e7d9e46588bfec526eae1ec29da3dd0acb952ab1af95ac759f1354bd14b21d37d1385e279f2f2e52bd32a089a5afbd640f
-  data.tar.gz: 85b6b3f4a22432c73b4bd3e7e282e7ea512f0b8629562fe56205dd2d326a23b00461887c1620beddf6a1d7a820186e15670add9419b06b9774de2c034f1d25f2
+  metadata.gz: 354295b2cd7f84d48ac1cc619da220cf79ae65205f876118da20bb626fa69f8304d3808836ebc6dcbeb012c165417cceedddf3282bbe8234a7a373d6eaa38d02
+  data.tar.gz: 05fd3b1468787d6252cc663b0fafe84ed6986142133cb523f755bc9d8aabba9661651e3efaacff55eff9cb0b7c5bdc055da629b811e34ba36162e42a03928cf6

data/README.markdown

@@ -1,10 +1,24 @@
-A few extra validations for rails.
+[![Gem Version](https://badge.fury.io/rb/rails_validations.svg)](http://badge.fury.io/rb/rails_validations)
+[![Build Status](https://travis-ci.org/bluerail/rails_validations.svg)](https://travis-ci.org/bluerail/rails_validations)
+[![Dependency Status](https://gemnasium.com/bluerail/rails_validations.svg)](https://gemnasium.com/bluerail/rails_validations)
+[![Inline docs](http://inch-ci.org/github/bluerail/rails_validations.svg?branch=master)](http://inch-ci.org/github/bluerail/rails_validations)
+
+
+A few extra validations for Rails.
+
+We try to do the ‘sane’ thing by not being too strict, when in doubt, we accept
+input as being valid. We never want to reject valid input as invalid.
+
+For many formats doing a 100% foolproof check is not trivial, email addresses
+are a famous example, but it also applies to other formats.  
+Regardless, you can never be sure it’s what the user *intended* anyway. For
+example, email validators will accept `artin@ico.nl` as being ‘valid’, even
+though my email address is `martin@lico.nl.`.  
 
-[RubyGems.org entry](http://rubygems.org/gems/rails_validations)
 
 date
 ----
-Validate if a column is a valid date, and if it's before or after another date.
+Validate if a column is a valid date, and if it’s before or after another date.
 
     validates :date_column, date: true
     validates :date_column, date: { after: Date.today }
@@ -13,28 +27,36 @@ Validate if a column is a valid date, and if it's before or after another date.
     validates :date_column, date: { before: Date.today }
     validates :date_column, date: { before_or_equal_to: Date.today }
 
-    # Check if the column `enddate` is after the value of the column `begindate`
+Check if the column `enddate` is after the value of the column `begindate`:
+
     validates :begindate, date: true
     validates :enddate, date: { after: :begindate }
 
 
 domain
 ------
-Validate if a string is a valid domain. This should work with [IDN](idn).
+Validate if a string looks like a valid domain. This should work with [IDN](idn).
+
+This will accept `lico.nl`, but rejects `martin@lico.nl`:
 
     validates :domain_column, domain: true
 
-    # Set a minimum/maximum number of domain parts (aka. labels)
+Set a minimum/maximum number of domain parts (aka. labels), this will accept
+`lico.nl`, but rejects `lico`:
+
     validates :domain_column, domain: { min_domain_parts: 2 }
+
+Accept `lico.nl`, but reject `www.lico.nl`:
+
     validates :domain_column, domain: { max_domain_parts: 2 }
 
 
 email
 -----
-Do a basic checks for emails. Not that this check is *not* very strict, it is
-nigh-impossible to check if an email address is valid (and even if it is, it's
-no guarantee if emails actually gets delivered to this address). This should
-work with unicode addresses ([RFC 6531][rfc6531], [IDN][idn]).
+Validate if a string looks liek an email address. This should work with unicode
+addresses ([RFC 6531][rfc6531], [IDN][idn]).
+
+Accepts `martin@lico.nl`, but rejects `martinlico.nl` or `martin@lico`
 
     validates :email_column, email: true
 
@@ -49,8 +71,10 @@ Check if this is a valid IBAN account number. This uses the
 
 phone
 -----
-Check if this is a valid phone number. As with the Email check, this isn't
-particularly strict; conventions for writing phone numbers vary a lot.
+Check if this is a valid phone number. This should work with most, if not all,
+writing conventions. We consider a phone to be valid if it consists of numbers &
+any number of ` \-.()`; a country code at the start indicated with `+` is also
+accepted.
 
     validates :phone_column, phone: true
 
@@ -73,10 +97,17 @@ Currently implemented countries:
 ChangeLog
 =========
 
+version 1.1.2, 20141201
+-----------------------
+- Fix typo in Dutch translation.
+- Update some docs.
+
+
 version 1.1.1, 20141013
 -----------------------
-- Fix i18n key for `phone`
-- Allow passing a Proc to `date` without an argument
+- Fix i18n key for `phone`.
+- Allow passing a Proc to `date` without an argument.
+
 
 version 1.1, 20141003
 ---------------------

data/config/locales/nl.yml

@@ -1,7 +1,7 @@
 nl:
   rails_validations:
     email:
-      invalid: geen geldig E-mailaddress
+      invalid: geen geldig e-mailaddress
 
     date:
       invalid: geen geldige datum

data/lib/validators/date_validator.rb

@@ -1,3 +1,15 @@
+# Validate if a column is a valid date, and if it's before or after another date.
+# 
+#  validates :date_column, date: true
+#  validates :date_column, date: { after: Date.today }
+#  validates :date_column, date: { after_or_equal_to: Date.today }
+#  validates :date_column, date: { equal_to: Date.today }
+#  validates :date_column, date: { before: Date.today }
+#  validates :date_column, date: { before_or_equal_to: Date.today }
+# 
+# Check if the column `enddate` is after the value of the column `begindate`
+#   validates :begindate, date: true
+#   validates :enddate, date: { after: :begindate }
 class DateValidator < ActiveModel::EachValidator
   CHECKS = {
     # These keys make the most sense for dates

data/lib/validators/domain_validator.rb

@@ -1,3 +1,11 @@
+# Validate if a string is a valid domain. This should work with [IDN](idn).
+#
+#  validates :domain_column, domain: true
+#
+# Set a minimum/maximum number of domain parts (aka. labels)
+#
+#  validates :domain_column, domain: { min_domain_parts: 2 }
+#  validates :domain_column, domain: { max_domain_parts: 2 }
 class DomainValidator < ActiveModel::EachValidator
   #\A[a-zA-Z\d-]{,63}\z
   REGEXP = /

data/lib/validators/iban_validator.rb

@@ -1,5 +1,5 @@
+# Check if this is a valid IBAN number; we use the +iban_tools+ gem for this.
 class IbanValidator < ActiveModel::EachValidator
-
   def validate_each record, attribute, value
     require 'iban-tools'
 

data/lib/validators/phone_validator.rb

@@ -1,3 +1,5 @@
+# Basic check for a telephone number; this should work with most, of not all,
+# writing conventions.
 class PhoneValidator < ActiveModel::EachValidator
   REGEXP = /\A
     (\(?\+\d+\)?)?    # optional country code

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_validations
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Martin Tournoij
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-13 00:00:00.000000000 Z
+date: 2014-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -42,16 +42,16 @@ dependencies:
   name: iban-tools
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement