rails_validations 1.0 → 1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df7a1d3faea070ed50a78256af355989bc2f7703
-  data.tar.gz: 5f0817c861fc63425c5d1f2bf2b45fc50a7c6588
+  metadata.gz: 1dbffdfff5db9e79c428f0f63703e7823f48ad06
+  data.tar.gz: 20b3a0d8aa8c014eb0bf13d145e856dc229dcdd3
 SHA512:
-  metadata.gz: a3ec178acd0a6744f6b57c8e2e4d276180b96aa45c71a7a2c2640a1ebcdb38df1cb196534583b449f58bb423d11b89062a4f4a78be3dc81c8be75e612d11f8bd
-  data.tar.gz: f5dedfc45b7943e5b820b56822ddd5686b5dbc5d9f3598156c195ee9e06cda3b18ddd9af6274611426a8571b373e5577a4c8e651073d2a8d96d2ce29a4b9a3e4
+  metadata.gz: 375251bca3b2ced7f504d983fdcccbe7687b9f5d9513cf6ae1b8483e831e7f813010e4d4039ee04b43e0b483bebf60af5ff9eeaa47af2b83b0848bad17c0dbfc
+  data.tar.gz: 49e34e36be5bf2f9818b3b4e34c54ce3c92917b24ab78a708e6ed4ada6c5f1faed0a32c19a65410ade7b0581e528dcc720d70f94b4d7625daf0851f299637d65

data/README.markdown

@@ -1,10 +1,89 @@
-Extra validations for rails:
+A few extra validations for rails.
 
-- date
-- domain
-- email
-- iban
-- phone
-- postal\_code
+[RubyGems.org entry](http://rubygems.org/gems/rails_validations)
 
-This needs to be documented...
+date
+----
+Validate if a column is a valid date, and if it's before or after another date.
+
+    validates :date_column, date: true
+    validates :date_column, date: { after: Date.today }
+    validates :date_column, date: { after_or_equal_to: Date.today }
+    validates :date_column, date: { equal_to: Date.today }
+    validates :date_column, date: { before: Date.today }
+    validates :date_column, date: { before_or_equal_to: Date.today }
+
+    # Check if the column `enddate` is after the value of the column `begindate`
+    validates :begindate, date: true
+    validates :enddate, date: { after: :begindate }
+
+
+domain
+------
+Validate if a string is a valid domain. This should work with [IDN](idn).
+
+    validates :domain_column, domain: true
+
+    # Set a minimum/maximum number of domain parts (aka. labels)
+    validates :domain_column, domain: { min_domain_parts: 2 }
+    validates :domain_column, domain: { max_domain_parts: 2 }
+
+
+email
+-----
+Do a basic checks for emails. Not that this check is *not* very strict, it is
+nigh-impossible to check if an email address is valid (and even if it is, it's
+no guarantee if emails actually gets delivered to this address). This should
+work with unicode addresses ([RFC 6531][rfc6531], [IDN][idn]).
+
+    validates :email_column, email: true
+
+
+iban
+----
+Check if this is a valid IBAN account number. This uses the
+[iban-tools][iban-tools] gem.
+
+    validates :iban_column, iban: true
+
+
+phone
+-----
+Check if this is a valid phone number. As with the Email check, this isn't
+particularly strict; conventions for writing phone numbers vary a lot.
+
+    validates :phone_column, phone: true
+
+
+postal\_code
+------------
+Check if this is a valid postal code (or zip code for the states).
+
+    validates :postal_code_column, postal_code: { country: :nl }
+
+    # Country defaults to I18n.locale
+    validates :postal_code_column, postal_code: true
+
+
+Currently implemented countries:
+
+- `nl` - The Netherlands
+
+
+ChangeLog
+=========
+
+version 1.1, 20141003
+---------------------
+- Make the date validation work if the column it points to is `nil`.
+- Add documentation.
+
+
+version 1.0, 20140905
+---------------------
+- Initial release.
+
+
+[idn]: http://en.wikipedia.org/wiki/Internationalized_domain_name).
+[rfc6531]: https://tools.ietf.org/html/rfc6531
+[iban-tools]: https://github.com/iulianu/iban-tools

data/lib/validators/date_validator.rb

@@ -23,7 +23,7 @@ class DateValidator < ActiveModel::EachValidator
             elsif raw_value.respond_to? :to_date
               raw_value.to_date
             else
-              record.errors.add attribute, I18n.t('rails_validations.date.invalid')
+              false
             end
 
             #elsif raw_value.is_a?(Symbol) || raw_value.is_a?(String)
@@ -48,6 +48,11 @@ class DateValidator < ActiveModel::EachValidator
                        raise ArgumentError
                      end
 
+      unless option_value
+        record.errors.add attribute, I18n.t('rails_validations.date.invalid')
+        return
+      end
+
       unless value.send CHECKS[option], option_value
         record.errors.add attribute, I18n.t("rails_validations.date.#{option}", date: I18n.l(option_value))
       end

data/spec/spec_helper.rb

@@ -45,11 +45,13 @@ module ValidationsSpecHelper
 
     def v; @value end
     def v= v; @value = v end
+    def v2; @value2 end
+    def v2= v; @value2 = v end
   end
 
 
-  def model v
-    described_class.new v: v
+  def model v, v2=nil
+    described_class.new v: v, v2: v2
   end
 
 

data/spec/validations/date_spec.rb

@@ -15,7 +15,6 @@ describe ValidationsSpecHelper::Date do
     with_validation 'date: true' do
       expect(model(Date.today).valid?).to eq(true)
       expect(model(Time.now).valid?).to eq(true)
-
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_validations
 version: !ruby/object:Gem::Version
-  version: '1.0'
+  version: '1.1'
 platform: ruby
 authors:
 - Martin Tournoij
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-05 00:00:00.000000000 Z
+date: 2014-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -66,7 +66,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-description: Extra validations for rails
+description: 'Extra validations for rails: date, domain, email, iban, phone, postal_code'
 email:
 - martin@lico.nl
 executables: []