rails_utils 3.2.1 → 3.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5eb6e346f134dad9cadcfd495c7d487b55c1d313
-  data.tar.gz: ae22be9cde9ae97cf0b19cb6d3f9dd96b87f76f6
+  metadata.gz: 7166c5b4a4b5666c7f5437f05141d887be49262d
+  data.tar.gz: 02cef886ad60d0c220f6c1d58fc6590136f53bde
 SHA512:
-  metadata.gz: 99b8f9431614ae786e11c74e955d3447aca32cb3eed01241841c13442a5be0efae2bdb932c67b469c7cdc8035585e9364fe9c4daef79fafbd7127b0d12733e21
-  data.tar.gz: 45ff6ca55f5db9dbc8c0fc04f9cdd62e841ae5b5ed6ac15ab63692ab36f56055f80cbcedd03a703e16291192a33432e9fa0948fecfe0b33dd2e7af8af106b486
+  metadata.gz: 2e18e7c2f93768d6657bf9a07370c4260ec9768398ef2de01a4fa7e2f30ab5a2ed60927bd1d1e87fdd3c16195c63e043d6c7124662dfdee02e904078945d7844
+  data.tar.gz: 5f306f45b70d3f8b1d1314f72f76efac1e82c7c4061d0b82b7d98f1e86c6f7ddf21dd5d46dcfccba5c267c32ce296fc1ac39eb40697ab666ea40bda83c2c48a9

data/{README.markdown → README.md}

@@ -121,10 +121,16 @@ Minitest-ed. To run all tests, just run `rake` or `rake test`.
 
 ## Changelog
 
+_Version 3.2.2_
+
+- [Pull Request 5](https://github.com/winston/rails_utils/pull/5) - Minor updates - by @JuanitoFatas.
+
+
 _Version 3.2.1_
 
 - Update `page_title` to support I18n interpolation - by @JuanitoFatas.
 
+
 _Version 3.2.0_
 
 - Add `page_title` that supports I18n - by @huynhquancam.

data/lib/rails_utils.rb

@@ -33,24 +33,18 @@ module RailsUtils
       JS
     end
 
-    def flash_messages
-      html = ""
-      flash.each do |key, message|
-        html <<
-          content_tag(:div, class: "#{flash_class(key.to_sym)} fade in") do
-            content = ""
-            content << content_tag(:button, "x", type: "button", class: "close", "data-dismiss" => "alert")
-            content << message
-            content.html_safe
-          end
-      end
-      html.html_safe
+    def flash_messages(options = {})
+      flash.collect do |key, message|
+        next if message.blank?
+
+        content_tag(:div, content_tag(:button, "x", type: "button", class: "close", "data-dismiss" => "alert") + message, class: "#{flash_class(key)} fade in #{options[:class]}")
+      end.join("\n").html_safe
     end
 
     private
 
     def flash_class(key)
-      case key
+      case key.to_sym
         when :success
           "alert alert-success"
         when :notice

data/lib/rails_utils/version.rb

@@ -1,3 +1,3 @@
 module RailsUtils
-  VERSION = "3.2.1"
+  VERSION = "3.2.2"
 end

data/test/rails_utils_test.rb

@@ -1,9 +1,9 @@
 require 'test_helper'
 
 describe "RailsUtils::ActionViewExtensions" do
-  let(:controller)  { ActionController::Base.new }
-  let(:request)     { ActionDispatch::Request.new(flash: {}) }
-  let(:view)        { ActionView::Base.new }
+  let(:controller) { ActionController::Base.new }
+  let(:request)    { ActionDispatch::Request.new(flash: {}) }
+  let(:view)       { ActionView::Base.new }
 
   before do
     controller.request = request
@@ -37,14 +37,14 @@ describe "RailsUtils::ActionViewExtensions" do
   describe "#page_action_class" do
     # action_name, expected
     [
-        [ "index"  , "index"   ],
-        [ "show"   , "show"    ],
-        [ "new"    , "new"     ],
-        [ "create" , "new"     ],
-        [ "edit"   , "edit"    ],
-        [ "update" , "edit"    ],
-        [ "destroy", "destroy" ],
-        [ "custom" , "custom"  ],
+      [ "index"  , "index"   ],
+      [ "show"   , "show"    ],
+      [ "new"    , "new"     ],
+      [ "create" , "new"     ],
+      [ "edit"   , "edit"    ],
+      [ "update" , "edit"    ],
+      [ "destroy", "destroy" ],
+      [ "custom" , "custom"  ],
     ].each do |action_name, expected|
       describe "when ##{action_name}" do
         before { controller.stubs(:action_name).returns(action_name) }
@@ -79,7 +79,7 @@ describe "RailsUtils::ActionViewExtensions" do
     end
 
     describe 'when translation is missing' do
-      let(:action_name)     { "random" }
+      let(:action_name)  { "random" }
       let(:default_translation) { "#{controller_name.capitalize} #{action_name.capitalize}" }
 
       it "combines page_controller_class and page_action_class" do
@@ -88,22 +88,22 @@ describe "RailsUtils::ActionViewExtensions" do
     end
 
     describe 'when translation is avaiable' do
-      let(:action_name) { 'show' }
+      let(:action_name) { "show" }
 
-      before { I18n.backend.store_translations("en", {controller_name.to_sym => {action_name.to_sym => {title: "An awesome title"}}}) }
+      before { I18n.backend.store_translations("en", { controller_name.to_sym => { action_name.to_sym => { title: "An awesome title" } }}) }
 
-      it 'translates page title' do
-        view.page_title.must_equal 'An awesome title'
+      it "translates page title" do
+        view.page_title.must_equal "An awesome title"
       end
     end
 
-    describe 'when translation is avaiable + interpolations' do
-      let(:action_name) { 'show' }
+    describe "when translation is avaiable + interpolations" do
+      let(:action_name) { "show" }
 
-      before { I18n.backend.store_translations("en", {controller_name.to_sym => {action_name.to_sym => {title: "An awesome title, %{name}"}}}) }
+      before { I18n.backend.store_translations("en", { controller_name.to_sym => { action_name.to_sym => { title: "An awesome title, %{name}" } }}) }
 
-      it 'translates page title' do
-        view.page_title(name: 'bro').must_equal 'An awesome title, bro'
+      it "translates page title" do
+        view.page_title(name: "bro").must_equal "An awesome title, bro"
       end
     end
   end
@@ -118,7 +118,7 @@ describe "RailsUtils::ActionViewExtensions" do
     end
 
     describe "when controller name and action name are standard" do
-      let(:action_name)     { "custom" }
+      let(:action_name) { "custom" }
 
       it "invokes application" do
         view.javascript_initialization.must_match "Dummy.init();"
@@ -131,7 +131,7 @@ describe "RailsUtils::ActionViewExtensions" do
     end
 
     describe "when action name is create" do
-      let(:action_name)     { "create" }
+      let(:action_name) { "create" }
 
       it "replaces create with new" do
         view.javascript_initialization.must_match "Dummy.#{controller_name}.init_new();"
@@ -139,7 +139,7 @@ describe "RailsUtils::ActionViewExtensions" do
     end
 
     describe "when action name is update" do
-      let(:action_name)     { "update" }
+      let(:action_name) { "update" }
 
       it "replaces update with create" do
         view.javascript_initialization.must_match "Dummy.#{controller_name}.init_edit();"
@@ -157,9 +157,11 @@ describe "RailsUtils::ActionViewExtensions" do
     # alert-error  is for Bootstrap 2.3.2
     [
       [ :success , /alert alert-success/            , "flash is success" ],
+      [ "success", /alert alert-success/            , "flash is success" ],
       [ :notice  , /alert alert-info/               , "flash is notice"  ],
       [ "notice" , /alert alert-info/               , "flash is notice"  ],
       [ :error   , /alert alert-danger alert-error/ , "flash is error"   ],
+      [ "error"  , /alert alert-danger alert-error/ , "flash is error"   ],
       [ :alert   , /alert alert-danger alert-error/ , "flash is alert"   ],
       [ "alert"  , /alert alert-danger alert-error/ , "flash is alert"   ],
       [ :custom  , /alert alert-custom/             , "flash is custom"  ],
@@ -180,12 +182,12 @@ describe "RailsUtils::ActionViewExtensions" do
 
     describe "when bootstrap is present" do
       it "can fade in and out" do
-        set_flash :alert  , "not important"
+        set_flash :alert, "not important"
         view.flash_messages.must_match /fade in/
       end
 
       it "can be dismissed" do
-        set_flash :alert  , "not important"
+        set_flash :alert, "not important"
         view.flash_messages.must_match /data-dismiss=.*alert/
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_utils
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 3.2.2
 platform: ruby
 authors:
 - Winston Teo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-11 00:00:00.000000000 Z
+date: 2014-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -75,7 +75,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - MIT-LICENSE
-- README.markdown
+- README.md
 - Rakefile
 - lib/rails_utils.rb
 - lib/rails_utils/version.rb
@@ -129,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Rails helpers based on opinionated project practices.