rails_url_shortener 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 964c9390d946bb5229d91c8760689cd5e001b7af1e3182b15e14087488c71a04
-  data.tar.gz: ee0971582ed1631913c0aa5ba8e43bbe4ecd5159931b9caa7723075363554102
+  metadata.gz: 4188bfea517eadff5ab16a22796513a39c6d50e3c51d63ad7a2025853299f644
+  data.tar.gz: 7e8ec534b52bc6ecba1f7ba4aab0f5e884a07cd4c208e5bf416ee75340555cf0
 SHA512:
-  metadata.gz: 216e49e0c1f9caba3b04fb5cebdcbf524a7525bc5a249031f3d29556fdfd7cff471652500c6b80166085b305087bfb050005140c52dc02f3f4d499d9421d1ec4
-  data.tar.gz: 194d5777d67c70bd659c227dc03e9b347e21396cf00c732453a74b552b2e8cc2b289e80489528d70376b6f3e5a7b113f40fbd84e458d27e64f2feeeb3311680d
+  metadata.gz: ffa940a3781070a35f1d6c681be0616a336230a967aae49fb418a9754847ffabd61e3540494c31bdf87fee71cfc3cd7bee808199b205e8ac8e9147d3f3f69da7
+  data.tar.gz: 85c07e0dd53da09ecb50069cd675c114921632333e5ba9d74daf59cd757ae34dfbe0f633f3aa572e9f8ba0f32ceb91c9a9a9f57ad380203551ef5ae29c0809ae

data/README.md

@@ -101,11 +101,12 @@ And finally install the migrations on your project and migrate:
 bin/rails rails_url_shortener:install:migrations db:migrate
 ```
 
-If you want the initializer for configurations do:
+For the configurations generate the initializer whith this:
 
 ```bash
 rails generate RailsUrlShortener:initializer
 ```
+**Here is important to configure the host at least if your are not running your app in localhost**
 
 ## Contributing
 

data/app/helpers/rails_url_shortener/urls_helper.rb

@@ -1,6 +1,13 @@
 module RailsUrlShortener
   module UrlsHelper
+    ##
+    # helper for generate short urls
+    #
+    # this method return a short url or the original url if something is bad
+    # Usage:
+    # short_url("https://tools.ietf.org/search/rfc2616#section-5.3")
     def short_url(url, owner: nil, key: nil, expires_at: nil, category: nil, url_options: {})
+      # generate
       url_object = Url.generate(
         url,
         owner: owner,
@@ -10,17 +17,18 @@ module RailsUrlShortener
       )
 
       if url_object.errors.empty?
-        # This must be fixed
-        # the url_for helper must generate the url
-        # options = {
-        #   controller: "rails_url_shortener_url/urls",
-        #   action: "show",
-        #   key: url.key
-        # }.merge(url_options)
+        # options for url_for
+        options = {
+          controller: "rails_url_shortener/urls",
+          action: "show",
+          key: url_object.key,
+          host: RailsUrlShortener.host
+        }.merge(url_options)
 
-        # url_for(options)
-        rails_url_shortener_url + url_object.key
+        # use helper of this engine
+        RailsUrlShortener::Engine.routes.url_for(options)
       else
+        # if not saved, return original url
         url
       end
     end

data/lib/generators/rails_url_shortener/templates/initializer.rb

@@ -4,6 +4,7 @@ CHARSETS = {
   alphanumcase: ('A'..'Z').to_a + ('a'..'z').to_a  + (0..9).to_a
 }
 
+RailsUrlShortener.host = "localhost:3000"           # the host used for the helper
 RailsUrlShortener.default_redirect = "/"            # where the users are redirect if the link doesn't exists or is expired.
 RailsUrlShortener.charset = CHARSETS[:alphanumcase] # used for generate the keys, better long.
 RailsUrlShortener.key_length = 6                    # Key length for random generator

data/lib/rails_url_shortener/version.rb

@@ -1,3 +1,3 @@
 module RailsUrlShortener
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/rails_url_shortener.rb

@@ -11,6 +11,10 @@ module RailsUrlShortener
     alphanumcase: ('A'..'Z').to_a + ('a'..'z').to_a  + (0..9).to_a
   }
 
+  ##
+  # host for build final url on helper
+  mattr_accessor :host, default: 'test.host'
+
   ##
   # default redirection url when the key isn't found
   mattr_accessor :default_redirect, default: '/'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_url_shortener
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - a-chacon
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-13 00:00:00.000000000 Z
+date: 2022-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -65,7 +65,6 @@ files:
 - README.md
 - Rakefile
 - app/controllers/rails_url_shortener/urls_controller.rb
-- app/helpers/rails_url_shortener/application_helper.rb
 - app/helpers/rails_url_shortener/urls_helper.rb
 - app/models/rails_url_shortener/application_record.rb
 - app/models/rails_url_shortener/url.rb
@@ -84,9 +83,9 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://www.github.com/a-chacon/rails_url_shortener/issues
-  changelog_uri: https://www.github.com/a-chacon/rails_url_shortener/releases/tag/v0.1.1
+  changelog_uri: https://www.github.com/a-chacon/rails_url_shortener/releases/tag/v0.1.2
   documentation_uri: https://github.com/a-chacon/rails_url_shortener/blob/main/README.md
-  source_code_uri: https://github.com/a-chacon/rails_url_shortener/tree/v0.1.1
+  source_code_uri: https://github.com/a-chacon/rails_url_shortener/tree/v0.1.2
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []

data/app/helpers/rails_url_shortener/application_helper.rb

@@ -1,4 +0,0 @@
-module RailsUrlShortener
-  module ApplicationHelper
-  end
-end