rails_twirp 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 34fc8b4e84ba8c456ac2fa01c3c35dd0fd11224360d6e21b832b5d17ed1f57a5
-  data.tar.gz: 9626b771c35bfdd034fa1dccad6ef5ed921aad0abdf3086bfe27a6b3b26f50b9
+  metadata.gz: 0ed88410115867b689de324aeaf99b91ba473d3aa573915d9bec5de1142b7986
+  data.tar.gz: dadc45ad3c6ed38f6791e8a45573127c69297772a7b0ae4861a2867dadf26d09
 SHA512:
-  metadata.gz: e4621381feff50a031faf89079aa49054d246bd52f0e9d0fe4fe588f3014c2dd9a779f249aa16ac15340d9e259b61e273b393dd6a69ecaa15b5bf76c29578434
-  data.tar.gz: e91d714d2ef9c5e6a45e34911a29de4c1927d2e8442c5bf3538c5c43f137c10010b0282d9a5f2d4c5901d9c1733191cd0e7ff4e2764d8ae546233798ef81d64b
+  metadata.gz: 976f3755035c22c65db62aa4b82e8019bf816e5e30cec968e19c5345630aa1b7c6d51d38439e267fde4d9696ce05667c5a2ed2566953bbe87a175ac2ea9df93f
+  data.tar.gz: f3c1460d7cd0ae988e8aabbb516afd1983b975e8aee872f295eb3017061a51500667ee1ecbd226f2260c03f179ad94560227710fc98095e0e60749288271d406

data/lib/rails_twirp/route_set.rb

@@ -50,12 +50,12 @@ module RailsTwirp
           method_name = rpc_info[:ruby_method]
 
           # Stolen from Rails in ActionDispatch::Request#controller_class_for
-          controller_name = mapping.controller.underscore
-          const_name = controller_name.camelize << "Controller"
           action_name = mapping.action
           response_class = rpc_info[:output_class]
 
           handler.define_method(method_name) do |req, env|
+            controller_name = mapping.controller.underscore
+            const_name = controller_name.camelize << "Controller"
             controller_class = ::ActiveSupport::Dependencies.constantize(const_name)
             controller_class.dispatch(action_name, req, response_class, env)
           end

data/lib/rails_twirp/testing/integration_test.rb

@@ -2,21 +2,40 @@ require "twirp/encoding"
 
 module RailsTwirp
   class IntegrationTest < ActiveSupport::TestCase
+    DEFAULT_HOST = "www.example.com"
     Response = Struct.new(:status, :body, :headers)
 
     attr_reader :response, :request, :controller
     attr_writer :mount_path
+    alias :mount_path! :mount_path=
 
     def initialize(name)
       super
       reset!
       @before_rpc = []
-      @mount_path = "/twirp"
+    end
+
+    def host
+      @host || DEFAULT_HOST
+    end
+    attr_writer :host
+    alias :host! :host=
+
+    def https?
+      @https
+    end
+
+    def https!(value = true)
+      @https = value
     end
 
     def reset!
       @request = nil
       @response = nil
+      @host = nil
+      @host = nil
+      @https = false
+      @mount_path = "/twirp"
     end
 
     def before_rpc(&block)
@@ -47,9 +66,13 @@ module RailsTwirp
     def build_rack_env(service, rpc, request, headers)
       env = {
         "CONTENT_TYPE" => request_content_type,
-        "HTTP_HOST" => "localhost",
+        "HTTPS" => https? ? "on" : "off",
+        "HTTP_HOST" => host,
         "PATH_INFO" => "#{@mount_path}/#{service.service_full_name}/#{rpc}",
-        "REQUEST_METHOD" => "POST"
+        "REQUEST_METHOD" => "POST",
+        "SERVER_NAME" => host,
+        "SERVER_PORT" => https? ? "443" : "80",
+        "rack.url_scheme" => https? ? "https" : "http"
       }
       if headers.present?
         http_request = ActionDispatch::Request.new(env)

data/lib/rails_twirp/version.rb

@@ -1,3 +1,3 @@
 module RailsTwirp
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/test/ping_controller_test.rb

@@ -11,7 +11,16 @@ class PingControllerTest < RailsTwirp::IntegrationTest
     req = RPC::DummyAPI::PingRequest.new(name: "Bouke")
     rpc RPC::DummyAPI::DummyService, "PingRender", req
     refute_instance_of Twirp::Error, response
-    assert_equal "http://localhost/twirp BoukeBouke", response.double_name
+    assert_equal "http://www.example.com/twirp BoukeBouke", response.double_name
+  end
+
+  test "you can ping render with host and https" do
+    host! "localhost"
+    https!
+    req = RPC::DummyAPI::PingRequest.new(name: "Bouke")
+    rpc RPC::DummyAPI::DummyService, "PingRender", req
+    refute_instance_of Twirp::Error, response
+    assert_equal "https://localhost/twirp BoukeBouke", response.double_name
   end
 
   test "you can ping template" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_twirp
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Bouke van der Bijl