rails_test_params_backport 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 93bbcda59b60c75f92f0d6897f123fdcf20749ac
-  data.tar.gz: 2a4b42950f02662b72ead546f5245e446515fd7d
+  metadata.gz: b7edb81ac6f46027c420b6e86701614fc4d18056
+  data.tar.gz: d5f88be4d18052c18219bb22c02df923b9c7dc33
 SHA512:
-  metadata.gz: 0d1423aafcc23433beb4f115ebe2849ea20d8cb5791c00fb8b2bec32fe9b38e85cb0e9edcc24474d2d1964a862735d9cd6f219f62b7c2d1ffaca74c51f7ecbc1
-  data.tar.gz: 484380ede8712c21f99e1f0c7436653b43b82c3cb96269aa9c8fc16bd1b311d085f32a3126aa0cb5c4f0793dc35d4a9d9e85e58d1cf7d88b2313e4b98dfd2a97
+  metadata.gz: 9d8b6fcabe876616e7404d5bb4bc6e00d816a48d469ce5ab88c541626c8eca95b639eb5a99f7eea380ff5c08eaf97eb0f9108d9b6b1e7b19808f0fee9382f5a6
+  data.tar.gz: 25538da8a2b103ab9329ca5a5e76f0cf5bb5b50a294566197547ea2c06c0ee8e35fb37d745d144ff1253c95bd738a17aac7f85dd874bb25684beb878e4ce65b2

data/lib/rails_test_params_backport.rb

@@ -3,6 +3,8 @@ require 'active_support'
 require 'action_dispatch'
 
 module RailsTestParamsBackport
+  ParameterError = Class.new(RuntimeError)
+
   ERROR_MESSAGE = <<-EOS.gsub(/^ {4}/, '')
     Test HTTP request methods will accept only
     the following keyword arguments in future Rails versions:
@@ -16,15 +18,11 @@ module RailsTestParamsBackport
   EOS
 
   class << self
-    def verify_parameters(parameters)
+    def offensive_parameters?(parameters)
       offensive_parameters = parameters.keys - %i(params headers env)
-      return if offensive_parameters.none?
-      raise RailsTestParamsBackport::ParameterError, ERROR_MESSAGE
+      offensive_parameters.any?
     end
   end
-
-  class ParameterError < RuntimeError
-  end
 end
 
 require 'rails_test_params_backport/rails3' if ActiveSupport::VERSION::MAJOR == 3

data/lib/rails_test_params_backport/rails3.rb

@@ -3,7 +3,9 @@ module RailsTestParamsBackport
     def process(action, parameters = nil, session = nil, flash = nil, http_method = 'GET')
       parameters = parameters.to_h
 
-      RailsTestParamsBackport.verify_parameters(parameters)
+      if RailsTestParamsBackport.offensive_parameters?(parameters) || session || flash
+        raise(ParameterError, ERROR_MESSAGE)
+      end
 
       headers = parameters.fetch(:headers, {})
       env = parameters.fetch(:env, {})
@@ -17,7 +19,9 @@ module RailsTestParamsBackport
     def process(method, path, parameters = nil, rack_env = nil)
       parameters = parameters.to_h
 
-      RailsTestParamsBackport.verify_parameters(parameters)
+      if RailsTestParamsBackport.offensive_parameters?(parameters) || rack_env
+        raise(ParameterError, ERROR_MESSAGE)
+      end
 
       headers = parameters.fetch(:headers, {})
       env = parameters.fetch(:env, {})

data/lib/rails_test_params_backport/rails4.rb

@@ -3,7 +3,9 @@ module RailsTestParamsBackport
     def process(action, http_method = 'GET', *args)
       parameters = args[0].to_h
 
-      RailsTestParamsBackport.verify_parameters(parameters)
+      if RailsTestParamsBackport.offensive_parameters?(parameters) || args.length > 1
+        raise(ParameterError, ERROR_MESSAGE)
+      end
 
       headers = parameters.fetch(:headers, {})
       env = parameters.fetch(:env, {})
@@ -17,7 +19,9 @@ module RailsTestParamsBackport
     def process(method, path, parameters = nil, headers_or_env = nil)
       parameters = parameters.to_h
 
-      RailsTestParamsBackport.verify_parameters(parameters)
+      if RailsTestParamsBackport.offensive_parameters?(parameters) || headers_or_env
+        raise(ParameterError, ERROR_MESSAGE)
+      end
 
       headers = parameters.fetch(:headers, {})
       env = parameters.fetch(:env, {})

data/lib/rails_test_params_backport/version.rb

@@ -1,3 +1,3 @@
 module RailsTestParamsBackport
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_test_params_backport
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Pierre Schambacher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-05 00:00:00.000000000 Z
+date: 2016-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -179,7 +179,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Write Rails 5 style tests in your Rails 3 or Rails 4 application.