rails_spreadsheet_reader 0.1.3 → 0.1.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTEzNTQyMTdkZmUwZmUzZjAwNmIwMTRmMDliZjJjOTFhODIxYjMyMg==
+    MTllZmRmOTIyYzY2OTRhMjRlMTM2NGNhODYyOWNlMDk3NmRiNWY4Yg==
   data.tar.gz: !binary |-
-    Y2ZiNGIwNDg5NDBlMTdmM2JhNTA2ZTVjYzk0NzNiZWVjMTFkY2EyYw==
+    NjQwOGJlNmE2ZGZhMWE1NTc2NTEzNDIyNTI2YzUwNGQ5Mjg1ZDEzYg==
 SHA512:
   metadata.gz: !binary |-
-    NWNjNzcyYjI4MjI3M2IxODA2NmVhNWY2MzRjZjZjNzU0Y2IzZTk5MTFiOWM3
-    OGViMDY5Y2YxYzRiYWRiNzU2ZjI1NzZhYjMzYzc5NGIxYzI2OWI4YWI2NDUw
-    NGU5NzM3ZGJhM2M1ZTM1MWMxZjMwNGZhOTU2MmEzZDJkZWQyODU=
+    NTdjNWQ1MjU1MTQzZTczNjVhNDdlZjdlZmU5NzA2ODc4ODYyZjgzZTFjMDU2
+    ZjRjN2Q5NTFkNWU4MjJjMDQ5NWM1MjBmMTNkNzRiY2IzZjliOGI5NjBjNmNm
+    NWIxZDgwM2ZmNjE0NDA3NGQ0NWZjYzkwNGJkNzAwM2Q2MDJlMjI=
   data.tar.gz: !binary |-
-    NTg0ZDM5NmQxNDI4YjhkOTA0NGE2MTJiYjY3OTA3NzVkYmEyNmUxYTVkYWI3
-    ZmNjMjY1YjUxOTQ3MzdlOGE5YTQxNjc4MmZjN2ZkNmRhYzkxM2JiNzgxNzIw
-    NWVmYTg4NjdmZWZjZjI5MzdkNDRjZjgxYzVjNGYyZTQyYWNiY2Q=
+    NDYwMTdmZDc1MmY2YWE4ZDczZGQ3ZDgxZjBhMzg2YzI4MzIwZTVhNDU3NGU3
+    M2U0ZGE1MDFmNmMzY2ZkOWRmYzdlYTgxODVlYzUzNjQzN2VmMzk5M2JhY2Vh
+    Yzk4OTQwMmM1Zjk1NTY3ZGY2ODYyM2ZiMTdkNjVhZTY0MDMzMTM=

data/lib/rails_spreadsheet_reader/base.rb

@@ -13,13 +13,28 @@ module RailsSpreadsheetReader
 
     attr_accessor :row_number
 
-    # Copy a ActiveModel::Model errors
-    def copy_errors(model)
-      model.errors.full_messages.each do |msg|
-        errors.add(:base, msg)
+    attr_accessor :models_with_errors
+
+    # Errors should be copied in a validation callback because valid?
+    # method flushes errors.
+    validate :copy_errors_on_validation
+
+    def copy_errors_on_validation
+      self.models_with_errors ||= []
+      self.models_with_errors.each do |model|
+        model.errors.full_messages.each do |msg|
+          errors.add(:base, msg)
+        end
       end
     end
 
+    # Models are added models_with_errors. They will be copied in to self.errors on
+    # copy_errors_on_validation callback
+    def copy_errors(model)
+      self.models_with_errors ||= []
+      self.models_with_errors << model
+    end
+
     # Defines the starting row of the excel where the class should start reading the data.
     #
     # == Returns:

data/lib/rails_spreadsheet_reader/version.rb

@@ -1,3 +1,3 @@
 module RailsSpreadsheetReader
-  VERSION = '0.1.3'
-end
+  VERSION = '0.1.4'
+end

data/spec/base_spec.rb

@@ -78,7 +78,7 @@ describe RailsSpreadsheetReader::Base do
     user_spreadsheet.errors.add(:username, 'is unique')
     expect(user_spreadsheet.valid?).to eq(false)
     expect(user_spreadsheet.invalid?).to eq(true)
-    valid = UserSpreadsheet.new
+    valid = EmptyColumnSpreadsheet.new
     valid.copy_errors(user_spreadsheet)
     expect(valid.valid?).to eq(false)
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_spreadsheet_reader
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - muzk
@@ -115,7 +115,6 @@ files:
 - rails_spreadsheet_reader.gemspec
 - spec/base_spec.rb
 - spec/files/users.csv
-- spec/files/users_duplicated.csv
 - spec/files/users_invalid.csv
 - spec/models/empty_column_spreadsheet.rb
 - spec/models/invalid_column_spreadsheet.rb
@@ -150,7 +149,6 @@ summary: Provides an easy way to add model-based validations to excel files.
 test_files:
 - spec/base_spec.rb
 - spec/files/users.csv
-- spec/files/users_duplicated.csv
 - spec/files/users_invalid.csv
 - spec/models/empty_column_spreadsheet.rb
 - spec/models/invalid_column_spreadsheet.rb

data/spec/files/users_duplicated.csv

@@ -1,2 +0,0 @@
-Username,Email
-user1,