rails_services 2.0.1 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8d4e1c031a6afe8e4b87061afdfe59288ec12f02
-  data.tar.gz: 32355b0c358064e2770dd211a5776dd30008da9a
+SHA256:
+  metadata.gz: d2f04402e73719510609114c229a41e0f81f0ebcb3bea04daf9805af3830ede4
+  data.tar.gz: 8d04e05060dbfe5ef9936f1c0bc0fd2835651765665328c105e4ec2e9741c81d
 SHA512:
-  metadata.gz: dfeaf7a546786158ee4cba951e8b06201efc786f78e564cdf444d968c5cdbab012360221d2e9f8ad97ca7e7e2c9f2d25e03857c028e5ec332afb20368b23fc40
-  data.tar.gz: abad3b5144c042d0628a019b1b5f57d0051a67f2323895f9c9ef795d6fff94947981a587258b13b7ab927e29b8ba30fd10f7da9d24c6a9af53d18f30a8d966c6
+  metadata.gz: b4aca48fb605ebba2f981e6bc58e4edf25692feb1302e3a34f722480d61d2d21c8ce24d616af504468eb42b3c13cf949480fbb7f84720f4a540757176967fbea
+  data.tar.gz: 3d3de55bd88596df2972fb1555a0fc7fbf51e99d45bc180c0f67b13d3eef51c6187ba9875661a5f9cdca255a24ab211d66c6f0f721a241bc206271a9becf3b2c

data/README.md

@@ -56,8 +56,8 @@ the following:
      class ClassName
        include BaseService
 
-     # Then ... change the method signatures, simply removing "self." from the definition
-     def self.call
+     # Then ... add an initialize method and change the method signatures, simply removing from the definition     
+     def call
        # ...
      end
      # becomes

data/lib/generators/rails_services/create_generator.rb

@@ -1,7 +1,9 @@
 module RailsServices
   class Generators
+    ##
+    # creates a service class
     class CreateGenerator < Rails::Generators::Base
-      source_root File.expand_path('../templates', __FILE__)
+      source_root File.expand_path('templates', __dir__)
       argument :service_name, type: :string
       argument :parent_name, type: :string
       argument :sub_folder, type: :string, default: ''
@@ -18,12 +20,13 @@ module RailsServices
       end
 
       private
+
       def copy_base_service_class
         template('base_service.rb.erb', 'app/services/base_service.rb') unless File.exist?('app/services/base_service.rb')
       end
 
       def create_test
-        if File.exists?('spec/spec_helper.rb')
+        if File.exist?('spec/spec_helper.rb')
           template 'base_service_spec.rb.erb', "spec/services/#{service_directory}/#{spec_file}"
         else
           template 'base_service_unit_test.rb.erb', "test/services/#{service_directory}/#{unit_file}"
@@ -31,7 +34,7 @@ module RailsServices
       end
 
       def service_directory
-        file_path = "#{parent_name.pluralize.underscore}"
+        file_path = parent_name.pluralize.underscore.to_s
         file_path += "/#{sub_folder.underscore}" if sub_folder.present?
         file_path
       end
@@ -51,21 +54,21 @@ module RailsServices
       def qualified_name
         name = "#{parent_name.pluralize.camelize}::"
         name += "#{sub_folder.camelize}::" if sub_folder.present?
-        name += "#{service_name.camelize}"
+        name += service_name.camelize.to_s
         name
       end
 
       def module_name
-        "#{parent_name.pluralize.camelize}"
+        parent_name.pluralize.camelize.to_s
       end
 
       def subfolder_name
-        "#{sub_folder.try(:camelize)}"
+        sub_folder.try(:camelize).to_s
       end
 
       def class_name
-        "#{service_name.camelize}"
+        service_name.camelize.to_s
       end
     end
   end
-end
+end

data/lib/generators/rails_services/destroy_generator.rb

@@ -1,5 +1,7 @@
 module RailsServices
   class Generators
+    ##
+    # destroys a service class
     class DestroyGenerator < Rails::Generators::Base
       argument :service_name, type: :string
       argument :parent_name, type: :string
@@ -13,14 +15,15 @@ module RailsServices
       end
 
       private
+
       def full_service_directory
-        file_path = "#{service_parent_directory}"
+        file_path = service_parent_directory.to_s
         file_path += "/#{sub_folder.underscore}" if sub_folder.present?
         file_path
       end
 
       def service_parent_directory
-        "#{parent_name.pluralize.underscore}"
+        parent_name.pluralize.underscore.to_s
       end
 
       def service_file
@@ -45,7 +48,6 @@ module RailsServices
       def parent_directory_empty?(directory_type)
         Dir["#{Rails.root}/#{directory_type}/services/#{service_parent_directory}/*"].empty?
       end
-
     end
   end
-end
+end

data/lib/generators/rails_services/templates/base_service.rb.erb

@@ -2,11 +2,10 @@
   <%= 'def self.included(base)' %>
     <%= 'base.extend ClassMethods' %>
   <%= 'end' %>
-
   <%= 'module ClassMethods' %>
     <%= 'def call(*args, &block)' %>
       <%= '@instance ||= self.new' %>
       <%= '@instance.call *args, &block' %>
     <%= 'end' %>
   <%= 'end' %>
-<%= 'end' %>
+<%= 'end' %>

data/lib/generators/rails_services/templates/base_service_new.rb.erb

@@ -1,23 +1,25 @@
 <%= "module #{module_name}" %>
-<% if subfolder_name.present? %>
+<% if subfolder_name.present? -%>
   <%= "module #{subfolder_name}" %>
-<% end  %>
-<% if subfolder_name.present? %>
+<% end -%>
+  <%= '##' %>
+  <%= "# #{qualified_name} Service Class"  %>
+<% if subfolder_name.present? -%>
     <%= "class #{class_name}" %>
       <%= 'include BaseService' %>
       <%= "# SAMPLE USAGE: #{qualified_name}.(*args)" %>
-      <%= 'def call' %>
-      <%= 'end' %>
+      <%= 'def initialize(_args);' %> <%= 'end' %>
+      <%= 'def call;' %> <%= 'end' %>
     <%= 'end' %>
-<% else %>
+<% else -%>
   <%= "class #{class_name}" %>
     <%= 'include BaseService' %>
     <%= "# SAMPLE USAGE: #{qualified_name}.(*args)" %>
-    <%= 'def call' %>
-    <%= 'end' %>
+    <%= 'def initialize(_args);' %> <%= 'end' %>
+    <%= 'def call;' %> <%= 'end' %>
   <%= 'end' %>
-<% end  %>
-<% if subfolder_name.present? %>
+<% end -%>
+<% if subfolder_name.present? -%>
   <%= 'end' %>
-<% end  %>
-<%= 'end' %>
+<% end -%>
+<%= 'end' %>

data/lib/generators/rails_services/templates/base_service_old.rb.erb

@@ -1,7 +1,7 @@
 <%= "module #{module_name}" %>
-<% if subfolder_name.present? %>
-  <%= "module #{subfolder_name}" %>
-<% end  %>
+<% if subfolder_name.present? %><%= "module #{subfolder_name}" %><% end  %>
+  <%= '##' %>
+  <%= "# #{qualified_name} Service Class"  %>
 <% if subfolder_name.present? %>
     <%= "class #{class_name}" %>
       <%= "# SAMPLE USAGE: #{qualified_name}.call(*args)" %>
@@ -15,7 +15,5 @@
     <%= 'end' %>
   <%= 'end' %>
 <% end  %>
-<% if subfolder_name.present? %>
-  <%= 'end' %>
-<% end  %>
-<%= 'end' %>
+<% if subfolder_name.present? %><%= 'end' %><% end  %>
+<%= 'end' %>

data/lib/generators/rails_services/templates/base_service_spec.rb.erb

@@ -4,4 +4,4 @@
       <%= 'skip' %>
     <%= 'end' %>
   <%= 'end' %>
-<%= 'end' %>
+<%= 'end' %>

data/lib/rails_services/version.rb

@@ -1,3 +1,3 @@
 module RailsServices
-  VERSION = '2.0.1'
+  VERSION = '2.5.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_services
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.5.0
 platform: ruby
 authors:
 - Craig Kaminsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-16 00:00:00.000000000 Z
+date: 2019-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -19,7 +19,7 @@ dependencies:
         version: '4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,9 +29,9 @@ dependencies:
         version: '4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '7'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -45,7 +45,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -59,7 +59,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest-reporters
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -116,7 +116,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A Ruby gem that adds a rails generator for creating service classes.