rails_performance 0.9.9 → 1.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6efdeeeb71789d08c284f21165138c13bdcb094cd0d48fcbaad521a946fec6f
-  data.tar.gz: 81b265d6bf3555fb2868504983ec3b01cf1efe9d99b4b4e74b08533d08ff2023
+  metadata.gz: d488f59068653fd127b680b6d2c067fbc23f85c84526d1259b2fb47dd3e25367
+  data.tar.gz: 6efcf5fb469225f298bf21b2812792acf771aebf27b623d747d4c46e29313dc3
 SHA512:
-  metadata.gz: 1f59e689a2b57a486b857cc910fccdf84fdc2a7afeee08f691a912aa3affcea5138f1be4f693699c06d9ac0c126c07f4b479e1434242d427581a413818d13fc7
-  data.tar.gz: 591b8b1334668e285fb8a23fdf01498e90b0f5d172378cce8abfd67af2d81f31046ee7520b1d1aad6c125cc61f13ef83f86dd6f2591eeb0fb1a2f89697518349
+  metadata.gz: 2513587de28e920769405e717488fe64725e780aa3f33f012e78078c7ece12afe873347c14ec450568066fbe7f2d031a3b04e164836dc3759725416ff5a95406
+  data.tar.gz: 87f823f42bbaf9c1491e49bbd194d8312ea395cb32372eac58fa97660b9a999c1de5106c5ab13d8ed28d63baebe6d2b8d8d05b933aece8ffaf4d5af338058417

data/README.md

@@ -18,7 +18,11 @@ It allows you to track:
 - total duration of time spent per request, views rendering, DB
 - SQL queries, rendering logs in "Recent Requests" section
 - simple 500-crashes reports
-- track Sidekiq jobs performance
+- Sidekiq jobs
+- Delayed Job jobs
+- Grape API inside Rails app
+- Rake tasks performance
+- Custom events wrapped with `RailsPerformance.measure do .. end` block
 - works with Rails 4.2+ (and probably 4.1, 4.0 too) and Ruby 2.2+
 
 All data are stored in `local` Redis and not sent to any 3rd party servers.
@@ -51,7 +55,8 @@ RailsPerformance.setup do |config|
   config.debug    = false # currently not used>
   config.enabled  = true
 
-  # default path where to mount gem
+  # default path where to mount gem,
+  # alternatively you can mount the RailsPerformance::Engine in your routes.rb
   config.mount_at = '/rails/performance'
 
   # protect your Performance Dashboard with HTTP BASIC password
@@ -98,10 +103,30 @@ You must also have installed Redis server, because this gem is storing data into
 
 After installation and configuration, start your Rails application, make a few requests, and open `https://localhost:3000/rails/performance` URL.
 
+### Alternative: Mounting the engine yourself
+
+If you, for whatever reason (company policy, devise, ...) need to mount RailsPerformance yourself, feel free to do so by using the following snippet as inspiration.
+You can skip the `mount_at` and `http_basic_authentication_*` configurations then, if you like.
+
+```ruby
+# config/routes.rb
+Rails.application.routes.draw do
+  ...
+  # example for usage with Devise
+  authenticate :user, -> (user) { user.admin? } do
+    mount RailsPerformance::Engine, at: 'rails/performance'
+  end
+end
+```
+
+
+
 ## How it works
 
 ![Schema](docs/rails_performance.png)
 
+In addition it's wrapping gems internal methods and collecting performance information. See `./lib/rails_performance/gems/*` for more information.
+
 ## Limitations
 
 - it doesn't track params of POST/PUT requests
@@ -146,7 +171,7 @@ The idea of this gem grew from curriosity how many RPM my app receiving per day.
 - better stats tooltip, do not show if nothing to show
 - dark mode toggle? save to the cookies?
 - integration with elastic search? or other?
-- monitor active job (sidekiq)?
+- monitor active job?
 - better logo?
 - number of requests last 24 hours, hour, etc.
 - collect deprecation.rails
@@ -154,6 +179,10 @@ The idea of this gem grew from curriosity how many RPM my app receiving per day.
 - show "loading banner" until jquery is loaded?
 - better UI on smaller screens? Recent requests when URL's are long? Truncate with CSS?
 - rules for highlighting durations? how many ms to show warning, alert
+- elastic search
+- searchkiq
+- sinatra?
+- tests to check what is actually stored in redis db after request
 
 ## Contributing
 

data/app/controllers/rails_performance/rails_performance_controller.rb

@@ -6,28 +6,20 @@ module RailsPerformance
 
     if RailsPerformance.enabled
       def index
-        @datasource                = RP::DataSource.new(**prepare_query, type: :requests, klass: RP::Models::Record)
+        @datasource                = RP::DataSource.new(**prepare_query, type: :requests)
         db                         = @datasource.db
 
-        @throughput_report         = RP::Reports::ThroughputReport.new(db)
-        @throughput_report_data    = @throughput_report.data
-
-        @response_time_report      = RP::Reports::ResponseTimeReport.new(db)
-        @response_time_report_data = @response_time_report.data
+        @throughput_report_data    = RP::Reports::ThroughputReport.new(db).data
+        @response_time_report_data = RP::Reports::ResponseTimeReport.new(db).data
       end
 
       def summary
-        @datasource                = RP::DataSource.new(**prepare_query, type: :requests, klass: RP::Models::Record)
+        @datasource                = RP::DataSource.new(**prepare_query, type: :requests)
         db                         = @datasource.db
 
-        @throughput_report         = RP::Reports::ThroughputReport.new(db)
-        @throughput_report_data    = @throughput_report.data
-
-        @response_time_report      = RP::Reports::ResponseTimeReport.new(db)
-        @response_time_report_data = @response_time_report.data
-
-        @report                    = RP::Reports::BreakdownReport.new(db, title: "Requests")
-        @data                      = @report.data
+        @throughput_report_data    = RP::Reports::ThroughputReport.new(db).data
+        @response_time_report_data = RP::Reports::ResponseTimeReport.new(db).data
+        @data                      = RP::Reports::BreakdownReport.new(db, title: "Requests").data
 
         respond_to do |format|
           format.js {}
@@ -36,9 +28,8 @@ module RailsPerformance
       end
 
       def trace
-        @record = RP::Models::Record.find_by(request_id: params[:id])
-        @report = RP::Reports::TraceReport.new(request_id: params[:id])
-        @data   = @report.data
+        @record = RP::Models::RequestRecord.find_by(request_id: params[:id])
+        @data   = RP::Reports::TraceReport.new(request_id: params[:id]).data
         respond_to do |format|
           format.js {}
           format.any { render plain: "Doesn't open in new window. Wait until full page load." }
@@ -46,38 +37,59 @@ module RailsPerformance
       end
 
       def crashes
-        @datasource   = RP::DataSource.new(**prepare_query({status_eq: 500}), type: :requests, klass: RP::Models::Record)
+        @datasource   = RP::DataSource.new(**prepare_query({status_eq: 500}), type: :requests)
         db            = @datasource.db
-        @report       = RP::Reports::CrashReport.new(db)
-        @data         = @report.data
+        @data         = RP::Reports::CrashReport.new(db).data
       end
 
       def requests
-        @datasource = RP::DataSource.new(**prepare_query, type: :requests, klass: RP::Models::Record)
+        @datasource = RP::DataSource.new(**prepare_query, type: :requests)
         db          = @datasource.db
-        @report     = RP::Reports::RequestsReport.new(db, group: :controller_action_format, sort: :count)
-        @data       = @report.data
+        @data       = RP::Reports::RequestsReport.new(db, group: :controller_action_format, sort: :count).data
       end
 
       def recent
-        @datasource = RP::DataSource.new(**prepare_query, type: :requests, klass: RP::Models::Record)
+        @datasource = RP::DataSource.new(**prepare_query, type: :requests)
         db          = @datasource.db
-        @report     = RP::Reports::RecentRequestsReport.new(db)
-        @data       = @report.data
+        @data       = RP::Reports::RecentRequestsReport.new(db).data
+      end
+
+      def sidekiq
+        @datasource                = RP::DataSource.new(**prepare_query, type: :sidekiq)
+        db                         = @datasource.db
+        @throughput_report_data    = RP::Reports::ThroughputReport.new(db).data
+        @response_time_report_data = RP::Reports::ResponseTimeReport.new(db).data
+        @recent_report_data        = RP::Reports::RecentRequestsReport.new(db).data
       end
 
-      def jobs
-        @datasource                = RP::DataSource.new(**prepare_query, type: :jobs, klass: RP::Models::JobRecord)
+      def delayed_job
+        @datasource                = RP::DataSource.new(**prepare_query, type: :delayed_job)
         db                         = @datasource.db
+        @throughput_report_data    = RP::Reports::ThroughputReport.new(db).data
+        @response_time_report_data = RP::Reports::ResponseTimeReport.new(db).data
+        @recent_report_data        = RP::Reports::RecentRequestsReport.new(db).data
+      end
 
-        @throughput_report         = RP::Reports::ThroughputReport.new(db)
-        @throughput_report_data    = @throughput_report.data
+      def custom
+        @datasource                = RP::DataSource.new(**prepare_query, type: :custom)
+        db                         = @datasource.db
+        @throughput_report_data    = RP::Reports::ThroughputReport.new(db).data
+        @response_time_report_data = RP::Reports::ResponseTimeReport.new(db).data
+        @recent_report_data        = RP::Reports::RecentRequestsReport.new(db).data
+      end
 
-        @response_time_report      = RP::Reports::ResponseTimeReport.new(db)
-        @response_time_report_data = @response_time_report.data
+      def grape
+        @datasource                = RP::DataSource.new(**prepare_query, type: :grape)
+        db                         = @datasource.db
+        @throughput_report_data    = RP::Reports::ThroughputReport.new(db).data
+        @recent_report_data        = RP::Reports::RecentRequestsReport.new(db).data
+      end
 
-        @recent_report             = RP::Reports::RecentRequestsReport.new(db)
-        @recent_report_data        = @recent_report.data(:jobs)
+      def rake
+        @datasource                = RP::DataSource.new(**prepare_query, type: :rake)
+        db                         = @datasource.db
+        @throughput_report_data    = RP::Reports::ThroughputReport.new(db).data
+        @recent_report_data        = RP::Reports::RecentRequestsReport.new(db).data
       end
 
       private

data/app/helpers/rails_performance/application_helper.rb

@@ -1,10 +1,10 @@
 module RailsPerformance
   module ApplicationHelper
-    def round_it(value)
+    def round_it(value, limit = 1)
       return nil unless value
       return value if value.is_a?(Integer)
 
-      value.nan? ? nil : value.round(1)
+      value.nan? ? nil : value.round(limit)
     end
 
     def duraction_alert_class(duration_str)
@@ -30,9 +30,15 @@ module RailsPerformance
       end
     end
 
-    def ms(value)
-      result = round_it(value)
-      result && result != 0 ? "#{result} ms" : '-'
+    def mss(value, limit = 1)
+      ms(value.to_f * 1000, limit)
+    end
+
+    def ms(value, limit = 1)
+      result = round_it(value, limit)
+      return '-' if result.nil?
+
+      result && result != 0 ? "#{result} ms" : '< 0 ms'
     end
 
     def short_path(path, length: 60)
@@ -65,6 +71,8 @@ module RailsPerformance
 
     def status_tag(status)
       klass = case status.to_s
+      when /error/
+        "tag is-danger"
       when /^5/
         "tag is-danger"
       when /^4/
@@ -73,6 +81,8 @@ module RailsPerformance
         "tag is-info"
       when /^2/
         "tag is-success"
+      when /success/
+        "tag is-success"
       else
         nil
       end
@@ -108,8 +118,16 @@ module RailsPerformance
         "is-active" if controller_name == "rails_performance" && action_name == "requests"
       when :recent
         "is-active" if controller_name == "rails_performance" && action_name == "recent"
-      when :jobs
-        "is-active" if controller_name == "rails_performance" && action_name == "jobs"
+      when :sidekiq
+        "is-active" if controller_name == "rails_performance" && action_name == "sidekiq"
+      when :delayed_job
+        "is-active" if controller_name == "rails_performance" && action_name == "delayed_job"
+      when :grape
+        "is-active" if controller_name == "rails_performance" && action_name == "grape"
+      when :rake
+        "is-active" if controller_name == "rails_performance" && action_name == "rake"
+      when :custom
+        "is-active" if controller_name == "rails_performance" && action_name == "custom"
       end
     end
   end

data/app/views/rails_performance/javascripts/app.js

@@ -22,7 +22,7 @@ function showTIRChart(div, data, addon, name) {
           },
           formatter: function() {
               if (this.y == 0) {
-                return '';
+                return 'n/a';
               }
             return this.y + addon;
           }
@@ -107,7 +107,7 @@ function showRTChart(div, data) {
           },
           formatter: function() {
               if (this.y == 0) {
-                return "";
+                return 'n/a';
               }
               return this.y + ' ms';
           }

data/app/views/rails_performance/rails_performance/_summary.html.erb

@@ -4,7 +4,7 @@
 <h2 class="subtitle">Average Response Time</h2>
 <div id="response_time_report_chart_mini" class="chart_mini"></div>
 
-<h2 class="subtitle"><%= @report.title %></h2>
+<h2 class="subtitle"><%= title %></h2>
 <table class="table is-fullwidth is-hoverable is-narrow is-size-7">
   <thead>
     <tr>

data/app/views/rails_performance/rails_performance/custom.html.erb

@@ -0,0 +1,83 @@
+<title>Custom Events</title>
+
+<% unless @datasource.default? %>
+  <%#= link_to raw("&larr; Back"), rails_performance_path, class: "back_link" %>
+<% end %>
+
+<div class="card">
+  <div class="card-content">
+    <h2 class="subtitle">Recent Events (last <%= RailsPerformance::Reports::RecentRequestsReport::TIME_WINDOW / 60 %> minutes)<h2>
+
+    <table class="table is-fullwidth is-hoverable is-narrow">
+      <thead>
+        <tr>
+          <th data-sort="string">Datetime</th>
+          <th data-sort="string">Tag</th>
+          <th data-sort="string">Namespace</th>
+          <th data-sort="string">Status</th>
+          <th data-sort="float">Duration</th>
+        </tr>
+      </thead>
+      <tbody>
+        <% if @recent_report_data.empty? %>
+          <tr>
+            <td colspan="5">
+              Nothing to show here. Try to make a few requests in the main app.
+
+              <pre>
+                <code>
+                  # in controller for example
+                  def index
+                    RailsPerformance.measure("stats calculation", "reports#index") do
+                      stats = User.calculate_stats
+                    end
+                  end
+                </code>
+              </pre>
+            </td>
+          </tr>
+        <% end %>
+        <% @recent_report_data.each do |e| %>
+          <tr>
+            <td><%= format_datetime e[:datetime] %></td>
+            <td><%= e[:tag_name] %></td>
+            <td><%= e[:namespace_name] %></td>
+            <td><%= status_tag e[:status] %></td>
+            <td class="nowrap"><%= ms e[:duration] %></td>
+          </tr>
+        <% end %>
+      </tbody>
+    </table>
+  </div>
+</div>
+
+<br/>
+
+<div class="card">
+  <div class="card-content">
+    <h2 class="subtitle">Custom Events Throughput Report</h2>
+    <div id="throughput_report_chart" class="chart"></div>
+    <p class="content is-small">All custom events in the application</p>
+  </div>
+</div>
+
+<br/>
+
+<div class="card">
+  <div class="card-content">
+    <h2 class="subtitle">Average Execution Time</h2>
+    <div id="response_time_report_chart" class="chart"></div>
+    <p class="content is-small">All custom events in the application</p>
+  </div>
+</div>
+
+
+<% content_for :on_load do %>
+  <script>
+    var data1 = <%= raw @throughput_report_data.to_json %>;
+    showTIRChart('throughput_report_chart', data1, ' events / minute', 'Events');
+
+    var data2 = <%= raw @response_time_report_data.to_json %>;
+    showRTChart('response_time_report_chart', data2);
+  </script>
+<% end %>

data/app/views/rails_performance/rails_performance/delayed_job.html.erb

@@ -0,0 +1,74 @@
+<title>Delayed::Job</title>
+
+<% unless @datasource.default? %>
+  <%#= link_to raw("&larr; Back"), rails_performance_path, class: "back_link" %>
+<% end %>
+
+<div class="card">
+  <div class="card-content">
+    <h2 class="subtitle">Delayed::Job Workers Throughput Report</h2>
+    <div id="throughput_report_chart" class="chart"></div>
+    <p class="content is-small">All workers in the application</p>
+  </div>
+</div>
+
+<br/>
+
+<div class="card">
+  <div class="card-content">
+    <h2 class="subtitle">Average Execution Time</h2>
+    <div id="response_time_report_chart" class="chart"></div>
+    <p class="content is-small">All workers in the application</p>
+  </div>
+</div>
+
+<br/>
+
+<div class="card">
+  <div class="card-content">
+    <h2 class="subtitle">Recent Jobs (last <%= RailsPerformance::Reports::RecentRequestsReport::TIME_WINDOW / 60 %> minutes)<h2>
+
+    <table class="table is-fullwidth is-hoverable is-narrow">
+      <thead>
+        <tr>
+          <th data-sort="string">Datetime</th>
+          <th data-sort="string">Job ID</th>
+          <th data-sort="string">Type</th>
+          <th data-sort="string">Class</th>
+          <th data-sort="string">Method</th>
+          <th data-sort="string">Status</th>
+          <th data-sort="float">Duration</th>
+        </tr>
+      </thead>
+      <tbody>
+        <% if @recent_report_data.empty? %>
+          <tr>
+            <td colspan="10">Nothing to show here. Try to make a few requests in the main app.</td>
+          </tr>
+        <% end %>
+        <% @recent_report_data.each do |e| %>
+          <tr>
+            <td><%= format_datetime e[:datetime] %></td>
+            <td><%= e[:jid] %></td>
+            <td><%= e[:source_type] %></td>
+            <td><%= e[:class_name] %></td>
+            <td><%= e[:method_name] %></td>
+            <td><%= status_tag e[:status] %></td>
+            <td class="nowrap"><%= ms e[:duration], 1 %></td>
+          </tr>
+        <% end %>
+      </tbody>
+    </table>
+  </div>
+</div>
+
+
+<% content_for :on_load do %>
+  <script>
+    var data1 = <%= raw @throughput_report_data.to_json %>;
+    showTIRChart('throughput_report_chart', data1, ' jobs / minute', 'Jobs');
+
+    var data2 = <%= raw @response_time_report_data.to_json %>;
+    showRTChart('response_time_report_chart', data2);
+  </script>
+<% end %>