rails_pending_migration_errors 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7eef8c4257d60313f2710c1dc334ee00ded3bcef
-  data.tar.gz: e3fa6ec2d241f6b2733ff0118f48841f52c24f0f
+  metadata.gz: 2a7eeed644aca9bc2ae160d7919bba47901ab4cd
+  data.tar.gz: c65db9bf6ce93b7b2fd32d9b7835c2013ea9b359
 SHA512:
-  metadata.gz: 04909b3bc42a3b5ace7fe31793502f81fb837c85dc2b8d5182bacba43773bc6920614cb565fe55639eeb204705186e6784b9029ceefad24c60a5387cdd2231e6
-  data.tar.gz: 01099cd05d31a4d1c03879dcb24aa73549dccdb15f0dc997c1c3b2c3b67a5554443a458c6ed8de0f5865bfeb7a78c0e852fc6aa1621f00ade22b7aa98f054beb
+  metadata.gz: 3ce97f8b0d78160a3ae15ee7cadf7be5265366af89a7f84744f736c5e353a46691d27a716fd790a539478b4d922bfb52ce4c1524203764b1fd8d2791a2779279
+  data.tar.gz: 07dc7c20e81ce6da82cc71a5050d71f96d3359ca6ddd17f03a428c6952970e661c82ddc435366c2a066221631620dff0239eb561fae1c1868caef709a64cba97

data/README.md

@@ -1,10 +1,8 @@
 # Rails Pending Migration Errors
 
-Raise errors in development mode when there are pending migrations to run.
+Append warnings or raise an exception in development mode when there are pending migrations to run.
 
-It is essentially a backport of [this feature](https://github.com/rails/rails/pull/6665) that made it in Rails 4.
-
-![Example](http://f.cl.ly/items/3a3Q0i3e1D0s12420t0v/Screen%20Shot%202013-10-09%20at%207.19.28%20PM.png "Example")
+It is inspired by [this feature](https://github.com/rails/rails/pull/6665) that made it in Rails 4.
 
 **Note:** this has only been tested against Rails 3.2.13 on ruby 2.0.0p247.
 
@@ -17,3 +15,9 @@ Add this line to your application's Gemfile:
 And then execute:
 
     $ bundle
+
+If you want to raise errors on page load instead of the default warning, add this to `config/environments/development.rb`:
+
+    config.after_initialize do
+      RailsPendingMigrationErrors.page_load = true
+    end

data/lib/rails_pending_migration_errors/middleware.rb

@@ -15,30 +15,50 @@ module RailsPendingMigrationErrors
     end
 
     def call(env)
-      ActiveRecord::Base.logger.quietly do
-        check_pending_migrations!
+      status, headers, response = @app.call(env)
+      response_body = nil
+
+      return [status, headers, response] unless html_request?(headers, response)
+
+      if RailsPendingMigrationErrors.needs_migrations?
+        if RailsPendingMigrationErrors.page_load
+          raise ActiveRecord::PendingMigrationError
+
+        else
+          response_body = append_response_body(headers, response)
+
+        end
       end
 
-      @app.call(env)
+      [status, headers, response_body ? [response_body] : response]
     end
 
     private
 
-    def check_pending_migrations!
-      raise ActiveRecord::PendingMigrationError if needs_migrations?
+    def append_response_body(headers, response)
+      response_body = response_body(response)
+      response_body << "<div #{footer_div_style}>Migrations are pending; run 'bin/rake db:migrate RAILS_ENV=#{::Rails.env}' to resolve this issue.</div>"
+      headers['Content-Length'] = response_body.bytesize.to_s
+      response_body
     end
 
-    def needs_migrations?
-      (file_versions - db_versions).size > 0
+    def html_request?(headers, response)
+      headers['Content-Type'] && headers['Content-Type'].include?('text/html') && response_body(response).include?("<html")
     end
 
-    def file_versions
-      ActiveRecord::Migrator.migrations( ActiveRecord::Migrator.migrations_paths ).map(&:version)
+    def response_body(response)
+      Array === response.body ? response.body.first : response.body
     end
 
-    def db_versions
-      ActiveRecord::Migrator.get_all_versions
+    def footer_div_style
+<<EOF
+style="position: fixed; bottom: 0; left: 0; cursor: pointer;
+       border-style: solid; border-color: red; border-width: 2px 2px 0 0;
+       padding: 6px; background: #FFB7B1; border-top-right-radius: 10px;
+       color: red; font-weight: bold; font-size: 18px; z-index: 100000;"
+EOF
     end
 
+
   end
 end

data/lib/rails_pending_migration_errors/version.rb

@@ -1,3 +1,3 @@
 module RailsPendingMigrationErrors
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/rails_pending_migration_errors.rb

@@ -3,4 +3,17 @@ require "rails_pending_migration_errors/middleware"
 require "rails_pending_migration_errors/rails"
 
 module RailsPendingMigrationErrors
+  mattr_accessor :page_load
+
+  def self.needs_migrations?
+    (file_versions - db_versions).size > 0
+  end
+
+  def self.file_versions
+    ActiveRecord::Migrator.migrations( ActiveRecord::Migrator.migrations_paths ).map(&:version)
+  end
+
+  def self.db_versions
+    ActiveRecord::Migrator.get_all_versions
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_pending_migration_errors
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Vincent Roy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-09 00:00:00.000000000 Z
+date: 2013-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler