rails_ops 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: c7a282f1eb15d57dad6975725b65767cd67154367d3990ec96360b76b317b14c
-  data.tar.gz: a7e9d4c6d3eef2b2166b2b1685f1c6908be6e23b215e1c7a6475d6f3d69e4cf6
+SHA1:
+  metadata.gz: '065973dd5cb31471910f1febb0abcf52d654cfba'
+  data.tar.gz: 533500fe5913bbb75f1629409268cd736c455ae7
 SHA512:
-  metadata.gz: 8ddb1d73625f62c2738112b7e459dd30d76b53a0c4897e9e3a52a20f4b1294b8867b2c8d044c8a998e5b2393edb0f0b208e0224ead5a6b281f1124772128be9f
-  data.tar.gz: 55624989107ab3de4dfd28f884f7c001172147d755f42986473ec6643f06ac868a4bf2bce4d85f8c305d25f23c35bef29a997239518b9059e3fad4d8f278a8ab
+  metadata.gz: c4fe791a2df0e6f23971661839e66c149940a8008e123c51bf42ce1810802944a6ccf63cc090719aaeeca842e5a8154dabdfedc9ab707c601901111c27d1a62c
+  data.tar.gz: b790df6bb1dcb2b74347d6e519dbac82b241d51c10e35bc72150706cb319ff4df51560bdbbd95576ca34b0f53090e5d0a5814e54e98821e8b7d19403a40cba75

data/CHANGELOG.md

@@ -1,5 +1,26 @@
 # Change log
 
+## 1.0.3 (2019-03-18)
+
+* Add missing imports of required third-party gems
+
+* Add policy chain `before_model_save` for model operations
+
+* Add policy chain `before_nested_model_ops` for model operations
+
+* If existing, use `ActiveSupport::ParameterFilter` over
+  `ActionDispatch::Http::ParameterFilter` which is deprecated in Rails 6
+
+* Fix error catching of nested model operations
+
+* Fix error handling of sub operations
+
+* Add `view` to operation contexts that contains the `view_context`. Only use
+  this for frontend operations that are always called from within a controller.
+
+* Expose `op_context` as a view helper method. This is useful for instantiating
+  new (view) operations from within views and helpers.
+
 ## 1.0.2 (2019-01-29)
 
 * Fix mass assignment protection errors under Rails 3

data/README.md

@@ -338,8 +338,8 @@ an appropriate exception.
 
 ### Policy chains
 
-As mentioned above, policies can be executed at 3 points in your operation's
-lifecycle. This is possible using *policy chains*:
+As mentioned above, policies can be executed at various points in your
+operation's lifecycle. This is possible using *policy chains*:
 
 - `:on_init`
 
@@ -351,6 +351,18 @@ lifecycle. This is possible using *policy chains*:
   Obviously this is never called if the operation is just instantiated and never
   run. This is the default chain.
 
+- `:before_model_save`
+
+  This only applies to operations deriving from `RailsOps::Operation::Model` and
+  its descendants. Policies in this chain run after nested model operations are
+  performed immediately before the "main" model is saved.
+
+- `:before_nested_model_ops`
+
+  This only applies to operations deriving from `RailsOps::Operation::Model` and
+  its descendants. Policies in this chain run after nested model operations are
+  performed before performing any nested model operations.
+
 - `:after_perform`
 
   Policies in this chain run immediately after the `perform` method is called.
@@ -464,6 +476,12 @@ operations. Contexts can include the following data:
   the operation context when calling an operation from a controller. This hash
   is used by {RailsOps::Mixins::Routes}.
 
+- View context
+
+  If the operation has been created from within a controller, the property
+  `view` includes the current view context. Only use this for frontend
+  operations that will always be called from a controller.
+
 - Called via hook
 
   `called_via_hook` is a boolean indicating whether or not this operation was

data/VERSION

@@ -1 +1 @@
-1.0.2
+1.0.3

data/lib/rails_ops.rb

@@ -1,3 +1,6 @@
+require 'schemacop'
+require 'request_store'
+
 module RailsOps
   AUTH_THREAD_STORAGE_KEY = :rails_ops_authorization_enabled
 

data/lib/rails_ops/context.rb

@@ -6,6 +6,7 @@ module RailsOps
     attribute :session
     attribute :called_via_hook
     attribute :url_options
+    attribute :view
 
     # For compatibility with rails < 4
     if defined?(attr_accessible)
@@ -15,6 +16,7 @@ module RailsOps
       attr_accessible :session
       attr_accessible :called_via_hook
       attr_accessible :url_options
+      attr_accessible :view
     end
 
     # Returns a copy of the context with the given operation added to the
@@ -26,7 +28,8 @@ module RailsOps
         session:         session,
         op_chain:        op_chain + [op],
         called_via_hook: false,
-        url_options:     url_options
+        url_options:     url_options,
+        view:            view
       )
     end
 

data/lib/rails_ops/controller_mixin.rb

@@ -22,6 +22,7 @@ module RailsOps
         helper_method :model
         helper_method :op
         helper_method :op?
+        helper_method :op_context
 
         after_action :ensure_operation_authorize_called!
       end
@@ -99,6 +100,7 @@ module RailsOps
         context.ability = current_ability if defined?(:current_ability)
         context.session = session
         context.url_options = url_options
+        context.view = view_context
         context
       end
     end

data/lib/rails_ops/mixins/model/nesting.rb

@@ -171,7 +171,7 @@ module RailsOps::Mixins::Model::Nesting
       # an exception happens here.
       begin
         op.run!
-      rescue op.validation_errors => e
+      rescue *op.validation_errors => e
         fail RailsOps::Exceptions::SubOpValidationFailed, e
       end
 

data/lib/rails_ops/mixins/policies.rb

@@ -5,7 +5,13 @@
 module RailsOps::Mixins::Policies
   extend ActiveSupport::Concern
 
-  POLICY_CHAIN_KEYS = [:on_init, :before_perform, :after_perform].freeze
+  POLICY_CHAIN_KEYS = [
+    :on_init,
+    :before_perform,
+    :after_perform,
+    :before_nested_model_ops,
+    :before_model_save
+  ].freeze
 
   included do
     class_attribute :_policy_chains

data/lib/rails_ops/mixins/sub_ops.rb

@@ -21,7 +21,7 @@ module RailsOps::Mixins::SubOps
 
     begin
       return op.run!
-    rescue op.validation_errors => e
+    rescue *op.validation_errors => e
       fail RailsOps::Exceptions::SubOpValidationFailed, e
     end
   end

data/lib/rails_ops/operation.rb

@@ -75,7 +75,15 @@ class RailsOps::Operation
 
   # Return a hash of parameters with all sensitive data replaced.
   def filtered_params
-    f = ActionDispatch::Http::ParameterFilter.new(Rails.application.config.filter_parameters)
+    if defined?(ActiveSupport::ParameterFilter)
+      # Rails >= 6
+      cls = ActiveSupport::ParameterFilter
+    else
+      # Rails < 6
+      cls = ActionDispatch::Http::ParameterFilter
+    end
+
+    f = cls.new(Rails.application.config.filter_parameters)
     return f.filter(params)
   end
 

data/lib/rails_ops/operation/model.rb

@@ -148,7 +148,9 @@ class RailsOps::Operation::Model < RailsOps::Operation
   # nested model operations, you should call this method instead of calling
   # `model.save!` directly.
   def save!
+    run_policies :before_nested_model_ops
     perform_nested_model_ops!
+    run_policies :before_model_save
     model.save!
   end
 

data/rails_ops.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: rails_ops 1.0.2 ruby lib
+# stub: rails_ops 1.0.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails_ops".freeze
-  s.version = "1.0.2"
+  s.version = "1.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2019-01-31"
+  s.date = "2019-03-18"
   s.files = [".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, ".travis.yml".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE.txt".freeze, "README.md".freeze, "RUBY_VERSION".freeze, "Rakefile".freeze, "VERSION".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_casting.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/model_mixins/virtual_model_name.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/patches/active_type_patch.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
   s.rubygems_version = "2.6.6".freeze
   s.summary = "An operations service layer for rails projects.".freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_ops
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Sitrox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-31 00:00:00.000000000 Z
+date: 2019-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -285,7 +285,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: An operations service layer for rails projects.