rails_ops 1.0.0.beta3 → 1.0.0.beta4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6e73b572936a8b96e078c9643cda027cc2153cb3
-  data.tar.gz: 795bc1c05411d76172846bd426a97088b9b90bb8
+  metadata.gz: 200bc5c12a821e07b6d10cfd18d1349c3005a1b3
+  data.tar.gz: 7dbf7c447bb0a472e28583ea0dc69d4f89ca185a
 SHA512:
-  metadata.gz: c965f3510959ead719a946a9468ed483e4a96fda98926b9aeb813e32fbd334929e418a11850064365c5c0c0a9d0595ecf00852cc4236ccd9b60a48ee3f617e12
-  data.tar.gz: 369a5561ed04ea12c2065dcbb57e859b329d17d6c9c76d78f223c5ccc9b7a57803b120082ea6f16f2e09dd94d74433f13d10b06f3589d150f8f77ef24bef335f
+  metadata.gz: 488428cdb605dd24250003a2d917200f46c86eab3906777489efcb19bca117c7e028a76412042e5a43f261c03c47726cd9780ba83f66ff2a2c92d2908e2e9f30
+  data.tar.gz: 417abae7e58449757d96885f22ab2ab92b70bb5ad08a27523d55c320e3f8b869ecba128f929a06bb431ca1ef5a5c963e3e8f2e16831733066359a3d949a90bd0

data/README.md

@@ -7,9 +7,9 @@ rails_ops
 
 This Gem introduces an additional service layer for Rails: *Operations*. An
 operation is in most cases a *business action* or *use case* and may or may not
-involve one or multiple models. Rails Ops allow creating more modular
-applications by splitting them up into its different operations. Each operation
-is specified in a single, testable class.
+involve one or multiple models. Rails Ops allows creating more modular
+applications by splitting them up into their different operations. Each
+operation is specified in a single, testable class.
 
 To achieve this goal, this Gem provides the following building blocks:
 
@@ -23,13 +23,13 @@ Operation Basics
 
 ### Placing and naming operations
 
-- Operations generally reside in `app/operations` and can be nested using various
-  subdirectories. They're all inside of the `Operations` namespace.
+- Operations generally reside in `app/operations` and can be nested using
+  various subdirectories. They're all inside of the `Operations` namespace.
 
 - Operations operating on a specific model should generally be namespaced with
   the model's class name. So for instance, the operation `Create` for the `User`
-  model should generally live under `app/operations/user/create.rb` and therefore
-  be called `Operations::User::Create`.
+  model should generally live under `app/operations/user/create.rb` and
+  therefore should be called `Operations::User::Create`.
 
 - Operations inheriting from other operations should generally be nested within
   their parent operation. See the next section for more details.
@@ -51,8 +51,8 @@ When declaring an operation within a namespace,
 - Determine whether the namespace you're using is a module or a class. Make sure
   you don't accidentally redefine a module as a class or vice-versa.
 
-- If the operation resides within a module, make a module definition on the first
-  line and the operation class on the second. Example:
+- If the operation resides within a module, make a module definition on the
+  first line and the operation class on the second. Example:
 
   ```ruby
   module Operations::Frontend::Navigation
@@ -958,7 +958,7 @@ source code for implementation details.
 ## Model authorization
 
 While you can use the standard `authorize!` method (see chapter *Authorization*)
-for authorizing models, RailsOps provides you a more convenient integration.
+for authorizing models, RailsOps provides a more convenient integration.
 
 ### Basic authorization
 
@@ -966,7 +966,7 @@ Model authorization can be performed via the operation instance methods
 `authorize_model!` and `authorize_model_with_authorize_only!` (see chapter
 *Authorization* for more information on the difference between these two).
 
-There two methods provide a simple wrapper around `authorize!` and
+These two methods provide a simple wrapper around `authorize!` and
 `authorize_only!` that casts the given model class or instance to an active
 record object. This is necessary if the given model class or instance is a
 (possibly anonymous) extension of an active record class for certain
@@ -1213,6 +1213,15 @@ while more specific operations can use `:update` or whatever. If we really need
 to check for `:read` when updating an object, it can be implemented in the
 ability class.
 
+## Change log
+
+### 1.0.0.beta4
+
+* Fix a bug where nested models are saved at build time in update operations in
+  some cases.
+
+* Start of change log.
+
 ## Copyright
 
 Copyright (c) 2017 Sitrox. See `LICENSE` for further details.

data/VERSION

@@ -1 +1 @@
-1.0.0.beta3
+1.0.0.beta4

data/lib/rails_ops/controller_mixin.rb

@@ -34,6 +34,7 @@ module RailsOps
       return @op
     end
 
+    # Determines whether an operation has been set.
     def op?
       !!@op
     end
@@ -65,20 +66,30 @@ module RailsOps
       return success
     end
 
+    # Returns the current operation's `model`. Fails with an exception if the
+    # current operation does not respond to the `model` (i.e. is not a model
+    # operation).
     def model
       return @model if @model
       fail 'Current operation does not support `model` method.' unless op.respond_to?(:model)
       return op.model
     end
 
+    # Filters the `params` hash for use with RailsOps. This removes certain
+    # web-specific parameters based on `EXCEPT_PARAMS`.
     def filter_op_params(params)
       (params || {}).except(*EXCEPT_PARAMS)
     end
 
+    # Filters operation params using `filter_op_params`, permits them using
+    # strong params and converts them to a hash. This method can be overridden
+    # for passing custom params to an operation for an entire controller.
     def op_params
       filter_op_params(params.permit!).to_h
     end
 
+    # Constructs and returns the operation context used for instantiating
+    # operations from within this controller.
     def op_context
       @op_context ||= begin
         context = RailsOps::Context.new

data/lib/rails_ops/mixins/model/nesting.rb

@@ -137,14 +137,18 @@ module RailsOps::Mixins::Model::Nesting
       # Instantiate nested operation
       @nested_model_ops[attribute] = sub_op(config[:klass], wrapped_params)
 
-      # Inject model of nested operation to our own model
+      # Inject model of nested operation to our own model. We directly set the
+      # association's target instead of using the standard setter method as the
+      # latter one can save the models in some occasions.
       nested_model = @nested_model_ops[attribute].model
-      model.send("#{attribute}=", nested_model)
+      model.association(attribute).target = nested_model
 
       # Inject our own model to model of nested operation (if the inverse
-      # reflection can be resolved)
+      # reflection can be resolved). We directly set the association's target
+      # instead of using the standard setter method as the latter one can save
+      # the models in some occasions.
       if (inverse_reflection = model.class.reflect_on_association(attribute).inverse_of)
-        nested_model.send("#{inverse_reflection.name}=", model)
+        nested_model.association(inverse_reflection.name).target = model
       end
     end
   end

data/rails_ops.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: rails_ops 1.0.0.beta3 ruby lib
+# stub: rails_ops 1.0.0.beta4 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails_ops".freeze
-  s.version = "1.0.0.beta3"
+  s.version = "1.0.0.beta4"
 
   s.required_rubygems_version = Gem::Requirement.new("> 1.3.1".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2017-06-20"
+  s.date = "2017-11-16"
   s.files = [".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, ".travis.yml".freeze, "Gemfile".freeze, "LICENSE.txt".freeze, "README.md".freeze, "RUBY_VERSION".freeze, "Rakefile".freeze, "VERSION".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_casting.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/protected_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/patches/active_type_patch.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/test_helper.rb".freeze]
   s.rubygems_version = "2.6.6".freeze
   s.summary = "An operations service layer for rails projects.".freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_ops
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta3
+  version: 1.0.0.beta4
 platform: ruby
 authors:
 - Sitrox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-20 00:00:00.000000000 Z
+date: 2017-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -245,7 +245,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: An operations service layer for rails projects.