rails_onboarding 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a343a9b6bbf7c81c4fc94b106a78cede4b1b240256dbb4941a4dc872d14c796
-  data.tar.gz: a93c58d4ef30dfe92b61d3062a3c8815cbb68b5ebc3e1aae970b5f1e497cb942
+  metadata.gz: 968d937235787bd7b4b096707cd9e44f2152d11c5b9d6f92f8f684d4b0807e98
+  data.tar.gz: f3b564a235899a551598ae48c9877ef5090261240a9e5b33cf0f63af6c155fc4
 SHA512:
-  metadata.gz: f59b87619ce223cb9efe7e4f4c6b3445e133b1d926a21c3e387dc1d6772d6e88eb7b03fe0f195e13879aa9a8bf837530d1824e22aaf59d70de0e11f8b8644311
-  data.tar.gz: 013a28a891c159d8867de01b83998ac5ce3bf91ab1e4c592c96f7b089df95129883f85902395b9d379603217913f841ef2b3f9b515b6ae031432c42f24a2bb19
+  metadata.gz: 35466bcb9f4c22021d9a8012cb4f0fc0bf3a2b3ccaeedf270f0681711d1a686e41b6a3e102b6a5084955ca7b0c2bc5ad84203b284303604b1e27c5c93a032a58
+  data.tar.gz: 1674b9b08636d82c3d71fb78b80d8aae49d7f7510f91ff948dbbf642c79ddf21118248d465bce33b84e5630c24ee37b04cdfc2d30542047cc50fa2469210babd

data/app/assets/javascripts/rails_onboarding/progress_controller.js

@@ -149,8 +149,8 @@ export default class extends Controller {
       </div>
     `
 
-        // Position tooltip (top/left are viewport-relative and computed per
-        // call, so they stay inline; everything else lives in .step-tooltip)
+        // Position tooltip (top/left are computed per call, so they stay inline;
+        // everything else lives in .step-tooltip)
         document.body.appendChild(tooltip)
         this.positionTooltip(tooltip, targetElement)
 
@@ -179,8 +179,12 @@ export default class extends Controller {
             top = rect.top - tooltipRect.height - 8
         }
 
-        tooltip.style.top = `${top}px`
-        tooltip.style.left = `${left}px`
+        // The maths above is all in viewport space (getBoundingClientRect,
+        // window.innerWidth/Height), but .step-tooltip is `position: absolute`
+        // on document.body, so add the scroll offset when applying. See the same
+        // conversion in tooltip_controller.js#positionTooltip.
+        tooltip.style.top = `${top + window.scrollY}px`
+        tooltip.style.left = `${left + window.scrollX}px`
     }
 
     // Advance to next step (for testing/demo purposes)

data/app/assets/javascripts/rails_onboarding/tooltip_controller.js

@@ -784,9 +784,16 @@ export default class extends Controller {
         
         let { position, top, left, arrowPosition } = bestPosition
 
-        // Apply position
-        this.tooltip.style.top = `${top}px`
-        this.tooltip.style.left = `${left}px`
+        // Apply position, converting viewport coordinates to document ones.
+        // Everything above - getBoundingClientRect, the edge clamping in
+        // calculatePosition, the collision checks in scorePosition - works in
+        // viewport space, but .onboarding-tooltip is `position: absolute` on
+        // document.body, so top/left are resolved against the document. Without
+        // the scroll offset the tooltip lands a full scroll position away from
+        // its trigger. Absolute (not fixed) is deliberate: it keeps the tooltip
+        // glued to the trigger if the page scrolls while it's open.
+        this.tooltip.style.top = `${top + viewport.scrollY}px`
+        this.tooltip.style.left = `${left + viewport.scrollX}px`
         
         // Style arrow based on final position
         if (arrow) {

data/lib/rails_onboarding/version.rb

@@ -1,3 +1,3 @@
 module RailsOnboarding
-  VERSION = "0.8.0"
+  VERSION = "0.8.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_onboarding
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - David Lewis
@@ -282,7 +282,7 @@ licenses:
 metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/bunnahabhain/rails_onboarding
-  source_code_uri: https://github.com/bunnahabhain/rails_onboarding/tree/v0.8.0
+  source_code_uri: https://github.com/bunnahabhain/rails_onboarding/tree/v0.8.1
   changelog_uri: https://github.com/bunnahabhain/rails_onboarding/blob/master/docs/CHANGELOG.md
 rdoc_options: []
 require_paths: