rails_modal_manager 1.0.12 → 1.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3731afb3a3d006cd6256e0e19780bb24e433153ca2f459807137ef52e0cfaf7
-  data.tar.gz: 6acd94d81d76b5490185a8675b8ddacd3a2759fe5f039f765ed23e31f17d4020
+  metadata.gz: 3aef02a89c60f4390647bdb318057751ef19caea49b2849ab1af859412267d54
+  data.tar.gz: aafa0a2b8165398b4f91dcb5ea3e3b013433550b227a0c6e0a5df9c6f2840b15
 SHA512:
-  metadata.gz: e81f5871bc33494bd283ac5adb41ca84571bfb9e3f9a23597e8a1b37ab1dfd62cd4033958030d2aaca80becc305593a68a0762d92d3d88c394d3ae80b693e22d
-  data.tar.gz: d87f1982e1dd5cb3df4c50f3ceea6a9fe1605ea789711528a89e942de5533d25fbdb8673d55a2d4b2e06ebc3305d9aeed27f58307c285887135f20bb873dd1ea
+  metadata.gz: f5e26d4b12715b984126fa2a4262a56e9f23a238fdc68c5c89c7179c159b7abb36fe93cb789be1f834ba51d720ace3bf66f24aa4a65266433ab166f8b30f68ad
+  data.tar.gz: af75896852ef1fc10956a6b8d305da635e074655dff95082234999de0b43ff379b58c22e5d39190007e28858af0e14819f57a67177de7841a34200c779491d5c

data/app/javascript/rails_modal_manager/controllers/rmm_modal_controller.js

@@ -147,6 +147,9 @@ export default class extends Controller {
     // Register close callback
     modalStore.registerCloseCallback(modalId, () => this.close('programmatic'))
 
+    // Move to persistent container (outside Turbo Frame) to survive navigation
+    this.moveToChildModalsContainer()
+
     // Add to history stack
     if (this.enableHistoryStackValue && !historyStackManager.hasHisData('modal', modalId)) {
       historyStackManager.addHisData('modal', modalId, () => this.close('history'))
@@ -682,9 +685,48 @@ export default class extends Controller {
       historyStackManager.removeMultipleHisData('modal', allModalIds)
     }
 
+    // Move modal DOM to persistent container (outside Turbo Frame)
+    // This ensures minimized modals survive Turbo Frame navigation
+    this.moveToChildModalsContainer()
+
     this.dispatch('minimize', { detail: { modalId: modalId } })
   }
 
+  /**
+   * Move modal (with wrapper if exists) to #child-modals-container
+   * This prevents DOM removal when Turbo Frame content is replaced
+   */
+  moveToChildModalsContainer() {
+    const container = document.getElementById('child-modals-container')
+    if (!container) return
+
+    const overlay = this.getOverlay()
+    const parent = this.element.parentElement
+
+    // Determine what to move: wrapper (if exists) or just modal
+    let elementToMove = this.element
+
+    // Check if parent is a wrapper (has data-controller and is not body/frame/container)
+    if (parent &&
+        parent.dataset.controller &&
+        parent.id !== 'child-modals-container' &&
+        parent.tagName !== 'TURBO-FRAME' &&
+        parent.tagName !== 'BODY') {
+      elementToMove = parent
+    }
+
+    // Skip if already in container
+    if (elementToMove.parentElement === container) return
+
+    // If overlay is outside the element to move, move it first
+    if (overlay && !elementToMove.contains(overlay) && overlay.parentElement !== container) {
+      container.appendChild(overlay)
+    }
+
+    // Move the element (modal or wrapper including overlay)
+    container.appendChild(elementToMove)
+  }
+
   maximize() {
     const modalId = this.effectiveModalId
     const config = modalStore.getModalConfig(modalId)
@@ -777,7 +819,18 @@ export default class extends Controller {
   // ============================================
 
   getOverlay() {
-    return document.getElementById(`${this.effectiveModalId}-overlay`)
+    const overlayId = `${this.effectiveModalId}-overlay`
+
+    // If this modal is inside child-modals-container, search there first
+    // This prevents finding duplicate overlays in turbo-frame
+    const container = document.getElementById('child-modals-container')
+    if (container && container.contains(this.element)) {
+      const overlayInContainer = container.querySelector(`#${overlayId}`)
+      if (overlayInContainer) return overlayInContainer
+    }
+
+    // Fallback to document-level search
+    return document.getElementById(overlayId)
   }
 
   hasAttribute(attr) {

data/lib/rails_modal_manager/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsModalManager
-  VERSION = "1.0.12"
+  VERSION = "1.0.13"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_modal_manager
 version: !ruby/object:Gem::Version
-  version: 1.0.12
+  version: 1.0.13
 platform: ruby
 authors:
 - reshacs