rails_http_preload 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1ab167b50cca5eecf4e8b289c407f12cd14fd96b343bd4562276c797fc8d0b7f
-  data.tar.gz: 9fc88a983e9e44f7c03ee37e8eb915c8f7766ad63410f8e18fc82b1279fbb855
+  metadata.gz: e16c99f5f30f2e9646d3618e76c888bdd32a41ad2c83b08fa682343517f5f4ea
+  data.tar.gz: ff66a5d7d823080a01265c76c6880023e98f5215e320b20ef2aa1952006fd551
 SHA512:
-  metadata.gz: 5ac3bb7fd8268eba569957770020c54fde8b67409d3376c41f6ac30e4373eb64e73636047338dd47dcc684b1f33da16af2d84e2171b8ec7d84a1105ebd72e180
-  data.tar.gz: 28f2a8d1585a17d899279ffab85979d5eb4744af9c1f6cfdf3ea98008ae47320c9d154bc46d224a0f0be056614b4f9951a8c1323eb82d273cb38da1191363b9b
+  metadata.gz: db26d1e098f70e2f1b1e23282e44a92d01ebcbb723693588c5e5d18530e2bc4c5068b7c21ed328a729907e42b82ec35b377b990c398175a8da7a880b34558eda
+  data.tar.gz: 79d9346fe00db3a23e25bf23de8ce9fc928d0640073365d3f3b8a8be8d7b535e5a9e4655d190b81919cbf5c3bb2c0b05e1278e1b2be8ae06644449b5084f5990

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.2.0] - 2022-05-29
+
+- Bugfix: blank asset hosts should not add a blank link header
+- Bugfix: don't overwrite existing link headers in responses
 ## [0.1.0] - 2022-11-21
 
 - Initial release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rails_http_preload (0.1.0)
+    rails_http_preload (0.2.0)
       actionpack
       actionview
       rails

data/README.md

@@ -47,7 +47,7 @@ In the best case scenario, your observed Largest Contentful Paint times should b
 
 ### Worst Case Scenario
 
-In the worst case, nothing happens. For example, your CDN doesn't support early hints. No problem, you've just added ~1kb of HTTP headers to your responses, it's basically a no-op. You cannot really create new bugs or bad behavior by including this header.
+In the worst case, nothing happens. For example, your CDN doesn't support early hints. No problem, you've just added a few bytes of HTTP headers to your responses, it's basically a no-op. You cannot really create new bugs or bad behavior by including this header.
 ## Installation
 
 Add this line to your application's Gemfile:

data/lib/rails_http_preload/middleware.rb

@@ -13,7 +13,7 @@ module RailsHttpPreload
     def call(env)
       response = @app.call(env)
 
-      response[1]["Link"] = preconnect_header if required?(response, ActionDispatch::Request.new(env))
+      response[1]["Link"] = preconnect_header(response) if required?(response, ActionDispatch::Request.new(env))
 
       response
     end
@@ -21,8 +21,7 @@ module RailsHttpPreload
     # TODO: Should we just add it to every response anyway and let the browser
     # figure it out?
     def required?(response, request)
-      html?(response) &&
-        !already_connected?(request)
+      config.asset_host.present? && html?(response) && !already_connected?(request)
     end
 
     # Adding this header to, for example, a JSON response would be pointless
@@ -31,18 +30,26 @@ module RailsHttpPreload
       response[1]["Content-Type"].match?("html")
     end
 
+    def current_asset_host
+      ActionController::Base.helpers.compute_asset_host("", host: config.asset_host)
+    end
+
     # If the asset host is equal to the request domain, no need to add.
     def already_connected?(request)
-      protocol = request.protocol.gsub("://", "")
-      ActionController::Base.helpers.compute_asset_host("", host: config.asset_host) ==
-        ActionController::Base.helpers.compute_asset_host("", { protocol: protocol, host: request.domain })
+      request.base_url == current_asset_host
     end
 
-    def preconnect_header
-      [
-        ActionController::Base.helpers.compute_asset_host("", host: config.asset_host),
+    def preconnect_header(response)
+      header = [
+        current_asset_host,
         *config.additional_urls
       ].compact.map { |url| create_link_header(url) }.join(", ")
+
+      if response[1]["Link"]
+        "#{header}, #{response[1]["Link"]}"
+      else
+        header
+      end
     end
 
     def create_link_header(url)

data/lib/rails_http_preload/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsHttpPreload
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_http_preload
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Nate Berkopec
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-05-26 00:00:00.000000000 Z
+date: 1980-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -95,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.15
+rubygems_version: 3.4.12
 signing_key:
 specification_version: 4
 summary: Automatically add an HTTP header to Rails apps to use 103 Early Hints