rails_friendly_urls 1.0.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: af293fd81ee336f7218d14dadd05ac8db59a2af4
-  data.tar.gz: 471c0d627736a1b2775ca170778a13335cefae85
+  metadata.gz: ca9f0ee5bfe9a12804fe9635897beb58e89368c7
+  data.tar.gz: d021d64e297aeeedc0f8d790d6cd7a91be257350
 SHA512:
-  metadata.gz: 1c398dd521a1ed256ade707cc1fe98cb58b774347197ed3802aec7750e251794b992f862871b33422f23cff9e3081c942135b3d0d93eb4ac448a2420bae78898
-  data.tar.gz: 90d1eee305f8e94e4ca150e73e53e23e1aae322f39e78bf84b36e0c10c94f9cc0e75672174afb3dae5e3b8b143bdf0edc3d6475aa841851052fa9bd1b7489e41
+  metadata.gz: d75be862be5b35ab6a801b688e99342439a6d4d28afd8f90a373b6a57e1802b04887ef524752377b362d5e64ca923c234a08ce34f9f8786f82be44d3a1ef04bd
+  data.tar.gz: 18d8372f1f4c2d9c57c77e60caa820762a397aff2f2c6a9b3d2f7a391c72cdd294de58083761d38d9779b68fcafb65190c66655a86b2b07c36b6f9931df1201f

data/README.md

@@ -1,10 +1,11 @@
-#Rails Friendly Urls Engine [![Build Status](https://travis-ci.org/calonso/rails_friendly_urls.svg?branch=master)](https://travis-ci.org/calonso/rails_friendly_urls)
+#Rails Friendly Urls Engine
+[![Build Status](https://travis-ci.org/calonso/rails_friendly_urls.svg?branch=master)](https://travis-ci.org/calonso/rails_friendly_urls) [![Code Climate](https://codeclimate.com/github/calonso/rails_friendly_urls/badges/gpa.svg)](https://codeclimate.com/github/calonso/rails_friendly_urls) [![Test Coverage](https://codeclimate.com/github/calonso/rails_friendly_urls/badges/coverage.svg)](https://codeclimate.com/github/calonso/rails_friendly_urls/coverage) [![calonso/rails_friendly_urls API Documentation](https://www.omniref.com/github/calonso/rails_friendly_urls.png)](https://www.omniref.com/github/calonso/rails_friendly_urls)
 
-Rails Gem to easily configure any url as a friendlier one. 
+Rails Gem to easily configure any url as a friendlier one.
 
 ##Features
 
-* Allows customisation of **ABSOLUTELY** any url into a friendlier one.
+* Allows customisation of **ABSOLUTELY** any url into a SEO friendlier one.
 * Takes care of the parameters you defined in your original route and will pass them into the controller when the friendly url is invoked.
 * Takes care of named routes and both url and path helpers so that there's no need to change a single line of code when adding a new friendly url.
 * When a friendly URL is defined to substitute another one. The non-friendly one is automatically configured to redirect to the friendly path so that you're not penalised by search engines.
@@ -14,12 +15,14 @@ Rails Gem to easily configure any url as a friendlier one.
 
 You can see the gem running live in the following url: [https://rails-friendly-urls-test.herokuapp.com/](https://rails-friendly-urls-test.herokuapp.com/)
 
+The source code for this example project is available here: [https://github.com/calonso/rails_friendly_urls_test](https://github.com/calonso/rails_friendly_urls_test)
+
 ##Installation
 
 Installing this gem only requires you to add the following line to your `Gemfile`
 
 ```ruby
-gem 'rails_friendly_urls', git: 'https://github.com/calonso/rails_friendly_urls'
+gem 'rails_friendly_urls'
 ```
 
 Run
@@ -33,7 +36,7 @@ $ rails generate rails_friendly_urls:install
 
 Here I detail you the steps that I followed to set up the friendly urls engine in the example application, so most of them should be the same for you, some others slightly different, but don't worry, you'll see appropriated explanations while reading this steps.
 
-###1. Friendly URLs Storage 
+###1. Friendly URLs Storage
 
 First of all we need to decide our urls storage technology, in my case I decided to use a standard activerecord rails model, but I guess that a YAML file could do the job as well or any other persistence technology.
 
@@ -57,7 +60,7 @@ In my example project this is the final implementation:
 
 ```
 # FriendlyUrls Manager contents
-class RailsFriendlyUrls::Manager 
+class RailsFriendlyUrls::Manager
   def self.urls
     ::FriendlyUrl.all
   end
@@ -74,3 +77,13 @@ As part of the installation process, a new line is inserted on top of the `route
 
 * At the moment, only GET requests are supported.
 * At the moment, the rails application has to be restarted for the new urls to start working.
+
+## Contributing
+
+1. Fork it ( https://github.com/calonso/rails_friendly_urls/fork )
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create a new Pull Request
+
+Released under the MIT-LICENSE.

data/Rakefile

@@ -1,19 +1,7 @@
+require "rubygems"
+require "bundler/setup"
 require 'bundler'
-
-Bundler.setup
-Bundler.require :default
-
 require 'appraisal'
-require 'rdoc/task'
-
-RDoc::Task.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'RailsFriendlyUrls'
-  rdoc.options << '--line-numbers'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
-
 
 require 'rspec/core/rake_task'
 
@@ -22,5 +10,5 @@ RSpec::Core::RakeTask.new(:spec)
 task :default => :spec
 
 if !ENV["APPRAISAL_INITIALIZED"] && !ENV["TRAVIS"]
-  task default: :appraisal
+  task :default => :appraisal
 end

data/lib/rails_friendly_urls.rb

@@ -1,9 +1,17 @@
-
 require 'singleton'
 require 'rails'
 
+#
+# Base gem's module
+#
+# @author Carlos Alonso
+#
 module RailsFriendlyUrls
 
+  #
+  # Method to quickly get the major and minor versions of the current Rails env
+  #
+  # @returns [String] with X.Y format with major and minor versions
   def self.rails_version
     "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}"
   end
@@ -12,17 +20,15 @@ end
 
 require 'rails_friendly_urls/manager'
 require 'rails_friendly_urls/friendly_url'
+require 'rails_friendly_urls/route_sets/route_set'
 
 case RailsFriendlyUrls.rails_version
 when '4.2'
-  require 'rails_friendly_urls/route_sets/rails4_2'
   require 'rails_friendly_urls/urls/rails4_2'
-when '4.1'
-  require 'rails_friendly_urls/route_sets/rails4_0'
-  require 'rails_friendly_urls/urls/rails4_0'
-when '4.0'
-  require 'rails_friendly_urls/route_sets/rails4_0'
+when '4.0', '4.1'
   require 'rails_friendly_urls/urls/rails4_0'
-else
+when '3.2'
   require 'rails_friendly_urls/route_sets/rails3'
+else
+  raise NotImplementedError.new "Rails Friendly URLs gem doesn't support Rails #{Rails.version}"
 end

data/lib/rails_friendly_urls/friendly_url.rb

@@ -1,7 +1,16 @@
-
 module RailsFriendlyUrls
+  #
+  # This module is to be included in the client class that represents the Friendly URL
+  #
+  # @author Carlos Alonso
+  #
   module FriendlyUrl
-
+    #
+    # This method tries to identify the route contained at self.path to extract
+    # the destination's controller, action and other arguments and save them
+    # into the corresponding controller, action and defaults fields of the
+    # including objects.
+    #
     def set_destination_data!
       route_info = Rails.application.routes.recognize_path self.path
       self.controller = route_info[:controller]
@@ -9,4 +18,4 @@ module RailsFriendlyUrls
       self.defaults = route_info.reject { |k, v| [:controller, :action].include? k }
     end
   end
-end
+end

data/lib/rails_friendly_urls/manager.rb

@@ -1,8 +1,18 @@
-
 module RailsFriendlyUrls
+  #
+  # This class is responsible for orchestrating the whole gem's functions.
+  #
+  # @author Carlos Alonso
+  #
   class Manager
+    # It is designed to be a Singleton, only one instance will run per process.
     include Singleton
 
+    #
+    # Injects the defined urls into the given RouteSet. This method should be invoked
+    # first thing in the routes.rb block
+    #
+    # @param [ActionDispatch::Routing::RouteSet] rails' current RouteSet.
     def self.inject_urls(mapper)
       list = self.urls || []
       Rails.logger.warn "Injecting empty Friendly URLs List!!" if list.empty?
@@ -12,17 +22,34 @@ module RailsFriendlyUrls
       end
     end
 
+    #
+    # Invokes Rails' routes reload. Useful to reload the routes after
+    # modifying the list of SEO Friendly defined ones without having to
+    # restart the application server.
+    #
     def self.apply_changes!
       Rails.application.reload_routes!
     end
 
+    #
+    # This method is used in Rails' URL Helpers to return the corresponding
+    # SEO Friendly URL instead of the default one.
+    #
+    # @param [String] The path we want the URL for.
+    # @returns [String] The SEO Friendly Slug for the required path.
     def self.url_for(path)
       self.instance.friendly path
     end
 
+    #
+    # INTERNAL: Searches the list of SEO Friendly defined substitutions for
+    # the corresponding to the given path
+    #
+    # @param [String] The path we want the substitution for.
+    # @returns [String] The SEO Friendly Slugh for the required path.
     def friendly(path)
       @all_friendly ||= Hash[*RailsFriendlyUrls::Manager.urls.map { |f_url| [f_url.path, f_url.slug] }.flatten]
       @all_friendly[path] || path
     end
   end
-end
+end

data/lib/rails_friendly_urls/route_sets/rails3.rb

@@ -1,7 +1,16 @@
-
 module ActionDispatch
   module Routing
+    #
+    # Monkey Patched Rails' class ActionDispatch::Routing::RouteSet.
+    #
+    # @author Carlos Alonso
+    #
     class RouteSet
+      #
+      # Monkey Patched Rails' method: Includes a call to RailsFriendlyUrls::Manager.url_for
+      # when the Rails' URL Helper is building a url for a path to use the
+      # configured SEO Friendly substutition if any.
+      #
       def url_for(options = {})
         finalize!
         options = (options || {}).reverse_merge!(default_url_options)
@@ -21,7 +30,7 @@ module ActionDispatch
         path << path_addition
         params.merge!(options[:params] || {})
 
-        path = friendly(path) || path
+        path = RailsFriendlyUrls::Manager.url_for path
 
         ActionDispatch::Http::URL.url_for(options.merge!({
           :path => path,
@@ -30,54 +39,6 @@ module ActionDispatch
           :password => password
         }))
       end
-
-      def friendly(path)
-        @all_friendly ||= Hash[*RailsFriendlyUrls::Manager.urls.map { |f_url| [f_url.path, f_url.slug] }.flatten]
-        @all_friendly[path]
-      end
-      
-      def recognize_path(path, environment = {})
-        method = (environment[:method] || "GET").to_s.upcase
-        path = Journey::Router::Utils.normalize_path(path) unless path =~ %r{://}
-        extras = environment[:extras] || {}
-
-        begin
-          env = Rack::MockRequest.env_for(path, {:method => method})
-        rescue URI::InvalidURIError => e
-          raise ActionController::RoutingError, e.message
-        end
-
-        req = @request_class.new(env)
-        @router.recognize(req) do |route, _matches, params|
-          params.merge!(extras)
-          params.merge!(req.parameters.symbolize_keys)
-          params.each do |key, value|
-            if value.is_a?(String)
-              value = value.dup.force_encoding(Encoding::BINARY)
-              params[key] = URI.parser.unescape(value)
-            end
-          end
-          old_params = env[::ActionDispatch::Routing::RouteSet::PARAMETERS_KEY]
-          env[::ActionDispatch::Routing::RouteSet::PARAMETERS_KEY] = (old_params || {}).merge(params)
-          dispatcher = route.app
-          while dispatcher.is_a?(Mapper::Constraints) && dispatcher.matches?(env) do
-            dispatcher = dispatcher.app
-          end
-
-          if dispatcher.is_a?(Dispatcher)
-            if dispatcher.controller(params, false)
-              dispatcher.prepare_params!(params)
-              return params
-            else
-              raise ActionController::RoutingError, "A route matches #{path.inspect}, but references missing controller: #{params[:controller].camelize}Controller"
-            end
-          elsif dispatcher.is_a?(Redirect)
-            return { status: 301, path: dispatcher.block.call({}, nil) }
-          end
-        end
-
-        raise ActionController::RoutingError, "No route matches #{path.inspect}"
-      end
     end
   end
 end

data/lib/rails_friendly_urls/route_sets/route_set.rb

@@ -0,0 +1,97 @@
+module ActionDispatch
+  module Routing
+    #
+    # Monkey Patched Rails' class ActionDispatch::Routing::RouteSet.
+    #
+    # @author Carlos Alonso
+    #
+    class RouteSet
+      #
+      # Monkey Patched Rails' method to recognize redirections as well as, for some
+      # reason, the original Rails' method doesn't.
+      #
+      def recognize_path(path, environment = {})
+        method = (environment[:method] || "GET").to_s.upcase
+        path = Journey::Router::Utils.normalize_path(path) unless path =~ %r{://}
+        extras = environment[:extras] || {}
+
+        begin
+          env = Rack::MockRequest.env_for(path, {:method => method})
+        rescue URI::InvalidURIError => e
+          raise ActionController::RoutingError, e.message
+        end
+
+        req = @request_class.new(env)
+        @router.recognize(req) do |route, _matches, params|
+          params = _matches if params.nil?
+          params.merge!(extras)
+          params.merge!(req.parameters.symbolize_keys)
+          params.each do |key, value|
+            if value.is_a?(String)
+              value = value.dup.force_encoding(Encoding::BINARY)
+              params[key] = URI.parser.unescape(value)
+            end
+          end
+
+          old_params = env[params_key]
+          env[params_key] = (old_params || {}).merge(params)
+          dispatcher = route.app
+          while dispatcher.is_a?(Mapper::Constraints) && dispatcher.matches?(env) do
+            dispatcher = dispatcher.app
+          end
+
+          if dispatcher.is_a?(Dispatcher)
+            if dispatcher.controller(params, false)
+              dispatcher.prepare_params!(params)
+              return params
+            else
+              raise ActionController::RoutingError, "A route matches #{path.inspect}, but references missing controller: #{params[:controller].camelize}Controller"
+            end
+          elsif dispatcher.is_a?(redirect_class)
+            return { status: 301, path: path_from_dispatcher(dispatcher) }
+          end
+        end
+
+        raise ActionController::RoutingError, "No route matches #{path.inspect}"
+      end
+
+      private
+
+      #
+      # INTERNAL: Helps deciding which module take the PARAMETERS_KEY constant
+      # from. This constant was moved in Rails 4.2 from one to another and
+      # using this method here allows us to reuse this file for all Rails 4.x
+      #
+      def params_key
+        defined?(::ActionDispatch::Http::Parameters::PARAMETERS_KEY) ?
+          ::ActionDispatch::Http::Parameters::PARAMETERS_KEY :
+            ::ActionDispatch::Routing::RouteSet::PARAMETERS_KEY
+      end
+
+      #
+      # INTERNAL: Helps reusing code by deciding which class to consider
+      # as the redirection depending on the Rails version running.
+      #
+      # @returns [ActionDispatch::Routing::Redirect] or [ActionDispatch::Routing::PathRedirect]
+      def redirect_class
+        Rails::VERSION::MAJOR == 3 ? Redirect : PathRedirect
+      end
+
+      #
+      # INTERNAL: Helps reusing code by obtaining the path from the Rails'
+      # ActionDispatch::Routing::Dispatcher depending on the Rails version
+      # running.
+      #
+      # @param [ActionDispatch::Routing::Dispatcher] in use.
+      # @return [String] the destination path of the redirection.
+      def path_from_dispatcher(dispatcher)
+        if Rails::VERSION::MAJOR == 3
+          dispatcher.block.call({}, nil)
+        else
+          dispatcher.block
+        end
+      end
+    end
+  end
+end
+

data/lib/rails_friendly_urls/urls/rails4_0.rb

@@ -1,28 +1,35 @@
-
 module ActionDispatch
   module Http
+    #
+    # Monkey Patched Rails' module ActionDispatch::Http::URL
+    #
+    # @author Carlos Alonso
+    #
     module URL
-      class << self
-        def url_for(options = {})
-          options = options.dup
-          path  = options.delete(:script_name).to_s.chomp("/")
-          path << options.delete(:path).to_s
+      #
+      # Monkey Patched Rails' method: Includes a call to RailsFriendlyUrls::Manager.url_for
+      # when the Rails' URL Helper is building a url for a path to use the
+      # configured SEO Friendly substutition if any.
+      #
+      def self.url_for(options = {})
+        options = options.dup
+        path  = options.delete(:script_name).to_s.chomp("/")
+        path << options.delete(:path).to_s
 
-          add_trailing_slash(path) if options[:trailing_slash]
+        add_trailing_slash(path) if options[:trailing_slash]
 
-          params = options[:params].is_a?(Hash) ? options[:params] : options.slice(:params)
-          params.reject! { |_,v| v.to_param.nil? }
+        params = options[:params].is_a?(Hash) ? options[:params] : options.slice(:params)
+        params.reject! { |_,v| v.to_param.nil? }
 
-          result = build_host_url(options)
+        result = build_host_url(options)
 
-          path = RailsFriendlyUrls::Manager.url_for path
+        path = RailsFriendlyUrls::Manager.url_for path
 
-          result << path
+        result << path
 
-          result << "?#{params.to_query}" unless params.empty?
-          result << "##{Journey::Router::Utils.escape_fragment(options[:anchor].to_param.to_s)}" if options[:anchor]
-          result
-        end
+        result << "?#{params.to_query}" unless params.empty?
+        result << "##{Journey::Router::Utils.escape_fragment(options[:anchor].to_param.to_s)}" if options[:anchor]
+        result
       end
     end
   end

data/lib/rails_friendly_urls/urls/rails4_2.rb

@@ -1,19 +1,25 @@
-
 module ActionDispatch
   module Http
+    #
+    # Monkey Patched Rails' module ActionDispatch::Http::URL
+    #
+    # @author Carlos Alonso
+    #
     module URL
-      class << self
-
-        def path_for(options)
-          path  = options[:script_name].to_s.chomp("/")
-          path << options[:path] if options.key?(:path)
+      #
+      # Monkey Patched Rails' method: Includes a call to RailsFriendlyUrls::Manager.url_for
+      # when the Rails' URL Helper is building a url for a path to use the
+      # configured SEO Friendly substutition if any.
+      #
+      def self.path_for(options)
+        path  = options[:script_name].to_s.chomp("/")
+        path << options[:path] if options.key?(:path)
 
-          add_trailing_slash(path) if options[:trailing_slash]
-          add_params(path, options[:params]) if options.key?(:params)
-          add_anchor(path, options[:anchor]) if options.key?(:anchor)
+        add_trailing_slash(path) if options[:trailing_slash]
+        add_params(path, options[:params]) if options.key?(:params)
+        add_anchor(path, options[:anchor]) if options.key?(:anchor)
 
-          RailsFriendlyUrls::Manager.url_for path
-        end
+        RailsFriendlyUrls::Manager.url_for path
       end
     end
   end

data/lib/rails_friendly_urls/version.rb

@@ -1,3 +1,3 @@
 module RailsFriendlyUrls
-  VERSION = "1.0.1"
+  VERSION = "1.1.2"
 end

data/spec/apps/rails3_2.rb

@@ -1,7 +1,6 @@
 require "rails"
 require 'rails/all'
 require 'action_view/testing/resolvers'
-require 'rails/test_help'
 
 require 'rails_friendly_urls' # our gem
 

data/spec/apps/rails4.rb

@@ -1,7 +1,6 @@
 require "rails"
 require 'rails/all'
 require 'action_view/testing/resolvers'
-require 'rails/test_help'
 
 require 'rails_friendly_urls' # our gem
 

data/spec/spec_helper.rb

@@ -1,13 +1,14 @@
 # Configure Rails Environment
-Bundler.setup
-Bundler.require :default
-Bundler.require :development
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
 
-require 'rails_friendly_urls'
+Bundler.setup
 
 ENV["RAILS_ENV"] = "test"
 
-case RailsFriendlyUrls.rails_version
+require 'rails'
+
+case "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}"
 when '3.2'
   ENV['DATABASE_URL'] = 'sqlite3://localhost/:memory:'
   require 'apps/rails3_2'
@@ -24,9 +25,11 @@ else
   raise NotImplementedError.new "Rails Friendly URLs gem doesn't support Rails #{Rails.version}"
 end
 
-require 'rspec/rails'
+Bundler.require :default
+Bundler.require :development
 
-Rails.backtrace_cleaner.remove_silencers!
+require 'rspec/rails'
+require 'rails_friendly_urls'
 
 # Load support files
 Dir["#{File.dirname(__FILE__)}/support/*.rb"].each { |f| require f }
@@ -44,5 +47,5 @@ RSpec.configure do |config|
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = "random"
-end
+  config.order = :random
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_friendly_urls
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Carlos Alonso
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-01 00:00:00.000000000 Z
+date: 2015-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -25,76 +25,62 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: rspec-core
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: generator_spec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 description: Rails Gem to easily configure any url as a friendlier one.
 email: info@mrcalonso.com
 executables: []
@@ -109,8 +95,7 @@ files:
 - lib/rails_friendly_urls/friendly_url.rb
 - lib/rails_friendly_urls/manager.rb
 - lib/rails_friendly_urls/route_sets/rails3.rb
-- lib/rails_friendly_urls/route_sets/rails4_0.rb
-- lib/rails_friendly_urls/route_sets/rails4_2.rb
+- lib/rails_friendly_urls/route_sets/route_set.rb
 - lib/rails_friendly_urls/urls/rails4_0.rb
 - lib/rails_friendly_urls/urls/rails4_2.rb
 - lib/rails_friendly_urls/version.rb
@@ -145,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: This is a Rails gem that allows to configure friendly urls for any url in
@@ -162,3 +147,4 @@ test_files:
 - spec/support/routes/rails3.rb
 - spec/support/routes/rails4.rb
 - spec/support/routes.rb
+has_rdoc: 

data/lib/rails_friendly_urls/route_sets/rails4_0.rb

@@ -1,77 +0,0 @@
-
-module ActionDispatch
-  module Routing
-    class RouteSet
-      def url_for(options = {})
-        finalize!
-        options = (options || {}).reverse_merge!(default_url_options)
-
-        handle_positional_args(options)
-
-        user, password = extract_authentication(options)
-        path_segments  = options.delete(:_path_segments)
-        script_name    = options.delete(:script_name)
-
-        path = (script_name.blank? ? _generate_prefix(options) : script_name.chomp('/')).to_s
-
-        path_options = options.except(*RESERVED_OPTIONS)
-        path_options = yield(path_options) if block_given?
-
-        path_addition, params = generate(path_options, path_segments || {})
-        path << path_addition
-        params.merge!(options[:params] || {})
-
-        ActionDispatch::Http::URL.url_for(options.merge!({
-          :path => path,
-          :params => params,
-          :user => user,
-          :password => password
-        }))
-      end
-
-      def recognize_path(path, environment = {})
-        method = (environment[:method] || "GET").to_s.upcase
-        path = Journey::Router::Utils.normalize_path(path) unless path =~ %r{://}
-        extras = environment[:extras] || {}
-
-        begin
-          env = Rack::MockRequest.env_for(path, {:method => method})
-        rescue URI::InvalidURIError => e
-          raise ActionController::RoutingError, e.message
-        end
-
-        req = @request_class.new(env)
-        @router.recognize(req) do |route, _matches, params|
-          params.merge!(extras)
-          params.merge!(req.parameters.symbolize_keys)
-          params.each do |key, value|
-            if value.is_a?(String)
-              value = value.dup.force_encoding(Encoding::BINARY)
-              params[key] = URI.parser.unescape(value)
-            end
-          end
-          old_params = env[::ActionDispatch::Routing::RouteSet::PARAMETERS_KEY]
-          env[::ActionDispatch::Routing::RouteSet::PARAMETERS_KEY] = (old_params || {}).merge(params)
-          dispatcher = route.app
-          while dispatcher.is_a?(Mapper::Constraints) && dispatcher.matches?(env) do
-            dispatcher = dispatcher.app
-          end
-
-          if dispatcher.is_a?(Dispatcher)
-            if dispatcher.controller(params, false)
-              dispatcher.prepare_params!(params)
-              return params
-            else
-              raise ActionController::RoutingError, "A route matches #{path.inspect}, but references missing controller: #{params[:controller].camelize}Controller"
-            end
-          elsif dispatcher.is_a?(PathRedirect)
-            return { :status => dispatcher.status, :path => dispatcher.block }
-          end
-        end
-
-        raise ActionController::RoutingError, "No route matches #{path.inspect}"
-      end
-    end
-  end
-end
-

data/lib/rails_friendly_urls/route_sets/rails4_2.rb

@@ -1,50 +0,0 @@
-
-module ActionDispatch
-  module Routing
-    class RouteSet
-      def recognize_path(path, environment = {})
-        method = (environment[:method] || "GET").to_s.upcase
-        path = Journey::Router::Utils.normalize_path(path) unless path =~ %r{://}
-        extras = environment[:extras] || {}
-
-        begin
-          env = Rack::MockRequest.env_for(path, {:method => method})
-        rescue URI::InvalidURIError => e
-          raise ActionController::RoutingError, e.message
-        end
-
-        req = @request_class.new(env)
-        @router.recognize(req) do |route, params|
-          params.merge!(extras)
-          params.merge!(req.parameters.symbolize_keys)
-          params.each do |key, value|
-            if value.is_a?(String)
-              value = value.dup.force_encoding(Encoding::BINARY)
-              params[key] = URI.parser.unescape(value)
-            end
-          end
-          old_params = env[::ActionDispatch::Http::Parameters::PARAMETERS_KEY]
-          env[::ActionDispatch::Http::Parameters::PARAMETERS_KEY] = (old_params || {}).merge(params)
-          dispatcher = route.app
-          while dispatcher.is_a?(Mapper::Constraints) && dispatcher.matches?(env) do
-            dispatcher = dispatcher.app
-          end
-
-          if dispatcher.is_a?(Dispatcher)
-            if dispatcher.controller(params, false)
-              dispatcher.prepare_params!(params)
-              return params
-            else
-              raise ActionController::RoutingError, "A route matches #{path.inspect}, but references missing controller: #{params[:controller].camelize}Controller"
-            end
-          elsif dispatcher.is_a?(PathRedirect)
-            return { :status => dispatcher.status, :path => dispatcher.block }
-          end
-        end
-
-        raise ActionController::RoutingError, "No route matches #{path.inspect}"
-      end
-    end
-  end
-end
-