rails_exception_handler 1.1.1 → 1.1.2

data/HISTORY

@@ -1,15 +1,19 @@
 CHANGELOG
 
 
-v1.1.1 - 18. Jul 2011
+v1.1.2 - July 19th 2011
+ - It should now be able to store user_info on routing errors too
+ - The RailsExceptionHandler class have been turned into a rails engine so that the load path manipulation could be removed
+
+v1.1.1 - July 18th 2011
  - Fixed issue related to the handling of routing errors
 
-v1.1.0 - 18. Jul 2011
+v1.1.0 - July 18th 2011
  - Better handling of ajax requests
  - Exceptions can be mapped to specific responses
 
-v1.0.1 - 17. Jul 2011
+v1.0.1 - July 17th 2011
 - Minor fix for 1.8.7 compatibility
 
-v1.0.0 - 17. Jul 2011
+v1.0.0 - July 17th 2011
  - Initial release

data/README.markdown

@@ -82,7 +82,7 @@ config.store_user_info = {:method => :current_user, :field => :login}
 ```
 
 Default value: false (no info will be stored)
-If you turn this on and the error is generated by a client that is not logged in, then "Anonymous" will be used. Currently, "Anonymous" is always used on routing errors, regardless of whether the user is logged in or not. This because the error happens before a controller instance has been initialized, and I haven't found a safe way to do this manually yet.
+If you turn this on and the error is generated by a client that is not logged in, then "Anonymous" will be used.
 
 ### responses and response_mapping
 
@@ -92,13 +92,15 @@ Create a set of responses and then map specific exceptions to these responses. T
 config.responses = {
   :default => "<h1>500</h1><p>Internal server error</p>",
   :not_found => "<h1>404</h1><p>Page not found</p>",
-  :wrong_token => "<h1>500</h1>There was a problem authenticating the submitted form. Reload the page and try again."
+  :wrong_token => "<h1>500</h1><p>There was a problem authenticating the submitted form. Reload the page and try again.</p>",
+  :teapot => "<h1>418</h1><p>I'm a teapot</p>"
 }
 config.response_mapping = {
  'ActiveRecord::RecordNotFound' => :not_found,
  'ActionController:RoutingError' => :not_found,
  'AbstractController::ActionNotFound' => :not_found,
- 'ActionController::InvalidAuthenticityToken' => :wrong_token
+ 'ActionController::InvalidAuthenticityToken' => :wrong_token,
+ 'Teapot::CoffeeGroundsNotSupported' => :teapot
 }
 ```
 

data/Rakefile

@@ -26,6 +26,8 @@ Jeweler::Tasks.new do |gem|
   gem.email = "contact@sharagoz.com"
   gem.authors = ["Sharagoz"]
   gem.extra_rdoc_files = ['README.markdown']
+  gem.require_paths = ["lib"]
+
   # dependencies defined in Gemfile
 end
 Jeweler::RubygemsDotOrgTasks.new

data/VERSION

@@ -1 +1 @@
-1.1.1
+1.1.2

data/app/controllers/error_response_controller.rb

@@ -2,4 +2,8 @@ class ErrorResponseController < ApplicationController
   def index
     render(:text => @_env['exception_handler.response'], :layout => @_env['exception_handler.layout'])
   end
+
+  def dummy_action
+    render :nothing => true
+  end
 end

data/lib/rails_exception_handler.rb

@@ -1,4 +1,5 @@
 class RailsExceptionHandler
+
   def initialize(app)
     @app = app
   end
@@ -21,17 +22,11 @@ class RailsExceptionHandler
 
     Rails.configuration.action_dispatch.show_exceptions = true
     require File.expand_path(File.dirname(__FILE__)) + '/patch/show_exceptions.rb'
-
-    %w{ models controllers }.each do |dir|
-      path = File.join(File.dirname(__FILE__), '../app', dir)
-      $LOAD_PATH << path
-      ActiveSupport::Dependencies.autoload_paths << path
-      ActiveSupport::Dependencies.autoload_once_paths.delete(path)
-    end
   end
 end
 
 require 'rails_exception_handler/configuration.rb'
 require 'rails_exception_handler/handler.rb'
 require 'rails_exception_handler/parser.rb'
+require 'rails_exception_handler/engine.rb'
 require 'net/http'

data/lib/rails_exception_handler/engine.rb

@@ -0,0 +1,4 @@
+class RailsExceptionHandler
+  class Engine < Rails::Engine
+  end
+end

data/lib/rails_exception_handler/handler.rb

@@ -4,7 +4,18 @@ class RailsExceptionHandler::Handler
     @env = env
     @request = ActionDispatch::Request.new(@env)
     @parsed_error = nil
-    @controller = @env['action_controller.instance'] || ApplicationController.new
+    if(@env['action_controller.instance'])
+      @controller = @env['action_controller.instance']
+    else
+      # A routing error has occurred and no controller instance exists. Here I am firing off a 
+      # request to a dummy action that goes through the whole action dispatch stack, which will
+      # hopefully make sure that any authentication mechanism are properly initialized so that 
+      # we may get the current_user object later.
+      @controller = ErrorResponseController.new
+      @controller.request = @request
+      @controller.response = ActionDispatch::Response.new
+      @controller.process(:dummy_action)
+    end
   end
 
   def handle_exception
@@ -75,3 +86,4 @@ class RailsExceptionHandler::Handler
     return config.responses[key]
   end
 end
+

data/lib/rails_exception_handler/parser.rb

@@ -49,11 +49,7 @@ class RailsExceptionHandler::Parser
   def user_info
     config = RailsExceptionHandler.configuration.store_user_info
     return nil unless(config)
-    begin
-      user_object = @controller.send(config[:method])
-    rescue
-      user_object = nil
-    end
+    user_object = @controller.send(config[:method])
     user_object ? user_object.send(config[:field]) : 'Anonymous'
   end
 

data/rails_exception_handler.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_exception_handler}
-  s.version = "1.1.1"
+  s.version = "1.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Sharagoz"]
-  s.date = %q{2011-07-18}
+  s.date = %q{2011-07-19}
   s.description = %q{}
   s.email = %q{contact@sharagoz.com}
   s.extra_rdoc_files = [
@@ -29,6 +29,7 @@ Gem::Specification.new do |s|
     "lib/patch/show_exceptions.rb",
     "lib/rails_exception_handler.rb",
     "lib/rails_exception_handler/configuration.rb",
+    "lib/rails_exception_handler/engine.rb",
     "lib/rails_exception_handler/handler.rb",
     "lib/rails_exception_handler/parser.rb",
     "rails_exception_handler.gemspec",

metadata

@@ -2,7 +2,7 @@
 name: rails_exception_handler
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors: 
 - Sharagoz
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-18 00:00:00 +02:00
+date: 2011-07-19 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -90,6 +90,7 @@ files:
 - lib/patch/show_exceptions.rb
 - lib/rails_exception_handler.rb
 - lib/rails_exception_handler/configuration.rb
+- lib/rails_exception_handler/engine.rb
 - lib/rails_exception_handler/handler.rb
 - lib/rails_exception_handler/parser.rb
 - rails_exception_handler.gemspec