rails_error_dashboard 0.8.3 → 0.8.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 270ac48ebee51c2f68cab29abdbf1169b7db7d7b860bf1fc5a43883960cdc0c6
-  data.tar.gz: 6def5b5a2bbcabffd1116f13607771f6923823dc65eec803e028ba911af85ec9
+  metadata.gz: ba282b251af897146a14dce9cbd14aae0032428b96bb8d274d7400db3b1386cd
+  data.tar.gz: 4d4de4a7d143fe4233ea283766f452018f0a057652620077579686c6a10b1cbe
 SHA512:
-  metadata.gz: fd6984fc8ccb2a68f9543786ffd6157d1a975ed5d446a13e38b3a38b42cc93047117918186b7f3936c2ddc3a53c3609db63073abad5f25d02edba4961e7b1f30
-  data.tar.gz: 55ba8d78b0d06176ac80e63919cd29a6ca94423d8880712c8fb82979a17741b5881878ef2351efd89c468fbb3d03c6411c82c5c4668a687f4f441b512c169814
+  metadata.gz: e794d0737d5c8381a8a127ff30ebea8023fbf3e9b73f089d2cde9832617f953a6a589481a954dad41e1a18c85400e36e3a04a8a3bac35eaedc35aa53cf3a3d87
+  data.tar.gz: b9cff40ccba8d4459e0fe829dbf43fd054c66ff3f2a28a15d0be334e84fe757fc02c1d34e326ab1956a5d6074474113951e42bfdd9f9ef43705a0cfae46c0165

data/app/controllers/rails_error_dashboard/application_controller.rb

@@ -12,6 +12,16 @@ module RailsErrorDashboard
 
     protect_from_forgery with: :exception
 
+    # Render pagination in the dashboard's own locale, not the host app's.
+    #
+    # Pagy stores its locale in Thread.current[:pagy_locale] and never resets it
+    # (pagy 43.6.1, modules/i18n/i18n.rb:24-31 — the "for the duration of a single
+    # request" comment is aspirational; nothing in the gem enforces it). A host app
+    # that sets a per-request locale leaves that value on the Puma thread, so a
+    # dashboard request landing on a recycled thread inherits whatever language the
+    # host last used — Russian on one refresh, Portuguese on the next (issue #148).
+    around_action :with_dashboard_locale
+
     # CRITICAL: Ensure dashboard errors never break the app
     # Catch all exceptions and render user-friendly error page
     # NOTE: rescue_from is checked in reverse declaration order (last = highest priority).
@@ -60,6 +70,49 @@ module RailsErrorDashboard
 
     private
 
+    # Set Pagy's locale for this request and restore whatever was there before.
+    #
+    # Two details are load-bearing:
+    #
+    # 1. The previous value is read from Thread.current directly, NOT from
+    #    Pagy::I18n.locale. The getter coerces nil to "en", so restoring through
+    #    it would stamp "en" onto a thread that started clean — making the
+    #    dashboard a source of the very leak it is fixing.
+    # 2. around_action + ensure, not before_action. A before_action would strand
+    #    the dashboard's locale on the thread for the host app's next request.
+    #    The ensure also covers the rescue_from handlers above, which still
+    #    render through the view layer.
+    def with_dashboard_locale
+      previous = Thread.current[:pagy_locale]
+      Pagy::I18n.locale = dashboard_pagy_locale
+      yield
+    ensure
+      Thread.current[:pagy_locale] = previous
+    end
+
+    def dashboard_pagy_locale
+      configured = RailsErrorDashboard.configuration.dashboard_locale.to_s.strip
+      return "en" if configured.empty?
+
+      self.class.resolved_pagy_locales[configured] ||= resolve_pagy_locale(configured)
+    rescue StandardError
+      "en"
+    end
+
+    # Pagy looks its dictionary up by exact filename AND by an exact top-level
+    # key inside that YAML, so "EN" finds en.yml but then reads a nil dictionary
+    # and raises mid-render. Match the shipped filenames case-insensitively and
+    # fall back to English for anything Pagy cannot serve.
+    def resolve_pagy_locale(configured)
+      available = Pagy::I18n.pathnames.flat_map { |dir| Dir.glob(dir.join("*.yml")) }
+                              .map { |path| File.basename(path, ".yml") }
+      available.find { |locale| locale.casecmp?(configured) } || "en"
+    end
+
+    def self.resolved_pagy_locales
+      @resolved_pagy_locales ||= {}
+    end
+
     def render_dashboard_error(icon:, title:, message:, detail: nil, icon_style: nil, status: :internal_server_error)
       set_common_view_variables
       error_html = <<~ERB

data/app/controllers/rails_error_dashboard/errors_controller.rb

@@ -490,6 +490,10 @@ module RailsErrorDashboard
         return
       end
 
+      # Distinguishes "gem not installed" from "installed but no rules matched"
+      # in the empty state — both otherwise render an identical blank page.
+      @rack_attack_missing = !defined?(::Rack::Attack)
+
       days = days_param(default: 30)
       @days = days
       result = Queries::RackAttackSummary.call(days, application_id: @current_application_id)

data/app/views/rails_error_dashboard/errors/rack_attack_summary.html.erb

@@ -22,11 +22,21 @@
 
   <% if @unique_rules == 0 %>
     <div class="red-empty-state">
-      <i class="bi bi-shield-check display-1 text-success mb-3"></i>
-      <div class="red-empty-state-title">No Rate Limit Events Found</div>
-      <p class="text-muted">
-        No Rack Attack throttle, blocklist, or track events were recorded over the last <%= @days %> days.
-      </p>
+      <% if @rack_attack_missing %>
+        <i class="bi bi-exclamation-triangle display-1 text-warning mb-3"></i>
+        <div class="red-empty-state-title">Rack Attack Is Not Installed</div>
+        <p class="text-muted">
+          Tracking is enabled, but the <code>rack-attack</code> gem is not loaded in this
+          application — so no events can be recorded. Add it to your Gemfile and configure
+          at least one rule, then events will appear here.
+        </p>
+      <% else %>
+        <i class="bi bi-shield-check display-1 text-success mb-3"></i>
+        <div class="red-empty-state-title">No Rate Limit Events Found</div>
+        <p class="text-muted">
+          No Rack Attack throttle, blocklist, or track events were recorded over the last <%= @days %> days.
+        </p>
+      <% end %>
       <div class="card mx-auto" style="max-width: 500px;">
         <div class="card-body text-start">
           <h6>How Rack Attack tracking works:</h6>

data/app/views/rails_error_dashboard/errors/settings.html.erb

@@ -144,7 +144,7 @@
       icon: "bi-broadcast",
       color: "info",
       settings: {
-        enable_rack_attack_tracking: { label: "Rack Attack Tracking", description: "Track throttle/blocklist events as breadcrumbs", type: :boolean },
+        enable_rack_attack_tracking: { label: "Rack Attack Tracking", description: "Record throttle/blocklist events to their own table", type: :boolean },
         enable_actioncable_tracking: { label: "ActionCable Tracking", description: "Track WebSocket channel events as breadcrumbs", type: :boolean },
         enable_activestorage_tracking: { label: "ActiveStorage Tracking", description: "Track uploads/downloads/deletes as breadcrumbs", type: :boolean }
       }

data/lib/rails_error_dashboard/configuration.rb

@@ -222,6 +222,11 @@ module RailsErrorDashboard
     # Dashboard UI appearance
     attr_accessor :accent_color  # :crimson (default), :ruby, :ember, :violet
 
+    # Locale the dashboard renders in, independent of the host app's locale.
+    # Currently applies to Pagy pagination labels — the rest of the dashboard
+    # UI is not yet translated (default: "en").
+    attr_accessor :dashboard_locale
+
     # LLM-powered AI help (disabled unless provider and API key are configured)
     attr_accessor :llm_provider              # :openai or :anthropic
     attr_accessor :llm_api_key               # String or lambda/proc
@@ -433,6 +438,7 @@ module RailsErrorDashboard
 
       # Dashboard UI
       @accent_color = :crimson  # :crimson, :ruby, :ember, :violet
+      @dashboard_locale = "en"  # Pagy pagination labels; rest of the UI is English-only
 
       # LLM-powered AI help defaults - OFF until provider and API key are configured
       @llm_provider = ENV["RED_LLM_PROVIDER"]&.to_sym
@@ -590,6 +596,16 @@ module RailsErrorDashboard
         if rack_attack_flush_interval && rack_attack_flush_interval < 1
           errors << "rack_attack_flush_interval must be at least 1 (got: #{rack_attack_flush_interval})"
         end
+
+        # Warn rather than auto-disable: validation may run before the host's
+        # Rack::Attack initializer has loaded, so a missing constant here does
+        # not prove it will still be missing at after_initialize (when the
+        # subscriber actually registers). Auto-disabling would break that case.
+        unless defined?(::Rack::Attack)
+          warnings << "enable_rack_attack_tracking is enabled but the rack-attack gem " \
+                      "does not appear to be loaded. No events will be recorded until " \
+                      "Rack::Attack is installed and configured."
+        end
       end
 
       # Validate actioncable tracking requires breadcrumbs

data/lib/rails_error_dashboard/version.rb

@@ -1,3 +1,3 @@
 module RailsErrorDashboard
-  VERSION = "0.8.3"
+  VERSION = "0.8.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_error_dashboard
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.8.4
 platform: ruby
 authors:
 - Anjan Jagirdar
@@ -530,7 +530,7 @@ metadata:
   funding_uri: https://github.com/sponsors/AnjanJ
 post_install_message: |
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-    RED (Rails Error Dashboard) v0.8.3
+    RED (Rails Error Dashboard) v0.8.4
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   First install: