rails_dictionary 0.0.9.1 → 0.0.9.2

data/CHANGELOG

@@ -1,7 +1,10 @@
+0.0.9.1
+  fix a cache bug in 0.0.9
 0.0.9
   add Rails Engine to redesign the gem
   use Rspec instead of Test::Unit to write test code
   remove many nonsence code
+  DictType.tab_and_column returns an array of symbols instead of strings
   if update from lower version,should run "rails runner "DictType.new.delete_all_caches" on app root.
 0.0.1-0.0.8
   old mixin coding style

data/README.rdoc

@@ -10,8 +10,10 @@ Rail3
 or
         gem "rails_dictionary",:git => 'git://github.com/raykin/rails_dictionary'
 
-!!For user who update from old version to 0.0.9 or higher,Please run following command on app root
+!!For user who update from old version to 0.0.9.1 or higher,Please run following command on app root after updates.
         rails runner "DictType.new.delete_all_caches"
+and in production
+        rails runner "DictType.new.delete_all_caches" -e production
 See change log for brief info.
 
 == Sample
@@ -73,7 +75,7 @@ Here is what should be like.Student model can be other models.
 
 == Features (relies on the above data) :
    DictType.all_cached #=> return cache of DictType.all
-   DictType.all_types = %w[student_city student_school] # also cached
+   DictType.all_types = [:student_city,:student_school] # also cached
    Dictionary.student_city #=> [Dictionary.find(5),Dictionary.find(6)]
 student_city is a dynamic method which returns a list of dictionary object which dict_type is "student_city".
 Actually Dictionary will have as many dynamic methods as DictType.count and each dynamic method name is DictType.name.
@@ -112,4 +114,4 @@ There are no convention and implemention to map Class like Ckeditor::Asset to a
 
 Rebuild core code.Using Rails engine.
 
-Rewrite Testing,make it more maintainable.
+Add test code for cache DictType.tab_and_column,then uncomment the cache code.

data/lib/rails_dictionary/models/acts_as_dict_type.rb

@@ -36,6 +36,7 @@ module RailsDictionary
       # TODO:
       #   To cache this method output need more skills on how to caculate ActiveRecord::Base.descendants
       #   Temply remove the cache
+      #   And add test for this situation
       def tab_and_column
         #Rails.cache.fetch("DictType.tab_and_column") do
           all_model_class=ActiveRecord::Base.descendants.map(&:name).map(&:underscore)

data/lib/rails_dictionary/models/acts_as_dictionary.rb

@@ -25,7 +25,10 @@ module RailsDictionary
       #   rethink about the cache.
       #   cache methods like Dictionary.student_city(:locale => :zh,:sort => :name_fr)
       #   but not cache Dictionary.student_city,return it as relation
-      def method_missing(method_id,options={},&block)
+      #
+      #   Remove nil noise,if listed_attr =[[nil, 201], [nil, 203], [nil, 202], ["Sciences", 200]]
+      #   the sort would be failed of ArgumentError: comparison of Array with Array failed
+      def method_missing(method_id,options={})
         method_name=method_id.to_s.downcase
         if DictType.all_types.include? method_id
           Rails.cache.fetch("Dictionary.#{method_name}") { dict_type_name_eq(method_name) }
@@ -33,7 +36,7 @@ module RailsDictionary
           # Instance of activerelation can not be dup?
           if options.keys.include? :locale or options.keys.include? "locale"
             locale="name_#{ options[:locale] }"
-            listed_attr.map! { |a| [a.send(locale),a.id] }
+            listed_attr.map! { |a| [a.send(locale),a.id] }.reject! {|ele| ele.first.nil?}
             listed_attr.sort { |a,b| a.first <=> b.first }
             # maybe remove the above line,or change some sorting and caching design
           else

data/lib/rails_dictionary/version.rb

@@ -1,3 +1,3 @@
 module RailsDictionary
-  VERSION = "0.0.9.1"
+  VERSION = "0.0.9.2"
 end

data/spec/rails_dictionary_spec.rb

@@ -1,7 +1,6 @@
 # -*- coding: utf-8 -*-
 require File.expand_path('spec_helper', File.dirname(__FILE__))
 
-
 describe RailsDictionary::ActiveRecordExtension do
   %w[acts_as_dict_type acts_as_dictionary acts_as_dict_slave].each do |method_name|
     it "contains #{method_name}" do

metadata

@@ -2,7 +2,7 @@
 name: rails_dictionary
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.9.1
+  version: 0.0.9.2
 platform: ruby
 authors: 
 - Raykin Lee
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-14 00:00:00 Z
+date: 2011-04-15 00:00:00 Z
 dependencies: []
 
 description: Rails plugin for mapping static data of web application to Dictionary class