rails_core_extensions 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 66b12180b0871631d3aa748d769096169a861e1c
-  data.tar.gz: 35d1ef716439e10dd806131a99254cfd40f98765
+SHA256:
+  metadata.gz: e6f3d03a0f590162030b45af40b62bc06cf43070b39329e128ecc8019a4dd493
+  data.tar.gz: 7464ef1b358eabf26b9acbf981c0521839ac2ab0188b4b5e684faedeedfacf23
 SHA512:
-  metadata.gz: ed049d5b08476af111e543f13771d91b96584b29732bfa8ea6376a1bfd4dd1a4e6c6b248a17c9d4761e37ca73fa053413d6c51d2d5174c8f59c27ace3b445720
-  data.tar.gz: b1ec8619fedbab171426d8fb4ec929cccd77bc6e1492a965da00b9905ac79b555cbc70522842a4a2c514300970043deab9e4e61db00d98fb21a8e8b652430a86
+  metadata.gz: ecb48e82f04873abc00679c6527e0e00f629e8e654747969a3f69eb0939730eca1272de3710f4e5308cd65b563483f599cafa5c15543a7b470aa4ba065713b14
+  data.tar.gz: 03fc9650d0d19bb1bb46c871f16becb722afdc65e061405e60e54c38e858ac74f91e8df5e83a453970473ba1d15c18c80614984c439a41c9e56ff7ae6da4d71b

data/.ruby-style.yml

@@ -13,7 +13,7 @@ Style/CollectionMethods:
     find: detect
     find_all: select
     reduce: inject
-Style/DotPosition:
+Layout/DotPosition:
   Description: Checks the position of the dot in multi-line method calls.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
   Enabled: true
@@ -21,7 +21,7 @@ Style/DotPosition:
   SupportedStyles:
   - leading
   - trailing
-Style/FileName:
+Naming/FileName:
   Description: Use snake_case for source file names.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-files
   Enabled: false
@@ -53,7 +53,7 @@ Style/PercentLiteralDelimiters:
     "%w": "()"
     "%W": "()"
     "%x": "()"
-Style/PredicateName:
+Naming/PredicateName:
   Description: Check the names of predicate methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
   Enabled: true
@@ -114,14 +114,24 @@ Style/StringLiteralsInInterpolation:
   SupportedStyles:
   - single_quotes
   - double_quotes
-Style/TrailingComma:
-  Description: Checks for trailing comma in parameter lists and literals.
+Style/TrailingCommaInArguments:
+  Description: Checks for trailing comma in argument lists.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas
-  Enabled: false
-  EnforcedStyleForMultiline: no_comma
+  EnforcedStyleForMultiline: comma
+  SupportedStyles:
+    - comma
+    - consistent_comma
+    - no_comma
+  Enabled: true
+Style/TrailingCommaInLiteral:
+  Description: Checks for trailing comma in array and hash literals.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas
+  EnforcedStyleForMultiline: comma
   SupportedStyles:
-  - comma
-  - no_comma
+    - comma
+    - consistent_comma
+    - no_comma
+Enabled: true
 Metrics/AbcSize:
   Description: A calculated magnitude based on number of assignments, branches, and
     conditions.
@@ -167,7 +177,7 @@ Lint/AssignmentInCondition:
 Style/InlineComment:
   Description: Avoid inline comments.
   Enabled: false
-Style/AccessorMethodName:
+Naming/AccessorMethodName:
   Description: Check the naming of accessor methods for get_/set_.
   Enabled: false
 Style/Alias:

data/.ruby-version

@@ -0,0 +1 @@
+2.5.0

data/.travis.yml

@@ -1,9 +1,10 @@
 language: ruby
 rvm:
-  - 2.3.0
+  - 2.3
+  - 2.4
+  - 2.5
 script: "bundle exec rake spec"
 gemfile:
-  - gemfiles/rails3.gemfile
   - gemfiles/rails4.gemfile
   - gemfiles/rails5.gemfile
 notifications:

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.4.0 (Removes Rails3 Support)
+
+* [TT-3778] Store the cacheable attributes in memory for the duration of the request
+
 ## 0.3.0
 
 * Use coverage kit to enforce maximum coverage

data/README.md

@@ -1,4 +1,4 @@
-Rails Core Extensions 
+Rails Core Extensions
 ====================
 
 [![Build Status](https://travis-ci.org/sealink/rails_core_extensions.png?branch=master)](https://travis-ci.org/sealink/rails_core_extensions)
@@ -30,15 +30,12 @@ end
 
 config/routes.rb
 
-In Rails 3:
+In Rails 4/5:
 resources :types do
   collection
     post :sort
   end
 end
-
-In Rails 2:
-map.resources :types, collection: {sort: :post}
 ```
 
 You need to submit a collection of objects named the same as the controller.

data/lib/rails_core_extensions/active_record_cache_all_attributes.rb

@@ -6,6 +6,7 @@ module ActiveRecordCacheAllAttributes
   module InstanceMethods
     def clear_attribute_cache
       self.class.cache.delete("#{self.class.name}.attribute_cache")
+      self.class.clear_request_cache
     end
   end
 
@@ -14,21 +15,24 @@ module ActiveRecordCacheAllAttributes
       Rails.cache
     end
 
+    def clear_request_cache
+      @request_cache = nil
+    end
+
     def attribute_cache
-      cache_key = "#{self.name}.attribute_cache"
-      cache.read(cache_key) || self.generate_cache(cache_key)
+      cache_key = "#{name}.attribute_cache"
+      @request_cache ||= cache.read(cache_key) || generate_cache(cache_key)
     end
 
     def generate_attributes_hash
       scope = self
       scope = scope.ordered if respond_to?(:ordered)
-      Hash[scope.all.map { |o| [o.send(self.cache_attributes_by), o.attributes] }]
+      Hash[scope.all.map { |o| [o.send(cache_attributes_by), o.attributes] }]
     end
 
     def generate_cache(cache_key)
-      if (cache_value = generate_attributes_hash)
-        cache.write(cache_key, cache_value)
-      end
+      cache_value = generate_attributes_hash
+      cache.write(cache_key, cache_value)
       cache_value
     end
   end

data/lib/rails_core_extensions/version.rb

@@ -1,3 +1,3 @@
 module RailsCoreExtensions
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/rails_core_extensions.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activerecord', ['>= 2.3.0']
-  spec.add_dependency 'actionpack', ['>= 2.3.0']
+  spec.add_dependency 'activerecord', ['>= 4.0.0']
+  spec.add_dependency 'actionpack', ['>= 4.0.0']
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'

data/spec/support/coverage_loader.rb

@@ -1,4 +1,4 @@
 require 'simplecov-rcov'
 require 'coveralls'
 require 'coverage/kit'
-Coverage::Kit.setup(minimum_coverage: 81)
+Coverage::Kit.setup(minimum_coverage: 81.3)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_core_extensions
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Michael Noack
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-27 00:00:00.000000000 Z
+date: 2018-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -17,28 +17,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -204,13 +204,13 @@ files:
 - ".hound.yml"
 - ".rspec"
 - ".ruby-style.yml"
+- ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- gemfiles/rails3.gemfile
 - gemfiles/rails4.gemfile
 - gemfiles/rails5.gemfile
 - lib/rails_core_extensions.rb
@@ -272,7 +272,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Set of extensions to core rails libraries.

data/gemfiles/rails3.gemfile

@@ -1,6 +0,0 @@
-source :rubygems
-gemspec :path => '../'
-
-group :development, :test do
-  gem 'activerecord', '~> 3.2.0'
-end